Re: namespace / typing thrash ...

On 04/16/2012 06:23 PM, Lubos Lunak wrote: On Monday 16 of April 2012, Michael Meeks wrote: Oh - and finally (Lubos) I pushed an item to the ESC agenda to discuss whether we should be exposing tons of classes and their symbols in the product, just to make unit tests work :-) I assume

[REVIEW 3-5] Fix regression in rendering Thai texts

Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=e57525b61af70a6ee33c26f979e724740cca8655 cherry-picked to the 3-5 branch to fix https://bugs.freedesktop.org/show_bug.cgi?id=48431 It's also important that Bug 32530 https://bugs.freedesktop.org/show_bug.cgi?id

Re: namespace / typing thrash ...

On 16 April 2012 18:23, Lubos Lunak wrote: >  It is made even worse by the fact that make+gbuild order build commands > so that allmost all compiles go first and linking goes last As I've seen complaining about this, I was thinking.. Now, when sw links against svx, make starts compiling sw's sour

Re: fdo #36946 -- categories for slide transitions in impress -- where to implement categorisation

On 05/04/12 14:59, Radek Doulik wrote: Yup, having fewer categories makes sense. Powerpoint 2010 has only 3 categories too. Ok, I now have "Wipe", "3d" and "Other" transitions as the categories -- but might add another one or two. I would prefer adding the information into transitions.xml. Othe

Re: [PUSHED][PATCH] Removing unused code

On Sun, 2012-04-15 at 19:47 +0200, Laure Garcí­a Linde wrote: > ___ Looks good, pushed now. Thanks for this. I think this is your first patch, so can you confirm this patch is under our preferred LGPLv3+/MPL combo ? Typical procedure is to send a sort o

Re: [PUSHED][PATCH]git diff included (only a tiny spelling mistake)

On Fri, 2012-04-13 at 21:03 -0400, Udo Schuermann wrote: > Spelling mistake (missing 'd' in "Unexpecte encryption algorithm is > provided!"): > Submission (output of 'git diff') is under GPLv3+/MPL. Pushed now. Can you confirm that you mean LGPLv3+/MPL. I know its only a missing 'd', but still, k

Re: [PUSHED][PATCH] Remove unused code (sc)

On Mon, 2012-04-16 at 20:10 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy looks good, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.o

Re: [PUSHED][PATCH] Remove unused code (connectivity)

On Sat, 2012-04-14 at 19:34 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/

Re: [PUSHED][PATCH] Remove unused code (sd)

On Sat, 2012-04-14 at 20:14 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy looks good, pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

[PUSHED] Re: [PATCH] fix proposed for fdo#48368

I pushed the commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=8bfee2c0eb6fcec49d05562bf1cb945356a4180e for the fix and updated bug status to RESOLVED/FIXED Julien. -- View this message in context: http://nabble.documentfoundation.org/PATCH-fix-proposed-for-fdo-48368-tp3910905p39154

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 48778, which changed state. Bug 48778 Summary: FILEOPEN arbitrary.pptx will CRASH https://bugs.freedesktop.org/show_bug.cgi?id=48778 What|Old Value |New Value

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 48778, which changed state. Bug 48778 Summary: FILEOPEN arbitrary.pptx will CRASH https://bugs.freedesktop.org/show_bug.cgi?id=48778 What|Old Value |New Value

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on||45171 -- Configure bugmail: https://bugs.fr

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #280 from Cor Nouws 2012-04-16 12:48:45 PDT --- (In reply to comment #275) > @dE > I think you should ask advise to the QA team (Reiner & co.) before removing > MABs. I think that indeed is the best idea. We have the QA list, and eve

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #279 from Cor Nouws 2012-04-16 12:43:37 PDT --- Hi dE (In reply to comment #269) > I don't think these bugs should be added here - Prolly this is not the best place to discuss. but ... > Bug 47355 -- the probability of someone pla

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on||45084 -- Configure bugmail: https://bugs.fr

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on||45085 -- Configure bugmail: https://bugs.fr

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on||46509 -- Configure bugmail: https://bugs.fr

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on|48081 | -- Configure bugmail: https://bugs.freedes

Re: SwFrmFmt::FindRealSdrObject() and stacking order

On 16/04/12 16:54, Lubos Lunak wrote: > > Hello, > > could somebody more knowledgeable of Writer internals please review this? > > While working on support for stacking order in the .docx filter, I found out > that setting z-order for an image using UNO and later trying to retrieve the > va

Re: [patch] [fdo#42986] Presentations in Wide-screen

Hi Rob, thanks a lot, great work! :) Just one detail: if you add smth to 'static const int PaperIndex' (print.cxx), I suppose you also have to add it to RID_STR_PAPERNAMES (print.src): OSL_ENSURE( sal_uInt32(SAL_N_ELEMENTS(PaperIndex)) == aPaperStrings.Count(), "localized paper name count w

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||48778 --- Comment #278 from Rainer Bi

[PATCH] Remove unused code (sc)

This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] 2/2 List cleanup in SD

On Sunday 15 of April 2012, Rafael Dominguez wrote: > Here are the patching fixing the issues you pointed me out. Yes, good, pushed, thanks again. One thing I didn't mention explicitly when talking about the named return value optimization was that it is done only if the named return variable

[PATCH] remove unnecessary auto_ptr complexity in chart2uno.cxx in SC moduel

Hi Patch is against master, and my license statement is on file. This is a precursor patch to converting from tools/table.hxx usage to std::map Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0001-Remove-unnecessary-auto_ptr-complexity.patch Description: applicat

Re: namespace / typing thrash ...

2012/4/16 Lubos Lunak : > On Monday 16 of April 2012, Michael Meeks wrote: >>       Oh - and finally (Lubos) I pushed an item to the ESC agenda to discuss >> whether we should be exposing tons of classes and their symbols in the >> product, just to make unit tests work :-) > >  I assume this is abo

Re: namespace / typing thrash ...

On Monday 16 of April 2012, Michael Meeks wrote: > Oh - and finally (Lubos) I pushed an item to the ESC agenda to discuss > whether we should be exposing tons of classes and their symbols in the > product, just to make unit tests work :-) I assume this is about 69d46dd7a6adfffd71da055bb6510

Re: [PUSHED:3-5] fdo#47802 fix crash on RTF import of shapes inside tables

Miklos Vajna píše v Ne 15. 04. 2012 v 13:03 +0200: > Hi, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=95803f4 Looks reasonable => pushed into 3-5. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [REVIEW:3-5] fix download and unpack-sources for .xz source tarballs

Petr Mladek píše v Pá 13. 04. 2012 v 18:36 +0200: > Petr Mladek píše v Pá 13. 04. 2012 v 18:00 +0200: > > Korrawit Pruegsanusak píše v Pá 13. 04. 2012 v 22:40 +0700: > > > Hello again Petr, > > > > > > On Fri, Apr 13, 2012 at 21:34, Petr Mladek wrote: > > > > "the scripts "download" and "unpack-s

Re: per library debug builds now possible via ./configure

On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote: > Is it possible to do the build also the other way around, i.e. e.g. "all but > sc"? Not yet, feel free to add it if you think it is essential. > If I work on something, I generally want to have also all its > dependencies built with

[REVIEW][3-5] fdo#38635: sw: printing border lines gaps regression

proposing for libreoffice-3-5: with the old border painting code, there is a special case for printing where the vertical borders are shortened so they don't overlap with the horizontal borders (the old borders were rectangular). this seems to be completely unnecessary and detrimental with the n

[REVIEW][3-5] fdo#38215: sw: fix consecutive border line gaps regression

this fixes a regression in painting border lines in LO 3.4, leading to small visible gaps between borders of consecutive paragraphs, and is proposed for libreoffice-3-5. fixed by re-implementing the merging of border lines that are less than 1.5 pixel apart that was done in the old paint implement

[REVIEW][3-5] Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions

On 26/03/12 11:42, Cedric Bosdonnat wrote: > Hi Michael, > > On Fri, 2012-03-23 at 17:44 +0100, Michael Stahl wrote: >> On 20/03/12 12:19, Cedric Bosdonnat wrote: >>> On Fri, 2012-03-16 at 23:29 +0100, Michael Stahl wrote: this fix introduces a new array to store the borders and paints them >

SwFrmFmt::FindRealSdrObject() and stacking order

Hello, could somebody more knowledgeable of Writer internals please review this? While working on support for stacking order in the .docx filter, I found out that setting z-order for an image using UNO and later trying to retrieve the value fails. The attached sw.patch fixes that for me, an

Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

On 04/16/2012 05:13 AM, Noel Power wrote: On 15/04/12 05:20, Daniel Bankston [danthedev] wrote: Hello, everyone, I have attached my patches for EasyHack 48140. I have taken baby steps, so this just the first part of completing EasyHack 48140. I changed WorkbookHelper::createNamedRangeObject

Re: Thanks for a fantastic Hackfest!

Op 16 april 2012 14:44 heeft Florian Effenberger het volgende geschreven: > I wanted to take a chance to thank everyone involved in the recent Hackfest > for a real fantastic and exciting weekend! > > Although it is no secret that I am no developer, I really enjoyed meeting > all of you, getting

(non)-minutes of ESC call ...

Hi guys, We didn't have a meeting last Thursday with the excuses built around various travel / hack-fest associated events :-) But people no doubt like to read the bug statistics, which I append. HTH, Michael. * 3.5 most annoying bugs ... + jump from (fin

Thanks for a fantastic Hackfest!

Hello, I wanted to take a chance to thank everyone involved in the recent Hackfest for a real fantastic and exciting weekend! Although it is no secret that I am no developer, I really enjoyed meeting all of you, getting to know various aspects of development, and having nice talks to our fel

[REVIEW-3-5] Fix fdo#33591 - edge-case trans gradients came out empty

Hi there, could someone please review http://cgit.freedesktop.org/libreoffice/core/commit/?id=983c27402e151126c5bef6623eeb07f333456243 and cherry-pick to -3-5? Thanks, -- Thorsten pgpJrzE3fnHvw.pgp Description: PGP signature ___ LibreOffice maili

Re: [PUSHED-3-5] Fix for n#717947, PDF export fixes

Muthu Subramanian wrote: > It will be great if someone can review this and cherry-pick it, please? > Done. -- Thorsten pgp6j3kG26YVH.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #277 from Petr Mladek 2012-04-16 06:17:40 PDT --- IMHO, dE did great job. We could discuss particular bugs but some clean up was useful. For example. I am not sure about removing the bug 45171. IMHO, the password protected documents

[PATCH] Removing unused code

>From ade2a4ad180eac9e72e5104fd8e0ef9014847bec Mon Sep 17 00:00:00 2001 From: Laureano G. Linde Date: Sun, 15 Apr 2012 18:47:57 +0200 Subject: [PATCH] Removed StgHeader::SetClassId(ClsId const &) --- sot/source/sdstor/stgelem.cxx |6 -- sot/source/sdstor/stgelem.hxx |1 - 2 files ch

[PATCH] Impress Help

Please check the patch very carefully, as I don't trust myself as a hacker. -- Italo Vignoli - it...@italovignoli.com mob +39.348.5653829 - VoIP 5316...@messagenet.it skype italovignoli - gtalk italo.vign...@gmail.com >From e35453fb390856e281bf69de8878d03fe5c7f585 Mon Sep 17 00:00:00 2001 From: I

Re: Lightproof easyhack

Hi, Thanks for the eligible patch. I have fixed some rules, using the Lightproof rule editor (http://extensions.libreoffice.org/extension-center/lightproof-editor), see http://www.numbertext.org/tmp/ukdat.odt. With a minor extension we will be able to add basic Ukrainian typo/grammar checking supp

git diff included (only a tiny spelling mistake)

Spelling mistake (missing 'd' in "Unexpecte encryption algorithm is provided!"): Submission (output of 'git diff') is under GPLv3+/MPL. --Udo. diff --git a/package/source/manifest/ManifestExport.cxx b/package/source/manifest/ManifestExport.cxx index 40786db..8bbb4ce 100644 --- a/package/sourc

Re: Weird error during build of 3.5.2 libreoffice

Tomáš Chvátal píše v Čt 12. 04. 2012 v 08:39 +0200: > Hi guys, > > I am kinda unable to figure what is the dmake complaining about. > > dmake: > /var/tmp/portage/app-office/libreoffice-3.5.2.2/work/libreoffice-core-3.5.2.2/solenv/inc/tg_ext.mk: > line 106: Error: -- A %-target must not be mix

Re: getting a list at build time of supported languages ?

Hi Caolán, On Friday, 2012-04-13 13:07:16 +0100, Caolán McNamara wrote: > I suppose we don't have a current mechanism to get a list a build time > of all the languages that we support in the UI as options for setting > the language ? If it's languages that can be used as character attribution th

Re: [Libreoffice-ux-advise] [PATCH] Mouse centered zooming

On 04/16/2012 01:29 PM, Michael Meeks wrote: > I gave this a test, and it's unclear quite what to expect here. eg. I > create a draw document, insert a stock box shape in the top right, move > my mouse to over the top of a specific corner of that, and scroll-in. > > What I'd expect (pe

Re: per library debug builds now possible via ./configure

On Monday 16 of April 2012, Bjoern Michaelsen wrote: > Hi, > > it should now be possible to build one (or more) libraries for debugging, > while building the rest nondebug. Thanks for Tor giving the inspiration to > this at the Hackfest! Is it possible to do the build also the other way around, i

Re: [Libreoffice-ux-advise] [PATCH] Mouse centered zooming

Hi Tim, On Thu, 2012-04-12 at 21:35 +0200, Tim Hardeck wrote: > During zoom out the direction is reversed to get back near the starting > point. This is disabled for Calc since it doesn't focus the center but > instead keeps the upper left cell where it is so reversing the zoom > direction feels n

Re: [PATCH] fix proposed for fdo#48368

Noel Power-3 wrote > >>... >> I can commit and push on master of course but I'd like first your opinion >> about this. >> > please commit looks like the correct fix to me ( on a side note can > anyone remember what ( #if _SOLAR__PRIVATE ) is all about, I can't see > any reason for it in the co

Re: [PUSHED-3-5] improve startup performance ...

Hi Stephan, On Mon, 2012-04-16 at 10:50 +0200, Stephan Bergmann wrote: > Pushed to -3-5 now as > > > (needed some trivial adaptation to -3-5, and I had not been aware you > had

namespace / typing thrash ...

On Fri, 2012-04-13 at 19:42 +0200, Lubos Lunak wrote: > No, you see it backwards :). It reduces code annoyances for IMO very little > price. Personally I'm a fan of Lubos' efforts here; possibly we need an underlying namespace to avoid conflicting with other software we link, but having

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #276 from sasha.libreoff...@gmail.com 2012-04-16 03:23:37 PDT --- 1) let not flame here 2) deleting something from "Depend on" not very important because: a) bug numbers still seen inside of comments b) most of them are closed because

per library debug builds now possible via ./configure

Hi, it should now be possible to build one (or more) libraries for debugging, while building the rest nondebug. Thanks for Tor giving the inspiration to this at the Hackfest! details: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ebed42c38ae91147633c47873307e07984bc62c1 Best, Bjoer

Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

On 15/04/12 05:20, Daniel Bankston [danthedev] wrote: Hello, everyone, I have attached my patches for EasyHack 48140. I have taken baby steps, so this just the first part of completing EasyHack 48140. I changed WorkbookHelper::createNamedRangeObject and createLocalNamedRangeObject to return

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 48081, which changed state. Bug 48081 Summary: Impress UI: impossible to select animated picture using left mouse click https://bugs.freedesktop.org/show_bug.cgi?id=48081 What|Old Value

[Bug 35673] LibreOffice 3.4 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36496, which changed state. Bug 36496 Summary: content of frames and captions not editable in text document https://bugs.freedesktop.org/show_bug.cgi?id=36496 What|Old Value |New Value --

Re: Automatic using ::rtl::OUString etc.

On 04/13/2012 07:42 PM, Lubos Lunak wrote: Strings already kind of are a magic special case. They are the one non-builtin type that is by far the most used one, close to the builtin ones (which is part of the reason why many programming languages do have strings as a builtin type). So I see not

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #275 from tommy27 2012-04-16 02:31:57 PDT --- @dE I think you should ask advise to the QA team (Reiner & co.) before removing MABs. removing those existing bugs from this page does not solves them. -- Configure bugmail: https://bug

Re: [REVIEW:3-5]patches for 35 MAB fdo#45376 already in master ..

On 16/04/12 09:49, Petr Mladek wrote: Cor Nouws píše v Ne 15. 04. 2012 v 16:08 +0200: Hi, I see Bug 45376 - [FORMATTING] Incorrect text wrapping around drawing shape, one of the 3.5 MAB issues, that seems to be fixed with two commits in master, according to comment 4 ( https://bugs.freedesktop.

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #274 from sasha.libreoff...@gmail.com 2012-04-16 02:12:39 PDT --- @ dE 1) here placed also regressions, not only annoying bugs 2) developers know what to do. Unimportant bugs they will ignore for now. -- Configure bugmail: https://bu

Re: [PUSHED-3-5] improve startup performance ...

On 04/14/2012 01:38 AM, Michael Meeks wrote: On Fri, 2012-04-13 at 15:03 +0200, Michael Meeks wrote: The basic idea is to push the iteration over directories down into the stoc/ code instead of having it in the cppuhelper code. That lets us re-use the same representation avoiding the nes

Re: [REVIEW:3-5]patches for 35 MAB fdo#45376 already in master ..

Cor Nouws píše v Ne 15. 04. 2012 v 16:08 +0200: > Hi, > > I see Bug 45376 - [FORMATTING] Incorrect text wrapping around drawing > shape, one of the 3.5 MAB issues, that seems to be fixed with two > commits in master, according to comment 4 ( > https://bugs.freedesktop.org/show_bug.cgi?id=45376#

Re: [PATCH] fix proposed for fdo#48368

On 14/04/12 22:20, julien2412 wrote: Hello, I reproduced the problem indicated by fdo#48368 and attached to the bugtracker bt with symbols (see https://bugs.freedesktop.org/attachment.cgi?id=59985&action=edit) Here are the lines of basctl/source/basicide/basidesh.cxx which seem to cause the pro