[PATCH] fdo#35042: previous color applied instead of latest "no fill" for "highlighting"

2012-04-08 Thread Aldo Román Nureña
Patch to fix the 35042 bug. As mentioned on the report: Steps to reproduce 1. open new WRITER document 2. type 3 words 3. select one word by double click 4. open character background color picker by long click on 'Highlighting' icon 5. Select "light red" by click picker closes. Character backgr

Configure.in tweaking for windows

2012-04-08 Thread Mat M
Good evening all, I am checking for usefulness of adding another option for Win builders in configure.in . In configure.in, I saw that around line 2750 : # Check for 64-bit (cross-)compiler to use to build the 64-bit # version of the Explorer extension (and maybe other small [SNIP] AC_MSG_CHE

Re: Using OOoPython from an external script

2012-04-08 Thread Christian Lohmaier
Hi Glenn, *, On Fri, Apr 6, 2012 at 10:32 PM, Glenn Ramsey wrote: > [...] > In order for a system python script to be able to execute lo-python it needs > to know where LO is installed and what platform it is running on. But why do you want to run system python when LO on Mac comes with its own

Re: [PATCH] Partial fix for Bug 30711

2012-04-08 Thread Brennan T Vincent
Hi, I have modified the patch somewhat; please take a look at this new version. On Sat, Apr 7, 2012 at 2:32 AM, Brennan T Vincent wrote: > Hi, > > Attached is a patch partially fixing Bug 30711. When the user has not > chosen to use OpenDocument format with extensions, text input fields > are no

[PUSHED] Re: Cppcheck reports "Same expression on both sides" in writerfilter module

2012-04-08 Thread julien2412
Pushed on master (http://cgit.freedesktop.org/libreoffice/core/commit/?id=39ba666f802db07e34eb848ad4e5f39ff85dd6ed) (cf last post http://nabble.documentfoundation.org/Cppcheck-reports-Same-expression-on-both-sides-of-on-basctl-module-tp3893608p3895210.html) Thank you too for this one Lubos. Julie

[PUSHED] Re: Cppcheck reports "Same expression on both sides of '|'" on basctl module

2012-04-08 Thread julien2412
Pushed on master (http://cgit.freedesktop.org/libreoffice/core/commit/?id=39ba666f802db07e34eb848ad4e5f39ff85dd6ed) (there are 2 fixes in this one). I don't know if it could be useful to push it on 3.5. Anyway, thank you Lubos. Julien. -- View this message in context: http://nabble.documentfou

[PATCH] Remove unused code (oox)

2012-04-08 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-oox.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build failed on cairo (Win32)

2012-04-08 Thread Mat M
Hi already got the commits. Make clean was necessary. TY Mat M Le Sat, 07 Apr 2012 18:23:28 +0200, julien2412 a écrit: Hi, If you talk about master repository, there have been some commits recently which could help : http://cgit.freedesktop.org/libreoffice/core/commit/?id=6219ff898a

Re: [Libreoffice-commits] .: 11 commits - dbaccess/CppunitTest_dbaccess_macros_test.mk extensions/CppunitTest_extensions_test_update.mk filter/CppunitTest_filter_tga_test.mk filter/CppunitTest_filter_

2012-04-08 Thread Lubos Lunak
On Sunday 08 of April 2012, David Tardon wrote: > dbaccess/CppunitTest_dbaccess_macros_test.mk | 17 -- > extensions/CppunitTest_extensions_test_update.mk | 11 - > filter/CppunitTest_filter_tga_test.mk | 15 - > filter/CppunitTest_filter_tiff_tes

[PUSHED-3-5] Re: [REVIEW:3-5] "Redundant assignment" in oox

2012-04-08 Thread Lubos Lunak
On Saturday 07 of April 2012, julien2412 wrote: > Hello, > > Cppcheck reported this : > [oox/source/vml/vmlformatting.cxx:251]: (warning) Redundant assignment of > "nModToken" in switch > Here are the lines : > 249 switch( AttributeConversion::decodeToken( > aColorIndex.copy( 0, nOp

Re: Cppcheck reports "Same expression on both sides of '|'" on basctl module

2012-04-08 Thread Lubos Lunak
On Sunday 08 of April 2012, julien2412 wrote: > Hello, > > On master, cppcheck reported this : > [basctl/source/basicide/bastypes.cxx:269] -> > [basctl/source/basicide/bastypes.cxx:269]: (style) Same expression on both > sides of '|'. > Here are the lines : > 266 BasicDockingWindow::BasicDockin

Re: Cppcheck reports "Same expression on both sides" in writerfilter module

2012-04-08 Thread Lubos Lunak
On Sunday 08 of April 2012, julien2412 wrote: > Hello, > > On master repo, cppcheck reported this : > [writerfilter/source/filter/ImportFilter.cxx:227] -> > [writerfilter/source/filter/ImportFilter.cxx:227]: (style) Same expression > on both sides of '||' ... > So because of the 2 things noticed, I

Re: [PUSHED] Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator

2012-04-08 Thread Lubos Lunak
On Saturday 07 of April 2012, Dézsi Szabolcs wrote: > > Unfortunately I was unable to push your other patch, I've got no more > > time for that - please send the link to the mailing list. > > Hi, I uploaded it to my site, but it's unavailable at the time... It's not > that large, so I attached it t

Re: RTL_CONSTASCII_(U)STRINGPARAM officially obsolete

2012-04-08 Thread Lubos Lunak
On Friday 06 of April 2012, Lubos Lunak wrote: > I'm aware only of these cases where the explicit > OUString ctor is needed: > > - return statements (because of the gcc bug) > - tool String class (because that one itself is obsolete and uses should be > converted to OUString) > - when OUString obje

Re: problem with compiling and linking the same file into different libraries

2012-04-08 Thread Lubos Lunak
On Sunday 08 of April 2012, Markus Mohrhard wrote: > There are currently 2 related problems. First the check for duplicated > linked objects complains that cursormove.o is linked into two libs and > then David pointed out that cursormove.cxx is only compiled once with > my current approach. So one

Re: RTL_CONSTASCII_(U)STRINGPARAM officially obsolete

2012-04-08 Thread Mark Stanton
OK, my mistake, you've done the "EqualsAscii" (like you said! I must learn to read better). Same question I suppose, are you intending to do the rest of the cleanup? I expect that's an even larger job :-z Mark ___ LibreOffice mailing list LibreOff

Re: RTL_CONSTASCII_(U)STRINGPARAM officially obsolete

2012-04-08 Thread Mark Stanton
I'm looking at the Base code and I'm still finding some of these. Should I correct them, or is this in process? Regards Mark Stanton ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffi

Base bugs

2012-04-08 Thread Mark Stanton
I'm starting to work through these. So far all the ones I've looked at don't fail on my Fedora 16 system. They are 43277, 43277, 36087, and I've commented on them, is that what's required? The last one I've marked as "resolved", is that the right thing? Mark Stanton _

Base bug 36087

2012-04-08 Thread Mark Stanton
Although the initial element of this bug is resolved, it does point to the wider issue of exporting data from Base. Having to cut and paste from Base to Calc doesn't really seem like a good idea, particularly as it will fail with more data than the clipboard can hold. What's best to do about

Re: [Libreoffice] Mac OSX daily build 26/10/2011 - Base Report Builder, Beanshell, and Javascript extensions disabled

2012-04-08 Thread Kálmán „KAMI” Szalai
Hi, Finally I get managed to release a new bugfix/feature version. Now it is working under LibO 3.4 and 3.5. Can you test it then cherry-pick it to 3.4 and3.5 branches? Thanks, KAMI 2011-10-28 15:56 keltezéssel, Stephan Bergmann írta: > On 10/28/2011 10:07 AM, Alexander Thurgood wrote: >> I can

Re: [PATCH] [PUSHED] gbuild conversion: rdbmaker module, second try

2012-04-08 Thread David Tardon
On Thu, Apr 05, 2012 at 11:10:06PM +0200, David Ostrovsky wrote: > Hi, > > another try to convert rdbmaker module. > The header files was not delivered in original build, fixed. > > @Matus, thank you for pointing this out. > > I updated > https://wiki.documentfoundation.org/Development/Build_Sy

Bugzilla EasyHack tags cleanup

2012-04-08 Thread Rainer Bielefeld
Hi, as a result of QA call l 2012-04-06 I am planning a cleanup of the EasyHack tags used in Bugzilla. Details concerning the plan you find in the Wiki on , concerns and suggestions please mention in thread

Re: Fwd: Re: [PATCH][IN PROGRESS] gbuild conversion: module cpputools

2012-04-08 Thread David Tardon
On Wed, Apr 04, 2012 at 06:33:44AM +0200, David Tardon wrote: > On Wed, Apr 04, 2012 at 12:50:47AM +0200, David Ostrovsky wrote: > > Hi David, > > > > thank you for your comments. Here is another try. Hi, I looked at the patch and there are still some problems to correct. I could easily do it my

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on|41996 | -- Configure bugmail: https://bugs.