On Sunday 08 of April 2012, julien2412 wrote:
> Hello,
>
> On master, cppcheck reported this :
> [basctl/source/basicide/bastypes.cxx:269] ->
> [basctl/source/basicide/bastypes.cxx:269]: (style) Same expression on both
> sides of '|'.
> Here are the lines :
> 266 BasicDockingWindow::BasicDockingWindow( Window* pParent, const
> ResId& rResId ) :
> 267 DockingWindow( pParent, rResId )
> 268 {
> 269 SetStyle( WB_BORDER | WB_3DLOOK | WB_DOCKABLE | WB_MOVEABLE |
> 270 WB_SIZEABLE | WB_ROLLABLE |
> 271 WB_DOCKABLE | WB_CLIPCHILDREN );
> 272 }
>
> It's quite recent, 1 month ago with commit
> 0e8eb19a53338c83dab7fe19e2f23bcaecd52077.
The problem actually has been there for over 10 years at least, the commit
you mention just copied it from those few lines above, where there is the
same duplication.
> I've got not idea, if we can just remove WB_DOCKABLE or if it should be
> replaced by another constant.
>
> Any advice ?
I think you can simply remove one of the duplicates.
--
Lubos Lunak
l.lu...@suse.cz
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
