Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

2012-03-14 Thread Markus Mohrhard
Hello Albert, 2012/3/15 Albert Thuswaldner : > Hi Markus, > So I have hacked on this a bit, progress has been slow, detours and so > on. Anyhow, I think have now completed the step 1, i.e changed the > underlying code removing the static limit. I've have tried to keep > much of the old structure f

Re: [PUSHED][PATCH] Remove unused code in drawingml

2012-03-14 Thread Mariana Marasoiu
On Wed, Mar 14, 2012 at 6:46 PM, Caolán McNamara wrote: > On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote: >> Hi! >> >> These patches remove unused code as listed in unusedcode.easy > > Looks good, pushed now. Thanks for these. If I'm not wrong, this is you > first submission ? If so, ca

[PUSHED] Reduce duplicate code: PrinterJob::writeProlog

2012-03-14 Thread Michael Meeks
On Wed, 2012-03-14 at 20:09 +0100, Chr. Rossmanith wrote: > Yes that's fine. Could you push it for me, please? I have some commits > queued up and don't want them to be pushed all together - and don't > remember how I've managed to push a single commit. Yes, that's not so easy :-)

License statement

2012-03-14 Thread Mariana Marasoiu
Hi! I hereby confirm that all my past and future contributions to LibreOffice, until I state otherwise, are licensed under LGPLv3+/MPLv1.1+. Thanks, Mariana Mărășoiu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedeskto

DrMemory howto (for Windows) ...

2012-03-14 Thread Michael Meeks
Hi guys, So - if you have a crasher bug on Windows, and the stack trace is inside 'malloc' or 'free' or 'new' or 'delete' then most likely you have a memory corruption - often intermittent bugs are these too. For these cases, there is a wonder-new-tool (for Windows), called DrMemo

Re: [PATCH] Translate German comments in core/connectivity

2012-03-14 Thread Philipp Weissenbacher
Ow, what a shame. Seems I've already done all of this. (see e.g. b5995754 ). Maybe you can apply for an account too so that getting your changes gets easi

Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category

2012-03-14 Thread Cor Nouws
Hi Stefan, Stefan Knorr (Astron) wrote (06-03-12 14:40) What specifically doesn't work for you? For me it's about okay ~today. (I remember August promised you a better solution for later, though.) It is about navigating through the various sections (left) with the arrow keys. If that does not

Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-14 Thread Chr. Rossmanith
Am 14.03.2012 15:42, schrieb Michael Meeks: Hi Christina, On Mon, 2012-03-05 at 14:59 +0100, Chr. Rossmanith wrote: as suggested on IRC I've removed the whole StrictSO52Compatibility stuff. It builds successfully - make test is on its way. "git grep" reported some test documents matching as wel

Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available

2012-03-14 Thread Rainer Bielefeld
Bjoern Michaelsen schrieb: We need to be sure to detect and pinpoint regressions earlier and more precise than in 3.4 Hi, That's at least an important part of the truth, when 3.4.0 release came only 15 regressions were known (bud keyword handling was very arbitrary in those days). Let's h

Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available

2012-03-14 Thread Bjoern Michaelsen
Hi Pedro, On Wed, Mar 14, 2012 at 05:32:04PM +, Pedro Lino wrote: > Maybe branch 3.4.x should continue to be updated (in the same way that > Mozilla keeps fixing bugs in version 3.6.x, with x currently at 28, even > though the latest version is 11.0...) until at least all 3.3.x regressions > a

Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available

2012-03-14 Thread Rainer Bielefeld
Pedro Lino schrieb: Maybe branch 3.4.x should continue to be updated (in the same way that Mozilla keeps fixing bugs in version 3.6.x, Hi, Yes, something like that would be great, but we should not underrate the work that such a proceeding would cost. But I believe I we have some kind of gu

[Libreoffice] [PATCH] modify default behaviour of the format paintbrush

2012-03-14 Thread Maxime de Roucy
Hello Two new patchs that modify the default behaviour of the format paintbrush. 0001-Format-paintbrush-default-behaviour.patch To apply to the core repository. 0001-Change-format-paintbrush.patch To apply to the help repository. By default the paintbrush doesn't copy the paragraph formatting ;

Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available

2012-03-14 Thread Bjoern Michaelsen
Hi Rainer, On Wed, Mar 14, 2012 at 05:48:17PM +0100, Rainer Bielefeld wrote: > We still have 45 unfixed regressions compared to 3.3, Lifecycle of > 3.4 will end with 3.4.6(?), so this version is more or less useless > for most (or at least very many) 3.3 or 3.4 users. While I agree that 45 regres

Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available

2012-03-14 Thread Pedro Lino
Hi Rainer, all It's my belief that we will have to rethink our release concept. > It is true that this model tends to accumulate regressions. Unfortunately it is not easy to measure if adding more features is attracting more users than repelling users because of regressions/unsolved problems...

Re: various Chinese "Kai" sizes

2012-03-14 Thread Takeshi Abe
Hi Joop, On Wed, 14 Mar 2012 18:05:08 +0100, Joop Kiefte wrote: > So you would actually need a distinct 中开(RPC Kai) and a 台开 (ROC Kai) right? No, I have little idea about these usage. Cheers, -- Takeshi Abe > > 2012/3/14 Takeshi Abe > >> Hi Caolán, >> >> Thank you for your comment! >> >> On

Re: various Chinese "Kai" sizes (Was: [PATCH] add 'Japanese Postcard' paper size to both Paper format and Print dialog)

2012-03-14 Thread Caolán McNamara
On Thu, 2012-03-15 at 01:46 +0900, Takeshi Abe wrote: > "Standard for Media Standardized Names" ... includes registration for > names of media sizes. It recognizes a couple of flavor of "K"s, i.e., > 'PRC' [2] and 'ROC' [3]. Each of them has its own 8K/16K etc., which > may explain part of the abov

Re: various Chinese "Kai" sizes (Was: [PATCH] add 'Japanese Postcard' paper size to both Paper format and Print dialog)

2012-03-14 Thread Joop Kiefte
So you would actually need a distinct 中开(RPC Kai) and a 台开 (ROC Kai) right? 2012/3/14 Takeshi Abe > Hi Caolán, > > Thank you for your comment! > > On Wed, 14 Mar 2012 14:09:19 +, Caolán McNamara > wrote: > > It wouldn't make sense to exclude Japanese Postcard size, when we show > > the rath

Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available

2012-03-14 Thread Rainer Bielefeld
Fridrich Strba schrieb: for 3.4.6 RC2, we're now uploading builds to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: If you've a bit of time, please give them a try& report *critical* bugs not yet in bugzilla here, Hi, w

various Chinese "Kai" sizes (Was: [PATCH] add 'Japanese Postcard' paper size to both Paper format and Print dialog)

2012-03-14 Thread Takeshi Abe
Hi Caolán, Thank you for your comment! On Wed, 14 Mar 2012 14:09:19 +, Caolán McNamara wrote: > It wouldn't make sense to exclude Japanese Postcard size, when we show > the rather bizarre Chinese "Kai" sizes, which despite my best efforts > (see my old docs at > http://wiki.services.openoffi

Re: [PUSHED][PATCH] Remove unused code in drawingml

2012-03-14 Thread Caolán McNamara
On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote: > Hi! > > These patches remove unused code as listed in unusedcode.easy Looks good, pushed now. Thanks for these. If I'm not wrong, this is you first submission ? If so, can you add yourself to http://wiki.documentfoundation.org/Developme

Re: [PATCH] [PUSHED] add 'Japanese Postcard' paper size to both Paper format and Print dialog

2012-03-14 Thread Takeshi Abe
Hi Kohei, On Wed, 14 Mar 2012 10:36:52 -0400, Kohei Yoshida wrote: > On Wed, 2012-03-14 at 10:13 -0400, Kohei Yoshida wrote: > >> Works fantastic. Pushed to master (sorry I forgot I could've asked you >> to push since you have push access to the repo). Great! > > Added it to the 3.6 release

Re: [PUSHED][REVIEW-3-5] TextEngine::SeekCursor needs to call SetFont after all

2012-03-14 Thread Caolán McNamara
On Tue, 2012-03-13 at 11:19 +0100, Stephan Bergmann wrote: > > commit 40c0ff75d2a0f987454b068a663908e6d9b87b9b ... > Please consider this patch for inclusion in libreoffice-3-5. cherry-picked this to 3-5 now C. ___ LibreOffice mailing list LibreOffice@

[Libreoffice] [PATCH] format clipboard

2012-03-14 Thread Maxime de Roucy
Hello Here is some new patchs on the format clipboard. The first just add some comment in the formatclipboard.hxx file. The second one depend on modifications I made in the previous patch 0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch which is itself dependant of the patch 0004-SwEd

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 43932, which changed state. Bug 43932 Summary: PRINTING: Paper tray setting not accepted from "File -> Print..." https://bugs.freedesktop.org/show_bug.cgi?id=43932 What|Old Value |New Va

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 47274, which changed state. Bug 47274 Summary: EDITING: Crash when copy/paste table with data from Writer https://bugs.freedesktop.org/show_bug.cgi?id=47274 What|Old Value |New Value

[ANN] LibreOffice 3.4.6 RC2 test builds available

2012-03-14 Thread Fridrich Strba
Hi *, for 3.4.6 RC2, we're now uploading builds to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try & report *critical* bugs not yet

Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-14 Thread Michael Meeks
Hi Christina, On Mon, 2012-03-05 at 14:59 +0100, Chr. Rossmanith wrote: > as suggested on IRC I've removed the whole StrictSO52Compatibility > stuff. It builds successfully - make test is on its way. "git grep" > reported some test documents matching as well, so I expect some tests to > fail.

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45521, which changed state. Bug 45521 Summary: [FILEOPEN] LibO Writer changes decimal delimiter when opening a sdw file which causes data loss after saving https://bugs.freedesktop.org/show_bug.cgi?id=45521 W

Re: [PATCH] [PUSHED] add 'Japanese Postcard' paper size to both Paper format and Print dialog

2012-03-14 Thread Kohei Yoshida
On Wed, 2012-03-14 at 10:13 -0400, Kohei Yoshida wrote: > Works fantastic. Pushed to master (sorry I forgot I could've asked you > to push since you have push access to the repo). Added it to the 3.6 release notes. https://wiki.documentfoundation.org/ReleaseNotes/3.6#Core -- Kohei Yoshida, Li

[REVIEW 3-5] fdo#45521 "most-annoying" .sdw bug

2012-03-14 Thread Caolán McNamara
some problems with .sdw documents, turns out that the binfilter import depends on being able to use the ascii text exporter to generate plain-text forms of some entries. http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=cfa62900291dc2d89793044a045ac1f29ca8b128 patch is big, but just re

Re: [REVIEW: 3-5, 3-4] fdo#43932 setting paper tray from print dialog

2012-03-14 Thread Ivan Timofeev
Hi David, actually, your fix was my first attempt to solve the bug. It solved the UI problem, I remember. And then I decided to clean-up the code a bit... You might see my patch. :) But I cannot ever understand, how it fixes the real problem (setting paper tray). https://bugs.freedesktop.org

build breakage on latest master on Windows

2012-03-14 Thread Noel Grandin
Hi Compiling using Visual Studio 2008. I'm seeing this error - any ideas? /cygdrive/c/LibreOffice/libo/canvas/Library_gdipluscanvas.mk:77: *** fdo#47246: canvas/source/directx/dx_bitmap is linked in by Library/idirectx9canvas.lib Library/igdipluscanvas.lib. Stop. dmake: Error code 2, while

Re: [PATCH] [PUSHED] add 'Japanese Postcard' paper size to both Paper format and Print dialog

2012-03-14 Thread Kohei Yoshida
On Wed, 2012-03-14 at 09:24 -0400, Kohei Yoshida wrote: > If nobody is reviewing his patch, I'd like to give it a quick test and > push it to master if I don't find anything obviously wrong. Works fantastic. Pushed to master (sorry I forgot I could've asked you to push since you have push access

Re: Bibliography DB and DBaseIII files [was: Patch for Easy Hack 45033]

2012-03-14 Thread Caolán McNamara
On Tue, 2012-03-13 at 16:25 +0100, Lionel Elie Mamane wrote: > In the 3.5 biblio.odb, they are only hidden from view. Right click on > any column header (title), choose "show columns" then "all". If we > want this to be the default, save that odb and commit it to git. Doh, done, thanks. C. _

Re: libcmis patch (was: [Libreoffice-commits] .: Enable -Wnon-virtual-dtor for GCC 4.6)

2012-03-14 Thread Cedric Bosdonnat
Hi Stephan On Wed, 2012-03-14 at 14:50 +0100, Stephan Bergmann wrote: > > diff --git a/libcmis/libcmis-0.1.0-non-virtual-dtor.patch > > b/libcmis/libcmis-0.1.0-non-virtual-dtor.patch > > new file mode 100644 > > index 000..764c7b2 > > --- /dev/null > > +++ b/libcmis/libcmis-0.1.0-non-virtual-

Re: [PATCH] add 'Japanese Postcard' paper size to both Paper format and Print dialog

2012-03-14 Thread Caolán McNamara
On Wed, 2012-03-14 at 03:01 +0900, Takeshi Abe wrote: > But I think it would be controversial to have extra paper sizes which no > ones but only in a few locale use often. > Any thought? Not a problem IMO, go ahead and push it. It wouldn't make sense to exclude Japanese Postcard size, when we sho

Re: [PUSHED] Re: Prevent possible memory leak by adding virtual destructor

2012-03-14 Thread Stephan Bergmann
On 03/13/2012 11:38 PM, Michael Stahl wrote: On 13/03/12 21:14, Arnaud Versini wrote: This patch add a virtual destructor to all classes from WW8ResourceModel.hxx with virtual methods to prevent memory leaks likes rtf few days ago almost from docx import filter. thanks, pushed Turns out my p

libcmis patch (was: [Libreoffice-commits] .: Enable -Wnon-virtual-dtor for GCC 4.6)

2012-03-14 Thread Stephan Bergmann
On 03/14/2012 01:32 PM, Stephan Bergmann wrote: commit 6e67c03dc0225fc66343546b14e902b9d238b1a3 Author: Stephan Bergmann Date: Wed Mar 14 13:27:56 2012 +0100 Enable -Wnon-virtual-dtor for GCC 4.6 ...which has the necessary features to support it. Change a lot of classes to eit

[REVIEW: 3-5, 3-4] fdo#43932 setting paper tray from print dialog

2012-03-14 Thread David Tardon
Commit 6d4cca9c22c52b5a7742adc47ebf1a2930e29764 is an attempt to fix fdo#43932 . The problem was that PrinterController always used default tray, unless it was overriden by application-set one. Now it actually uses the chosen one (which may not be the same the user selected, because of of printer d

Re: [ANN] LibreOffice 3.5.1 RC2 available

2012-03-14 Thread Ivan Timofeev
On 14.03.2012 16:56, Joop Kiefte wrote: I recommend/suggest to answer in the language you speak best (I suppose Russian in this case) At least, I could translate from Russian to English, and I think I would do it better then Google Translate... :) Ivan ___

Re: [PATCH] add 'Japanese Postcard' paper size to both Paper format and Print dialog

2012-03-14 Thread Kohei Yoshida
On Wed, 2012-03-14 at 03:01 +0900, Takeshi Abe wrote: > Hi, > > I would like to add an option for the paper size of 'Japanese Postcard' > [1] to combo boxes such as Paper format and Print dialog. > The attached patch against master seems sufficient for that because its > actual dimension is alread

Re: [Libreoffice] [PATCH] add function in SwEditShell and fix some comments

2012-03-14 Thread Maxime de Roucy
Attention : the patch 0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch need the preview patch 0004-SwEditShell-use-of-the-STL-swap-function.patch which is currently waiting for moderator approval to be published in the mailing list. -- Maxime de Roucy Groupe LINAGORA - OSSA 80 rue Ro

[PATCH] convert tools/table.hxx usage in to std::map in ScChartPosition class in SC module

2012-03-14 Thread Noel Grandin
Hi License is on file. Note that this is not the nicest patch to review because I'm converting complicated nested loops. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0001-Convert-tools-table.hxx-to-std-map-in-ScChartPositio.patch Description: application/mbox

Re: [ANN] LibreOffice 3.5.1 RC2 available

2012-03-14 Thread Joop Kiefte
I recommend/suggest to answer in the language you speak best (I suppose Russian in this case) and give the translation as an addition. That way people with even a little knowledge of Russian or with access to a dictionary might be able to understand you better, because they have a fallback. 2012/3

Re: [ANN] LibreOffice 3.5.1 RC2 available

2012-03-14 Thread ape
My English and Google Translate does not give me a chance to explain the cause of the error in a single message - LibreOffice can not create all descriptions (folder) for all OLE objects. But I found a workaround: 1. Open DOCX. 2. DOCX Save as FODT. 3. FODT reload. 4. FODT save as ODT. Best

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 35669, which changed state. Bug 35669 Summary: Incorrect cross-references to illustrations and equations in master documents https://bugs.freedesktop.org/show_bug.cgi?id=35669 What|Old Value

Re: [PATCH] convert tools/table.hxx to std::map in ScEEParser class in SC module

2012-03-14 Thread Noel Grandin
Hi Updated patch attached. Thanks, Noel Grandin On 2012-03-12 14:33, Ivan Timofeev wrote: Hi Noel, for ( SCCOL nCol = nStartCol; nCol <= nEndCol; nCol++ ) { - sal_uInt16 nWidth = (sal_uInt16)(sal_uLong) pColWidths->Get( nCol ); + sal_uInt16 nWidth = 0; + if ( rColWidths.find( nCol )

[Libreoffice] [PATCH] add function in SwEditShell and fix some comments

2012-03-14 Thread Maxime de Roucy
Hello Here is 2 new patch : 0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch Create the function GetCurParAttr and GetPaMParAttr in the SwEditShell class. The function will be used in future patchs (on the format paintbrush) that I need to format correctly. 0002-fix-of-comments.patc

Svx..ToolBoxControl: why is StateChanged) not called?

2012-03-14 Thread Winfried Donkers
Hello all, I am working on the 'old style' colour button to split button conversion (fdo 45671), but I encounter a problem: The split button uses SvxColorExtToolBoxControl, which has a method StateChanged(). This method is called when a colour has been chosen from the colour palette. However, i

Re: Linux-x86 not uploading to dev-builds ?

2012-03-14 Thread Cor Nouws
Hi Petr, Petr Mladek wrote (14-03-12 10:59) Thanks to Fridrich, we have one from yesterday. \\o// for Fridrich We are sorry, we were busy with the 3.4 and 3.5 bugfix releases and sometimes forgot to switch the tinderbox back to master. It's not a huge problem - I don't download it so of

Re: [PUSHED] Add Switches to find-german-comments to aid in weeding false positives

2012-03-14 Thread Miklos Vajna
Hi Michael, On Wed, Mar 14, 2012 at 09:30:21AM +, Michael Meeks wrote: > It's a tad unclear to me why hexadecimal is flagged as German :-) I'd > prefer to grok & fix that really: > > $ bin/find-german-comments cppuhelper > cppuhelper/source/unourl.cxx:264: c != 0x2F && c != 0x3A && c

Re: performance enhancements for cygwin make

2012-03-14 Thread Noel Grandin
Can't be completely sure because I'm struggling to get the current master to build on Windows, but from some cursory testing, I'm not seeing much (if any) use of cp and touch in the offapi makefile. On the other hand, cygpath, mktemp and echo get called a lot. On 2012-03-13 14:36, Michael Meek

Re: Linux-x86 not uploading to dev-builds ?

2012-03-14 Thread Petr Mladek
Cor Nouws píše v St 07. 03. 2012 v 17:46 +0100: > http://dev-builds.libreoffice.org/daily/Linux-x86_10-Release_Configuration/ Thanks to Fridrich, we have one from yesterday. We are sorry, we were busy with the 3.4 and 3.5 bugfix releases and sometimes forgot to switch the tinderbox back to master

Re: [PUSHED] Add Switches to find-german-comments to aid in weeding false positives

2012-03-14 Thread Michael Meeks
On Wed, 2012-03-14 at 08:59 +0100, Miklos Vajna wrote: > > comments. The second is --threshold (t), which suppresses any output for > > comments that have less than [t] flagged comments. This should help with > > false positives, since it seems that files with only 1 or 2 "German" > > comments are

Re: [ANNOUNCE] libreoffice-3.5.1.2 tag created (3.5.1-rc2)

2012-03-14 Thread Michael Meeks
Hi Tommy, On Wed, 2012-03-14 at 09:39 +0100, Tommy wrote: > > there have been created the libreoffice-3.5.1.2 tag for 3.5.1-rc2 > > release. > > Hi, is the RC2 going to be released "bit-per-bit" as 3.5.1 final? In the absence of any horrors I would expect that :-) > on the release plan

Re: Issue with vcl Text Control

2012-03-14 Thread Andrew Higginson
Hi, >> So basically my question is, is there a way to wrap text on a FixedText, >> or make the background on a MultiLineEdit transparent (or is there a >> better text control I can use?) > Use SetPaintTransparent( sal_True ); > If I remember correctly :) Okay so that worked but now I have anothe

Re: [ANNOUNCE] libreoffice-3.5.1.2 tag created (3.5.1-rc2)

2012-03-14 Thread Tommy
On Mon, 05 Mar 2012 17:39:09 +0100, Petr Mladek wrote: Hi, there have been created the libreoffice-3.5.1.2 tag for 3.5.1-rc2 release. Hi, is the RC2 going to be released "bit-per-bit" as 3.5.1 final? on the release plan page the publishing date is march 11th but I haven't seen an official

[Libreoffice] License statement: Linagora

2012-03-14 Thread Maxime de Roucy
Hello As asked by Michael, here is a quick statement about the Linagora's contributions to the LO project : All contributions past and present made to LibreOffice from Linagora are available under the terms the MPL / LGPLv3+. Until further notice, future contributions made to LibreOffice from Lin

Re: [PUSHED] Add Switches to find-german-comments to aid in weeding false positives

2012-03-14 Thread Miklos Vajna
Hi Tom, On Tue, Mar 13, 2012 at 10:58:23PM -0400, Tom Thorogood wrote: > Added two switches to bin/find-german-comments > The first is --line-numbers (-l), which outputs a filename only once, > followed by (mostly) neat formatting of the line numbers with flagged > comments. The second is --thre