Re: [PATCH] convert tools/table.hxx to std::map in ScEEParser class in SC module

[Noel Grandin]

Hi

Updated patch attached.

Thanks, Noel Grandin

On 2012-03-12 14:33, Ivan Timofeev wrote:

Hi Noel,

 for ( SCCOL nCol = nStartCol; nCol <= nEndCol; nCol++ )
 {
-   sal_uInt16 nWidth = (sal_uInt16)(sal_uLong) pColWidths->Get( nCol );
+   sal_uInt16 nWidth = 0;
+   if ( rColWidths.find( nCol ) != rColWidths.end() )
+      nWidth = rColWidths[ nCol ];

  iterator it = rColWidths.find( nCol );
  if ( it != rColWidths.end() )
     nWidth = it->second;

is better? Or I am missing smth.?

Regards,
Ivan

so this code performs a search twice - firstly 'find', then 'operator[]'. And it is in the loop. And it is an import filter. Maybe

Disclaimer: http://www.peralex.com/disclaimer.html

0001-Convert-tools-table.hxx-to-std-map-in-ScEEParser-cla.patch
Description: application/mbox

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice