Re: [Libreoffice] Check for updates uses keep-alive / impacts the server (opengrok, tinderbox..)

2012-01-16 Thread Stephan Bergmann
On 01/17/2012 05:00 AM, Thorsten Behrens wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=09954fc863c8ee900f157cab4458e1dcf51493d3 (css.beans.NamedValue is a little more lightweight than PropertyValue in cases like this.) Stephan _

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread julien2412
I just finished to compile. There's no errors in console but when I clicked on Preview, I've got no response as if there was a infinite loop (I've just waited 20 seconds not minutes so perhaps I'm wrong :-)). I must go to my job so I don't have time for the moment to gdb this part. Julien. -- Vi

[Libreoffice] error in running solenv/bin/ooinstall

2012-01-16 Thread Cor Nouws
Hi, so fresh pull, make, make dev-install $ cd install/program $ . ./ooenv $ ./soffice.bin works as exxpected: build ID Build ID: a9ebfbc-9eed775-f061262 $ cd ../.. $ source ./Env/Host.sh $ solenv/bin/ooinstall ~/LibreOffice/35master120116 gives errors .. Running LibreOffice installer Subro

[Libreoffice] [REVIEW 3-5, 3-4] fdo#43193: fix rotation of shapes in imported MS documents

2012-01-16 Thread Ivan Timofeev
Hello, I want to push the following commit to 3-5 and to 3-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=005d6524977bd51ce2f859b5ae5352a2fba68dd0 It fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43193 partially reverting: http://cgit.freedesktop.org/libreoffice/core/commit/?id

Re: [Libreoffice] Check for updates uses keep-alive / impacts the server (opengrok, tinderbox..)

2012-01-16 Thread Thorsten Behrens
Michael Meeks wrote: > The code lives in extensions/source/update/check/ quite why it is > failing to close the connection there is unclear to me. I -imagine- we > want clients to poll at intervals, instant notification of updates is > not a useful feature to pay for millions of open sockets

[Libreoffice] --with-theme without tango ?

2012-01-16 Thread Bjoern Michaelsen
Hi, while adding the human theme to configure and scp, I stumbled over: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d1839b973b330e2e0e8d8a6aca2a21f2c982e63c which, if I see that correctly has to break in module_hidden_ooo.scp if building without the last listed theme. I therefore a

[Libreoffice] uno.RuntimeException when convert ODT to HTML

2012-01-16 Thread Gabriel Monnerat
Hello everybody, I am trying convert one document(ODT to HTML) using one web service written in Python. But, using the LibreOffice interface I got this failure: """ Error saving the document P-SAFI-Install.Serv: Write Error. The file could not be written """ and using the web service via PyUNO,

[Libreoffice] [PUSHED][PATCH] Removing unused code

2012-01-16 Thread Caolán McNamara
On Mon, 2012-01-16 at 12:26 +0100, Alexander Bergmann wrote: > --- > sax/source/tools/fshelper.cxx | 48 > - > unusedcode.easy |4 --- > 2 files changed, 0 insertions(+), 52 deletions(-) Looks good to me. Pushed now, thanks for these.

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread Caolán McNamara
On Mon, 2012-01-16 at 12:33 -0800, julien2412 wrote: > You're right Caolan, I checked there : > http://en.cppreference.com/w/cpp/container/map/erase > I didn't know that it was a recent feature, just thought it was useful, so I > didn't think about checking it existed :-) > > I'm trying right now

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread julien2412
You're right Caolan, I checked there : http://en.cppreference.com/w/cpp/container/map/erase I didn't know that it was a recent feature, just thought it was useful, so I didn't think about checking it existed :-) I'm trying right now to find a solution another way. Julien PS : I use gcc (Debian 4.

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread Stephan Bergmann
On 01/16/2012 06:12 PM, Caolán McNamara wrote: Does this work ? I worry (maybe I'm out of date on this one?) that std::map::erase only returns an iterator in C++11x not C++98 which we still support. Its a C++11 extension. Stephan ___ LibreOffice mail

[Libreoffice] [PUSHED] Re: About "Same expression on both sides of '||'" in LockEntrySequence.cxx

2012-01-16 Thread julien2412
Thank you Caolan and Christophe ! I commited the patch as it was and pushed on Master. Julien. (PS : if you want/think useful I cherry pick it on 3.5, I can do it) -- View this message in context: http://nabble.documentfoundation.org/About-Same-expression-on-both-sides-of-in-LockEntrySequence-cx

Re: [Libreoffice] [PATCH][PUSHED] Add import of docvariable fields from word documents

2012-01-16 Thread Lubos Lunak
On Wednesday 11 of January 2012, Kenneth Aafløy wrote: > Hi, > > Attached is a patch that adds support for importing docvariable fields > from microsoft word documents. The variables themselves are already > converted correctly, so this patch only ties the field to the existing > custom document in

Re: [Libreoffice] There is no round() in msvc library (fdo#44173)

2012-01-16 Thread Korrawit Pruegsanusak
Hello Tim, Kohei, * On Mon, Jan 16, 2012 at 01:26, Kohei Yoshida wrote: > Calc uses rtl::math::round from sal module (in sal/inc/rtl/math.hxx). > My suggestion is to stick with that one instead of introducing another > OS independent round function. Thanks! :-) I just push a fix. http://cgit.fre

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread Caolán McNamara
On Sat, 2012-01-14 at 11:17 -0800, julien2412 wrote: > Hello, > > I propose the attached patch for fdo#44040 (see > https://bugs.freedesktop.org/attachment.cgi?id=55580) > Since I could have missed something, I would like your opinion about this. Does this work ? I worry (maybe I'm out of date on

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-16 Thread Eike Rathke
Hi Noel, On Monday, 2012-01-16 16:11:14 +, Noel Power wrote: > >Not every operation on date types should return a date, > I have to admit I was swayed by Andrew's point that letting the > operations just return Dates seems more consistent.Also it would > seem to me subtraction should at least

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 43458, which changed state. Bug 43458 Summary: LibreOffice does not start with a second monitor connected https://bugs.freedesktop.org/show_bug.cgi?id=43458 What|Old Value |New Value

[Libreoffice] License statement

2012-01-16 Thread Cheng-Chia Tseng
Hi, All my current and past contributions made to the LibreOffice project are done under the LGPLv3 / MPL1.1 or later version of these licenses. Until further notice, all my future contributions to the LibreOffice project are available under the LGPLv3 / MPL1.1 or later version of these licenses.

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #101 from Michael Meeks 2012-01-16 08:55:24 PST --- Suggest bug#44836 - leaking page-breaks in the rendering, makes the new feature look bad. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You ar

[Libreoffice] Writer table layout fix

2012-01-16 Thread Lubos Lunak
Hello, is there anybody knowledgeable enough of the Writer layout code who'd know what the purpose of the code in the attached patch is? I intend the remove it based on the fact that the purpose seems to be broken (assuming that I got it right in the commit message) and that I have a testcas

Re: [Libreoffice] [LibreOffice] [PUSHED][PATCH] DateAcceptancePattern and PartitiveMonths for Czech language

2012-01-16 Thread Eike Rathke
forgot PUSHED in subject -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpRLtRda6TeH.pgp Description: PGP signature ___ LibreOffice mailing lis

Re: [Libreoffice] [LibreOffice] [PATCH] DateAcceptancePattern and PartitiveMonths for Czech language

2012-01-16 Thread Eike Rathke
Hi Da'angh, On Sunday, 2012-01-15 11:02:20 +0100, Da'angh Khagaroth wrote: > Attached patch adds DateAcceptancePatterns and PartitiveMonths for > Czech language. Thanks, pushed to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=2955fc0c3ef3c15b5fdad43969402503ed439336 and the Par

Re: [Libreoffice] About "Same expression on both sides of '||'" in LockEntrySequence.cxx

2012-01-16 Thread Christophe Strobbe
At 17:15 16-1-2012, Caol�n McNamara wrote: On Sun, 2012-01-15 at 09:04 -0800, julien2412 wrote: > First, I thought about just replacing the above line by this one : > if ( !pCtx->hasType || !pCtx->hasScope ) I have no idea, but http://rfc-ref.org/RFC-TEXTS/2518/chapter23.html has... and th

[Libreoffice] [PUSHED][PATCH]Removed FormatterBase::SetFieldText(String const&, unsigned char) listed in unusedcode.easy

2012-01-16 Thread Caolán McNamara
On Sat, 2012-01-14 at 23:55 +0100, Mariusz Dykierek wrote: > Code is contributed under the LGPLv3+ / MPL pushed now as http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2d730f65774564f27f3f5a0d3a1ee94db21c47f, thanks for this. C. p.s. I added removing SetFieldText from the header as well

Re: [Libreoffice] About "Same expression on both sides of '||'" in LockEntrySequence.cxx

2012-01-16 Thread Caolán McNamara
On Sun, 2012-01-15 at 09:04 -0800, julien2412 wrote: > First, I thought about just replacing the above line by this one : > if ( !pCtx->hasType || !pCtx->hasScope ) I have no idea, but http://rfc-ref.org/RFC-TEXTS/2518/chapter23.html has... and this is LockEntrySequence_endelement_callback p

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-16 Thread Noel Power
Hi Eike, On 16/01/12 13:01, Eike Rathke wrote: Hi Noel, On Friday, 2012-01-13 09:51:33 +, Noel Power wrote: this change ( the variant ) is what is on master, here the intention is as Andrew pointed out ( in a previous mail discussing the regression ) to allow operations on date types retur

Re: [Libreoffice] New Tinderbox Linux-RHEL6-x86_64-check

2012-01-16 Thread Stephan Bergmann
On 01/13/2012 05:42 PM, Stephan Bergmann wrote: On 01/13/2012 03:33 PM, Michael Stahl wrote: On 13/01/12 15:14, Stephan Bergmann wrote: Given that SwXTextDocument::close is just void SwXTextDocument::close( sal_Bool bDeliverOwnership ) throw( util::CloseVetoException, RuntimeException ) { if(

Re: [Libreoffice] FOSDEM / proto schedule ...

2012-01-16 Thread Cor Nouws
Michael Meeks wrote (16-01-12 15:12) On Mon, 2012-01-16 at 13:47 +0100, Cor Nouws wrote: Will be the Saturday, I suppose? That's the plan - did you want to do a QA talk at lunch ? No idea yet - but if there is room in the schedule, I'd love to step in for that subject! -- - Cor

Re: [Libreoffice] ooo_custom_images to icon-themes, was: Re: Do we support classic and industrial theme?

2012-01-16 Thread Noel Power
On 16/01/12 13:48, Stefan Knorr (Astron) wrote: Anyway, I just moved these icons over: http://cgit.freedesktop.org/libreoffice/core/commit/?id=75e3bffa1006eeb91324eaeabd52182d25b28711 I would have gladly moved them myself ( with the info ) but grateful that you did it for me :-) thanks again,

Re: [Libreoffice] FOSDEM / proto schedule ...

2012-01-16 Thread Michael Meeks
On Mon, 2012-01-16 at 13:47 +0100, Cor Nouws wrote: > Will be the Saturday, I suppose? That's the plan - did you want to do a QA talk at lunch ? Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot _

Re: [Libreoffice] [PUSHED][REVIEW] pls add this to 3.4.6 Re: [Bug 39118] Charts with anchor to cell do not update automatically

2012-01-16 Thread Cor Nouws
Eike Rathke wrote (16-01-12 14:43) Pushed to 3-4 with my sign-off: 99484e05a48f6253e1ff4fd2e8cc80cdbe5d Thanks guys ! -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 39118, which changed state. Bug 39118 Summary: Charts with anchor to cell do not update automatically https://bugs.freedesktop.org/show_bug.cgi?id=39118 What|Old Value |New Value

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

2012-01-16 Thread Cor Nouws
Cor Nouws wrote (15-01-12 21:05) Hmm, am I right if I guess that the RC1 will be delayed, in the queue behind 3.4.5 and the beta3 ? In that case, we might want to consider to move the 2nd session one/two weekends further on... According to IRC/devs, RC1 still to be expected this week. Great :-)

Re: [Libreoffice] ooo_custom_images to icon-themes, was: Re: Do we support classic and industrial theme?

2012-01-16 Thread Stefan Knorr (Astron)
Hi Noel, > hmm I didn't realise things changed here :-/ where should images formally in > custom_images live now ? looks like custom_images/*/*  => icon_images/*/* is > that right ?  i just need to move the files there ? Hm, almost, it's ooo_custom_images/* > icon-themes/* and default_images/ >

Re: [Libreoffice] [PUSHED][REVIEW] pls add this to 3.4.6 Re: [Bug 39118] Charts with anchor to cell do not update automatically

2012-01-16 Thread Eike Rathke
Hi, On Friday, 2012-01-13 23:39:43 +0100, Cor Nouws wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=681e8b1e43c1949871463934fa92396c00110270 Pushed to 3-4 with my sign-off: 99484e05a48f6253e1ff4fd2e8cc80cdbe5d Eike -- LibreOffice Calc developer. Number formatter stricke

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #100 from sasha.libreoff...@gmail.com 2012-01-16 05:40:35 PST --- Possible regression from 3.3.4 if confirmed: Bug 44829 - Impress EDITING: Undo not works when change master page -- Configure bugmail: https://bugs.freedesktop.org/use

Re: [Libreoffice] new configmgr access API ...

2012-01-16 Thread Stephan Bergmann
On 01/16/2012 02:09 PM, Caolán McNamara wrote: On Mon, 2012-01-16 at 09:18 +0100, Stephan Bergmann wrote: The UNO concept is to thread the (one and only) component context instance through the code Does the configmgr need the component context just for Components::getExternalValue, which I ima

Re: [Libreoffice] new configmgr access API ...

2012-01-16 Thread Caolán McNamara
On Mon, 2012-01-16 at 09:18 +0100, Stephan Bergmann wrote: > The UNO concept is to thread the (one and only) component context > instance through the code Does the configmgr need the component context just for Components::getExternalValue, which I imagine is to handle stuff like officecfg/regist

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-16 Thread Eike Rathke
Hi Noel, On Friday, 2012-01-13 09:51:33 +, Noel Power wrote: > this change ( the variant ) is what is on master, here the > intention is as Andrew pointed out ( in a previous mail discussing > the regression ) to allow operations on date types return dates ( > regardless of the operation )

Re: [Libreoffice] FOSDEM / proto schedule ...

2012-01-16 Thread Cor Nouws
Hi Michael, Michael Meeks wrote (16-01-12 13:14) I append the suggested schedule for some final review before I start typing it into the web interface at some length ;-) Impressive :-) Will be the Saturday, I suppose? -- - Cor - http://nl.libreoffice.org _

Re: [Libreoffice] embedded nulls in SvStream::ReadLine

2012-01-16 Thread Eike Rathke
Hi Caolán, On Monday, 2012-01-16 10:45:40 +, Caolán McNamara wrote: > caolanm->erack:, from" erAck 26.02.01: Old behavior was no special > treatment of '\0'..." I presume you noticed this weirdness ages ago as > well in converting it from += to Append. What do you think, worth > syncing ReadL

[Libreoffice] FOSDEM / proto schedule ...

2012-01-16 Thread Michael Meeks
Hi guys, So - JFYI - every submitted talk was accepted and packed (somehow) into the eight hours. That means some of them are quite short, and we'll really need to get moving in the room. I append the suggested schedule for some final review before I start typing it into the web i

[Libreoffice] [ANN] LibreOffice 3.5.0 Beta3 available

2012-01-16 Thread Thorsten Behrens
Dear Community, The Document Foundation is happy to announce the third beta release of LibreOffice 3.5.0. The upcoming 3.5 will be our third major release line, packed with many exciting new features. Please be aware that LibreOffice 3.5.0 Beta3 is not ready for production use, you should continue

Re: [Libreoffice] [PATCH] [PUSHED] Replaced DBG_ERRORFILE with SAL_INFO.

2012-01-16 Thread David Tardon
On Sun, Jan 15, 2012 at 10:11:36AM +0100, Marcel Metz wrote: > Hello lo-devs, > > as mentioned in the subject these patches replace the DBG_ERRORFILE > macro with SAL_INFO as suggested in the tools/debug.hxx header. The > patches were created with git format-patch. Thanks, pushed. D. ___

[Libreoffice] [PATCH] Removing unused code

2012-01-16 Thread Alexander Bergmann
--- sax/source/tools/fshelper.cxx | 48 - unusedcode.easy |4 --- 2 files changed, 0 insertions(+), 52 deletions(-) diff --git a/sax/source/tools/fshelper.cxx b/sax/source/tools/fshelper.cxx index 89c2b1a..6cdd39d 100644 --- a/sax/source

[Libreoffice] [REVIEWED]PUSHED][3.4.x]fdo#38515 annoying crasher fix

2012-01-16 Thread Michael Meeks
On Fri, 2012-01-13 at 18:46 +0100, Cedric Bosdonnat wrote: > Could someone review / cherry-pick this patch for the 3.4.x branches? > http://cgit.freedesktop.org/libreoffice/core/commit/?id=4914b23e7e91b184d69eb00a74ce1c463c5754a7 Looks reasonable to me, ATB, Mich

[Libreoffice] [LibreOffice] License statement

2012-01-16 Thread Alexander Bergmann
Hi @all, all my contributions to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Best regards, Alexander Bergmann ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [LibreOffice][Patch][PUSHED] translate comments to English frmedt

2012-01-16 Thread David Tardon
On Sun, Jan 15, 2012 at 10:56:38PM +0100, Luc Castermans wrote: > Hi, > > Following yesterdays contribution here more translations. > One more file to go and then /sw/source/core/frmedt is done. Too late > to finish today. Pushed. Thank you for your great work :-) D. ___

Re: [Libreoffice] ooo_custom_images to icon-themes, was: Re: Do we support classic and industrial theme?

2012-01-16 Thread Noel Power
On 16/01/12 10:17, Michael Meeks wrote: On Sun, 2012-01-15 at 13:04 +0100, Stefan Knorr (Astron) wrote: Finally done that, it was easier than I thought, too. Just had to change another help makefile ... actually reading make's error messages does help. Lovely :-) - strangely I still hav

[Libreoffice] embedded nulls in SvStream::ReadLine

2012-01-16 Thread Caolán McNamara
In tools/qa/cppunit/test_stream.cxx:Test I added test_readline and after poking around adding some edge-cases I see that Stream::ReadLine has the odd quirk that it ignores embedded nulls in lines it reads, i.e. foo\0bar\n is read as "foobar", not "foo\0bar" or even "foo". That seems kind of odd to

Re: [Libreoffice] [PATCH] Simple fix for fontconfig.cxx to review (from cppcheck report)

2012-01-16 Thread Caolán McNamara
On Sun, 2012-01-15 at 09:48 +0400, Ivan Timofeev wrote: > AFAIK in arithmetic bools are concerted to int so that true->1 and false->0. > Then, the result is converted back to bool (because the function returns > bool) so that 0->false and 'any other value'->true. > > So "return bool1 - bool2" can

Re: [Libreoffice] ooo_custom_images to icon-themes, was: Re: Do we support classic and industrial theme?

2012-01-16 Thread Michael Meeks
On Sun, 2012-01-15 at 13:04 +0100, Stefan Knorr (Astron) wrote: > Finally done that, it was easier than I thought, too. Just had to > change another help makefile ... actually reading make's error > messages does help. Lovely :-) - strangely I still have an ooo_custom_images directory loc

Re: [Libreoffice] Check for updates uses keep-alive / impacts the server (opengrok, tinderbox..)

2012-01-16 Thread Michael Meeks
Hi Christian, On Mon, 2012-01-16 at 00:43 +0100, Christian Lohmaier wrote: > GET /check.php?pkgfmt=rpm HTTP/1.1 > Keep-Alive: > Connection: TE, Keep-Alive Nice catch :-) > Please consider this as stopper for upcomping versions. Right; so one problem here is that Kendy who did th

Re: [Libreoffice] new configmgr access API ...

2012-01-16 Thread Stephan Bergmann
On 01/13/2012 04:14 PM, Michael Meeks wrote: On Fri, 2012-01-13 at 14:15 +0100, Stephan Bergmann wrote: UNO *is* the tool to make functionality available to different languages, to extensions, and to scripting facilities. Sure - of course. This API, on the other hand, is a C++ syntacti