Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-15 Thread Stephan Bergmann
On 01/13/2012 05:08 AM, Markus Mohrhard wrote: I did not push that patch directly because I'm not sure if we really want to introduce another registry entry for this. After seeing the patch pushed, it occurred to me that we usually use env vars (instead of configuration settings etc.) to contr

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44210, which changed state. Bug 44210 Summary: VIEWING: StartCenter corrupted under Gnome 3 https://bugs.freedesktop.org/show_bug.cgi?id=44210 What|Old Value |New Value --

Re: [Libreoffice] [PATCH] Simple fix for frmsh.cxx to review (from cppcheck report)

2012-01-15 Thread julien2412
You're absolutely right ! It can't be both at the same time :-( Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-Simple-fix-for-frmsh-cxx-to-review-from-cppcheck-report-tp3658800p3662400.html Sent from the Dev mailing list archive at Nabble.com.

Re: [Libreoffice] [PATCH] Simple fix for frmsh.cxx to review (from cppcheck report)

2012-01-15 Thread David Tardon
On Sat, Jan 14, 2012 at 04:08:46AM -0800, julien2412 wrote: > Hello, > > cppcheck reported this : > core/sw/source/ui/shells/frmsh.cxx > 516 duplicateExpression style Same expression on both sides of '&&' > > After a quick reading, i thought about this page but perhaps it's less > straigh

Re: [Libreoffice] [PUSHED] libvisio: simple fix to prevent startMarker from disabling endMarker when both are non-zero

2012-01-15 Thread Fridrich Strba
Thanks for spotting this. I just pushed it into libvisio. F. On 15/01/12 17:31, Bruno Girin wrote: Hi all, It appears that in libvisio, if a line has a start arrow, the end arrow gets ignored. You'll find attached a simple patch that fixes this. Cheers, Bruno _

[Libreoffice] Dead code removal

2012-01-15 Thread Marc-André Laverdière
Hello list, Since I went a bit beyond unusedcode.easy, I prefer to ask review on this one :) Marc-André LAVERDIÈRE "Perseverance must finish its work so that you may be mature and complete, not lacking anything." -James 1:4 http://asimplediscipleslife.blogspot.com/ mlaverd.theunixplace.com From 4

[Libreoffice] Check for updates uses keep-alive / impacts the server (opengrok, tinderbox..)

2012-01-15 Thread Christian Lohmaier
Hi *, as there have been complaints lately that tinderbox server and also opengrok are unresponsive despite the server not seeing any CPU load or memory constraints, I thought that maybe the newly activated check-for-updates is to blame here, and indeed it is: Capturing the dialog with wireshark

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

2012-01-15 Thread Cor Nouws
Hi Petr, Thorsten, * Hmm, am I right if I guess that the RC1 will be delayed, in the queue behind 3.4.5 and the beta3 ? In that case, we might want to consider to move the 2nd session one/two weekends further on... Cor Nouws wrote (15-01-12 19:41) In any case, as it looks now, we are rathe

Re: [Libreoffice] About "Same expression on both sides of '||'" in LockEntrySequence.cxx

2012-01-15 Thread julien2412
Hi Miklos, Sorry, I badly explained what I meant in the last lines. When I told this "But I wonder if it should be "||" or "&&" " , I meant i don't know if it should be if ( !pCtx->hasType || !pCtx->hasScope ) or if ( !pCtx->hasType && !pCtx->hasScope ) Julien -- View this message in context:

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

2012-01-15 Thread Cor Nouws
Cor Nouws wrote (12-01-12 23:22) Cor Nouws wrote (09-01-12 23:10) Find mentors "officially" and don't rely on people to show up for the second one. It did work out on the first session, but esp. for the follow-up event it should be sure that mentors are around. I agree with that. Are there

Re: [Libreoffice] About "Same expression on both sides of '||'" in LockEntrySequence.cxx

2012-01-15 Thread Miklos Vajna
On Sun, Jan 15, 2012 at 09:04:23AM -0800, julien2412 wrote: > Cppcheck detects this : > core/ucb/source/ucp/webdav/LockEntrySequence.cxx > 174 duplicateExpression style Same expression on both sides of '||'. > > case STATE_LOCKENTRY: > if ( !pCtx->hasType || !pCtx->ha

Re: [Libreoffice] There is no round() in msvc library (fdo#44173)

2012-01-15 Thread Kohei Yoshida
Hi there, On Sun, Jan 15, 2012 at 1:04 PM, Tim Hardeck wrote: > But if ::boost::math::iround will be used in other places or if there is > already another usable round function - what does Calc use? Calc uses rtl::math::round from sal module (in sal/inc/rtl/math.hxx). My suggestion is to stick

Re: [Libreoffice] [PUSHED][PATCH] Bug 33794 - The "Open..." button of the initial screen needs more room for localization fdo#33794

2012-01-15 Thread Ivan Timofeev
14.01.2012 03:30, Tomcsik Bence Tibor пишет: I send the new patch. Ok, pushed to the master branch and cherry-picked to libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f628c7bf8361086be2044d0d6aa8bbf3f128162 http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreo

Re: [Libreoffice] There is no round() in msvc library (fdo#44173)

2012-01-15 Thread Tim Hardeck
Hi Korrawit, thanks for testing and your hints how to address the problem. The reason why I was using round was to reduce the difference between the positions while scrolling in one direction and then back. With round it takes more steps to reach a position where they will differ slightly. Sinc

[Libreoffice] About "Same expression on both sides of '||'" in LockEntrySequence.cxx

2012-01-15 Thread julien2412
Hello, Cppcheck detects this : core/ucb/source/ucp/webdav/LockEntrySequence.cxx 174 duplicateExpression style Same expression on both sides of '||'. case STATE_LOCKENTRY: if ( !pCtx->hasType || !pCtx->hasType ) <-- Here return 1; // abort

[Libreoffice] [PATCH] libvisio: simple fix to prevent startMarker from disabling endMarker when both are non-zero

2012-01-15 Thread Bruno Girin
Hi all, It appears that in libvisio, if a line has a start arrow, the end arrow gets ignored. You'll find attached a simple patch that fixes this. Cheers, Bruno >From f794fdd967d2eb9a9cd5d4d0fb16a1d19f65f168 Mon Sep 17 00:00:00 2001 From: Bruno Girin Date: Sun, 15 Jan 2012 16:25:12 + Su

Re: [Libreoffice] libvisio: how can I help?

2012-01-15 Thread Fridrich Strba
On 15/01/12 14:59, Bruno Girin wrote: Would anybody be able to tell me where I can find the git repos for libwpd, libwpg and libwps please? Libwpd: git://libwpd.git.sourceforge.net/gitroot/libwpd/libwpd Libwps: git://libwps.git.sourceforge.net/gitroot/libwps/libwps Libwpg: git://libwpg.git.so

[Libreoffice] There is no round() in msvc library (fdo#44173)

2012-01-15 Thread Korrawit Pruegsanusak
Hello Tim, all, Your patch addressing fdo#44173 regarding zoom level [1] cause the windows msvc tinderbox failure. [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=022ce7d362f146ed69f54aae20cf2b8c582e9f8d Actually, the one to blame is the msvc library, because it doesn't have round()

Re: [Libreoffice] libvisio: how can I help?

2012-01-15 Thread Bruno Girin
On 12/01/12 08:14, Fridrich Strba wrote: 1) I install the git versions of libwpd/libwpg/libwps/libvisio (and libcdr for master builds) in the usual system prefix. For my 64-bit system it is --prefix=/usr --libdir=/usr/lib64 Would anybody be able to tell me where I can find the git repos for l

Re: [Libreoffice] [PATCH] Simple fix for fontconfig.cxx to review (from cppcheck report)

2012-01-15 Thread Mat M
Le Sun, 15 Jan 2012 06:48:28 +0100, Ivan Timofeev a écrit: Hi Mat, cppcheck reported this : core/vcl/generic/fontmanager/fontconfig.cxx 196 duplicateExpression style Same expression on both sides of '-' class SortFont : public ::std::binary_function< const FcPattern*, const FcPattern*, boo

Re: [Libreoffice] ooo_custom_images to icon-themes, was: Re: Do we support classic and industrial theme?

2012-01-15 Thread Stefan Knorr (Astron)
Hi, just to let you know: > On 4 January 2012 17:39, Michael Meeks wrote: >>        Great; so - moving default_images into there and making it 'galaxy' >> would be a nice cleanup I guess; Finally done that, it was easier than I thought, too. Just had to change another help makefile ... actually

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #99 from Lior Kaplan 2012-01-15 03:53:32 PST --- @Roman I closed bug 44770 (as dup) after it was mentioned here. The fix will be at beta3 while it was reported on beta2. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #98 from Roman Eisele 2012-01-15 03:48:35 PST --- (In reply to comment #96) > Another interesting bug: > Bug 44770 - Writer FILESAVE: document, saved by LibO 3.5.0 opens incorrectly > in > LibO 3.3.4 and 3.4.3 @sasha: You nominated

[Libreoffice] [LibreOffice] [PATCH] DateAcceptancePattern and PartitiveMonths for Czech language

2012-01-15 Thread Da'angh Khagaroth
Attached patch adds DateAcceptancePatterns and PartitiveMonths for Czech language. Aside from that it also changes a few date formating patterns to better comply with Czech date writing conventions. Note that there is one peculiarity in date writing in Czech. Normally the partitive form is used whe