[Libreoffice] About "Same expression on both sides of '||'" in LockEntrySequence.cxx

[julien2412]

Hello,

Cppcheck detects this :
core/ucb/source/ucp/webdav/LockEntrySequence.cxx
174     duplicateExpression     style   Same expression on both sides of '||'.

        case STATE_LOCKENTRY:
            if ( !pCtx->hasType || !pCtx->hasType ) <-- Here
                return 1; // abort
            break;

First, I thought about just replacing the above line by this one : 
if ( !pCtx->hasType || !pCtx->hasScope )

But I wonder if it should be "||" or "&&"

Any idea ?

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/About-Same-expression-on-both-sides-of-in-LockEntrySequence-cxx-tp3661021p3661021.html
Sent from the Dev mailing list archive at Nabble.com.
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice