[Libreoffice] unit test concept for draw/impress

2012-01-12 Thread Markus Mohrhard
Hey, I finally found some time working on a unit test concept for draw/impress as promised to Thorsten in Paris. (see [1]) The attached patch enables the new test concept in sd. The test is based on calc's filters-test concept but needs to do some additional steps. We take a import file (e.g. an

[Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-12 Thread Markus Mohrhard
Hey, I finally found a solution to the lockfile problem. The attached patch prevents lockfiles during unit tests. I did not push that patch directly because I'm not sure if we really want to introduce another registry entry for this. If this is the correct patch i would like to push that to mast

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-12 Thread Michael Stahl
On 12/01/12 16:55, Noel Power wrote: > Be good to get this in, afaict this shouldn't cause any problems > see attached patch > > Noel looking at the change, i notice that now it is independent of the operation being performed, while the code that was originally removed in adcba12537d047f5ad65334b

[Libreoffice] FATToVFat_Impl: desktop/source/app/appsys.*: windows

2012-01-12 Thread Caolán McNamara
These can be removed right ?, I mean, I don't see any use of them anywhere or anything using appsys.hxx, so appsys.hxx and appsys.cxx could be completely removed as far as I can see. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

2012-01-12 Thread Cor Nouws
Hi all, Cor Nouws wrote (09-01-12 23:10) Find mentors "officially" and don't rely on people to show up for the second one. It did work out on the first session, but esp. for the follow-up event it should be sure that mentors are around. I agree with that. Are there people that can help with

Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?

2012-01-12 Thread August Sodora
Does it make sense to do --log-file=valgrind.out.%p ? August Sodora aug...@gmail.com (201) 280-8138 On Thu, Jan 12, 2012 at 11:46 AM, Petr Mladek wrote: > Stephan Bergmann píše v Čt 12. 01. 2012 v 11:37 +0100: >> On 11/11/2011 09:36 AM, Stephan Bergmann wrote: >> > On 10/26/2011 09:00 PM, Step

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Kohei Yoshida changed: What|Removed |Added Depends on|37860 | -- Configure bugmail: https://bugs.fre

Re: [Libreoffice] How can we use extensions' plugins ?

2012-01-12 Thread Petr Mladek
Matúš Kukan píše v Čt 12. 01. 2012 v 16:32 +0100: > Hi there, > > I was wondering, mainly because there are still problems to compile > extensions: > > there are two *plugin* directories: > extensions/source/plugin/ > extensions/source/nsplugin/ > - Here we also build Executable and Library but

Re: [Libreoffice] minutes of ESC call ...

2012-01-12 Thread Petr Mladek
Michael Meeks píše v Čt 12. 01. 2012 v 16:23 +: > Hard English string & UI freeze - in effect now > > + After Monday/Tuesday's RC1 tag need a 2nd review It means to ask for one review/approval on the libreoffice@lists.freedesktop.org mailing list before cherry-

Re: [Libreoffice] [REVIEW][3-4] fdo#44078 boxes shown for glyph fallback with DejaVu Sans ExtraLight (he/ar)

2012-01-12 Thread Kohei Yoshida
On Thu, 2012-01-12 at 11:08 +, Caolán McNamara wrote: > We probably need a wiki dashboard Perhaps we could add such info to this wiki page: http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc _

Re: [Libreoffice] [PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

2012-01-12 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Christina Em 12-01-2012 14:30, Chr. Rossmanith escreveu: > Am 12.01.2012 17:17, schrieb Olivier Hallot: > > 1) update bug fdo43460 with your (pushed) patch? >> You mean just add an comment which mentions the directory I've been >> working in? Of c

Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?

2012-01-12 Thread Petr Mladek
Stephan Bergmann píše v Čt 12. 01. 2012 v 11:37 +0100: > On 11/11/2011 09:36 AM, Stephan Bergmann wrote: > > On 10/26/2011 09:00 PM, Stephan Bergmann wrote: > > But today I had to find out that even a single invocation of the > > sw/qa_complex test internally starts multiple soffice instances in a

Re: [Libreoffice] [PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

2012-01-12 Thread Chr. Rossmanith
Am 12.01.2012 17:17, schrieb Olivier Hallot: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thank you Christina for the patch. It look like your patch is ok, with respect to the logic inversion. A build should indicate if the method isEmpty() is valid for the right object (e.g. it is not valid f

[Libreoffice] minutes of ESC call ...

2012-01-12 Thread Michael Meeks
* Present: + Lionel, Tor, Michael, Eike, Norbert, Stephan, David, Fridrich, Rainer, Christian, Petr, Andras, Kohei, Thorsten, Mitch * Completed Action Items + add postgresql to 3.5 feature page (Lionel) + make it clear the SAL_INFO etc. macros are intern

Re: [Libreoffice] [PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

2012-01-12 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thank you Christina for the patch. It look like your patch is ok, with respect to the logic inversion. A build should indicate if the method isEmpty() is valid for the right object (e.g. it is not valid for OUStringBuffer or Sequence). Do you mind to

[Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-12 Thread Noel Power
Be good to get this in, afaict this shouldn't cause any problems see attached patch Noel >From 778c2ad1225ee3d1e9ac40ab584d8f5f428845fe Mon Sep 17 00:00:00 2001 From: Noel Power Date: Thu, 12 Jan 2012 15:46:52 + Subject: [PATCH] restore special DATE handling code for SbxValue::Compute fdo#4

Re: [Libreoffice] How can we use extensions' plugins ?

2012-01-12 Thread Michael Stahl
On 12/01/12 16:32, Matúš Kukan wrote: > extensions/source/nsplugin/ > - Here we also build Executable and Library but how can we use them ? >Because the library npsoplugin has no .component file associated to it. >Maybe here the executable loads the library ? But who is running > the execu

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #92 from Petr Mladek 2012-01-12 07:37:43 PST --- I understand it the way that all bugs are kind of nominated because they could be added and removed from the dependencies at any time if there are good reasons. I think that the main c

[Libreoffice] How can we use extensions' plugins ?

2012-01-12 Thread Matúš Kukan
Hi there, I was wondering, mainly because there are still problems to compile extensions: there are two *plugin* directories: extensions/source/plugin/ - We build there Library which has pl.component file, so I understand we can use it. There is also Executable for Linux which I guess is call

Re: [Libreoffice] [PUSHED] progressbar for rtf import

2012-01-12 Thread Miklos Vajna
On Thu, Jan 12, 2012 at 01:59:39PM +, Michael Meeks wrote: > > On Thu, 2012-01-12 at 14:11 +0100, Andras Timar wrote: > > We don't have process for that. The best solution would be, if I > > leveraged translation from sw for each language. So translators won't > > even notice. What a pity th

[Libreoffice] [ANN] LibreOffice 3.5.0 beta3 available

2012-01-12 Thread Thorsten Behrens
Hi *, for the upcoming new version 3.5.0, we continue with a beta3 build that is now feature-complete. For further milestones on the way towards 3.5.0, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.5_release Builds are now being uploaded to a pu

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #91 from Rainer Bielefeld 2012-01-12 07:01:01 PST --- @Tor: Because of that confusion I changed my wording to "Adding bug ...". I do not believe we should do long discussions here concerning each bug, IMHO the proceeding should be:

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #90 from Tor Lillqvist 2012-01-12 06:48:52 PST --- I am still confused about the usage of "nominate" here. http://en.wiktionary.org/wiki/nominate says it has two meanings: 1) To name someone as a candidate for a particular role or po

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #89 from Lionel Elie Mamane 2012-01-12 06:30:52 PST --- Nominate bug 44721: Cannot resize a control with the mouse in Report Builder. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiv

[Libreoffice] [PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

2012-01-12 Thread Chr. Rossmanith
Hi, while replacing ByteString with OString I came across some getLength() calls which might be replaced with isEmpty(). Hope Olivier won't be annoyed :-) Some reviewing would be nice to be sure the logic didn't get inverted accidently.I have git push access - so reviewing would be sufficie

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Lionel Elie Mamane changed: What|Removed |Added Depends on||44721 -- Configure bugmail: https:

[Libreoffice] [PATCH] Replace (Byte)String with rtl::O(U)String

2012-01-12 Thread Chr. Rossmanith
Hi, another bit of replacements for reviewing. Christina >From aadab6fdb17ef5fd56964164b711c3034d42168f Mon Sep 17 00:00:00 2001 From: Christina Rossmanith Date: Thu, 12 Jan 2012 10:52:31 +0100 Subject: [PATCH 1/2] Replace (Byte)String with rtl::O(U)String --- vcl/generic/fontmanager/fontcach

Re: [Libreoffice] error in writerperfect?

2012-01-12 Thread Fridrich Strba
Yes, indeed, Fixed now, thanks a lot. Cheers F. On 12/01/12 14:30, Ivan Timofeev wrote: Hi, glancing over the git-log I have noticed the following code writerperfect/source/filter/OdgGenerator.cxx:951 if (!propList["libwpg:mime-type"] && propList["libwpg:mime-type"]->getStr().len() <= 0) r

Re: [Libreoffice] [REVIEW-3-5] progressbar for rtf import

2012-01-12 Thread Michael Stahl
On 11/01/12 21:26, Miklos Vajna wrote: > Hi, > > I've implemented a progressbar for rtf import yesterday: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=92c7b6733e55a6ab62bc231ecf0ffd5c0da7c8d2 > > There are two bugreports requesting this: fdo#38057 and fdo#44157. The > second calls

Re: [Libreoffice] [REVIEWED] progressbar for rtf import

2012-01-12 Thread Michael Meeks
On Thu, 2012-01-12 at 14:11 +0100, Andras Timar wrote: > We don't have process for that. The best solution would be, if I > leveraged translation from sw for each language. So translators won't > even notice. What a pity that writerfilter cannot use sw's resources > directly. :) Which sou

Re: [Libreoffice] New Tinderbox Linux-RHEL6-x86_64-check

2012-01-12 Thread Michael Stahl
On 12/01/12 14:44, Stephan Bergmann wrote: > I added a new tinderbox "Linux-RHEL6-x86_64-check" to > (and it will spam > suspects with messages about failing builds in the usual way). > > The box does a rather complete build (--enable-binfilt

[Libreoffice] New Tinderbox Linux-RHEL6-x86_64-check

2012-01-12 Thread Stephan Bergmann
I added a new tinderbox "Linux-RHEL6-x86_64-check" to (and it will spam suspects with messages about failing builds in the usual way). The box does a rather complete build (--enable-binfilter, no --with-system switches) and especially enabl

[Libreoffice] error in writerperfect?

2012-01-12 Thread Ivan Timofeev
Hi, glancing over the git-log I have noticed the following code writerperfect/source/filter/OdgGenerator.cxx:951 if (!propList["libwpg:mime-type"] && propList["libwpg:mime-type"]->getStr().len() <= 0) return; Is there should be || instead of && ? Regards, Ivan __

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2012-01-12 Thread Michael Meeks
On Thu, 2012-01-12 at 10:44 +0100, Stephan Bergmann wrote: > > I think the best solution here would be to change the LibO hsqldb code, > > to call Attach/DetachCurrentThread rarely rather than frequently, but > > according to Ocke Janssen (who used to maintain that code) that was no > > easy optio

Re: [Libreoffice] [REVIEW-3-5] progressbar for rtf import

2012-01-12 Thread Andras Timar
Hi Michael, 2012/1/12 Michael Meeks : > Hi Miklos, > > On Wed, 2012-01-11 at 21:26 +0100, Miklos Vajna wrote: >> I've implemented a progressbar for rtf import yesterday: > >        Nice work ! :-) > >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=92c7b6733e55a6ab62bc231ecf0ffd5c0da7c8d2

Re: [Libreoffice] [LibreOffice] fdo#39428 Remove/audit SvStream operator long

2012-01-12 Thread Stephan Bergmann
On 01/11/2012 06:51 PM, Keith McRae wrote: Trying a full build resulted in "undefined reference to SvStream::operator>>(long&)" in svl/ vcl/ and svtools/ (so far). As most of these errors are the result of trying to (de)serialize Pair derived classes, I'm now wondering whether it

Re: [Libreoffice] [REVIEW-3-5] progressbar for rtf import

2012-01-12 Thread Michael Meeks
Hi Miklos, On Wed, 2012-01-11 at 21:26 +0100, Miklos Vajna wrote: > I've implemented a progressbar for rtf import yesterday: Nice work ! :-) > http://cgit.freedesktop.org/libreoffice/core/commit/?id=92c7b6733e55a6ab62bc231ecf0ffd5c0da7c8d2 > > There are two bugreports requesting this: f

Re: [Libreoffice] [REVIEW][PUSHED][3-4] fdo#44078 boxes shown for glyph fallback with DejaVu Sans ExtraLight (he/ar)

2012-01-12 Thread Stephan Bergmann
On 01/12/2012 12:08 PM, Michael Meeks wrote: On Thu, 2012-01-12 at 11:54 +0100, Stephan Bergmann wrote: How many reviews are currently needed for 3-4? One (ie. author + 1) - so it can be picked ;-) Pushed now. Stephan ___ LibreOffice maili

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Philipp Gassmann changed: What|Removed |Added Depends on||37860 --- Comment #88 from Philipp Ga

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Philipp Gassmann changed: What|Removed |Added Depends on||37860 --- Comment #246 from Philipp G

Re: [Libreoffice] [REVIEWED: 3-4] [PUSHED: 3-4] possible missing translations

2012-01-12 Thread David Tardon
On Thu, Jan 12, 2012 at 11:06:26AM +0100, Andras Timar wrote: > Hi David, > > 2012/1/12 David Tardon : > > Hi, > > > > commit 196885980bbb51562264cb5aad9a3e01133d1d7d fixes a situation where > > some translated strings may be missing from installation because of a > > bug in one of our tools. I wo

Re: [Libreoffice] [REVIEW][3-4] fdo#44078 boxes shown for glyph fallback with DejaVu Sans ExtraLight (he/ar)

2012-01-12 Thread Michael Meeks
On Thu, 2012-01-12 at 11:54 +0100, Stephan Bergmann wrote: > How many reviews are currently needed for 3-4? One (ie. author + 1) - so it can be picked ;-) Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___

Re: [Libreoffice] [REVIEW][3-4] fdo#44078 boxes shown for glyph fallback with DejaVu Sans ExtraLight (he/ar)

2012-01-12 Thread Caolán McNamara
On Thu, 2012-01-12 at 11:54 +0100, Stephan Bergmann wrote: > On 01/11/2012 10:09 PM, Caolán McNamara wrote: > > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=25b90909a7a22f6900abbe9df12570a24e528c9a > > Patch looks good to me (at least, it can't really make things worse

Re: [Libreoffice] [REVIEW][3-4] fdo#44078 boxes shown for glyph fallback with DejaVu Sans ExtraLight (he/ar)

2012-01-12 Thread Stephan Bergmann
On 01/11/2012 10:09 PM, Caolán McNamara wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=25b90909a7a22f6900abbe9df12570a24e528c9a Patch looks good to me (at least, it can't really make things worse, anyway; the cacheLocalizedFontNames signature change is not rel

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||38515 --- Comment #87 from Petr Mladek 20

Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?

2012-01-12 Thread Stephan Bergmann
On 11/11/2011 09:36 AM, Stephan Bergmann wrote: On 10/26/2011 09:00 PM, Stephan Bergmann wrote: On 10/26/2011 01:55 PM, Petr Mladek wrote: What is your preferred way of use? What exactly do you hate and/or miss? One problem is output of multiple (batched, like "make subsequentcheck") valgrind

Re: [Libreoffice] [REVIEWED: 3-4] possible missing translations

2012-01-12 Thread Andras Timar
Hi David, 2012/1/12 David Tardon : > Hi, > > commit 196885980bbb51562264cb5aad9a3e01133d1d7d fixes a situation where > some translated strings may be missing from installation because of a > bug in one of our tools. I would like to see it in 3.4 . > +1 from me. I tested your version on 3.4.5 and

Re: [Libreoffice] crasher in writer (footer)

2012-01-12 Thread Cedric Bosdonnat
Hi Michael, On Tue, 2012-01-10 at 22:28 +0100, Michael Stahl wrote: > should be fixed now on master and libreoffice-3-5: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e898354fc76339a9a007b30f1ebe123981d0426 > > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2012-01-12 Thread Stephan Bergmann
On 10/20/2011 09:08 AM, Stephan Bergmann wrote: On 10/19/2011 07:17 PM, Andrew Haley wrote: On 10/19/2011 05:57 PM, Michael Meeks wrote: On Wed, 2011-10-19 at 17:32 +0200, Stephan Bergmann wrote: What the LibO hsqldb code does a lot is call JNI's Attach/DetachCurrentThread. Googling around, <

Re: [Libreoffice] [PATCH] [PUSHED] Translate German comments

2012-01-12 Thread David Tardon
On Wed, Jan 11, 2012 at 04:10:36PM +0100, Philipp Weissenbacher wrote: > Hi lo-devs, > > More translations. Business as usual. Thanks :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/lib

[Libreoffice] [REVIEW: 3-4] possible missing translations

2012-01-12 Thread David Tardon
Hi, commit 196885980bbb51562264cb5aad9a3e01133d1d7d fixes a situation where some translated strings may be missing from installation because of a bug in one of our tools. I would like to see it in 3.4 . Details: The fast_merge.pl script creates hierarchy of localize.sdf files (one per source dir

Re: [Libreoffice] libvisio: how can I help?

2012-01-12 Thread Fridrich Strba
Hello, Thanks for filing the bugs. I really did not see that mistake with justified text, since I don't have many documents with justified text and since the problem with line-breaks and tabs are still preventing us from having the text completely correct and thus, I did not pay attention so