Re: [Libreoffice] [REVIEW 3.4(.2)] The number of paragraphs always zerro

+1 from me. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Running smoketest module standalone.

Hi Caoln, Thanks for the ideas! The preferred goal is for option b, to make it able to run automatically without manual intervention. As an ideal result, we can have machines persistently check out the latest build and give back the testing results automatically. One question is I saw the smokete

[Libreoffice] [REVIEW 3-4] Update mdds to 0.5.3

Hi there, I'd like to update mdds to 0.5.3 for the -3-4 branch and preferably the -3-4-2 branch as well. The attached patches would make that happen. That should improve the performance issue raised in https://bugs.freedesktop.org/show_bug.cgi?id=38028 but since this affects the general perfor

Re: [Libreoffice] [REVIEW] [PUSHED 3-4-2] oosplash.bin crash fix for -3-4 & 3-4-2

On Wed, 2011-07-13 at 21:17 +0100, Noel Power wrote: > On 13/07/11 18:24, Jan Holesovsky wrote: > > Hi Michael, > > > > Michael Meeks píše v St 13. 07. 2011 v 11:00 +0100: > > > >>A very trivial no-brainer; review/cherry-picking much appreciated. > > Reviewed, pushed to libreoffice-3-4, thank y

Re: [Libreoffice] [GSOC] Report #7: Wizards

Hi Xisco, On 14 July 2011 00:41, Xisco Faulí wrote: > Hello, > I took a look to the problem related to the Adress Data Souce Wizard ( it's > not loaded on master ) and it's not caused by the changes i've been working > on. I moved git to a commit before the one I merged the feature branch into >

Re: [Libreoffice] [GSOC] Report #7: Wizards

Hello, I took a look to the problem related to the Adress Data Souce Wizard ( it's not loaded on master ) and it's not caused by the changes i've been working on. I moved git to a commit before the one I merged the feature branch into master and it still fails. The code fails here : http://opengr

Re: [Libreoffice] DDEInitiate bug

On 13 July 2011 21:00, Miklos Vajna wrote: > On Wed, Jul 13, 2011 at 04:54:32PM +0200, Knut Olav B?hmer > wrote: >> http://openoffice.org/bugzilla/show_bug.cgi?id=118283 vs. >> https://bugs.freedesktop.org/show_bug.cgi?id=39194 >> >> Now, fight! :D > > If there is a relation we try to avoid with

Re: [Libreoffice] DDEInitiate bug

On 13 July 2011 19:57, Luuk wrote: > On 13-07-2011 16:54, Knut Olav Bøhmer wrote: >> http://openoffice.org/bugzilla/show_bug.cgi?id=118283 vs. >> https://bugs.freedesktop.org/show_bug.cgi?id=39194 >> >> Now, fight! :D >> >> >> 2011/7/13 Knut Olav Bøhmer : >>> Hi, >>> >>> I posted a bug-report at O

[Libreoffice] ms import of ocx/userform controls

Hi there, Be aware that in master regarding the import of controls ( ole/ocx controls and userform controls ) , please be on the look out for any regressions in this area and let me know. Note: the import of older form controls is still handled in the escher import in filters, the hasn't chan

Re: [Libreoffice] [REVIEW 3.4(.2)] The number of paragraphs always zerro

On 13/07/11 19:26, Jan Holesovsky wrote: Hi, https://bugs.freedesktop.org/show_bug.cgi?id=36816 The attached patch fixes that - in the original code we were incrementing the number of paragraphs as the first thing, so I have just moved the ++rStart.nPara to the original location. Would be grea

Re: [Libreoffice] [1 more review needed] oosplash.bin crash fix for -3-4 & 3-4-2

On Wed, 2011-07-13 at 19:24 +0200, Jan Holesovsky wrote: > 2 more reviews needed for 3.4.2... Yes. The patch makes sense & should be good for 3.4.2. You have my sign-off. One more review needed for 3.4.2. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___

Re: [Libreoffice] [PUSHED 3-4, 2 more reviews needed] Re: [REVIEW] oosplash.bin crash fix for -3-4 & 3-4-2

On 13/07/11 18:24, Jan Holesovsky wrote: Hi Michael, Michael Meeks píše v St 13. 07. 2011 v 11:00 +0100: A very trivial no-brainer; review/cherry-picking much appreciated. Reviewed, pushed to libreoffice-3-4, thank you! :-) 2 more reviews needed for 3.4.2... given the difficulty I h

[Libreoffice] [PUSHED 3-4, 2 more reviews needed] Re: [REVIEW] oosplash.bin crash fix for -3-4 & 3-4-2

Hi Michael, Michael Meeks píše v St 13. 07. 2011 v 11:00 +0100: > A very trivial no-brainer; review/cherry-picking much appreciated. Reviewed, pushed to libreoffice-3-4, thank you! :-) 2 more reviews needed for 3.4.2... Regards, Kendy ___ Libr

[Libreoffice] [REVIEW 3.4(.2)] The number of paragraphs always zerro

Hi, https://bugs.freedesktop.org/show_bug.cgi?id=36816 The attached patch fixes that - in the original code we were incrementing the number of paragraphs as the first thing, so I have just moved the ++rStart.nPara to the original location. Would be great to get 3 reviews to get it to 3.4.2 :-)

Re: [Libreoffice] DDEInitiate bug

2011/7/13 Michael Meeks : > Hi Knut, > > On Wed, 2011-07-13 at 16:54 +0200, Knut Olav Bøhmer wrote: >> Now, fight! :D > >        This is a developers forum, not a place for sending E-mails about > reported bugs :-) It is only on-topic if you have a patch, or you want > advice and code pointers to h

Re: [Libreoffice] DDEInitiate bug

On Wed, Jul 13, 2011 at 04:54:32PM +0200, Knut Olav B?hmer wrote: > http://openoffice.org/bugzilla/show_bug.cgi?id=118283 vs. > https://bugs.freedesktop.org/show_bug.cgi?id=39194 > > Now, fight! :D If there is a relation we try to avoid with OOo developers, then that's fighting, I think. pgpA

Re: [Libreoffice] DDEInitiate bug

Hi Knut, On Wed, 2011-07-13 at 16:54 +0200, Knut Olav Bøhmer wrote: > Now, fight! :D This is a developers forum, not a place for sending E-mails about reported bugs :-) It is only on-topic if you have a patch, or you want advice and code pointers to help chase the issue down. It'

Re: [Libreoffice] [PATCH] Simplify a function returning the temporary directory name

On Wed, Jul 13, 2011 at 09:16:33AM -0600, Tor Lillqvist wrote: > Do we really want to have those access() checks there? > > I am not evil enough to think of a way to abuse that code (insert maniacal > laughter), but in general, isn't that exactly the kind of coding that could > be a security vul

Re: [Libreoffice] DDEInitiate bug

On 13-07-2011 16:54, Knut Olav Bøhmer wrote: > http://openoffice.org/bugzilla/show_bug.cgi?id=118283 vs. > https://bugs.freedesktop.org/show_bug.cgi?id=39194 > > Now, fight! :D > > > 2011/7/13 Knut Olav Bøhmer : >> Hi, >> >> I posted a bug-report at OpenOffice.org >> http://openoffice.org/bugzil

Re: [Libreoffice] [PATCH] Simplify a function returning the temporary directory name

Do we really want to have those access() checks there? I am not evil enough to think of a way to abuse that code (insert maniacal laughter), but in general, isn't that exactly the kind of coding that could be a security vulnerability? (TOCTTOU seems to be the technical term, http://en.wikipedia

Re: [Libreoffice] DDEInitiate bug

http://openoffice.org/bugzilla/show_bug.cgi?id=118283 vs. https://bugs.freedesktop.org/show_bug.cgi?id=39194 Now, fight! :D 2011/7/13 Knut Olav Bøhmer : > Hi, > > I posted a bug-report at OpenOffice.org > http://openoffice.org/bugzilla/show_bug.cgi?id=118283 > > Do I need to create the bug-repor

[Libreoffice] [PATCH] Second patch for Bug 38936

Hi, Second patch for bug. Now the undo statement for "Insert Horizontal Rule" replaces "Insert horizontal ruler". -- --Jeffrey Chang From 4437a23af30f4b04835911534cb81fd1e6e2a7ec Mon Sep 17 00:00:00 2001 From: jeffrey Chang Date: Tue, 12 Jul 2011 09:11:27 +0800 Subject: [PATCH] Changed undo ins

Re: [Libreoffice] Patch for Bug 38936

Hi Jeffrey, On Wed, 2011-07-13 at 14:17 +0800, jeffrey chang wrote: > Yes I am submitting under the LGPLv3+/MPL 1.1 license. Thanks. I'm forwarding this to the list as we need this on public record. Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] Replacing ByteString with rtl::OString

On Tue, 2011-07-12 at 21:18 +0200, Chr. Rossmanith wrote: > Hi, > > next problem: there is no IsNumericAscii() for O(U)String but for > ByteString. Should O(U)String get this method as well? Don't know if its really widely used enough to warrant expanding the O[U]String API ? You could perhaps r

Re: [Libreoffice] Unit tests - cppunit crashing with debug build

On Tue, 2011-07-12 at 10:35 +0200, Lubos Lunak wrote: > On Monday 11 of July 2011, Caolán McNamara wrote: > > I reckon we probably have to bite the bullet and drop -D_GLIBCXX_DEBUG > > from solenv ? > > I think we could simply force --without-system-libs (or at least for C++ > libs) when --enabl

[Libreoffice] [PATCH] Second patch for Bug 38936

Hi, Here is the finish touch for the "Ruler" bug pushed last week. Now the undo step will also display "Insert Horizontal Rule" instead of "Ruler" -- --Jeffrey Chang From 4437a23af30f4b04835911534cb81fd1e6e2a7ec Mon Sep 17 00:00:00 2001 From: jeffrey Chang Date: Tue, 12 Jul 2011 09:11:27 +0800

[Libreoffice] [REVIEW] oosplash.bin crash fix for -3-4 & 3-4-2

Hi guys, A very trivial no-brainer; review/cherry-picking much appreciated. Thanks, Michael. >From 22f82035331956cbb95e6e735c4549d8ace2bc23 Mon Sep 17 00:00:00 2001 From: Michael Meeks Date: Wed, 13 Jul 2011 10:56:59 +0100 Subject: [PATCH] null the display point

[Libreoffice] sylk unit tests

On Tue, 2011-07-12 at 00:31 +0200, Maciej Rumianowski wrote: > But I wasn't successful using ScImportExport::ImportStream and > ScImportExport::ExportStream, which use Sylk2Doc. Hmm, well I've now added a sylk import unit test to sc, i.e. http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8ac

[Libreoffice] DDEInitiate bug

Hi, I posted a bug-report at OpenOffice.org http://openoffice.org/bugzilla/show_bug.cgi?id=118283 Do I need to create the bug-report at libreoffice as well? The bug is also there. -- Knut Olav Bøhmer ___ LibreOffice mailing list LibreOffice@lists.fre

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37488, which changed state. Bug 37488 Summary: PRINTING table borders in Writer not printed if there are also images in the document, DRAW object printed crippled https://bugs.freedesktop.org/show_bug.cgi?id=37488

[Libreoffice] [PATCH] Simplify a function returning the temporary directory name

Patch attached, and discussed with Caolán. I've detected a bit of duplicate code in different files, I'll try to make them use this function in the future. -- Francois Tigeot >From 0f396782dee612dabea9ee9830f564d7815e464f Mon Sep 17 00:00:00 2001 From: Francois Tigeot Date: Wed, 13 Jul 2011 11: