Hello,
after I talked to Michael on IRC we agreed that the following patch is much
better.
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=4defbffb7654402cf6bbd4b8c3cb0d897ce88126
It fixes an additional potential crash.
Regards,
Markus
2011/6/20 Michael Meeks
>
> On Mon, 2011-06-20 at
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Rainer Bielefeld changed:
What|Removed |Added
Depends on||37195
--- Comment #151 from Rainer Bi
Title: Coloratus Design
Não conseguiu visualizar a mensagem? Click aqui
Não gostaria mais de receber nossos emails? Remova-se aqui
> It can help debugging if methods always return from the same place; but
> then it can help code readability if it is not incredibly deeply
> indented.
I am from the "code readability" school of programing :)
>
>> Thanks for the help! :)
>
> Sorry for not helping :-) just do what y
On Mon, 2011-06-20 at 20:25 +0100, Michael Meeks wrote:
> The rest of that method seems to assume in several places that
> pActiveViewSh can be NULL and checks for that:
Markus is committing an updated patch to master, that I'd love to see
on -3-4 and also in -3-4-1 it potentially f
Le 20/06/2011 15:19, Caolán McNamara a écrit :
On Mon, 2011-06-20 at 10:08 +0100, serv serva wrote:
It happens each time. I don't know what element has triggered this.
I tried gdb but when I runned it, it makes the first which is ok. I don't know
how to go to this specific test.
Could you see
Hi Jesus,
On Mon, 2011-06-20 at 20:47 +0200, Jesús Corrius wrote:
> What's the preferred way to fix it?
:-)
> a) put everything in an if (pFrame) {} block
> b) if(!pFrame) return;
It can help debugging if methods always return from the same place; but
then it can help code r
Hi Markus,
On Mon, 2011-06-20 at 21:04 +0200, Markus Mohrhard wrote:
> I have here a quick patch for fdo#38455. Calc crahs if you go to
> Data->Define range and type some text to a cell because pActiveViewSh
> isn't set in the InputHandler.
Hokay ?
> This fix only checks that pActiveView
Hello,
I have here a quick patch for fdo#38455. Calc crahs if you go to
Data->Define range and type some text to a cell because pActiveViewSh isn't
set in the InputHandler.
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=165ccab687d976d06afa0b02582065045132ee6d
This fix only checks that p
Hi all,
I'd like to fix this function implementation, as it makes my eyes cry ;)
Notice that if pFrame == NULL, the function will crash anyway because
it's only checked in the first if block and later is dereferenced.
static void ImplHandleInputLangChange( HWND hWnd, WPARAM, LPARAM lParam )
{
On Mon, 2011-06-20 at 13:50 +0100, Caolán McNamara wrote:
> If we want c), which is a more attractive and obvious api, then the
> attached would do it I think. It does mean a change of the typedef of
> oslThreadKey from sal_uInt32 to void*, which changes its size on 64bit.
> So technically this is
Hello Petr, Michael, *
Many thanks for your answer :) My build was success with --disable-systray
Anyway, may I ask some questions please?
On Fri, Jun 17, 2011 at 18:08, Petr Mladek wrote:
> This header should be provided by the module "libegg". Please, make sure
> that this module is built and
Hi Michael,
On 20 June 2011 16:02, Michael Meeks wrote:
> On Sun, 2011-06-19 at 23:30 +0200, Matúš Kukan wrote:
>> Now I'm playing with makefiles and next week I want to merge
>> some libraries.
>
> Heh - hopefully we can identify which libraries to merge there; then I
> guess we will need
On Mon, 2011-06-20 at 13:50 +0100, Caolán McNamara wrote:
> If we want c), which is a more attractive and obvious api, then the
> attached would do it I think.
I decided to push c, hopefully that resolves this correctly.
C.
___
LibreOffice mailing list
Hi Ronald,
Roland Baudin píše v Pá 17. 06. 2011 v 23:23 +0200:
> Hi,
>
> here is a small patch for sw that fixes another issue related to bug
> 33781 that I already fixed last month.
>
> The problem is that a graphic object of type "Draw 8" is not
> anti-aliased when anchored as char (see test
> I got fed up by the warnings while compiling. Okay to commit?
Go ahead.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi
I got fed up by the warnings while compiling. Okay to commit?
diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index 23cb408..90fdf5c 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -1621,4 +1621,4 @@ void ScDocument::Trans
On Mon, Jun 20, 2011 at 4:14 PM, Tor Lillqvist wrote:
>> so the _s create a false sens of security...
On the other hand, I guess shouldn't be that bad to use the "secure
functions" on the Windows specific bits of code.
If I remember well, Mingw32 ships the safelib too, so it wouldn't be a
problem
Michael Meeks píše v Po 20. 06. 2011 v 12:03 +0100:
> On Mon, 2011-06-20 at 02:26 -0600, Tor Lillqvist wrote:
> > Go ahead and push to master and 3-4. Two more reviews needed for
> > 3-4-1, unless it is already too late for that.
>
> bug:
> https://bugs.freedesktop.org/show_bug.cgi?id=37110
> so the _s create a false sens of security...
Exactly.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Mon, Jun 20, 2011 at 5:31 AM, Caolán McNamara wrote:
> On Mon, 2011-06-20 at 09:51 +0530, Marc-André Laverdière wrote:
>> Hello list.
>>
>> Now, I think we should make it multi-platform, so that the whole code
>> base can benefit from it. The transition must be gradual, for sure, but
>> I think
Hi Matus,
On Sun, 2011-06-19 at 23:30 +0200, Matúš Kukan wrote:
> I've started adding prefixes for components, so we can then merge libraries.
> Just in already gnumake-ified modules.
Nice :-)
> First was toolkit. There is just one component and it seems to be
> working. I have tested th
Hi,
please note that the commit deadline for 3.4.1-rc2 is today, Jun 20,
2011. If no blocker is found, rc2 will be marked as final.
See also
http://wiki.documentfoundation.org/ReleasePlan#3.4_release
http://wiki.documentfoundation.org/Release_Criteria
http://wiki.documentfoundation.org/Developmen
On Mon, 2011-06-20 at 10:08 +0100, serv serva wrote:
> It happens each time. I don't know what element has triggered this.
> I tried gdb but when I runned it, it makes the first which is ok. I don't
> know how to go to this specific test.
Could you see the patch in the other thread "interesting d
Markus Mohrhard píše v Pá 17. 06. 2011 v 19:21 +0200:
> Oh, I had reviewed this patch already but forgot to write a mail.
>
> But I have no access to my 3-4 build, so would someone please push it
> for me.
This was 3rd approval => pushed into 3-4-1 branch.
Thanks for the contribution.
Best Reg
On Sun, 2011-06-19 at 14:10 -0600, Tor Lillqvist wrote:
> On Windows, if the value of a key is changed with
> osl_setThreadKeyData() (or its wrapper, ThreadData::setData()), the
> destructor callback is called for the old value. (See the code in
> sal/osl/w32/thread.c. On Unix this does not seem
On (2011-06-20 05:48), Tor Lillqvist wrote:
> > I have to say, I'm kind of unenthusiastic about deprecating strlen and
> > memcpy.
>
> I agree fully.
>
> I was under the impression that LO mostly uses its own (too many) string
> classes anyway, and usually for strings of UTF-16 (16-bit) elemen
> Contributed under LGPLv3+ and MPL.
Thanks, kiitoksia, pushed to master.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Robert Nagy píše v Ne 19. 06. 2011 v 16:52 +0200:
> After switching to gbuild ENABLE_SYSTRAY_GTK was not defined in the
> sfx target and the plugin name for libqstart was also hardcoded for
> linux.
It has been approved by me, Tor, and Michael => pushed into master,
libreoffice-3-4 and libreoffice
> I have to say, I'm kind of unenthusiastic about deprecating strlen and
> memcpy.
I agree fully.
I was under the impression that LO mostly uses its own (too many) string
classes anyway, and usually for strings of UTF-16 (16-bit) elements (for lack
of better word), seldom plain C library char
On (2011-06-20 15:30), Marc-André Laverdi??re wrote:
> >> - Gcc TODO
For GCC you could redefine all of the functions with the deprecated
attribute like:
#include
int printf(const char *format, ...) __attribute__((deprecated));
int
main()
{
printf("");
return 0;
}
Which will e
On Mon, 2011-06-20 at 11:14 +0100, julian.ashbo...@ba.com wrote:
> being new to the list, is there a specific topic for new development ideas?
The list is for developers, and people discussing code.
There are far more good ideas for development than there are people to
work on th
On Mon, 2011-06-20 at 02:26 -0600, Tor Lillqvist wrote:
> Go ahead and push to master and 3-4. Two more reviews needed for
> 3-4-1, unless it is already too late for that.
bug:
https://bugs.freedesktop.org/show_bug.cgi?id=37110
patch:
https://bugs.freedesktop.org/attachment.cgi?id
Hi,
being new to the list, is there a specific topic for new development ideas?
J
--
This message is private and confidential and may also be legally privileged.
If you have received this message in error, please email it back to the sender
and immediately permanently delete it from your c
On Mon, 2011-06-20 at 12:10 +0200, Alexander Thurgood wrote:
> Enclosed diff proposing change to configure switch help message text.
Looks good, PUSHED.
I sort of wonder why we have that in there at all actually, but anyway.
C.
___
LibreOffice mailing
On Mon, 2011-06-20 at 09:51 +0530, Marc-André Laverdière wrote:
> Hello list.
>
> Now, I think we should make it multi-platform, so that the whole code
> base can benefit from it. The transition must be gradual, for sure, but
> I think we'd benefit a lot from it in the long run.
I have to say,
btw., on openbsd you already get warnings if you use unsafe functions, like:
(ws robert 45001)$ gcc `pkg-config --cflags --libs glib-2.0` -lkvm proc.c
/usr/local/lib/libglib-2.0.so.2800.0: warning: vsprintf() is often misused,
please use vsnprintf()
/usr/local/lib/libglib-2.0.so.2800.0: warning: s
Le 20/06/11 11:18, Alexander Thurgood a écrit :
>
> whereas it would probably be better to state something like :
>
> "This switch should only be enabled for those who have the right to use
> or distribute the proprietary Agfa Monotype fonts."
>
Enclosed diff proposing change to configure swit
Hello,
Well you don't have it any other supported platforms either.
You can't just use macros to use those whenever they are supported,
we would have to walk through the code and convert each by hand.
If we don't do this there is no real point in listing strcpy and friends
in banned.h.
On (2011-0
Hello,
That's a good question. I'm in the "don't code it if you don't have to"
school of thought, so I'm not too hot in implementing those...
Is there a way to detect if our platform has it and use it. And if our
platform doesn't have it, define some macro that would have a
functionally identi
On 19/06/11 10:10, Anurag Jain wrote:
But the problem I'm
facing is now when I removed the aTextWnd.Show() from constructor of
ScInputWindow and added it into the ScInputBarGroup's constructor the
inputbar will not appear.
I presume you call ScInputBarGroup's Show() right ?
_
Hi Julien,
On Sat, 2011-06-18 at 14:09 +0200, Julien Nabet wrote:
> Ok, so I added the 2 break instructions, commited and pushed on master.
> Thank you !
Nice :-) it's good to see this stream of snafu's cleaned up over time.
Thanks,
Michael.
--
michael.me...@n
Hi Olivier,
On Sat, 2011-06-18 at 08:25 -0300, Olivier Hallot wrote:
> Can such minutes be posted in TDF blog? I think it deserves publicity:
> Either for its content and for visibility + vitality of the TSC and
> LibreOffice.
Again, it'd be wonderful if someone wanted to do that. Havin
Hi Andrea,
On Sat, 2011-06-18 at 14:57 +0200, Andrea Pescetti wrote:
> Would it be possible to have some more information about the security
> issues fixed in LibreOffice 3.3 ?
Sure - this is what the agenda item is about; AFAIR there is only one
interesting one, that is a Lotus Word Pro
Le 20/06/11 10:53, Alexander Thurgood a écrit :
In fact, what is written is not very clear :
--with-agfa-monotype-fonts
Do not include the proprietary Agfa Monotype fonts (even if present) in
the LibreOffice installation set.
whereas it would probably be better to state something like :
"This
Hi Anurag
On 19/06/11 10:10, Anurag Jain wrote:
Hello Kohei, Noel
This is the brief of my work for this week. As I was supposed to
create a new container class which will contain ScTextWnd obejct +
ScrollBar + Button object, I've done so. Also I've tunneled the calls
to ScTextWnd from ScInputWin
> Looks fine to me, feel free to push to master (you have push rights, don't
> you?).
Pushed.
--
Jesús Corrius
Document Foundation founding member
Mobile: +34 661 11 38 26
Skype: jcorrius | Twitter: @jcorrius
___
LibreOffice mailing list
LibreOffice@
--- En date de : Lun 20.6.11, Caolán McNamara a écrit :
> De: Caolán McNamara
> Objet: Re: [Libreoffice] Debug compilation fails in sal module
> À: "Julien Nabet"
> Cc: libreoffice@lists.freedesktop.org
> Date: Lundi 20 juin 2011, 10h57
> On Sun, 2011-06-19 at 12:04 +0200,
> Julien Nabet wrote:
On Sun, 2011-06-19 at 14:10 -0600, Tor Lillqvist wrote:
> When run on Linux, I see no such problems.
I see a problem about once in 10 or 20 runs under valgrind. I was poking
at this last week to see if I could flush the problem out.
C.
___
LibreOffice
On Sun, 2011-06-19 at 12:04 +0200, Julien Nabet wrote:
> LD_LIBRARY_PATH=/home/maryline/compile-libreoffice/libo/clone/ure/sal/unxlngi6/lib:/home/maryline/compile-libreoffice/libo/solver/350/unxlngi6/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}
>
> ../../../unxlngi6/bin/cppunittester ../../../unxln
Le 20/06/11 10:08, Tor Lillqvist a écrit :
Hi Tor,
> You are not supposed to use that switch unless you have these (proprietary)
> fonts and the right to redistribute them to your customers.
All fair enough, but is that actually mentioned anywhere in the config
switch help ?
Alex
___
Go ahead and push to master and 3-4. Two more reviews needed for 3-4-1, unless
it is already too late for that.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
You are not supposed to use that switch unless you have these (proprietary)
fonts and the right to redistribute them to your customers.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/
Looks fine to me, feel free to push to master (you have push rights, don't
you?).
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Pushed to master, but I am not sure if this is a serious enough bug to push to
3-4 (or 3-4-1)?
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
55 matches
Mail list logo
