Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues -> menus

2011-02-15 Thread David Tardon
On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote: > diff --git a/svtools/source/config/menuoptions.cxx > b/svtools/source/config/menuoptions.cxx > index a12f1e0..4e814a7 100644 > --- a/svtools/source/config/menuoptions.cxx > +++ b/svtools/source/config/menuoptions.cxx > @@ -62,

[Libreoffice] Please help us fix this Writer autocorrect bug

2011-02-15 Thread Samphan Raruenrom
I'm going to work on this bug. Anyone have any idea about the problematic auto-style T1 in the bug report? Bug 33092 – Autocomplete display double character for this word [CTL / Thai] https://bugs.freedesktop.org/show_bug.cgi?id=33092 Step to reproduced:

Re: [Libreoffice] [PATCH] Remove legacy Addin mechanism from calc

2011-02-15 Thread Regina Henschel
Hi Alfonso, Alfonso Eusebio schrieb: Hi, Please find attached two patches for the removal of the legacy Addin Mechanism from calc. One of the patches removes the code from binfilter. I have now read what this module is about and I guess it might not have been necessary to remove stuff from here

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-15 Thread Luke Dixon
Hi Jonas, On Tue, 2011-02-15 at 21:51 +0100, Jonas Finnemann Jensen wrote: > Well, lets just think about writing a note for the next guy, if we > find a solution :) I suppose the EditEngine::SetText functions would be be a good place to start. > > I noticed that 0x is used in Selec

Re: [Libreoffice] [REVIEW] fdo#32552 (alt key opens "File"-menu)

2011-02-15 Thread Thomas Arnhold
Hi Julien, I've compiled and tested it. Works fine. I read the bug description and there was said, that on Windows Alt works as F6 on Linux - to set focus on the menubar. Now we completely got rid of this with Alt on Linux. Is this intentionally, say that Alt alone has no effect at all? I slightl

Re: [Libreoffice] Supported arches

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 22:22 +0100, Francois Tigeot wrote: > Of the ports listed on http://porting.openoffice.org/ , Tru64 is dead and > I would be surprised if VMS and Linux/m68k were much alive. Yeah, only take the "completed" one, VMS and Tru64 never actually happened. m68k only exists emulated

[Libreoffice] [PUSHED] Re: [PATCH] GentooOnly cleanup and 64bit jdk server path (sun/oracle jdk)

2011-02-15 Thread Caolán McNamara
On Fri, 2011-02-11 at 13:31 +0100, Hanno Meyer-Thurow wrote: > Hi all, > attached is one patch to libreoffice/build tree branch libreoffice-3-3 > that just cleans up the Gentoo patchset. You may merge it to the > libreoffice-3-3-1 branch as well, please. I pushed to master anyway, I guess we'd nee

Re: [Libreoffice] Supported arches

2011-02-15 Thread Francois Tigeot
On Tue, Feb 15, 2011 at 09:05:15PM +, Caolán McNamara wrote: > On Tue, 2011-02-15 at 18:34 +0100, Francois Tigeot wrote: > > > - i386 / amd64 > > - power / powerppc > > - sparc / sparc64 > > - arm > > - mips > > - alpha > > http://porting.openoffice.org/ might help btw. FWIW We (Red Hat, Inc.

[Libreoffice] [REVIEW] fdo#32552 (alt key opens "File"-menu)

2011-02-15 Thread Julien Nabet
Hello, Here is small patch to close the tracker 32552 (alt key opens "File"-menu). I removed the block quoted in the comments, it compiles but I didn't test it. I use Gnome and so Gtk on my Debian. Could someone confirm it's ok (or not) ? Julien. (LGPLv3+ / MPL) commit 92ec3bb031d94cfc8658ee7

Re: [Libreoffice] Supported arches

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 18:34 +0100, Francois Tigeot wrote: > We also have at least msdos and Atari ST in dmake/ That's just the imported and hacked up third party dmake tool, so can be ignored. > - i386 / amd64 > - power / powerppc > - sparc / sparc64 > - arm > - mips > - alpha > > Everything els

Re: [Libreoffice] Supported arches

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 18:14 +0100, Thomas Arnhold wrote: > Hi, > > i stumbled across some precompiler checks for several (deprecated?) arches: > HP9000 (already removed some parts of this) > SINIX > RM400 Yeah, those can all go. > And another thing, in combination with GCC: "C272" (occurs with

Re: [Libreoffice] [PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Noel Power
Hi Caolan On 15/02/11 16:17, Noel Power wrote: On 15/02/11 15:28, Michael Meeks wrote: Which it doesn't, so good catch; Noel we should fix that :-) well as it turns out it does, rtl_string_ImplAlloc always creates a buffer 1 bigger than the requested len and stuffs a '\0' in it. Strange bu

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-15 Thread Jonas Finnemann Jensen
Hi Luke, Would be cool, would be a bit difficult to document it when I don't know > what it's supposed to be doing though. That isn't an excuse though, I > don't mind trying to work out a few of them. Well, lets just think about writing a note for the next guy, if we find a solution :) pDocSh

[Libreoffice] [PATCH][PUSHED 4/54] translated comments

2011-02-15 Thread Christina Roßmanith
Hi, pushed 8 more diffs. Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Files without Copyright notice

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 19:50 +0100, Francois Tigeot wrote: > Is there a correct header example somewhere ? See TEMPLATE.SOURCECODE.HEADER, adjust the /* to # for .mk files. > By the way, should it be there ? AFAIK, unxobsd.mk was created after > LibreOffice was forked... Well, I guess it was basi

Re: [Libreoffice] DirEntryStack not used?

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 20:45 +0100, Christina Roßmanith wrote: > Hi, > > I'm trying to figure out whether DirEntryStack is necessary or not. This > is what I did already: > > 1. ./g grep DirEntryStack: found class implementation in dirent.cxx > and "TOOLS_DLLPRIVATE USHORTImpTr

[Libreoffice] DirEntryStack not used?

2011-02-15 Thread Christina Roßmanith
Hi, I'm trying to figure out whether DirEntryStack is necessary or not. This is what I did already: 1. ./g grep DirEntryStack: found class implementation in dirent.cxx and "TOOLS_DLLPRIVATE USHORTImpTryUrl( DirEntryStack& rStack, const String& rPfad, FSysPathStyle eStyle );

Re: [Libreoffice] [PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Michael Meeks
On Tue, 2011-02-15 at 16:17 +, Noel Power wrote: > On 15/02/11 15:28, Michael Meeks wrote: > > Which it doesn't, so good catch; Noel we should fix that :-) > well as it turns out it does, rtl_string_ImplAlloc always creates a mea culpa :-) I was too quick, and forgot the char buf

Re: [Libreoffice] Files without Copyright notice

2011-02-15 Thread Francois Tigeot
On Mon, Feb 14, 2011 at 09:10:03PM +, Caolán McNamara wrote: > On Mon, 2011-02-14 at 22:02 +0100, Thomas Arnhold wrote: > > You're right with ww8toolbar.* > > We need to make a list of the ones that belong to LibreOffice solely and > have no copyright attribution and nag the initial committer

Re: [Libreoffice] Tools - Media Player

2011-02-15 Thread Thomas Arnhold
Hi, >> On 02/12/2011 10:01 PM, Michael Meeks wrote: >>> On Fri, 2011-02-11 at 23:08 +0100, Christoph Noack wrote: > what the heck do we do with "Tools - Media Player"? Do we need this > within an office suite? Is anyone using this?! >>> >>> :-) My suspicion is that ~no-one is using it.

Re: [Libreoffice] [PATCH] GentooOnly cleanup and 64bit jdk server path (sun/oracle jdk)

2011-02-15 Thread Andreas Proschofsky
Hi everyone, Could someone please take a look at it and commit it for us (Gentoo), we'd really like to get the broken stuff out of the tree ;-) bye Andreas On Fri, 2011-02-11 at 13:31 +0100, Hanno Meyer-Thurow wrote: > Hi all, > attached is one patch to libreoffice/build tree branch libreoffice-

Re: [Libreoffice] Supported arches

2011-02-15 Thread Francois Tigeot
Hi, On Tue, Feb 15, 2011 at 06:14:36PM +0100, Thomas Arnhold wrote: > > i stumbled across some precompiler checks for several (deprecated?) arches: > > HP9000 (already removed some parts of this) > SINIX > RM400 > ... > > There is a full list of this stuff at bootstrap/solenv/bin/modules/osarch

Re: [Libreoffice] [REVIEW] disable EMF+ in 3-3-1 on all platforms

2011-02-15 Thread Thorsten Behrens
Radek Doulík wrote: > please review this patch for inclusion in 3-3-1 > ACKed. Go for it. -- Thorsten pgpr2mvXzvM4l.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listi

Re: [Libreoffice] [REVIEW] disable EMF+ in 3-3-1 on all platforms

2011-02-15 Thread Petr Mladek
Radek Doulík píše v Út 15. 02. 2011 v 18:22 +0100: > Hi, > > please review this patch for inclusion in 3-3-1. Because the previous > fix seemed too risky, we will disable the EMF+ altogether for this > release. Patch looks fine. We will get better results than with LO-3.3.0 with it. The real fix

[Libreoffice] [REVIEW] disable EMF+ in 3-3-1 on all platforms

2011-02-15 Thread Radek Doulík
Hi, please review this patch for inclusion in 3-3-1. Because the previous fix seemed too risky, we will disable the EMF+ altogether for this release. Cheers Radek diff --git a/svtools/source/filter.vcl/wmf/enhwmf.cxx b/svtools/source/filter.vcl/wmf/enhwmf.cxx index 1dd5c64..4bb7643 100644 --- a

[Libreoffice] Supported arches

2011-02-15 Thread Thomas Arnhold
Hi, i stumbled across some precompiler checks for several (deprecated?) arches: HP9000 (already removed some parts of this) SINIX RM400 ... And another thing, in combination with GCC: "C272" (occurs with GCC) i.e. at impress/sd/source/ui/view/zoomlist.cxx:#if ( defined GCC && defined C272 ) . Do

Re: [Libreoffice] [PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Noel Power
On 15/02/11 15:28, Michael Meeks wrote: The original problem to be fixed is a lack of a zero terminator in the *output* blob, its just an issue of copying it from the original string or adding a new one, just making sure that if we go with copying it from the original string, that the original

Re: [Libreoffice] [REVIEW] fix for EMF+ on 3-3 and 3-3-1

2011-02-15 Thread Radek Doulík
On Tue, 2011-02-15 at 08:31 -0700, Tor Lillqvist wrote: > > Do I take it that these two then fix win32 ? > > These are the same two diffs I tested on Friday (I think it was), > aren't they? They did not help. Of course, it might be that my quick > testing was flawed in some way. Yup, I think on

Re: [Libreoffice] [REVIEW] fix for EMF+ on 3-3 and 3-3-1

2011-02-15 Thread Radek Doulík
On Tue, 2011-02-15 at 15:21 +, Michael Meeks wrote: > Hi Radek, > > You missed the patch disabling EMF+ rendering for Win32. I hope not. My patches fix it on all the platforms where EMF+ is enabled. EMF+ was broken on unx for quite some time, basically when impress started using drawing

Re: [Libreoffice] [REVIEW] fix for EMF+ on 3-3 and 3-3-1

2011-02-15 Thread Tor Lillqvist
> Do I take it that these two then fix win32 ? These are the same two diffs I tested on Friday (I think it was), aren't they? They did not help. Of course, it might be that my quick testing was flawed in some way. --tml ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Michael Meeks
On Tue, 2011-02-15 at 15:04 +, Caolán McNamara wrote: > Yes, ::insert don't dereference the final end iterator, but it does use Hah - quite right ;-) I only got past the double bluff to get suckered at the next fence; so this is duff; we should append getLength() and then push_back a

Re: [Libreoffice] [REVIEW] fix for EMF+ on 3-3 and 3-3-1

2011-02-15 Thread Michael Meeks
Hi Radek, You missed the patch disabling EMF+ rendering for Win32. On Tue, 2011-02-15 at 15:44 +0100, Radek Doulík wrote: > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=229df81b920ddee5a1b057af75db7b293f88e3bd > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=

Re: [Libreoffice] [PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 14:50 +, Michael Meeks wrote: > std::vector< char > * blob = data.newBlob(); > blob->insert(blob->begin(), str.getStr(), str.getStr() + str.getLength() + 1) > > As passint a char * start and end iterator to the stl insert. The end > iterator is not used, we terminat

Re: [Libreoffice] [PUSHED] Re: [PATCH] Reworking build.pl: What to do with the "--html" and "--interactive" parameters

2011-02-15 Thread Christian Lohmaier
Hi Jan, *, On Tue, Feb 15, 2011 at 10:48 AM, Jan Holesovsky wrote: > On 2011-02-02 at 19:39 +0100, Michael Koch wrote: > > BTW - calling 'cat' is a curious thing, can we change that to something > more Perl? ;-) Well, not sure whether it is really preferable, but instead of system("cat $log_file

Re: [Libreoffice] [PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Michael Meeks
On Tue, 2011-02-15 at 12:01 +, Caolán McNamara wrote: > Is it guaranteed that str is NULL terminated, i.e. getStr() has always > claimed that it might not actually be NULL terminated Right - it is not NULL terminated. Then again I read this: std::vector< char > * blob = data

Re: [Libreoffice] [REVIEW] fix for EMF+ on 3-3 and 3-3-1

2011-02-15 Thread Petr Mladek
Jesús Corrius píše v Út 15. 02. 2011 v 12:42 +0100: > Related to this bug, make sure to consider this one to for the 3.3.1 > branch, too (AFAIK it's only in 3.3) > > http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-3&id=a4848e8cebe712f96f409f8687fc76cef22b640f It has alre

Re: [Libreoffice] [REVIEW] fix for EMF+ on 3-3 and 3-3-1

2011-02-15 Thread Radek Doulík
On Tue, 2011-02-15 at 12:30 +0100, Radek Doulík wrote: > Hi, > > I would like to have EMF+ support fixed in 3.3. The following two > commits are needed to fix it on > > libreoffice-3-3 (1 review needed) > libreoffice-3-3-1 (3 reviews needed) > > branches. > > http://cgit.freedesktop.org/libreof

Re: [Libreoffice] [PUSHED] Re: Patch

2011-02-15 Thread Bálint Dózsa
Hi, Yes, my code is under the LGPLv3+/MPL dual license. Balint 2011. február 15. 12:35 Caolán McNamara írta, : > On Tue, 2011-02-15 at 11:41 +0100, Bálint Dózsa wrote: > > Hi, > > I have removed some dead code form /writerperfect and /xmerge. > > Looks good, pushed. Can you confirm that these a

Re: [Libreoffice] [PUSHED][PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Petr Mladek
Noel Power píše v Po 14. 02. 2011 v 20:08 +: > (reposting with [PATCH] keyword > although the fix for this issue will appear from dev300m98 onwards it > would be worth I think getting this into > > a) libreoffice-3-3 ( one ack please ) > and possibly > b) libreoffice-3.3.1 ( 3 acks please

Re: [Libreoffice] [PUSHED][REVIEWED] crashing oosplash and malformed picture (bnc#652562)

2011-02-15 Thread Petr Mladek
Michael Meeks píše v Út 15. 02. 2011 v 09:11 +: > On Mon, 2011-02-14 at 20:23 +0100, Thorsten Behrens wrote: > > Ugh. Yep, would absolutely like to have that in -3-3-1. Good catch. > > And another ack for 3.3.1 - it should really go there; I guess with > Kendy's approval (the fixes look

Re: [Libreoffice] [REVIEWED] fix for i#115716 & fdo#33964

2011-02-15 Thread Noel Power
Hi Petr On 15/02/11 09:04, Michael Meeks wrote: Fine for that too; if we can collect another ack then fwd. to Petr for merging it'd be great:-) 2 acks now, can you have a look then for 3.3.1 ? note the patch associated with the commit id ( from master ) won't do ( filenames changed ), t

Re: [Libreoffice] [PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 12:42 +, Noel Power wrote: > yeah, I think we can pretty much assume that the strings are null > terminate Sure, +1 then. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/

Re: [Libreoffice] deliver.pl defaulting to strip

2011-02-15 Thread Bjoern Michaelsen
Hi Caolán, On Tue, 15 Feb 2011 09:09:48 + Caolán McNamara wrote: > Are symbols insanely large under windows ?. I'd randomly guess that in > an ideal world we default symbols on when building with gcc and strip > them at the very last stage when making the final .rpms/.debs when > using the e

Re: [Libreoffice] [PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Noel Power
Hi Caolán On 15/02/11 12:01, Caolán McNamara wrote: Is it guaranteed that str is NULL terminated, i.e. getStr() has always claimed that it might not actually be NULL terminated, and this assumes a NULL terminator exists and can be pushed into blob. yeah, I think we can pretty much assume that th

Re: [Libreoffice] [PUSHED] Re: Dragonfly patches

2011-02-15 Thread Francois Tigeot
On Tue, Feb 15, 2011 at 12:09:49PM +, Caolán McNamara wrote: > On Mon, 2011-02-14 at 17:21 +0100, Francois Tigeot wrote: > > Here's a second batch. With these ones, and by disabling some cppunit > > tests, I am now able to complete a LibreOffice build on DragonFly. > > Looks sane, pushed. Gre

Re: [Libreoffice] Easy Hacks: Migrate module descriptions to our wiki

2011-02-15 Thread Thorsten Behrens
Michael Meeks wrote: > to link to there, and then wondered: could we not (perhaps) automate > the creation of those README files from the wiki with some shell / perl > script ? such that we could update all the READMEs at once, and use the > wiki as the authoritative location, and the README

Re: [Libreoffice] compilation and bundled extensions

2011-02-15 Thread Jean-Baptiste Faure
Le 15/02/2011 10:14, Caolán McNamara a écrit : > On Tue, 2011-02-15 at 08:44 +0100, Jean-Baptiste Faure wrote: >> It seems that bundled extensions have not been build : pdfimport.oxt >> does not exist. Even after having done > Ah, I assumed you'd already *built* them, but wondered why they weren't

[Libreoffice] [PUSHED] Re: Dragonfly patches

2011-02-15 Thread Caolán McNamara
On Mon, 2011-02-14 at 17:21 +0100, Francois Tigeot wrote: > Here's a second batch. With these ones, and by disabling some cppunit > tests, I am now able to complete a LibreOffice build on DragonFly. Looks sane, pushed. You really need to debug those cppunit tests however :-). Maybe you've gotten l

Re: [Libreoffice] [PATCH] fix for i#115716 & fdo#33964

2011-02-15 Thread Caolán McNamara
On Mon, 2011-02-14 at 20:08 +, Noel Power wrote: > (reposting with [PATCH] keyword > although the fix for this issue will appear from dev300m98 onwards it > would be worth I think getting this into > > a) libreoffice-3-3 ( one ack please ) > and possibly > b) libreoffice-3.3.1 ( 3 acks pl

Re: [Libreoffice] [REVIEW] fix for EMF+ on 3-3 and 3-3-1

2011-02-15 Thread Jesús Corrius
Hi, 2011/2/15 Radek Doulík : > Hi, > > I would like to have EMF+ support fixed in 3.3. The following two > commits are needed to fix it on > > libreoffice-3-3 (1 review needed) > libreoffice-3-3-1 (3 reviews needed) > > branches. > > http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=7de8

Re: [Libreoffice] Easy Hacks: Migrate module descriptions to our wiki

2011-02-15 Thread Michael Meeks
Hi Christoph, On Sun, 2011-02-13 at 21:45 +0100, Christoph Herzog wrote: > I'm busy with this easy hack, i.e. filling > http://wiki.documentfoundation.org/Development/Code_Overview. Great to see that completed ! and looking pretty :-) I updated this easy hack: http://wiki.docum

[Libreoffice] [PUSHED] Re: Patch

2011-02-15 Thread Caolán McNamara
On Fri, 2011-02-11 at 12:16 +0100, Bálint Dózsa wrote: > Hy! > > > I have removed this unused method: > writerfilter::dmapper::ConversionHelper::convertDateTime(rtl::OUString > const&) Yeah, looks good, removed now. Thanks for this. C. ___ LibreOffi

[Libreoffice] [PUSHED] Re: Patch

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 11:41 +0100, Bálint Dózsa wrote: > Hi, > I have removed some dead code form /writerperfect and /xmerge. Looks good, pushed. Can you confirm that these are submitted under our recommended LGPLv3+/MPL dual license combo ? C. ___ Li

[Libreoffice] [REVIEW] fix for EMF+ on 3-3 and 3-3-1

2011-02-15 Thread Radek Doulík
Hi, I would like to have EMF+ support fixed in 3.3. The following two commits are needed to fix it on libreoffice-3-3 (1 review needed) libreoffice-3-3-1 (3 reviews needed) branches. http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=7de8695f19626c764a4b43cfb30179525d9a5956 http://cgit

Re: [Libreoffice] Easy Hacks: Migrate module descriptions to our wiki

2011-02-15 Thread Christoph Herzog
On 02/14/2011 10:20 AM, Michael Meeks wrote: And in this context: Can some text from other parts of the OOo Wiki be copied and pasted? In a word; no - not unless it is fair use, or written by a friendly, non-Oracle contributor [ at least, that is my take ]. ATB,

Re: [Libreoffice] [PATCH][PUSHED] More "Default Formatting" --> "Clear Direct Formatting"

2011-02-15 Thread Cedric Bosdonnat
Forgot to change the subject On Tue, 2011-02-15 at 11:42 +0100, Cedric Bosdonnat wrote: > Hi Octavio, > > On Mon, 2011-02-14 at 22:33 -0800, Octavio Alvarez wrote: > > Hi! Sorry for the long time gap between the two patch sets. > > > > In the following two patches I continue the work on renaming

[Libreoffice] Patch

2011-02-15 Thread Bálint Dózsa
Hi, I have removed some dead code form */writerperfect* and */xmerge*. Regards, Balint Dozsa From 60150a3a38b68188b9edeb17a5fb7a49bb0c514e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A1lint=20D=C3=B3zsa?= Date: Tue, 15 Feb 2011 11:35:24 +0100 Subject: [PATCH] Remove dead codes --- writerperf

Re: [Libreoffice] [PATCH] More "Default Formatting" --> "Clear Direct Formatting"

2011-02-15 Thread Cedric Bosdonnat
Hi Octavio, On Mon, 2011-02-14 at 22:33 -0800, Octavio Alvarez wrote: > Hi! Sorry for the long time gap between the two patch sets. > > In the following two patches I continue the work on renaming "Default > Formatting" to "Clear Direct Formatting". > > In the past patchset, Cédric reported pr

Re: [Libreoffice] [REVIEW] BorderLine conversion fix

2011-02-15 Thread Michael Meeks
On Tue, 2011-02-15 at 11:12 +0100, Cedric Bosdonnat wrote: > I just fixed the bug https://bugs.freedesktop.org/show_bug.cgi?id=34226. > Could anyone review the fix that I pushed to master for inclusion in 3.3 > and 3.3.1. As per the bug; ack'd by me - David it'd be great if you could look

[Libreoffice] [PATCH] Translation of German comments in libs-core/editeng

2011-02-15 Thread Albert Thuswaldner
Hi, Just wanted to highlight this in case it went under the radar: https://bugs.freedesktop.org//show_bug.cgi?id=34196 If already noted, sorry for the "double post". /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.fr

[Libreoffice] [REVIEW] BorderLine conversion fix

2011-02-15 Thread Cedric Bosdonnat
Hi all, I just fixed the bug https://bugs.freedesktop.org/show_bug.cgi?id=34226. Could anyone review the fix that I pushed to master for inclusion in 3.3 and 3.3.1. http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=4da3c4b2874fba5451d391a13e8443d451712bbe My apologies for not having r

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

2011-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32894 Bug 32894 depends on bug 34226, which changed state. Bug 34226 Summary: Calc, Drawing borders with Frame drop down in Format menu - bug in EDITING https://bugs.freedesktop.org/show_bug.cgi?id=34226 What|Old Value

Re: [Libreoffice] Tools - Media Player

2011-02-15 Thread Michael Meeks
Hi Christoph, On Mon, 2011-02-14 at 23:03 +0100, Christoph Noack wrote: > === Usage Data === Useful numbers indeed. .. > * All Applications: 2063 How does this compare to eg. File->Open or Format->Paragraph or something frequently used ? > Of course, these are only relativ

Re: [Libreoffice] [PUSHED] Re: [PATCH] O(U)StringBuffer::toString()

2011-02-15 Thread Caolán McNamara
On Mon, 2011-02-14 at 22:30 +0100, Sébastien Le Ray wrote: > Actually I'm gonna start adding missing methods from > UniString/ByteString to O(U)String and StringBuffer There are some original design thoughts behind O(U)String FWIW, e.g it's roughly based on the immutable java String so apart from

Re: [Libreoffice] Issues building LO on Linux prior to attempting on Android

2011-02-15 Thread Andrew Wafaa
On 14 February 2011 11:03, Thorsten Behrens wrote: > Andrew Wafaa wrote: >> I'm trying to build LO on openSUSE 11.3, but get a failure with make. >> The steps I've taken are: >> > Hi Andrew, > > um, looks like a bigger cock-up - can you re-do that, pipe all the > make output to a file, and make th

[Libreoffice] [PUSHED] Re: [PATCH] Reworking build.pl: What to do with the "--html" and "--interactive" parameters

2011-02-15 Thread Jan Holesovsky
Hi Michael, On 2011-02-02 at 19:39 +0100, Michael Koch wrote: > >> I don't have strong feelings about having the actual html page or not. > >> When I started building, I used it quite a bit, but now I do automated > >> builds, so I don't sit and wait "man, when it is finished" :-) [...] > > I mad

Re: [Libreoffice] On-web Help Basic ?

2011-02-15 Thread Jan Holesovsky
Hi Cor, On 2011-02-15 at 10:18 +0100, Cor Nouws wrote: > I noticed that our on-web Help is missing the Basic text: > http://help.libreoffice.org/Main_Page > > Was that decided, or did it just slip through? Not at all, just an omission; what is the best entry page for Basic, please? Regards, Ke

Re: [Libreoffice] compilation and bundled extensions

2011-02-15 Thread Alexander Thurgood
Le 15/02/11 10:14, Caolán McNamara a écrit : Hi, > Ah, I assumed you'd already *built* them, but wondered why they weren't > auto-installed, use --enable-ext-pdfimport, etc. to build them. > > C. > Is there no single switch to build them all in one go ? I was looking through the autogen.sh o

[Libreoffice] On-web Help Basic ?

2011-02-15 Thread Cor Nouws
Hi *, I noticed that our on-web Help is missing the Basic text: http://help.libreoffice.org/Main_Page Was that decided, or did it just slip through? Best, Cor -- - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice ma

Re: [Libreoffice] compilation and bundled extensions

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 08:44 +0100, Jean-Baptiste Faure wrote: > It seems that bundled extensions have not been build : pdfimport.oxt > does not exist. Even after having done Ah, I assumed you'd already *built* them, but wondered why they weren't auto-installed, use --enable-ext-pdfimport, etc. to

[Libreoffice] [REVIEWED] crashing oosplash and malformed picture (bnc#652562)

2011-02-15 Thread Michael Meeks
On Mon, 2011-02-14 at 20:23 +0100, Thorsten Behrens wrote: > Ugh. Yep, would absolutely like to have that in -3-3-1. Good catch. And another ack for 3.3.1 - it should really go there; I guess with Kendy's approval (the fixes look trivial) we should be good. Thanks,

Re: [Libreoffice] deliver.pl defaulting to strip

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 09:32 +0100, Jan Holesovsky wrote: > Hi Caolan, > > On 2011-02-11 at 20:27 +, Caolán McNamara wrote: > > > > deliver.pl now defaults to stripping binaries / libraries when it > > > delivers to solver, unless you export DISABLE_STRIP. > > > > It doesn't strip if you have

[Libreoffice] [REVIEWED] fix for i#115716 & fdo#33964

2011-02-15 Thread Michael Meeks
Hi Noel, On Mon, 2011-02-14 at 20:08 +, Noel Power wrote: > a) libreoffice-3-3 ( one ack please ) Ack :-) though I was initially concerned about this relying on a \0 after the end of an OString - it seems that we are using the cha * pointers as iterators in this case; so - makes sen

Re: [Libreoffice] deliver.pl defaulting to strip

2011-02-15 Thread Jan Holesovsky
Hi Caolan, On 2011-02-11 at 20:27 +, Caolán McNamara wrote: > > deliver.pl now defaults to stripping binaries / libraries when it > > delivers to solver, unless you export DISABLE_STRIP. > > It doesn't strip if you have --enable-symbols on FWIW, right ? Correct, thanks for the hint - so wha

Re: [Libreoffice] ODF 1.2 and extended

2011-02-15 Thread Thorsten Behrens
Cesare Leonardi wrote: > As a user i'd want a stable and long term file format, not one that > change often and without clear evidence of that. > Hi Cesare, yes, but you probably also want to sometimes load MS Office documents that people mail you, and not loose half of the layout. Or maybe not y