Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Jonathan Aquilina
Not trying to hijack, but i'm still a novice developer still learning the ways of development, but is there such a thing as over optimization? On 1/12/11 7:36 PM, Noel Power wrote: On 12/01/11 18:03, Norbert Thiebaud wrote: On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez wrote: On Wed, 12

Re: [Libreoffice] Debug build of sw vs system-libxml

2011-01-12 Thread David Tardon
On Thu, Jan 13, 2011 at 01:15:25AM +0100, Miklos Vajna wrote: > Hi, > > I needed the attached patch to get a debug build of the sw module. Does > it look sane and I can push it or do you have a better idea? > > The error message I get is included in the commit message. > > I put it to sw.mk afte

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] new cppcheck cleaning in cppu and cppuhelper + error in compilation

2011-01-12 Thread David Tardon
On Wed, Jan 12, 2011 at 01:12:19PM +, Caolán McNamara wrote: > On Tue, 2011-01-11 at 23:17 +0100, Julien Nabet wrote: > > It's better with the attachments :-) > > Hum, it all looks good except for the operator=, I mean, it compiles but > I don't think it *should* compile :-) it is changing the

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 alex changed: What|Removed |Added Depends on||32939 --- Comment #61 from alex 2011-01-12 19:05

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 tester8 changed: What|Removed |Added Depends on||32991 --- Comment #60 from tester8 2011-01-12

[Libreoffice] Debug build of sw vs system-libxml

2011-01-12 Thread Miklos Vajna
Hi, I needed the attached patch to get a debug build of the sw module. Does it look sane and I can push it or do you have a better idea? The error message I get is included in the commit message. I put it to sw.mk after getting about the third similar error. :) Thanks. From 2da823da67cf5b4a9591

Re: [Libreoffice] [PUSHED] Splitting up source/header files for clarity

2011-01-12 Thread Thorsten Behrens
Soeren Moeller wrote: > Thank you very much for your review, I attached a new patch (the three > patches together contain the old patch and the fixes), and below > commented on some of your your remarks. > Hi Soeren, cool, nice work - pushed as-is, just squashed into one commit. Many thanks, --

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Bug 31865 depends on bug 32193, which changed state. Bug 32193 Summary: Missing language packs, untranslated language/help packs https://bugs.freedesktop.org/show_bug.cgi?id=32193 What|Old Value |New Value --

[Libreoffice] minutes of tech steering call ...

2011-01-12 Thread Michael Meeks
Attending: Caolan, Norbert, Michael, Petr, David, Wols, Thorsten, Rene Regrets: ChaoSun + FOSDEM - schedule ok, all good. + proposed licensing policy write-up (Wols) + standardized license header template, AA: and COPYING files -> bootstrap (Wols) AA:

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Bug 31865 depends on bug 32635, which changed state. Bug 32635 Summary: BrOffice and Windows desktop integration https://bugs.freedesktop.org/show_bug.cgi?id=32635 What|Old Value |New Value --

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Noel Power
On 12/01/11 18:03, Norbert Thiebaud wrote: On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez wrote: On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote: Hi there fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is riskless etc. http://cgit.freedesktop.org/libreoffic

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Norbert Thiebaud
On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez wrote: > On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote: > >> Hi there >> >> fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is >> riskless etc. >> >> >> http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe22660

Re: [Libreoffice] [PATCH] Reducing chmod spawning by replacing exec by xargs

2011-01-12 Thread Julien Nabet
Le 12/01/2011 13:34, Christian Lohmaier a écrit : Hi *, On Sat, Jan 8, 2011 at 2:06 AM, Julien Nabet wrote: I used xargs instead of -exec to reduce chmod spawning. Hope there's no mistake in it. I don't see the point in using -i - since that in turn causes one process per file, so y

[Libreoffice] Mac Build with lang=ALL

2011-01-12 Thread Norbert Thiebaud
Thorsten, So I tried a build with lang=ALL on mac. indeed it is a dog. it took 15h20. conservatively at least 13 hours of it were in helcontent2, mostly I/O bound creating temp files and copying things around over and over. based on profiling while this was running... I did another attempt at bu

[Libreoffice] Created branch libreoffice-3-3-0

2011-01-12 Thread Petr Mladek
(sigh, pressed enter too early) Hi all, we want to reduce regressions caused by LibO-3.3.0 fixes to a real minimum. For this purpose, we created the branch "libreoffice-3-3-0" from the tag "libreoffice-3.3.0.3". Please, follow the following rules: + any commit has to be reviewed by 3 per

[Libreoffice] Created branch libreoffice-3-3-0

2011-01-12 Thread Petr Mladek
Hi all, we want to reduce regressions caused by LibO-3.3.0 fixes to a real minimum. For this purpose, we created the branch "libreoffice-3-3-0" from the tag "libreoffice-3.3.0.3". with the following rules: + any commit has to be reviewed by 3 persons + preferably add only transla

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Octavio Alvarez
On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote: Hi there fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is riskless etc. http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daacead0e1 is ripe for signoff and cherrypicking, be g

Re: [Libreoffice] Sensible lang list [was: Re: Don't change the naming scheme for rc2 please - keep windows at *install*_all_lang.exe]

2011-01-12 Thread Fridrich Strba
Since for the time being I am packaging the multi installer manually, from rc3 on. Cheers F. On Wed, 2011-01-12 at 16:57 +0100, Christian Lohmaier wrote: > Hi Friedrich, > > On Wed, Jan 12, 2011 at 4:51 PM, Fridrich Strba wrote: > > OK, just for record, this is the new sensiblelangiso list:

Re: [Libreoffice] Sensible lang list [was: Re: Don't change the naming scheme for rc2 please - keep windows at *install*_all_lang.exe]

2011-01-12 Thread Christian Lohmaier
Hi Friedrich, On Wed, Jan 12, 2011 at 4:51 PM, Fridrich Strba wrote: > OK, just for record, this is the new sensiblelangiso list: What means "new"? Since when is that list active? For next release or is this already use for currently available DL? Thanks a lot for clarifying, ciao Christian __

Re: [Libreoffice] Quasi-patch: Cursor vs Scroll

2011-01-12 Thread Maximilian Odendahl
Here's the change that triggered this... Do you think we should just revert this bit, without it we get the original scroll behaviour again. but probably break some parts of the new accessibility stuff. Let's see what od finds out. -Max ___ Libr

[Libreoffice] Sensible lang list [was: Re: Don't change the naming scheme for rc2 please - keep windows at *install*_all_lang.exe]

2011-01-12 Thread Fridrich Strba
OK, just for record, this is the new sensiblelangiso list: en-US,ar,ast,be-BY,bg,bn,bo,br,ca,ca-XV,cs,da,de,dz,el,en-GB,es,et,eu,fi,fr,gl,gu,he,hi,hr,hu,is,it,ja,km,kn,ko,lt,lv,mr,nb,nl,oc,om,or,pl,pt,pt-BR,ru,sh,si,sk,sl,sr,sv,te,tr,ug,vi,zh-CN,zh-TW Cheers Fridich On Mon, 2011-01-10 at 13:00

Re: [Libreoffice] Quasi-patch: Cursor vs Scroll

2011-01-12 Thread Caolán McNamara
On Mon, 2011-01-10 at 14:01 +0100, Maximilian Odendahl wrote: > Hi, > > > max, do you remember the code in the postits that the attached patch > > affects, can you remember what the problem was that needed fixing ? > > no, I don't remember why this is needed, but I don't think this is the > ri

Re: [Libreoffice] Translation updates in libreoffice-3-3-0

2011-01-12 Thread Michael Meeks
Hi Andras, On Wed, 2011-01-12 at 15:31 +0100, Andras Timar wrote: > Is it allowed to push translation updates (lo-build-* stuff) to > libreoffice-3-3-0 branch ? Yes. > (After double checking for formatting errors, including the ones that > Fridrich found yesterday in hr and te readme tra

[Libreoffice] Translation updates in libreoffice-3-3-0

2011-01-12 Thread Andras Timar
Hi, Is it allowed to push translation updates (lo-build-* stuff) to libreoffice-3-3-0 branch? (After double checking for formatting errors, including the ones that Fridrich found yesterday in hr and te readme translations.) Many teams reached 100% in the last two days and others are busy with upda

Re: [Libreoffice] [REVIEW] (Offensive Word Found In Message)

2011-01-12 Thread Noel Power
On 12/01/11 12:25, Michael Meeks wrote: On Wed, 2011-01-12 at 06:17 -0600, Norbert Thiebaud wrote: is available for cherrypick/signoff It looks fine to me. Merged to libreoffice-3-3 and libreoffice-3-3-0, and re-working in master to suck less too ;-) Thanks, M

Re: [Libreoffice] [PATCH] [PUSHED] Translations of comments in writer/sw/inc

2011-01-12 Thread Thorsten Behrens
Christoph Herzog wrote: > Subject: [PATCH] Translations of comments in writer/sw/inc > Looks all good, pushed. Thanks a lot, -- Thorsten pgpXXEhy8Xx0H.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http:

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] new cppcheck cleaning in cppu and cppuhelper + error in compilation

2011-01-12 Thread Caolán McNamara
On Wed, 2011-01-12 at 13:12 +, Caolán McNamara wrote: > On Tue, 2011-01-11 at 23:17 +0100, Julien Nabet wrote: > > It's better with the attachments :-) > > Hum, it all looks good except for the operator=, I mean, it compiles but > I don't think it *should* compile :-) it is changing the state

[Libreoffice] [PUSHED, partial] Re: [PATCH] new cppcheck cleaning in cppu and cppuhelper + error in compilation

2011-01-12 Thread Caolán McNamara
On Tue, 2011-01-11 at 23:17 +0100, Julien Nabet wrote: > It's better with the attachments :-) Hum, it all looks good except for the operator=, I mean, it compiles but I don't think it *should* compile :-) it is changing the state of "this". Something odd here. Pushed the rest of this however. Nee

Re: [Libreoffice] [PATCH] Reducing chmod spawning by replacing exec by xargs

2011-01-12 Thread Christian Lohmaier
Hi *, On Sat, Jan 8, 2011 at 2:06 AM, Julien Nabet wrote: > > I used xargs instead of -exec to reduce chmod spawning. > Hope there's no mistake in it. I don't see the point in using -i - since that in turn causes one process per file, so you don't really gain anything, do you? Furthermore -i is

Re: [Libreoffice] [REVIEW]

2011-01-12 Thread Michael Meeks
On Wed, 2011-01-12 at 06:17 -0600, Norbert Thiebaud wrote: > > is available for cherrypick/signoff > It looks fine to me. Merged to libreoffice-3-3 and libreoffice-3-3-0, and re-working in master to suck less too ;-) Thanks, Michael. -- michael.me...@novell.co

Re: [Libreoffice] [REVIEW]

2011-01-12 Thread Norbert Thiebaud
On Wed, Jan 12, 2011 at 5:51 AM, Noel Power wrote: > I'd like to include this fix ( which fixes corruption of formfield checkbox > related data in binary format on export ) in libreoffice-3-3 > > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=af4d6062b7e676ed56dc84927fb99b79aa03a7b5 > >

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Michael Meeks
Hi Noel, On Wed, 2011-01-12 at 11:18 +, Noel Power wrote: > fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is > riskless etc. wow - that is a surprising code flow :-) > http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daace

[Libreoffice] [REVIEW]

2011-01-12 Thread Noel Power
I'd like to include this fix ( which fixes corruption of formfield checkbox related data in binary format on export ) in libreoffice-3-3 http://cgit.freedesktop.org/libreoffice/writer/commit/?id=af4d6062b7e676ed56dc84927fb99b79aa03a7b5 is available for cherrypick/signoff thanks, Noel

[Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Noel Power
Hi there fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is riskless etc. http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daacead0e1 is ripe for signoff and cherrypicking, be grateful if someone could help with that thanks, Noel

Re: [Libreoffice] Review request

2011-01-12 Thread Michael Meeks
On Tue, 2011-01-11 at 20:29 +0100, Cedric Bosdonnat wrote: > I'ld like to get a crasher fix around the enhanced fields into > libreoffice-3-3 branch... .. > Could anyone review and cherry-pick this commit? > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=0921bd5dc88dfd212fc5a332e0902347

Re: [Libreoffice] Wanted Presenter Screen

2011-01-12 Thread Michael Meeks
On Wed, 2011-01-12 at 10:05 +0100, Rene Engelhard wrote: > Committed and pushed to both libreoffice-3-3 and libreoffice-3-3-0 branches. Great - it looks fine to me too. Incidentally - we are in triple review mode for libreoffice-3-3-0 :-) ATB, Michael.

Re: [Libreoffice] Localizations of UI and help - what languages does LibO support?

2011-01-12 Thread Michael Meeks
On Tue, 2011-01-11 at 20:32 +, Wols Lists wrote: > (And English is the language spoken by the Saxons! :-) Those evil Saxons ! ;-) Michael (an Anglo Saxon ish. type) -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___

[Libreoffice] [PATCH] Translations of comments in writer/sw/inc

2011-01-12 Thread Christoph Herzog
From fcda1e5b7cd78b186dd4d6e8b86df8e3ea4d6833 Mon Sep 17 00:00:00 2001 From: Christoph Herzog Date: Wed, 12 Jan 2011 10:32:43 +0100 Subject: [PATCH] Translations of comments in writer/sw/inc --- sw/inc/docary.hxx | 17 sw/inc/docfac.hxx |2 +- sw/inc/docsh.hxx| 72 +

Re: [Libreoffice] Occitan's project - About installation of optional components like dictionaries

2011-01-12 Thread Andras Timar
2011/1/12 bruno gallart > Occitan lengadocian's project LibreOffice > > Hi all, > > I don't know if it is here that I must ask about some problem on > installation of dictionaries in LibreOffice so ... I try !! > > I wanted know who I have to contact to introduce the spellcheker's files > for O

Re: [Libreoffice] Wanted Presenter Screen

2011-01-12 Thread Jean-Baptiste Faure
Le 12/01/2011 10:05, Rene Engelhard a écrit : > On Wed, Jan 12, 2011 at 02:40:09AM +0100, Rene Engelhard wrote: >> diff --git a/sdext/source/presenter/makefile.mk >> b/sdext/source/presenter/makefile.mk >> index 696d0e5..9e25e34 100755 >> --- a/sdext/source/presenter/makefile.mk >> +++ b/sdext/sou

Re: [Libreoffice] Wanted Presenter Screen

2011-01-12 Thread Rene Engelhard
On Wed, Jan 12, 2011 at 02:40:09AM +0100, Rene Engelhard wrote: > diff --git a/sdext/source/presenter/makefile.mk > b/sdext/source/presenter/makefile.mk > index 696d0e5..9e25e34 100755 > --- a/sdext/source/presenter/makefile.mk > +++ b/sdext/source/presenter/makefile.mk > @@ -372,7 +372,7 @@ PHONY

[Libreoffice] Occitan's project - About installation of optional components like dictionaries

2011-01-12 Thread bruno gallart
Occitan lengadocian's project LibreOffice Hi all, I don't know if it is here that I must ask about some problem on installation of dictionaries in LibreOffice so ... I try !! I wanted know who I have to contact to introduce the spellcheker's files for Occitan lengadocian (oc_Fr.dic and oc_

[Libreoffice] About installation of optional components like dictionaries - occitan's project

2011-01-12 Thread bruno gallart
Occitan lengadocian's project LibreOffice Hi all, I don't know if it is here that I must ask about some problem on installation of dictionaries in LibreOffice so ... I try !! I wanted know who I have to contact to introduce the spellcheker's files for Occitan lengadocian (oc_Fr.dic and oc_