Re: [Libreoffice] regression tests - for word count ...

2010-11-01 Thread LeMoyne
[PATCH] Fixes char overcount when selection ends in middle of word Patch in sw changes only one object: sw/source/core/txtedt.cxx Error was reported by Sophie Gautier on bug 30550 https://bugs.freedesktop.org/show_bug.cgi?id=30550 The basic fix is very simple: change the SwScanner constructor

Re: [Libreoffice] support for mono 2.8

2010-11-01 Thread Andreas Radke
After talking to our mono package maintainer there's probably a broken pkgconfig call in LibO. We had a similar issue when building kdebindings-csharp: https://bugs.archlinux.org/task/21319 There's probably somewhere in the LibO build code a call like pkg-config --libs --cflags mono that needs

[Libreoffice] Icons

2010-11-01 Thread Joseph Powers
Andrew, I'm a little crazy, but I want to work on the icon issues. I'm a programmer, so I've been looking at things from the other side... Currently the system is a mess, the top level determines if if we're in high-contrast mode or not and then requests the correct image. On top of this, we h

Re: [Libreoffice] Build Issue on Mac OS X

2010-11-01 Thread LeMoyne
Hi Joseph, Not a build expert but can see that your run dies because 'shl/OOO/NONE' isn't defined in the action set. I would copy paste line with shl/NONE/OOO and edit in the required (fallback?) key like: ... 'shl/NONE/OOO' => '@__VIA_LIBRARY_PATH__', 'shl/OOO/NONE' => '@__VIA

Re: [Libreoffice] Help concerning code style and documentation

2010-11-01 Thread Kohei Yoshida
Hi Regina, On Sun, 2010-10-24 at 18:13 +0200, Regina Henschel wrote: > Hi all, > > I'm currently working on LINEST and have attached a draft to issue > http://www.openoffice.org/issues/show_bug.cgi?id=115189 > > There is no mathematical problem, but I'm uncertain about coding style. > The algor

[Libreoffice] Build Issue on Mac OS X

2010-11-01 Thread Joseph Powers
Ok, I need a build system expert: Making:test_pathutils.dylib illegal combination shl/OOO/NONE at /Users/jpowers27/build/build/libreoffice-3.2.99.2/solenv/bin/macosx-change-install-names.pl line 54, line 5. dmake: Error code 9, while making '../unxmacxi.pro/lib/test_pathutils.dylib' dmake:

[Libreoffice] [PUSHED] EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

2010-11-01 Thread Kohei Yoshida
Hello Joost, Thanks for the patch. Just pushed to the master branch. :-) On Mon, 2010-11-01 at 23:38 +0100, Joost Eekhoorn wrote: > MPL 1.1 / GPLv3+ / LGPLv3+ > > What must be done with empty strings ("")? I did only the replacement > with the macro: For empty strings, I would simply construct

Re: [Libreoffice] [Review Request] remove a confusing use of GetMutex() when a SolarMutexGuard is really meant

2010-11-01 Thread Thorsten Behrens
Norbert Thiebaud wrote: > The attached patches are pending... I am submitting them to the list > for comments or objections before pushing them. > Hi Norbert - patches seem to be pushed - many thanks for the cleanup! Cheers, -- Thorsten pgp52GbxTjXhW.pgp Description: PGP signature

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Thorsten Behrens
Norbert Thiebaud wrote: > On Mon, Nov 1, 2010 at 6:05 AM, Caolán McNamara wrote: > > Can anyone convince me that its not cargo-cult programming and that the > > mutexes achieve something worth-while ;-) ? > Nope. Looking at other places, there's really no consistent serialization whatsoever. > mu

Re: [Libreoffice] Export OLE objects as PDF / graphics

2010-11-01 Thread Thorsten Behrens
gertfal...@aliceadsl.fr wrote: > in draw : easy rotate, crop, resize and right click 'save as...' > in impress : same features and same toolbars > in calc : easy resize, right click 'rotate', but no crop nor 'save as...' > in writer : no 'rotate', easy resize, right click 'crop', right click 'save

Re: [Libreoffice] OpenBSD patch #1

2010-11-01 Thread Thorsten Behrens
Michael Meeks wrote: > As for the csh .Set file - hopefully we can bin that in a gnumake > world, by having a single set of makefile variables generated instead of > whacking them all in the environment via a given shell. > Please - bin both .Set and .Set.sh then - since this hidden-in-the-e

Re: [Libreoffice] SW_DLLPUBLIC limitations ...

2010-11-01 Thread Thorsten Behrens
Cedric Bosdonnat wrote: > I finally got it working with SAL_DLLPUBLIC_EXPORT as michael suggested. > If there is any possible trouble, let me know ;) > Hi - oh wow, dynamic_casting on interfaces is really nasty - we should truly put up a bunch of big red warning signs around that. FWIW, if you try

Re: [Libreoffice] Help concerning code style and documentation

2010-11-01 Thread Thorsten Behrens
Regina Henschel wrote: > There is no mathematical problem, but I'm uncertain about coding > style. The algorithms work on matrices. They have a lot of parts > which are nearly identical but the matrices are transposed. How to > handle that? > Hi Regina, I'd suggest using templates to achieve that

Re: [Libreoffice] Building on CentOS 5

2010-11-01 Thread Wols Lists
On 01/11/10 23:06, Terrell Prude' Jr. wrote: > Wols Lists wrote: >> On 01/11/10 05:03, Terrell Prude' Jr. wrote: >> >>> There is also one I'm not sure how to satisfy within CentOS 5's >>> packaging. This would be Qt4. Here are the messages from make. >>> >>> checking which jfreereport libs to

Re: [Libreoffice] Building on CentOS 5

2010-11-01 Thread Terrell Prude' Jr.
Wols Lists wrote: On 01/11/10 05:03, Terrell Prude' Jr. wrote: There is also one I'm not sure how to satisfy within CentOS 5's packaging. This would be Qt4. Here are the messages from make. checking which jfreereport libs to use... internal checking for jfreereport module... OK checking

[Libreoffice] EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

2010-11-01 Thread Joost Eekhoorn
MPL 1.1 / GPLv3+ / LGPLv3+ What must be done with empty strings ("")? I did only the replacement with the macro: - sFileExtension = sFirstFilter.equalsAscii("*.*") ? *::rtl::OUString::**createFromAscii("") *: sFirstFilter.copy( sFirstFilter.indexOfAsciiL("*.", 2) + 2 ); - aPathStr = sFileExte

[Libreoffice] [PATCH] Another Qt/gtk configure patch

2010-11-01 Thread Wols Lists
I've now got configure autodetecting Qt4, and created an "automagic" patch. Things are still partly broken because to fix things properly I need to get rid of OOO_WIDGET_FLAGS, and that's probably a big job ... Anyways, the patch does the following: Adds a new --enable-automagic option. As the he

[Libreoffice] Easy Hack: Don't draw caret when visual formula editor looses focus

2010-11-01 Thread Luke Dixon
Hello, I thought I'd try one of the visual formula editor easy hacks, as Michael had recommended. This one seemed the easiest of the three there. Hope it's okay. Regards, Luke >From 9de527f33cd410422e706da547fae67d6a5adbee Mon Sep 17 00:00:00 2001 From: Luke Dixon <6b8b4...@gmail.com> Date: Mo

Re: [Libreoffice] build failure loading pythonloader.uno.so

2010-11-01 Thread Thomas Klausner
On Sun, Oct 24, 2010 at 12:56:39PM +0100, Caolán McNamara wrote: > This sucks, looks like catch throw and catch catch don't work on NetBSD. > Or maybe its too old a gdb or something. Maybe add a "break main" and > reorganize the gdb script in the hope that it needs libstdc++ to be > loaded before i

[Libreoffice] build failure in dbaccess/qa/complex/dbaccess

2010-11-01 Thread Thomas Klausner
Entering /build/libreoffice-3.2.99.2/dbaccess/qa/complex/dbaccess Making:DbaComplexTests.dpj /usr/pkg/java/openjdk7/bin/javac -source 1.5 -target 1.5 -classpath ".:../../../unxbsdx3.pro/class:/usr/pkg/java/openjdk7/jre/lib/rt.jar:.:/build/libreoffice-3.2.99.2/solver/330/unxbsdx3.pro/

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 4

2010-11-01 Thread Gert Faller
Selon Caolán McNamara : > Mostly good, though createFromAscii_7.patch has... > > OUString::createFromAscii( GetWindowState( WINDOWSTATE_MASK_POS ).GetBuffer() > ) ); > > that one can't be changed to use RTL_CONSTASCII_USTRINGPARAM because > GetWindowState is a method rather than a string literal,

[Libreoffice] [Pushed] Fix comments in filters/xmerge

2010-11-01 Thread Michael Meeks
Hi Nigel, On Mon, 2010-11-01 at 16:16 +, Nigel Hawkins wrote: > Well, since the first lot worked, a few more patches on the same lines. Thanks :-) lots of nice cleanups; pushed ... Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot __

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 4

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 20:28 +0100, Gert Faller wrote: > Hi, > > more of that... > Mostly good, though createFromAscii_7.patch has... OUString::createFromAscii( GetWindowState( WINDOWSTATE_MASK_POS ).GetBuffer() ) ); that one can't be changed to use RTL_CONSTASCII_USTRINGPARAM because GetWindo

[Libreoffice] [PUSHED] Re: [PATCH] Fix comments in filters/xmerge

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 16:16 +, Nigel Hawkins wrote: > Well, since the first lot worked, a few more patches on the same lines. Heh, all looks good, pushed. Thanks. If Java's your thing you might be interested in poking at things like the wiki-publisher extension in swext with an eye to improvi

[Libreoffice] [Pushed] Bogus comments, commented lines removed and some comments translated.

2010-11-01 Thread Michael Meeks
Hi Robert, On Mon, 2010-11-01 at 20:26 +0200, Roth Robert wrote: > Attached you'll find 4 patches, colicensed with LGPLv3+, GPLv3+ and > MPL, with some bogus comments removed containing only changed date, > some commented lines removed, and some german comments translated. > I hope this is the rig

Re: [Libreoffice] [PUSHED] Re: (no subject)

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 21:06 +0100, Rene Engelhard wrote: > Hi, > > On Mon, Nov 01, 2010 at 10:11:07AM +, Caolán McNamara wrote: > > caolanm->rene: Think we should use AS_HELP_STRING everywhere ? > > Yeah. Good idea. Sounds like a easy hack :) oky doky, added as an easy hack. caolanm->ronkk

Re: [Libreoffice] LibreOffice Icon Naming

2010-11-01 Thread Andrew C. E. Dent
Hi Andrew I'm another Andrew who also cares about Icons! (Normally people refer to me by my User name of 'ace_dent').I first started to analyse the problem about 5yrs ago(!) but gave in under the original Sun ownership.I have started the bare seeds of this over on the wiki:http://wiki.document

Re: [Libreoffice] [PUSHED] Re: (no subject)

2010-11-01 Thread Rene Engelhard
Hi, On Mon, Nov 01, 2010 at 10:11:07AM +, Caolán McNamara wrote: > caolanm->rene: Think we should use AS_HELP_STRING everywhere ? Yeah. Good idea. Sounds like a easy hack :) Grüße/Regards, René ___ LibreOffice mailing list LibreOffice@lists.freede

Re: [Libreoffice] supported compilers?

2010-11-01 Thread Kohei Yoshida
On Mon, 2010-11-01 at 20:56 +0200, Jani Monoses wrote: > Is there a list of which compilers are supported and what versions > recommeneded for building LO? I don't think we have an official list of recommended compilers and their versions per se. But normally we suggest whatever compiler your pl

[Libreoffice] supported compilers?

2010-11-01 Thread Jani Monoses
Is there a list of which compilers are supported and what versions recommeneded for building LO? I was thinking of the feasibility of using gcc's __builtin_constant_p in a macro to differentiate fast and not so fast paths for createFromAscii cases to keep the code uniform but still get the opt

Re: [Libreoffice] LibreOffice Icon Naming

2010-11-01 Thread Andrew
Regarding https://bugs.freedesktop.org/show_bug.cgi?id=30425 The way that LibreOffice packages its icon themes if far too complex and difficult and therefore stifles creativity when it comes to creating new icon themes. Icon are given cryptic names such as envvl_l.png in cryptic directories such

Re: [Libreoffice] CloudOS : summer project

2010-11-01 Thread Michael Meeks
Hi Arvind, On Mon, 2010-11-01 at 21:04 +0530, Arvind Prabhakar wrote: > Therefore , I would like to invite you in my project. Please provide > us the guidelines and help me to accomplish my project . For this > act of your kindness I shall be highly obliged to you . Sounds like fun; I s

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Wols Lists
On 01/11/10 14:13, Jan Holesovsky wrote: > Hi Sebastian, > > On 2010-11-01 at 09:36 +0100, Sebastian Spaeth wrote: > >>> The idea is to forget the 'build' repository in the normal process, and >>> let it only for the documentation, and for the distro maintainers - if >>> they need it at all. 'boot

Re: [Libreoffice] Building on CentOS 5

2010-11-01 Thread Wols Lists
On 01/11/10 05:03, Terrell Prude' Jr. wrote: > There is also one I'm not sure how to satisfy within CentOS 5's > packaging. This would be Qt4. Here are the messages from make. > > checking which jfreereport libs to use... internal > checking for jfreereport module... OK > checking which Apache

Re: [Libreoffice] Decrease installer size by 1 MB for each language

2010-11-01 Thread Michael Meeks
Hi Kami, On Mon, 2010-11-01 at 12:17 +0100, Kálmán „KAMI” Szalai wrote: > I would like to consulate related to topic. I found that every wizards' > bitmap enclosed for every language however it has no language dependent > bitmaps in it. :-) This is a beautiful patch. > My suggestion to

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Michael Meeks
Hi Sebastian, On Mon, 2010-11-01 at 09:27 +0100, Sebastian Spaeth wrote: > May I nag a little ? Please do ! :-) > Besides some rumours I did not know anything about a > branching over the weekend (and it does not seem to have happened > anyway). Neither could I find any branching plans

Re: [Libreoffice] Building LibreOffice in Ubuntu Maverick

2010-11-01 Thread Michael Meeks
Hi there, On Sun, 2010-10-31 at 02:31 +0530, surensp...@gmail.com wrote: > There were few issues Grief - I hope we can solve these with auto-detection etc. in master post branch. It would be worth adding your fixes to the wiki if you can maintain that - to help other Ubuntu-ites :-) > Bu

Re: [Libreoffice] [PUSHED] Re: [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM in starmath

2010-11-01 Thread Michael Meeks
Hi there, On Sat, 2010-10-30 at 22:24 +0100, Caolán McNamara wrote: > > This changes the only occurrence in writer/starmath. > > Thanks, Hmm, an empty string. I wonder why it using ::createFromAscii > for the empty string case. I suggest that... Interesting question that needs testing. S

Re: [Libreoffice] MERRY IN THE LORD

2010-11-01 Thread Michael Meeks
Hi Caolan, On Sun, 2010-10-31 at 20:22 +, Caolán McNamara wrote: > This is truly fabulous news and not at all unlikely and ridiculous. I > look forward to being improved. Heh - we got quite a lot of bounces initially fro people un-subscribed to the list; and time was wasted approving

Re: [Libreoffice] [PATCH] [Pushed] Removed deprecated option --with-unzip-home

2010-11-01 Thread Norbert Thiebaud
Pushed, Thanks Norbert On Mon, Nov 1, 2010 at 11:49 AM, Niko Rönkkö wrote: > MPL 1.1 / GPLv3+ / LGPLv3+ > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > > _

Re: [Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-01 Thread Norbert Thiebaud
On Mon, Nov 1, 2010 at 12:23 PM, Michael Meeks wrote: > > On Mon, 2010-11-01 at 17:44 +0100, Sebastian Spaeth wrote: >> Also because binfilter annoys me and other developers on IRC prefered it >> disabled by default too :) > >        Quite ;-) wastes lots of cycles. > >        I believe we have --

Re: [Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-01 Thread Michael Meeks
On Mon, 2010-11-01 at 17:44 +0100, Sebastian Spaeth wrote: > Also because binfilter annoys me and other developers on IRC prefered it > disabled by default too :) Quite ;-) wastes lots of cycles. I believe we have --disable-binfilter in the default profile though (?) either way,

[Libreoffice] [PATCH] Removed deprecated option --with-unzip-home

2010-11-01 Thread Niko Rönkkö
MPL 1.1 / GPLv3+ / LGPLv3+ >From 8d356d68781be2a312072c7b2855f45c9a60a169 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niko=20R=C3=B6nkk=C3=B6?= In-Reply-To: <4cceeef3.5050...@iki.fi> References: <4cceeef3.5050...@iki.fi> Date: Mon, 1 Nov 2010 18:41:45 +0200 Subject: [PATCH] Removed deprecated option

[Libreoffice] Branched for LibreOffice 3.3

2010-11-01 Thread Jan Holesovsky
Hi all, I created the 'libreoffice-3-3' branch for the stabilization for the 3.3 release [aka feature freeze ;-)] You can again unleash your creativity in 'master' - so please do so! One of the things that will be done in master is the deprecation of the 'build' repo (discussed in the 'build vs.

Re: [Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-01 Thread Sebastian Spaeth
On Mon, 01 Nov 2010 16:14:35 +, Caolán McNamara wrote: > On Mon, 2010-11-01 at 17:11 +0100, Sebastian Spaeth wrote: > > Currently the deprecated binfilter are build by default as the inner > > configure explicitely requires --disable-binfilter to get rid of > > them. This patch defaults to dis

Re: [Libreoffice] [PATCH] Fix comments in filters/xmerge

2010-11-01 Thread Nigel Hawkins
Well, since the first lot worked, a few more patches on the same lines. Nigel >From a4d81a4e0da75696c8210cecb57a3e4c7bcc0e93 Mon Sep 17 00:00:00 2001 From: Nigel Hawkins Date: Thu, 28 Oct 2010 13:41:37 +0100 Subject: [PATCH 10/17] Fix javadoc comments in EmbeddedXMLObject.java --- .../xmerge/co

Re: [Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 17:11 +0100, Sebastian Spaeth wrote: > Currently the deprecated binfilter are build by default as the inner > configure explicitely requires --disable-binfilter to get rid of > them. This patch defaults to disabled and require --enable-binfilter > to turn them on. Ran configur

[Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-01 Thread Sebastian Spaeth
Currently the deprecated binfilter are build by default as the inner configure explicitely requires --disable-binfilter to get rid of them. This patch defaults to disabled and require --enable-binfilter to turn them on. Ran configure with both options and it worked fine. Signed-off-by: Sebastian S

Re: [Libreoffice] [PATCH] have git diff treat dictionaries/*.idx|dic|dat as binary

2010-11-01 Thread Andrea Pescetti
Sebastian Spaeth wrote: > Treating those dictionaries as binary files has no side-effect other > than that git won't try to show a diff for those commits And this would be a loss to me: dictionaries are plain text files, and I would like to be able to see what changed in/before a commit just like

Re: [Libreoffice] Apple Java update on Mac OSX breaks all java functionality in LibO - Issue 115180

2010-11-01 Thread Caolán McNamara
On Sun, 2010-10-24 at 21:35 +0200, Alexander Thurgood wrote: > Hi all, > > Just a heads up coz I don't know whether you've heard about this yet. > Reported in Issue 115180 on OOo Issue Tracker. The problem also affects > LibO in its latest incarnations. The fix for this of issuezill#115180 is now

[Libreoffice] CloudOS : summer project

2010-11-01 Thread Arvind Prabhakar
Hi I'm Arvind Prabhakar , a final year B.tech student pursuing my B.tech degree from cochin university , India . I'm currently into a project named cloud OS . In the project first of all we are trying to build a client OS with minimum requirements i.e a window manager and a web browser . In server

Re: [Libreoffice] [PATCH] Enable testtool (and possibly other stuff) to run with LibO "soffice"

2010-11-01 Thread Giuseppe Castagno
Caolán McNamara wrote: So, let me get this straight. Various bits of tooling etc depend on a /usr/bin/soffice right ? Is that the problem. So perhaps the solution right, depends on a /usr/bin/soffice to reach the installation location is to simply add a /usr/bin/soffice to go alongside /usr/b

Re: [Libreoffice] Building on CentOS 5

2010-11-01 Thread Terrell Prude' Jr.
Caolán McNamara wrote: On Mon, 2010-11-01 at 01:03 -0400, Terrell Prude' Jr. wrote: - gperf - libXaw-devel - GConf2-devel - gnome-vfs2-devel Added these to the wiki. There is also one I'm not sure how to satisfy within CentOS 5's packaging. This would be Qt4. Here are the mes

Re: [Libreoffice] [PATCH] Enable testtool (and possibly other stuff) to run with LibO "soffice"

2010-11-01 Thread Caolán McNamara
So, let me get this straight. Various bits of tooling etc depend on a /usr/bin/soffice right ? Is that the problem. So perhaps the solution is to simply add a /usr/bin/soffice to go alongside /usr/bin/libreoffice in the desktop-integration rpms. C. ___

[Libreoffice] [PATCH] have git diff treat dictionaries/*.idx|dic|dat as binary

2010-11-01 Thread Sebastian Spaeth
The git contributor script crunches through repos and invokes git to gather data. However, the dictionaries are 100k lines of code changes and git log --numstat literally works for hours on those commits. All other LO git repos take about 5-10 minutes to analyze. lib-extern-sys takes about 5 hours

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Sebastian Spaeth
On Mon, 01 Nov 2010 15:13:35 +0100, Jan Holesovsky wrote: > And if you have the build dependencies of eg. writer (eg. from your > Linux distro), you shouldn't need any of the other repositories at all, > to be able to build it. Thanks for the info. Sebastian pgportBw9QEio.pgp Description: PGP

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Jan Holesovsky
Hi Sebastian, On 2010-11-01 at 09:36 +0100, Sebastian Spaeth wrote: > > The idea is to forget the 'build' repository in the normal process, and > > let it only for the documentation, and for the distro maintainers - if > > they need it at all. 'bootstrap' would become the new main repo, and > >

Re: [Libreoffice] Debian packaging in universal LibO seems broken.

2010-11-01 Thread Giuseppe Castagno
Hi Petr, Petr Mladek wrote: Giuseppe Castagno píše v Pá 22. 10. 2010 v 15:19 +0200: Comments follow Giuseppe Castagno wrote: Hi all, it seems that the Debian packaging in the universal is somehow broken in instsetoo_native. The URE package name seems wrong. Seems related to the new naming

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Jan Holesovsky
Hi Sebastian, On 2010-11-01 at 09:17 +, Caolán McNamara wrote: > > > ...post the branch / freeze over the weekend... > > > > May I nag a little? Besides some rumours I did not know anything about a > > branching over the weekend (and it does not seem to have happened > > anyway). Neither cou

Re: [Libreoffice] killing EPM ...

2010-11-01 Thread Petr Mladek
Christian Lohmaier píše v Po 25. 10. 2010 v 22:36 +0200: > Hi Michael, > > On Mon, Oct 25, 2010 at 10:10 PM, Michael Meeks > wrote: > >Soo ... I hate EPM ;-) not sure if that is a universal feeling, but > > it > > certainly fouls up the compilation, deps and smoke-testing process. > > W

Re: [Libreoffice] Macro Cleanup in UNO

2010-11-01 Thread Joseph Powers
On Oct 31, 2010, at 10:40 PM, Norbert Thiebaud wrote: > On Sun, Oct 31, 2010 at 11:44 PM, Joseph Powers wrote: > [...] >> >> The defaults for the classes where defined in the header (good); however, >> they used generic names like DEFAULT_VALUE, FREESPACE, … (bad). I went ahead >> and renamed t

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Norbert Thiebaud
On Mon, Nov 1, 2010 at 6:05 AM, Caolán McNamara wrote: > On Mon, 2010-11-01 at 10:54 +0100, David Tardon wrote: >> Yes, but the situation here is different. The Paint method is actually >> defined in the same class and has nothing in common with VCL's >> Window::Paint. The actual painting is done

[Libreoffice] Decrease installer size by 1 MB for each language

2010-11-01 Thread Kálmán „KAMI” Szalai
Hi All, I would like to consulate related to topic. I found that every wizards' bitmap enclosed for every language however it has no language dependent bitmaps in it. My suggestion to remove language dependency, so we can save around 1 MB of every installer. I created two patches however they are

Re: [Libreoffice] Debian packaging in universal LibO seems broken.

2010-11-01 Thread Petr Mladek
Giuseppe Castagno píše v Pá 22. 10. 2010 v 15:19 +0200: > Comments follow > > Giuseppe Castagno wrote: > > Hi all, > > > > it seems that the Debian packaging in the universal is somehow broken in > > instsetoo_native. > > > > The URE package name seems wrong. > > > > Seems related to the new na

Re: [Libreoffice] [PATCH][Pushed] emacs.el: Replace all mentions of OOo with LO

2010-11-01 Thread Norbert Thiebaud
On Sat, Oct 30, 2010 at 5:35 AM, Tim Retout wrote: > Hello, world! > > This is a naive replacement of "OpenOffice.org" with "LibreOffice" in > emacs.el in the "build" repository. > Thanks Tim, Pushed. > Will patches sent with git send-email be accepted? I speak only for myself, but due to my s

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 10:54 +0100, David Tardon wrote: > Yes, but the situation here is different. The Paint method is actually > defined in the same class and has nothing in common with VCL's > Window::Paint. The actual painting is done through Canvas. Can anyone convince me that its not cargo-cu

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

2010-11-01 Thread Caolán McNamara
On Thu, 2010-10-28 at 13:21 +0100, Caolán McNamara wrote: > Hmm, sort of looks like the underlying cppu stuff, or something it uses, > got pulled out from under it during the test. I don't think it could > have gotten that far for the uno::sequence dtor (which looks up the type > of its argument) t

Re: [Libreoffice] Bug Triage Process

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 11:29 +0100, Sophie Gautier wrote: > Also, I would like to help on closing some issues that are fixed. Is > it ok if I check them against a build provided by Cedric some days > ago, or is it better to wait for the next beta? I reckon you can go ahead and close anything that y

Re: [Libreoffice] Bug Triage Process

2010-11-01 Thread Sophie Gautier
Hi all, On Sun, Oct 31, 2010 at 1:07 AM, Caolán McNamara wrote: > On Thu, 2010-10-21 at 04:36 -0600, Muthu Subramanian wrote: >> Hi, >> >> I wrote a simple wiki for bug triage process, >> http://wiki.documentfoundation.org/BugTriage as a starting point. >> This would help anyone who is looking at

[Libreoffice] [PUSHED] Re: (no subject)

2010-11-01 Thread Caolán McNamara
I pushed your fix for the help text. I didn't however add the AS_HELP_STRING piece seeing as we're not doing that in the other ones. I reckon that if we use AS_HELP_STRING we should do it consistently across all of them. caolanm->rene: Think we should use AS_HELP_STRING everywhere ? C. _

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Norbert Thiebaud
On Mon, Nov 1, 2010 at 4:54 AM, David Tardon wrote: > On Mon, Nov 01, 2010 at 09:24:09AM +, Caolán McNamara wrote: >> On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: >> >     ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); >> >     Paint(rEvent.UpdateRect); >> >> > I

[Libreoffice] [PUSHED] Re: [PUSHED, partially] Re: [PATCH] cppcheck "Common realloc mistake"

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 09:02 +0100, Gert Faller wrote: > I was just wondering if freeing some bytes was worth while. > A patch for this... re: realloc_patch_3.patch Yeah, it's probably a bit expensive to realloc in order to drop a tiny amount of bytes, but its an unlikely code path anyway so patch

Re: [Libreoffice] [PATCH] (bootstrap) Internal separation of options of configure

2010-11-01 Thread Kálmán „KAMI” Szalai
Committed, Pushed Thanks, KAMI 2010-10-31 18:26 keltezéssel, Niko Rönkkö írta: > After KAMIs changes... > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice signature.asc

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread David Tardon
On Mon, Nov 01, 2010 at 09:24:09AM +, Caolán McNamara wrote: > On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: > > ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); > > Paint(rEvent.UpdateRect); > > > I'm thinking I should change this guard with a SolarMutexGua

Re: [Libreoffice] [Review Request] remove a confusing use of GetMutex() when a SolarMutexGuard is really meant

2010-11-01 Thread Caolán McNamara
On Sun, 2010-10-31 at 23:07 -0500, Norbert Thiebaud wrote: > The attached patches are pending... I am submitting them to the list > for comments or objections before pushing them. Looks reasonable to me anyway, most of this is in toolkit, maybe Thorsten can have a double-check of that as I'd guess

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Caolán McNamara
On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: > ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); > Paint(rEvent.UpdateRect); > I'm thinking I should change this guard with a SolarMutexGuard aSolarGuard; > > Someone has an opinion on this ? Because it's protect

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 09:27 +0100, Sebastian Spaeth wrote: > On Fri, 29 Oct 2010 21:41:26 +0100, Michael Meeks > wrote: > > ...post the branch / freeze over the weekend... > > May I nag a little? Besides some rumours I did not know anything about a > branching over the weekend (and it does not s

Re: [Libreoffice] Building on CentOS 5

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 01:03 -0400, Terrell Prude' Jr. wrote: > > - gperf > > - libXaw-devel > > - GConf2-devel > > - gnome-vfs2-devel Added these to the wiki. > > > > There is also one I'm not sure how to satisfy within CentOS 5's > > packaging. This would be Qt4. Here are the messages from ma

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Sebastian Spaeth
On Sat, 30 Oct 2010 00:12:56 +0200, Jan Holesovsky wrote: > The idea is to forget the 'build' repository in the normal process, and > let it only for the documentation, and for the distro maintainers - if > they need it at all. 'bootstrap' would become the new main repo, and > would have the foll

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Sebastian Spaeth
On Fri, 29 Oct 2010 21:41:26 +0100, Michael Meeks wrote: > ...post the branch / freeze over the weekend... May I nag a little? Besides some rumours I did not know anything about a branching over the weekend (and it does not seem to have happened anyway). Neither could I find any branching plans

Re: [Libreoffice] [PUSHED, partially] Re: [PATCH] cppcheck "Common realloc mistake"

2010-11-01 Thread Gert Faller
Selon Caolán McNamara : > 2. The other possible solution is to take advantage that in this case I > can see that the string is bring shrunk, so (double-checking man > realloc) on failure "the original block is left untouched". Right before > the realloc a NULL char is entered at the point where