On Mon, Nov 1, 2010 at 4:54 AM, David Tardon <dtar...@redhat.com> wrote: > On Mon, Nov 01, 2010 at 09:24:09AM +0000, Caolán McNamara wrote: >> On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: >> > ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); >> > Paint(rEvent.UpdateRect); >> >> > I'm thinking I should change this guard with a SolarMutexGuard aSolarGuard; >> > >> > Someone has an opinion on this ? >> >> Because it's protecting a "Paint" which generally would use the VCL >> drawing/widget stuff which is not thread-safe, >> (http://wiki.services.openoffice.org/wiki/Terms/Solar_Mutex I reckon >> you're right and it should be a SolarMutexGuard that's taken there. >> >> caolanm->dtardon: Did you have something vaguely similiar in the desktop >> extension gui-updating thread at one stage, any opinion ? >> > > Yes, but the situation here is different. The Paint method is actually > defined in the same class and has nothing in common with VCL's > Window::Paint. The actual painting is done through Canvas.
So I should change aSolarGuard into aGuard to avoid confusion ? Norbert > > D. > _______________________________________________ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
