Re: [Libreoffice] [Pushed] Macro Cleanup in UNO

2010-10-31 Thread Norbert Thiebaud
On Sun, Oct 31, 2010 at 11:44 PM, Joseph Powers wrote: > In UNO land, each header would declare macros to make defining the class > easier; however, these macros where never used outside of the header they > where declared in. Thus we'd get the following: > > #define UNO3_ANY ::com::sun::star::uno

Re: [Libreoffice] Macro Cleanup in UNO

2010-10-31 Thread Norbert Thiebaud
On Sun, Oct 31, 2010 at 11:44 PM, Joseph Powers wrote: [...] > > The defaults for the classes where defined in the header (good); however, > they used generic names like DEFAULT_VALUE, FREESPACE, … (bad). I went ahead > and renamed them by prefixing CLASSNAME_ to the start of them. Someone > alrea

Re: [Libreoffice] Building on CentOS 5

2010-10-31 Thread Terrell Prude' Jr.
I will YET learn to hit the "Reply-All" button! AAARGH!! --Tp Terrell Prude' Jr. wrote: Caolán McNamara wrote: On Fri, 2010-10-29 at 17:56 -0400, Terrell Prude' Jr. wrote: Unfortunately, yum-builddep still isn't happy yet, even when I throw --enablerepo=*SRPMS. I still get a "No such pa

[Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-10-31 Thread Norbert Thiebaud
the followinf code seems suspect to me: //- XPaintListener void SAL_CALL PresenterClock::windowPaint (const awt::PaintEvent& rEvent) throw (RuntimeException) { (void)rEvent; ThrowIfDisposed(); ::osl::MutexGuard aSolarGu

[Libreoffice] (no subject)

2010-10-31 Thread Niko Rönkkö
>From 09a62885c6c5aea12412d9bcb37a997bce87fa2d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niko=20R=C3=B6nkk=C3=B6?= Date: Mon, 1 Nov 2010 00:36:23 +0200 Subject: [PATCH] Wrong option name in help MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="kaben8Ohv4ahdainoh7Ohche4iequood

[Libreoffice] [PUSHED, partially] Re: [PATCH] cppcheck "Common realloc mistake"

2010-10-31 Thread Caolán McNamara
On Sun, 2010-10-31 at 20:51 +0100, Gert Faller wrote: > Hi, > > a second try. > Making cppcheck happy is not easy... realloc_patch_1 looks good for the reallocs part of things. But I believe cppcheck is basically wrong about the ferr not being closed, its a false positive I think, i.e. closeErro

[Libreoffice] [PUSHED] Re: EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

2010-10-31 Thread Caolán McNamara
On Sun, 2010-10-31 at 21:18 +0100, Joost Eekhoorn wrote: > MPL 1.1 / GPLv3+ / LGPLv3+ Excellent, all good. Thanks for the stylistic improvement in cFA_joost_5.patch while you were adding the RTL_CONSTASCII_USTRINGPARAM's :-) C. ___ LibreOffice mailing

Re: [Libreoffice] MERRY IN THE LORD

2010-10-31 Thread Caolán McNamara
On Tue, 2010-11-02 at 03:40 -0700, DAV J NANCY wrote: > I want you as a God fearing person, to also use this money to fund > churches, orphanages and widows. I took this decision, before I rest > in peace because my time will soon be up. As soon as I receive your > reply I shall give you the contac

[Libreoffice] EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

2010-10-31 Thread Joost Eekhoorn
MPL 1.1 / GPLv3+ / LGPLv3+ Joost diff --git a/sc/source/ui/attrdlg/attrdlg.cxx b/sc/source/ui/attrdlg/attrdlg.cxx index a7eb582..b7716e7 100644 --- a/sc/source/ui/attrdlg/attrdlg.cxx +++ b/sc/source/ui/attrdlg/attrdlg.cxx @@ -72,7 +72,7 @@ ScAttrDlg::ScAttrDlg( SfxViewFrame* pFrameP, #if LAYO

Re: [Libreoffice] [PATCH] cppcheck "Common realloc mistake"

2010-10-31 Thread Gert Faller
Hi, a second try. Making cppcheck happy is not easy... The first file may be ok. The second no : but what to do ? loose memory or risk a fail ? /* very strange case, but have to believe it: reduce the * full qualified name to the unqualified host name */ if ( !bHostsAreE

[Libreoffice] support for mono 2.8

2010-10-31 Thread Andreas Radke
While building Go/LibO for ArchLinux I've run into a few issues today after we had updated our mono packages to the 2.8 release. 1) the patches/mono/*.diff call mkbundle2 at several places. "mkbundle2" (that called /usr/lib/mono/2.0/mkbundle.exe) isn't shipped anymore in the mono 2.8 release /usr

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro bis

2010-10-31 Thread Caolán McNamara
On Sat, 2010-10-30 at 22:08 +0100, Caolán McNamara wrote: > old: OUString sFoo(OUString::createFromAscii(bBool ? "true" : "false)); > > new: OUString sFoo(RTL_CONSTASCII_USTRINGPARAM(bBool ? "true" : > "false)); > > would be expanded as... > > OUString sFoo(bBool ? "true" : "false, ((sal_Int32)(

[Libreoffice] [PUSHED]Re: [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM 3

2010-10-31 Thread Caolán McNamara
On Sun, 2010-10-31 at 13:41 +0100, Gert Faller wrote: > Hi, > > I'am not sure of my previous mail... This looks good. I pushed this patch as well. I see (again this was already there and not added by your patch) a few rather odd rtl::OUString sEmpty(OUString::createFromAscii("")) in there to cre

Re: [Libreoffice] [PATCH] Internal separation of options of configure

2010-10-31 Thread Niko Rönkkö
Correct description would be: Grouped inner "Optional Features (--enable/disable-)" and "Optional Packages (--with/without-)" to ease maintenance. Minor fix: ]>\n] -> >]\n Option --with-servlet-api-jar=JARFILE was named wrong in --help. (It was named as --servlet-api-jar=JARFILE.) No changes t

[Libreoffice] [PUSHED] Re: EasyHack RTL_CONSTASCII_USTRINGPARAM in cui

2010-10-31 Thread Caolán McNamara
On Sun, 2010-10-31 at 15:37 +0100, Joost Eekhoorn wrote: > MPL 1.1 / GPLv3+ / LGPLv3+ All good, committed and pushed, thanks :-) > In ./cui/source/tabpages/numpages.cxx (line 2852): > String sMsg( RTL_CONSTASCII_USTRINGPARAM( "Preview") ); > > Should that not be RTL_CONSTASCII_STRINGPARAM, b

Re: [Libreoffice] [PATCH] (bootstrap) Internal separation of options of configure

2010-10-31 Thread Niko Rönkkö
After KAMIs changes... >From eb4c7303cf9f75f83239507a9a38ba4fe7f3015b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niko=20R=C3=B6nkk=C3=B6?= Date: Sun, 31 Oct 2010 19:04:28 +0200 Subject: [PATCH] Internal separation of options of configure MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="--

[Libreoffice] EasyHack RTL_CONSTASCII_USTRINGPARAM in cui

2010-10-31 Thread Joost Eekhoorn
MPL 1.1 / GPLv3+ / LGPLv3+ In ./cui/source/tabpages/numpages.cxx (line 2852): String sMsg( RTL_CONSTASCII_USTRINGPARAM( "Preview") ); Should that not be RTL_CONSTASCII_STRINGPARAM, because sMsg is a String and not a OUString? Joost diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/t

[Libreoffice] LibreOffice reddit

2010-10-31 Thread Joop Kiefte
I want to propose to the emerging LibreOffice-community a new reddit: http://reddit.com/r/libreoffice Suggestions are welcome :) -- Linux-user #496644 (http://counter.li.org) - first touch of linux in 2004 Demandoj en aŭ pri Esperanto? Questions about Esperanto? Vragen over Esperanto? Perguntas

[Libreoffice] [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM 3

2010-10-31 Thread Gert Faller
Hi, Quote : "I'am not sure of my previous mail." I sent it 3 hours ago but it did not appear (and it's in my 'sent-mail' directory) : maybe some problem with my ISP because of the end of DST this night... Regards. ___ LibreOffice mailing list LibreOff

[Libreoffice] [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM 3

2010-10-31 Thread Gert Faller
Hi, I'am not sure of my previous mail... Regards. createFromAscii_5.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED]Re: [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM in desktop

2010-10-31 Thread Caolán McNamara
On Sun, 2010-10-31 at 11:56 +0100, Joost Eekhoorn wrote: > MPL 1.1 / GPLv3+ / LGPLv3+ Excellent, pushed, thanks. > About coding conventions: > In /desktop/source/app/dispatchwatcher.cxx starts with > "using ::rtl::OUString;" and then there are: > ::rtl::OUString > rtl::OUString > OUString > > Wh

[Libreoffice] [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM in desktop

2010-10-31 Thread Joost Eekhoorn
MPL 1.1 / GPLv3+ / LGPLv3+ About coding conventions: In /desktop/source/app/dispatchwatcher.cxx starts with "using ::rtl::OUString;" and then there are: ::rtl::OUString rtl::OUString OUString What is the advised way? diff --git a/desktop/source/app/dispatchwatcher.cxx b/desktop/source/app/dispatc