the followinf code seems suspect to me:
//----- XPaintListener --------------------------------------------------------
void SAL_CALL PresenterClock::windowPaint (const awt::PaintEvent& rEvent)
throw (RuntimeException)
{
(void)rEvent;
ThrowIfDisposed();
::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex());
Paint(rEvent.UpdateRect);
}
getGlobalMutex() is not the solarmutex. this is a mutex instanciated
by the osl library.
The fact that the guard is named SoalrGuard, lead me to believe that
the original author meant to take a guard on the solarMutex.
I'm thinking I should change this guard with a SolarMutexGuard aSolarGuard;
Someone has an opinion on this ?
Note: similar code exist in PresentedNotesView.cxx and PresenterTimer.cxx
Norbert
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
