Re: [libmicrohttpd] [GSoC Update] Week 1

2017-06-05 Thread Tim Rühsen
Hi Didik, thanks for the summary of week #1 ! On Dienstag, 6. Juni 2017 00:40:56 CEST Didik Setiawan wrote: > On Mon, 05 Jun 2017 23:51:00 +0700 Christian Grothoff wrote: > > Maybe I missed something, but why should the MHD dependency become > > _mandatory_? Why not conditionally-compile and ru

Re: [libmicrohttpd] [GSoC Update] Week 1

2017-06-06 Thread Tim Rühsen
On 06/06/2017 02:32 AM, Didik Setiawan wrote: > On Tue, 06 Jun 2017 02:37:54 +0700 Tim Rühsen wrote: >> I guess Christian meant to skip the appropriate tests if MHD is not >> installed/ >> available. We should definitely get rid of our server code in libwget a

Re: [libmicrohttpd] [GSoC Update] Week 2

2017-06-17 Thread Tim Rühsen
On Samstag, 17. Juni 2017 13:53:06 CEST Didik Setiawan wrote: > On Tue, Jun 13, 2017 at 06:37:27PM +0200, Darshit Shah wrote: > > > - http_server_port still hardcoded. > > > > This is important. The port should be a random number. Usually, passing 0 > > in the port number makes the kernel choose

[libmicrohttpd] [PATCH] Fix 'make check'

2017-06-17 Thread Tim Rühsen
Hi, path to fix a small bug in test_daemon.c. Regards, Tim From 9f7f9f65e8a3870a337ee78932e26c40fa1fc872 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim Rühsen?= Date: Sat, 17 Jun 2017 12:37:49 +0200 Subject: [PATCH] testStartError(): Add missing argument to MHD_stop_daemon() --- src/microhttpd

[libmicrohttpd] Add 'manywarnings' module from Wget2

2017-06-18 Thread Tim Rühsen
ebde04cebf4de8ce10e21b7904 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim Rühsen?= Date: Sun, 18 Jun 2017 12:33:08 +0200 Subject: [PATCH] Add m4/wget_manywarnings This enables (if switched on) basically all warnings for gcc and clang. Exceptions are explicitly controlled in configure.ac. To en

Re: [libmicrohttpd] Add 'manywarnings' module from Wget2

2017-06-19 Thread Tim Rühsen
On Montag, 19. Juni 2017 18:48:47 CEST Evgeny Grin wrote: > On 18.06.2017 13:45, Tim Rühsen wrote: > > maybe you like this... > > > > "Add m4/wget_manywarnings > > > > This enables (if switched on) basically all warnings for gcc and > >

[libmicrohttpd] Is there something like MHD_free() ?

2017-10-09 Thread Tim Rühsen
Hi, a library included free() function is basically needed on systems where the library malloc heap is different from the caller's malloc heap, which happens on Windows when the library is a separate DLL. So, is there (or could we have) something like void MHD_free(void *ptr) { free(ptr

Re: [libmicrohttpd] Is there something like MHD_free() ?

2017-10-09 Thread Tim Rühsen
rely > intended as an optimization to avoid a copy. > > Happy hacking! > > Christian > > On 10/09/2017 04:38 PM, Tim Rühsen wrote: > > Hi, > > > > a library included free() function is basically needed on systems where > > the library malloc heap is d

Re: [libmicrohttpd] Is there something like MHD_free() ?

2017-10-09 Thread Tim Rühsen
On Montag, 9. Oktober 2017 19:30:39 CEST Christian Grothoff wrote: > On 10/09/2017 07:24 PM, Tim Rühsen wrote: > > Hi Christian, > > > > On Montag, 9. Oktober 2017 17:46:32 CEST Christian Grothoff wrote: > >> Hi Tim, > >> > >> We definitively don&#

Re: [libmicrohttpd] Is there something like MHD_free() ?

2017-10-10 Thread Tim Rühsen
On 10/09/2017 10:43 PM, Christian Grothoff wrote: > Ok, added and documented in 181ac3c5..6c4c13ef. -Christian Thanks ! With Best Regards, Tim signature.asc Description: OpenPGP digital signature

[libmicrohttpd] Please add support for RFC7616 (Digest auth with sha-2 instead of md5)

2017-10-28 Thread Tim Rühsen
Hi, curl just added support for RFC7616, and I just opened an issue for Wget2 as well. Since wget2 uses MHD for it's test suite, support for that RFC in MHD would be great. Basically, it's just sha-2 instead of md5 hashing, so should be straight forward. WDYT ? Regards, Tim signature.asc

Re: [libmicrohttpd] Please add support for RFC7616 (Digest auth with sha-2 instead of md5)

2017-10-29 Thread Tim Rühsen
me and could speed up things. > > -- > Best Wishes, > Evgeny Grin > > 28.10.2017, 21:44, "Tim Rühsen" : > > Hi, > > > > curl just added support for RFC7616, and I just opened an issue for Wget2 > > as well. > > > > Since wget2

Re: [libmicrohttpd] To Git or not to Git

2017-11-15 Thread Tim Rühsen
On 11/15/2017 01:40 AM, Gumbel, Matthew K wrote: > It's been a long time since 0.9.55. I need to upgrade my production software > to a more recent MHD build (I'm currently on 0.9.52). > > I wonder if I should just build and use latest Git master in production (I'd > test thoroughly of course). D

[libmicrohttpd] Warnings from libmicrohttpd.h

2018-01-03 Thread Tim Rühsen
Hi, I see these annoying from the user-included file libmicrohttpd.h (latest git master). Could you fix it, please ? /usr/oms/src/wget2/x86_64-w64-mingw32/include/microhttpd.h:215:5: warning: "__clang_major__" is not defined, evaluates to 0 [-Wundef] #if __clang_major__+0 >= 5 || \ ^~~~

[libmicrohttpd] Build breaks

2018-02-15 Thread Tim Rühsen
Hi, current master builds break, here is a (trivial) fix. diff --git a/src/microhttpd/mhd_sockets.h b/src/microhttpd/mhd_sockets.h index c999ea35..b013baad 100644 --- a/src/microhttpd/mhd_sockets.h +++ b/src/microhttpd/mhd_sockets.h @@ -755,6 +755,6 @@ MHD_socket_noninheritable_ (MHD_socket sock

[libmicrohttpd] Clang build fails

2018-02-21 Thread Tim Rühsen
Hi, currently, clang can't build latest master. It because of a missing prototype for MHD_init() in src/lib/init.c. Clang errors at that point while gcc just emits a warning. Anyways, this breaks building the dependency chain for Wget2 fuzzing :-( Do you make a CI build before pushing to maste

Re: [libmicrohttpd] Clang build fails

2018-02-21 Thread Tim Rühsen
On 02/21/2018 10:28 AM, Christian Grothoff wrote: > Hi, > > Build issue should be fixed in Git now. Thanks ! > IIRC, our CI (Buildbot) is not (yet) setup to build with clang, but also > it doesn't send out proper notifications on failures in the first place, > so it is right now of limited use.

Re: [libmicrohttpd] Clang build fails

2018-02-22 Thread Tim Rühsen
On 02/21/2018 09:02 PM, Tim Ruehsen wrote: > Am Mittwoch, den 21.02.2018, 20:38 +0100 schrieb Christian Grothoff: >> On 02/21/2018 12:15 PM, Tim Rühsen wrote: >>>> Generally, I would like >>>> to end up with a setup where the entire CI configuration is also &

[libmicrohttpd] Gitlab CI still fails

2018-02-27 Thread Tim Rühsen
Hi, two tests still fail because of memory leaks. It's reproducible with CC=gcc CFLAGS="-O0 -g -ggdb3 -fno-omit-frame-pointer -fsanitize=address" ./configure make clean make check ... FAIL: test_upgrade FAIL: test_upgrade_tls ... cat src/microhttpd/test_upgrade.log With Best Regards, Tim

[libmicrohttpd] Another CI failure ...

2018-02-27 Thread Tim Rühsen
Two more usages of strcpy() annoy the clang static analyzer: $ make clean $ scan-build-3.9 -v -enable-checker security,nullability --status-bugs make -j$(nproc) With Best Regards, Tim signature.asc Description: OpenPGP digital signature

[libmicrohttpd] Three runtime errors in tests with UBSAN

2018-02-27 Thread Tim Rühsen
$ CC=gcc CFLAGS="-O0 -g -ggdb3 -fno-omit-frame-pointer -fsanitize=undefined" ./configure $ make clean $ make check $ grep runtime src/*/*.log src/microhttpd/test_upgrade.log:test_upgrade.c:1075:32: runtime error: member access within misaligned address 0x560144586014 for type 'const union MHD_Dae

[libmicrohttpd] test_upgrade aborts (and thus FAILS)

2018-02-28 Thread Tim Rühsen
Reported by Gitlab CI and reproducible here (amd64): $ ./bootstrap && ./configure --enable-asserts && make clean $ TESTS_ENVIRONMENT="valgrind --trace-children=yes" make check src/microhttpd/test_upgrade.c FAILs, log file contains: ==2363== Process terminating with default action of signal 6 (

[libmicrohttpd] make distcheck fails

2018-02-28 Thread Tim Rühsen
$ ./bootstrap && ./configure --enable-asserts && make clean $ make distcheck In file included from ../../../../src/lib/action_from_response.c:25:0: ../../../../src/lib/internal.h:32:10: fatal error: microhttpd2.h: No such file or directory #include "microhttpd2.h" ^~~ Wi

Re: [libmicrohttpd] make distcheck fails

2018-02-28 Thread Tim Rühsen
There now is a fix for 'make distcheck' and the clang's scan-build in branch gitlab/ci-test (if you like to merge that). With Best Regards, Tim On 02/28/2018 09:50 AM, Tim Rühsen wrote: > $ ./bootstrap && ./configure --enable-asserts && make clean >

[libmicrohttpd] Request: stricter checks for client input

2018-03-01 Thread Tim Rühsen
Hi, could MHD_OPTION_STRICT_FOR_CLIENT be more strict regarding spaces in the 'resource' of HTTP requests, please ? Currently MHD accepts spaces (instead %20 resp. +) and converts them to + for the return value of MHD_get_connection_values(). This makes a test for wget2 succeed though wget2 doe

Re: [libmicrohttpd] How to proper fix error: "ISO C90 does not support ‘long long’"?

2018-03-24 Thread Tim Rühsen
Hi Silvio, On 24.03.2018 04:30, silvioprog wrote: > I'm using the following compilers: > > 1) clang version 5.0.1-svn325091-1~exp1 (branches/release_50) > > 2) arm-linux-androideabi-gcc (Linaro GCC 4.7-2014.04-1~dev) 4.7.4 > > 3) gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 > > clang and ar

Re: [libmicrohttpd] How to proper fix error: "ISO C90 does not support ‘long long’"?

2018-03-24 Thread Tim Rühsen
On 24.03.2018 17:24, silvioprog wrote: > Oops... > > On Sat, Mar 24, 2018 at 1:11 PM, silvioprog > wrote: > > ... it seems GCC doesn't provide a specific option for this checking. > > > I meant "it seems -Wcomment/-Wcomments works only in 'C<=90'". > And that make

Re: [libmicrohttpd] HTTP2 support for MHD

2018-03-30 Thread Tim Rühsen
Hey Maru, that's awesome, great news ! I am looking forward to extend GNU Wget2's test suite to support http/2 :-) We are using MHD for the test suite's server side. Thank you so much for working on this ! Regard, Tim On 30.03.2018 14:48, Maru Berezin wrote: > Hello everyone, > > My name is

[libmicrohttpd] [PATCH] Fix build issue when parent dir is an automake project dir

2018-10-18 Thread Tim Rühsen
Building fails if the parent directory is an automake project dir: $ ./bootstrap libtoolize: putting auxiliary files in '..'. libtoolize: copying file '../ltmain.sh' libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'. libtoolize: copying file 'm4/libtool.m4' libto

[libmicrohttpd] Build issue on MINGW

2018-10-18 Thread Tim Rühsen
Hi, the build on MinGW fails in lib/src/ due to @echo Creating $@ and libmicrohttpd2.exp by $(DLLTOOL)... && \ dll_name=`$(EGREP) -o dlname=\'.+\' libmicrohttpd2.la` && \ libmicrohttpd2.la contains dlname='' and thus the egrep (or grep -E) fails. I am on Debian unstable and us

Re: [libmicrohttpd] Build issue on MINGW

2018-10-23 Thread Tim Rühsen
can propose: I'm adding an option (--enable-experimental) > which disables building src/lib/ by default, so that users that don't > care about the experimental code don't get disrupted like this. > > Happy hacking! > > Christian > > On 10/18/2018 04:45 PM,

Re: [libmicrohttpd] Build issue on MINGW

2018-10-24 Thread Tim Rühsen
gt; > Happy hacking! > > Christian > > On 10/23/2018 10:28 AM, Tim Rühsen wrote: >> Hi Christian, >> >> sorry for answering so late :-( >> >> Such a switch would indeed be useful if one wants to test/use the latest >> master branch. >>

Re: [libmicrohttpd] next release

2018-11-07 Thread Tim Rühsen
Congrats ! Here is the first show stopper: you updated the gettext requirements to a very recent version (AM_GNU_GETTEXT_VERSION([0.19.8]) in configure.ac). This prevents building on slightly older system with gettext 0.19.7 or lower. Here is a log from OSS-Fuzz where we build wget2 + dependencie

Re: [libmicrohttpd] next release

2018-11-07 Thread Tim Rühsen
> Does that help? > > Happy hacking! > > Christian > > On 11/7/18 1:14 PM, Tim Rühsen wrote: >> Congrats ! >> >> Here is the first show stopper: you updated the gettext requirements to >> a very recent version (AM_GNU_GETTEXT_VERSION([0.19.8]) in

Re: [libmicrohttpd] 0.9.62 doesn't build on Visual Studio

2018-12-10 Thread Tim Rühsen
Hi, instead of keeping all projects at C89, you can also use Visual Studio with LLVM/Clang or GCC: https://blogs.msdn.microsoft.com/vcblog/2017/03/07/use-any-c-compiler-with-visual-studio/ I personally don't have any experiences with that (just don't have a MS Windows license) but know people bu

Re: [libmicrohttpd] 0.9.62 doesn't build on Visual Studio

2018-12-10 Thread Tim Rühsen
; > If so, we could > > #if __STDC_NO_VLA__ > #define VLA_LEN_DIGEST(n) (32*2+1) > #else > #define VLA_LEN_DIGEST(n) (n) > #endif > > and then use > > char buf[VLA_LEN_DIGEST(n)] > > instead of > > char buf[n] > > in the digestauth code. > > WDYT?

Re: [libmicrohttpd] Post-Handshake Authentication Support

2019-04-14 Thread Tim Rühsen
Hello Christian, if you are at it, please consider adding GNUTLS_ENABLE_EARLY_DATA as well. That allows the server to accept 0-RTT packets for TLS 1.3 - something we would like to test as well with Wget2. GNUTLS_ENABLE_EARLY_DATA: since 3.6.5 GNUTLS_POST_HANDSHAKE_AUTH: since 3.6.3 Regards, Tim

[libmicrohttpd] Two minor fixes

2019-04-14 Thread Tim Rühsen
Hi, here are two minor fixes to succeed the Gitlab CI. Regards, Tim From ce96294b334ec3f34a68a4ae6f2caa2bd761441e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Sun, 14 Apr 2019 18:13:06 +0200 Subject: [PATCH 1/2] Fix memleak in example --- src/examples/http_chunked_compres

[libmicrohttpd] Fix realloc memleak

2019-04-14 Thread Tim Rühsen
Another small issue fixed Regards, Tim From a663f24dd0a6636d34c2bd86f81e6dc55cc1ce48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Sun, 14 Apr 2019 19:48:54 +0200 Subject: [PATCH] Fix realloc memleak in compress_buf() --- src/examples/http_chunked_compression.c | 12 +++

[libmicrohttpd] SEGFAULT in digest_calc_ha1_from_user()

2019-04-14 Thread Tim Rühsen
Hi, in digestauth.c, L296 you'll find an unconditional strlen(password). The function is called via digest_auth_check_all() from MHD_digest_auth_check_digest2() with a NULL 'password'. I am not sure what your favorite place is for a fix, so I'll just report and leave it to you. Regards, Tim

Re: [libmicrohttpd] Post-Handshake Authentication Support

2019-04-15 Thread Tim Rühsen
now if anything is amiss. > > Happy hacking! > > Christian > > On 4/14/19 5:21 PM, Tim Rühsen wrote: >> Hello Christian, >> >> if you are at it, please consider adding GNUTLS_ENABLE_EARLY_DATA as >> well. That allows the server to accept 0-RTT packets f

Re: [libmicrohttpd] clang formatting discussion via [gnunet-developers]

2019-04-18 Thread Tim Rühsen
Without looking into the details... basically a good idea ! We also opened an MR (WIP) for Wget2, but using GNU indent for it. The rules should be clear and easy, without nitpicks. That would prevent a clang-format lock-in situation. One of the great things here is that you can locally use your o

[libmicrohttpd] Small fix in examples/http_chunked_compression.c

2019-04-28 Thread Tim Rühsen
Random find, the fread() error check needed a cast to work. Regards, Tim From 5b3579774c3870003b9de36f6b9e87ff0bd6d990 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Sun, 28 Apr 2019 19:54:36 +0200 Subject: [PATCH] Fix signed/unsigned comparison in example --- src/examples/

[libmicrohttpd] Recommended format specifiers for size_t / ssize_t ?

2019-05-20 Thread Tim Rühsen
Hi, since there are portability issues with %zu / %zd, what is the recommended way to print / log size_t / ssize_t type variables ? Regards, Tim signature.asc Description: OpenPGP digital signature

[libmicrohttpd] Two tests failing in master branch

2019-05-24 Thread Tim Rühsen
Hi, master branch (at 9da5831ce0fa14605ad15315d3ac6af74d33767c) two tests are failing with make check LOG_COMPILER="valgrind --trace-children=yes --leak-check=full --show-leak-kinds=all" From test_quiesce.log: ==16263== LEAK SUMMARY: ==16263==definitely lost: 12 bytes in 1 blocks ==16263=

Re: [libmicrohttpd] Two tests failing in master branch

2019-05-24 Thread Tim Rühsen
On 24.05.19 18:14, Darshit Shah wrote: > * Tim Rühsen [190524 18:02]: >> Hi, >> >> master branch (at 9da5831ce0fa14605ad15315d3ac6af74d33767c) two tests >> are failing with >> >> make check LOG_COMPILER="valgrind --trace-children=yes --leak-check=

Re: [libmicrohttpd] Two tests failing in master branch

2019-05-24 Thread Tim Rühsen
er protocols). > > Happy hacking! > > Christian > > On 5/24/19 5:00 PM, Tim Rühsen wrote: >> Hi, >> >> master branch (at 9da5831ce0fa14605ad15315d3ac6af74d33767c) two tests >> are failing with >> >> make check LOG_COMPILER="valgrind --t

Re: [libmicrohttpd] Two tests failing in master branch

2019-05-28 Thread Tim Rühsen
s the curl kitchen sink (i.e. skips support for imap, > ssh, and a host of other protocols). > > Happy hacking! > > Christian > > On 5/24/19 5:00 PM, Tim Rühsen wrote: >> Hi, >> >> master branch (at 9da5831ce0fa14605ad15315d3ac6af74d33767c) two tests >> are

[libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in parallel

2019-05-28 Thread Tim Rühsen
Hi, test_upgrade_tls always fails here (make check on multi-core). Attached patch fixes it. Regards, Tim From 775d1a3647400a4747ab0e0e37cc4140b11e1451 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Tue, 28 May 2019 10:40:32 +0200 Subject: [PATCH] Fix test_upgrade/test_upgrade

[libmicrohttpd] [PATCH] Fix more 'address already in use' issues

2019-05-28 Thread Tim Rühsen
Three more tests fail in parallel 'make check'. The attached patch fixes all three. Regards, Tim From 70a0266e1255acfe23bc344a87d5e5451c7ed4ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Tue, 28 May 2019 10:49:15 +0200 Subject: [PATCH] Fix more 'address already in use' issu

Re: [libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in parallel

2019-05-28 Thread Tim Rühsen
On 28.05.19 21:07, Evgeny Grin wrote: > On which system did you test it? > Looks like MHD_FEATURE_AUTODETECT_BIND_PORT is not available on you OS, > which is pretty strange as it should works on all modern platforms. > Debian unstable, daily updated. With those patches, all works for me, reprodu

Re: [libmicrohttpd] [PATCH] Fix more 'address already in use' issues

2019-05-29 Thread Tim Rühsen
On 5/28/19 9:03 PM, Evgeny Grin wrote: > Hi Tim, > > Thanks for patches. > However whole testsuite is not designed to be run in parallel. > Testsuite individual tests use all available CPU cores so when used in > parallel, tests could produce unpredictable wrong results. Despite that, I wish you

Re: [libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in parallel

2019-05-29 Thread Tim Rühsen
On 5/28/19 9:07 PM, Evgeny Grin wrote: > On which system did you test it? > Looks like MHD_FEATURE_AUTODETECT_BIND_PORT is not available on you OS, > which is pretty strange as it should works on all modern platforms. > MHD_config.h: /* Define if you have usable `getsockname' function. */ /* #und

Re: [libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in parallel

2019-05-29 Thread Tim Rühsen
On 29.05.19 15:36, Evgeny Grin wrote: > Could you provide config.log, please? See my other email for relevant details from config.log. Let me know if that is not enough and I try to reproduce (on a different machine the next days). > 28 мая 2019 г. 23:39:18 GMT+03:00, "Tim Rühsen&quo

Re: [libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in parallel

2019-05-30 Thread Tim Rühsen
Hi Evgeny, On 30.05.19 13:50, Evgeny Grin wrote: > Hi Tim, > > Thanks for details. > I'll fix this case. Thank you ! > > However, it is not advisable to use any -Werror= flags for configure, as > it may break some tests. > For example, if you will use -Werror=extra-semi clang flag then you wil

Re: [libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in parallel

2019-05-31 Thread Tim Rühsen
On 5/30/19 10:36 PM, Evgeny Grin wrote: > > 30.05.2019 16:45, Tim Rühsen wrote: >>> Thanks for details. >>> I'll fix this case. >> Thank you ! > Check updated git master, please. >> >>> However, it is not advisable to use any -Werror= flags f

[libmicrohttpd] Gitlab CI

2019-05-31 Thread Tim Rühsen
Hey, just wanted to let you know that I made some changes for the Gitlab CI. The docker images are now updated once a week. That is - Debian stretch, to perform - make, make check, make distcheck with gcc - make, make check, make distcheck with clang + ASAN/UBSAN - clang's scan-build - Debia

Re: [libmicrohttpd] GNU libmicrohttpd 0.9.65 released

2019-07-09 Thread Tim Rühsen
Thanks for the new release ! Could you push the git tags to the repo(s) ? Regards, Tim On 7/5/19 10:26 PM, Evgeny Grin wrote: > Dear all, > > > I'm glad to announce the release of GNU libmicrohttpd 0.9.65. > > GNU libmicrohttpd is a small C library that is supposed to make it easy > to run an

[libmicrohttpd] Adding code for OCSP stapling

2019-07-16 Thread Tim Rühsen
Hi, for the GNU Wget2 GSOC project we needed the ability to test OCSP stapling. I created an MR at Gitlab: https://gitlab.com/libmicrohttpd/libmicrohttpd/merge_requests/1. Writing a test for this is a bit more work. It includes a valid CA cert+key, a derived server cert. Additionally you need an

Re: [libmicrohttpd] Adding code for OCSP stapling

2019-07-16 Thread Tim Rühsen
en you merge this into master, please also bump the MHD_VERSION in > microhttpd.h. > > happy hacking! > > Christian > > > On 7/16/19 3:23 PM, Tim Rühsen wrote: >> Hi, >> >> for the GNU Wget2 GSOC project we needed the ability to test OCSP >> stap

Re: [libmicrohttpd] Adding code for OCSP stapling

2019-07-16 Thread Tim Rühsen
On 16.07.19 20:08, Tim Rühsen wrote: > Hi Christian, > > thanks for looking into it. > > The requested changes have been made - I am not sure if they exactly > fit, so please have another look. > > In libmicrohttpd.texi there is a section '

[libmicrohttpd] CI errors

2019-09-26 Thread Tim Rühsen
Hi, I see an error in the Gitlab CI for quite some time: In file included from mhd_assert.h:34:0, from internal.h:33, from connection.c:28: connection.c:3090:39: error: 'struct MHD_Connection' has no member named 'repsonse'; did you mean 'response'? mhd_

Re: [libmicrohttpd] gnutls install

2019-10-07 Thread Tim Rühsen
Hi Erik, On 07.10.19 20:47, Erik Smith wrote: > More recent versions of MHD are requiring newer versions of gnutls then > RH can provide, so I'm trying to build gnutls from source with a prefix > into a third party lib bundle for my project.  I get all the way up to > the part where gnutls fails o

[libmicrohttpd] CI Pipeline fails (doc / etex fails)

2019-10-13 Thread Tim Rühsen
Please have a look at https://gitlab.com/libmicrohttpd/libmicrohttpd/-/jobs/319336621 Regards, Tim signature.asc Description: OpenPGP digital signature

[libmicrohttpd] CI Pipeline fails (address sanitizer issue)

2019-10-13 Thread Tim Rühsen
Is this wanted / expected behavior in 'test_upgrade_large' ? If yes, we can set ASAN_OPTIONS=allocator_may_return_null=1 when running the tests. ### Warning: Zero size, specified for thread pool size, is ignored. Thread pool is not used. Using debug build of libmicrohttpd. Warning: Zero size,

Re: [libmicrohttpd] CI Pipeline fails (doc / etex fails)

2019-10-18 Thread Tim Rühsen
Hi Christian, I can even reproduce on Debian unstable: ./bootstrap ./configure make cd doc make dvi Regards, Tim On 10/17/19 3:11 PM, Christian Grothoff wrote: > I downloaded an Ubuntu 18.04.3 LTS VM image, installed the required > packages (including texlive 2017 and texinfo 6.5) and it _still

Re: [libmicrohttpd] CI Pipeline fails (doc / etex fails)

2019-10-18 Thread Tim Rühsen
@enumerate a 173:@end enumerate 314:@end enumerate As you can see L67-L314 is an enumerate, where L286 (@heading) is enclosed. So it looks like a problem in gpl-2.0.texi (or in the texi2dvi command chain). Any ideas ? Regards, Tim On 10/18/19 9:54 AM, Tim Rühsen wrote: > Hi Christian, &g

Re: [libmicrohttpd] CI Pipeline fails (doc / etex fails)

2019-10-18 Thread Tim Rühsen
ou can see L67-L314 is an enumerate, where L286 (@heading) is enclosed. >> >> So it looks like a problem in gpl-2.0.texi (or in the texi2dvi command >> chain). Any ideas ? >> >> Regards, Tim >> >> >> On 10/18/19 9:54 AM, Tim Rühsen wrote: >>

Re: [libmicrohttpd] CI Pipeline fails (doc / etex fails)

2019-10-18 Thread Tim Rühsen
There was a stale 'doc/texinfo.tex' here (no idea where it's from). After removing it, everything works out smooth. Sorry for the wind. Regards, Tim On 10/18/19 10:02 AM, Tim Rühsen wrote: > @Paul > > The error says > "/home/oms/src/libmicrohttpd/doc/gpl-2.0.tex

Re: [libmicrohttpd] CI Pipeline fails (doc / etex fails)

2019-10-18 Thread Tim Rühsen
Hi, please apply this patch. It fixes the Gitlab CI pipeline. On Debian/Stretch 'make distcheck' after 'make' doesn't work. So, what works is the sequence ./bootstrap ./configure make distcheck Regards, Tim On 10/13/19 2:59 PM, Tim Rühsen wrote: > Plea

[libmicrohttpd] 0.9.67 regression

2019-10-23 Thread Tim Rühsen
Hi, with 0.9.67 some tests for Wget2 fail which were fine with 0.9.66. This is still reproducible with latest master. As it seems, a response with an empty body doesn't send a response any more. That means response = MHD_create_response_from_buffer(0, (void *) "", MHD_RESPMEM_PERSISTENT); do

Re: [libmicrohttpd] 0.9.67 regression

2019-10-24 Thread Tim Rühsen
; and wget as clients. > > Maybe your issue is about a specific threading mode or something else > you are doing? Please modify the minimal_example_empty.c to emulate the > situation that is causing the issue. > > Thanks! > > Christian > > On 10/23/19 3:39 PM, Tim Rühs

Re: [libmicrohttpd] Cannot set Content-Length in header

2019-10-25 Thread Tim Rühsen
Hi Christian, for Wget2 we have to test and prepare for all kinds of malicious and misconfigured / misbehaving servers. So what you call a new feature is from our point of view a regression, since it breaks tests. Of course I understand your intention. But maybe we can have both by adding a new o

Re: [libmicrohttpd] Cannot set Content-Length in header

2019-10-25 Thread Tim Rühsen
le. > > I'd prefer having such a more "generic" option over a specific one to > just disable header checks. Alternatively, we could define a bit-field > option SANITY_CHECK to just disable certain sanity checks. WDYT? > > Happy hacking! > > -Christian &g

Re: [libmicrohttpd] 0.9.67 regression

2019-10-26 Thread Tim Rühsen
ld really appreciate being able to reproduce this one. You > could also point me to the wget code, I'd dig there myself, but it would > likely take a bit longer in that case ;-). > > Happy hacking! > > Christian > > On 10/24/19 4:07 PM, Tim Rühsen wrote: >> Hi

Re: [libmicrohttpd] 0.9.67 regression

2019-10-26 Thread Tim Rühsen
this > time? > > Happy hacking! > > Christian > > On 10/26/19 6:07 PM, Tim Rühsen wrote: >> Hi Christian, >> >> I am just staring at minimal_example_empty.c and wonder what should >> happen when I call the executable !? Anyways, I can't easily

Re: [libmicrohttpd] Cannot set Content-Length in header

2019-10-29 Thread Tim Rühsen
sponse_options (response, > MHD_RF_INSANITY_HEADER_CONTENT_LENGTH, > MHD_RO_END); > > *before* calling MHD_add_response_header() to get your desired insanity ;-). > > Test for MHD_VERSION 0x00096702. > > Happy hacking! >

[libmicrohttpd] Gitlab CI update

2020-01-27 Thread Tim Rühsen
Hi, I fixed an issue with the Gitlab CI. Please apply the attached patch. There is now one issue found by clang static analyzer, please have a look: https://libmicrohttpd.gitlab.io/-/libmicrohttpd/-/jobs/416465579/artifacts/scan-build/2020-01-27-184011-7830-1/index.html Regards, Tim From 783c1b

[libmicrohttpd] Clang static analyzer reports...

2020-02-02 Thread Tim Rühsen
Hi, with clang 8.0.1 static analyzer you'll get "scan-build: 8 bugs found." on latest master (b8a0f69866a82ae186cfaba955bba5e3f8d9df3e). CC=clang ./configure scan-build --use-cc=clang make -j$(nproc) Regards, Tim signature.asc Description: OpenPGP digital signature

Re: [libmicrohttpd] Clang static analyzer reports...

2020-02-03 Thread Tim Rühsen
ould simply disable/remove the runner. Regards, Tim > > Happy hacking! > > Christian > > On Mon, 2020-02-03 at 15:33 +0100, Tim Rühsen wrote: >> Hi Christian, >> >> there is no online version. I regenerated the report and attached it. >> Unpack and

Re: [libmicrohttpd] Clang static analyzer reports...

2020-02-20 Thread Tim Rühsen
On 05.02.20 19:29, Christian Grothoff wrote: > On Mon, 2020-02-03 at 16:09 +0100, Tim Rühsen wrote: >> Hi Christian, >> On 2/3/20 3:44 PM, Christian Grothoff wrote: >>> Hi Tim, >>> >>> Thanks for forwarding the report. I've looked through them. The &g

[libmicrohttpd] Fixing Gitlab CI

2024-06-14 Thread Tim Rühsen via libmicrohttpd
Hey, I just pushed a branch `fix-gitlab-ci` that fixes the Gitlab CI for libmicrohttpd, see https://gitlab.com/libmicrohttpd/libmicrohttpd/-/pipelines/1332510732 Please feel free to merge into master / gnunet.org. Accidentally, I also pushed the same branch to https://gnunet.org/git/libmicr