Re: [Libguestfs] [PATCH v2v] convert: linux: Require host cpu for all RHEL-alike >= 9

2023-02-06 Thread Daniel P . Berrangé
On Mon, Feb 06, 2023 at 12:19:40PM +, Richard W.M. Jones wrote: > RHEL >= 9 and compatible distros like Rocky >= 9 will not boot using > the default qemu CPU. You will see an error at boot: > > Fatal glibc error: CPU does not support x86-64-v2 > > Instead you need to use -cpu host. > > In

Re: [Libguestfs] [PATCH v2v] convert: linux: Require host cpu for all RHEL-alike >= 9

2023-02-07 Thread Daniel P . Berrangé
On Mon, Feb 06, 2023 at 12:49:41PM +, Richard W.M. Jones wrote: > On Mon, Feb 06, 2023 at 12:37:30PM +0000, Daniel P. Berrangé wrote: > > On Mon, Feb 06, 2023 at 12:19:40PM +, Richard W.M. Jones wrote: > > > RHEL >= 9 and compatible distros like Rocky >= 9 will

Re: [Libguestfs] [PATCH libnbd] generator: Pass LISTEN_FDNAMES=nbd with systemd socket activation

2023-02-07 Thread Daniel P . Berrangé
On Tue, Feb 07, 2023 at 08:56:11AM +, Richard W.M. Jones wrote: > > We worried about getenv's safety (lack of) for quite a while when we > were writing libguestfs, which uses a lot more environment variables > in many more places. But we decided there was simply nothing we could > do about it

Re: [Libguestfs] [PATCH v2v] convert: linux: Require host cpu for all RHEL-alike >= 9

2023-02-07 Thread Daniel P . Berrangé
On Tue, Feb 07, 2023 at 10:20:14AM +, Richard W.M. Jones wrote: > On Tue, Feb 07, 2023 at 08:56:06AM +0000, Daniel P. Berrangé wrote: > > On Mon, Feb 06, 2023 at 12:49:41PM +, Richard W.M. Jones wrote: > > > (2) If the guest is RHEL family >= 9, use -cpu ho

Re: [Libguestfs] [PATCH] lib: Choose q35 machine type for x86-64

2023-02-09 Thread Daniel P . Berrangé
On Thu, Feb 09, 2023 at 01:45:33PM +, Richard W.M. Jones wrote: > This machine type is more modern than the older 'pc' type and as most > qemu development is now focused there we expect it will perform and > behave better. In almost all respects this change should make no > difference. The ke

Re: [Libguestfs] Issue with downloading files whose path contains multi-byte utf-8 characters

2023-02-13 Thread Daniel P . Berrangé
On Mon, Feb 13, 2023 at 06:07:58PM +, Richard W.M. Jones wrote: > On Sun, Feb 12, 2023 at 03:31:08PM +0200, Yonatan Shtarkman wrote: > > Hey, > > When downloading a file whose path contains multi-byte utf-8, libguestfs > > sometimes crashes. > > This reproduces when using python, and not when u

Re: [Libguestfs] [libnbd PATCH v3 09/29] lib/utils: introduce async-signal-safe execvpe()

2023-02-21 Thread Daniel P . Berrangé
On Wed, Feb 15, 2023 at 03:11:38PM +0100, Laszlo Ersek wrote: > execvp() [01] is powerful: > > - it performs PATH search [02] if necessary, > > - it falls back to executing the file with the shell as a shell script in > case the underlying execv() or execve() fails with ENOEXEC. > > However, e

Re: [Libguestfs] [libnbd PATCH v3 09/29] lib/utils: introduce async-signal-safe execvpe()

2023-02-21 Thread Daniel P . Berrangé
On Tue, Feb 21, 2023 at 05:03:23PM +0100, Laszlo Ersek wrote: > On 2/21/23 13:08, Daniel P. Berrangé wrote: > > On Wed, Feb 15, 2023 at 03:11:38PM +0100, Laszlo Ersek wrote: > >> execvp() [01] is powerful: > >> > >> - it performs PATH search [02] if nec

Re: [Libguestfs] [libnbd PATCH v3 09/29] lib/utils: introduce async-signal-safe execvpe()

2023-02-21 Thread Daniel P . Berrangé
On Tue, Feb 21, 2023 at 06:53:39PM +0100, Laszlo Ersek wrote: > > More in general, this lesson tells me that POSIX is effectively > irrelevant -- which is quite sad in itself; the bigger problem however > is that *nothing replaces it*. If the one formal standard we have for > portability does not

Re: [Libguestfs] [libnbd PATCH v3 09/29] lib/utils: introduce async-signal-safe execvpe()

2023-02-22 Thread Daniel P . Berrangé
On Tue, Feb 21, 2023 at 11:59:30PM +0100, Laszlo Ersek wrote: > On 2/21/23 19:04, Daniel P. Berrangé wrote: > > > AFAIK, libnbd/nbdkit haven't made a statement about what platforms > > they aim to target. In my response I'm more or less assuming though > > that

Re: [Libguestfs] [V2V PATCH 0/5] Bring support for virtio-scsi back to Windows

2023-02-23 Thread Daniel P . Berrangé
On Thu, Feb 23, 2023 at 11:43:38AM +0100, Laszlo Ersek wrote: > On 2/22/23 19:20, Andrey Drobyshev wrote: > > Since commits b28cd1dc ("Remove requested_guestcaps / rcaps"), f0afc439 > > ("Remove guestcaps_block_type Virtio_SCSI") support for installing > > virtio-scsi driver is missing in virt-v2v.

Re: [Libguestfs] [PATCH libnbd] lib/errors.c: Fix assert fail in exit path in multi-threaded code

2023-03-08 Thread Daniel P . Berrangé
even once implemented. The use of pthread thread-data destructors is inherantly dangerous when combined with dlclose, to the extent that the best course of action is to simply forbid this scenario. Libvirt hit this problem with pthread data destructors and dlclose() many years ago and we me

Re: [Libguestfs] [PATCH libnbd v3] lib/errors.c: Fix assert fail in exit path in multi-threaded code

2023-03-09 Thread Daniel P . Berrangé
On Thu, Mar 09, 2023 at 08:44:51AM +, Richard W.M. Jones wrote: > When a highly multi-threaded program such as nbdcopy encounters an > error, there is a race condition in the library which can cause an > assertion failure and thus a core dump: > > (1) An error occurs on one of the threads. nb

Re: [Libguestfs] [PATCH libnbd v4] lib/errors.c: Fix assert fail in exit path in multi-threaded code

2023-03-09 Thread Daniel P . Berrangé
; > https://gitlab.com/libvirt/libvirt/-/commit/8e44e5593eb9b89fbc0b54fde15f130707a0d81e > > (a) Use '-z nodelete' to prevent the library from being unloaded on > dlclose(). > > (b) Do not call pthread_key_destroy (thus leaking the key). > > (c) When threads exit

Re: [Libguestfs] [libnbd PATCH v4 0/2] lib/utils: introduce async-signal-safe execvpe()

2023-03-22 Thread Daniel P . Berrangé
On Tue, Mar 21, 2023 at 09:05:12AM -0500, Eric Blake wrote: > > $ podman build -f ci/containers/alpine-edge.Dockerfile -t libnbd-alpine-edge You usually shouldn't need this step when reproducing a problem on CI. Instead just use the container that gitlab has published under the project's registry

Re: [Libguestfs] [libnbd PATCH v4 0/2] lib/utils: introduce async-signal-safe execvpe()

2023-03-22 Thread Daniel P . Berrangé
On Tue, Mar 21, 2023 at 03:56:22PM +0100, Laszlo Ersek wrote: > On 3/21/23 15:05, Eric Blake wrote: > > On Tue, Mar 21, 2023 at 07:04:59AM +0100, Laszlo Ersek wrote: > >> On 3/20/23 20:41, Eric Blake wrote: > >>> On Sun, Mar 19, 2023 at 10:41:37AM +0100, Laszlo Ersek wrote: > This is version 4

Re: [Libguestfs] [libnbd PATCH v4 0/2] lib/utils: introduce async-signal-safe execvpe()

2023-03-22 Thread Daniel P . Berrangé
On Wed, Mar 22, 2023 at 12:13:49PM +0100, Laszlo Ersek wrote: > On 3/22/23 11:42, Laszlo Ersek wrote: > > > Now the "podman build -f ci/containers/alpine-edge.Dockerfile -t > > libnbd-alpine-edge" command is failing with a different error message -- > > the download completes, but the internal rel

Re: [Libguestfs] Proposal to delete the mirrors github.com/libguestfs/libnbd & /nbdkit

2023-06-08 Thread Daniel P . Berrangé
On Wed, Jun 07, 2023 at 07:18:46PM +0100, Richard W.M. Jones wrote: > I don't want to actually link to them to avoid giving them link-karma, > but the old repositories / now mirrors at: > > github.com/libguestfs/libnbd > github.com/libguestfs/nbdkit > > stopped mirroring the true repositories: >

Re: [Libguestfs] [libnbd PATCH 5/7] golang: Use 'gofmt' style recommendations on manual files

2023-07-27 Thread Daniel P . Berrangé
On Wed, Jul 26, 2023 at 12:50:03PM -0500, Eric Blake wrote: > I ran: > gofmt -s -w $(git ls-files -- '**/*.go') > > then touched up a few comments in test 590 where it mis-interpreted > our intentions of having a single sentence that occupies more than 80 > columns. Touching up manually isn't a

Re: [Libguestfs] [libnbd PATCH 5/7] golang: Use 'gofmt' style recommendations on manual files

2023-07-27 Thread Daniel P . Berrangé
On Thu, Jul 27, 2023 at 09:50:01AM -0500, Eric Blake wrote: > On Thu, Jul 27, 2023 at 01:52:00PM +0200, Laszlo Ersek wrote: > > On 7/26/23 19:50, Eric Blake wrote: > > > I ran: > > > gofmt -s -w $(git ls-files -- '**/*.go') > > > > > > then touched up a few comments in test 590 where it mis-inte

Re: [Libguestfs] [libnbd PATCH 5/7] golang: Use 'gofmt' style recommendations on manual files

2023-07-28 Thread Daniel P . Berrangé
On Thu, Jul 27, 2023 at 11:07:07AM -0500, Eric Blake wrote: > On Thu, Jul 27, 2023 at 04:00:25PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 26, 2023 at 12:50:03PM -0500, Eric Blake wrote: > > > I ran: > > > gofmt -s -w $(git ls-files -- '**/*.go'

Re: [Libguestfs] regression: file does not understand the -S option

2023-09-21 Thread Daniel P . Berrangé
On Thu, Sep 21, 2023 at 12:25:21PM +0100, Richard W.M. Jones wrote: > On Wed, Sep 20, 2023 at 11:42:55PM +0200, Olaf Hering wrote: > > Recently a commit was added to call 'file -zSb' instead of 'file -zb'. > > > > This causes a regression on Leap 15 (but not on Tumbleweed), because > > file 5.32 d

Re: [Libguestfs] Fwd: virt-v2v creating image that does not install guest agent on first boot

2023-09-25 Thread Daniel P . Berrangé
On Mon, Sep 25, 2023 at 01:14:40PM +0100, Richard W.M. Jones wrote: > On Mon, Sep 25, 2023 at 01:09:15PM +0200, Lee Garrett wrote: > > On 23.09.23 19:37, Laszlo Ersek wrote: > > >On 9/22/23 16:47, Lee Garrett wrote: > > >>On 22.09.23 14:54, Richard W.M. Jones wrote: > > >>>On Fri, Sep 22, 2023 at 1

Re: [Libguestfs] [PATCH v2v 0/5] convert: Find out if Windows guest is expecting BIOS localtime or UTC

2023-09-25 Thread Daniel P . Berrangé
On Mon, Sep 25, 2023 at 04:26:59PM +0200, Alice Frosi wrote: > Hi Rich, > > On Mon, Sep 25, 2023 at 4:10 PM Richard W.M. Jones > wrote: > > > [Alice: See patch 2] > > > > I'm not 100% sure about the source of this work. However, we had in > KubeVirt people interested in using localtime with Win

Re: [Libguestfs] [PATCH libnbd v2 1/2] golang: Changes test license to LPGL

2021-11-01 Thread Daniel P . Berrangé
On Sun, Oct 31, 2021 at 06:20:05PM +, Richard W.M. Jones wrote: > On Sun, Oct 31, 2021 at 06:59:32PM +0200, Nir Soffer wrote: > > Having different license for the tests complicates everyone life for no > > benefit. Change the license to LGPL2+ like the rest of the library. > > > > Related disc

Re: [Libguestfs] [PATCH libnbd v2 1/2] golang: Changes test license to LPGL

2021-11-01 Thread Daniel P . Berrangé
On Mon, Nov 01, 2021 at 11:30:07AM +, Richard W.M. Jones wrote: > On Mon, Nov 01, 2021 at 09:32:37AM +0000, Daniel P. Berrangé wrote: > > On Sun, Oct 31, 2021 at 06:20:05PM +, Richard W.M. Jones wrote: > > > On Sun, Oct 31, 2021 at 06:59:32PM +0200, Nir Soffer wro

Re: [Libguestfs] [virt-v2v RFC wave 2 03/10] convert/windows_virtio: restrict the warning with virtio-win.iso absent

2021-11-09 Thread Daniel P . Berrangé
On Tue, Nov 09, 2021 at 11:55:32AM +0100, Laszlo Ersek wrote: > I'm asking now because these simplifications look technically possible > even before I start investigating the "OVF video device" topic. I expect > the latter to turn into an infinite mess, so if I can (or should) tack > the cirrus cle

Re: [Libguestfs] Minimum OCaml compiler version (2021/2022 edition)

2021-11-09 Thread Daniel P . Berrangé
On Tue, Nov 09, 2021 at 09:04:40AM +, Richard W.M. Jones wrote: > Previously: > https://listman.redhat.com/archives/libguestfs/2020-March/msg00063.html > https://listman.redhat.com/archives/libguestfs/2017-September/msg00203.html > > Our current minimum version across projects is 4.03. > > We

Re: [Libguestfs] [PATCH libnbd CI] ci: Drop Fedora 33, add Fedora 35

2021-12-13 Thread Daniel P . Berrangé
On Mon, Dec 13, 2021 at 03:17:56PM +, Richard W.M. Jones wrote: > On Mon, Dec 13, 2021 at 04:07:27PM +0100, Martin Kletzander wrote: > > On Mon, Dec 13, 2021 at 02:40:40PM +, Richard W.M. Jones wrote: > > > > > >I pushed this (commit 202d0ecad) in the hope it might fix the tests. > > >Howev

Re: [Libguestfs] [v2v PATCH v2] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-17 Thread Daniel P . Berrangé
On Fri, Dec 17, 2021 at 10:31:40AM +, Richard W.M. Jones wrote: > On Fri, Dec 17, 2021 at 10:21:39AM +, Richard W.M. Jones wrote: > > So we need to keep things going for them even if RHEL doesn't > > necessarily support their use case. That means making conversions of > > RHEL 5/6 work on

Re: [Libguestfs] [PATCH 0/3] resolve conflict between manual and libvirt-assigned PCI addresses

2022-01-04 Thread Daniel P . Berrangé
On Thu, Dec 23, 2021 at 11:36:58AM +0100, Laszlo Ersek wrote: > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2034160 > > The first patch extends our current hack, moving the > virtio-net-pci device to slot 0x1E, where it is very unlikely to > conflict with any libvirt-assigned PCI addres

Re: [Libguestfs] [PATCH 0/3] resolve conflict between manual and libvirt-assigned PCI addresses

2022-01-04 Thread Daniel P . Berrangé
On Tue, Jan 04, 2022 at 02:02:57PM +, Richard W.M. Jones wrote: > On Tue, Jan 04, 2022 at 10:33:14AM +0000, Daniel P. Berrangé wrote: > > On Thu, Dec 23, 2021 at 11:36:58AM +0100, Laszlo Ersek wrote: > > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2034160 >

Re: [Libguestfs] [v2v PATCH] convert/libosinfo-c.c: turn caml_copy_*() return blocks into root values

2022-01-12 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 11:22:56AM +, Richard W.M. Jones wrote: > On Tue, Jan 11, 2022 at 12:15:13PM +0100, Laszlo Ersek wrote: > > By the way, we have more "offenders" left: > > > > - three in "bundled/libvirt-ocaml/libvirt_c_common.c": > > I'm quite sure this happens in a lot of places. >

Re: [Libguestfs] [v2v PATCH] convert/libosinfo-c.c: turn caml_copy_*() return blocks into root values

2022-01-12 Thread Daniel P . Berrangé
On Wed, Jan 12, 2022 at 03:14:43PM +0100, Laszlo Ersek wrote: > On 01/12/22 12:26, Daniel P. Berrangé wrote: > > On Tue, Jan 11, 2022 at 11:22:56AM +, Richard W.M. Jones wrote: > >> On Tue, Jan 11, 2022 at 12:15:13PM +0100, Laszlo Ersek wrote: > >>> By the way,

Re: [Libguestfs] Running lcitool in nbdkit

2022-03-14 Thread Daniel P . Berrangé
On Sat, Mar 12, 2022 at 10:50:21AM +, Richard W.M. Jones wrote: > Am I doing this wrong? [see log below] This is using the upstream > libvirt-ci checked out just now from gitlab, but it seems as if nbdkit > has to be listed as a project under that repo. > > "./lcitool projects" shows libnbd

Re: [Libguestfs] Running lcitool in nbdkit

2022-03-14 Thread Daniel P . Berrangé
On Mon, Mar 14, 2022 at 10:01:46AM +, Richard W.M. Jones wrote: > On Mon, Mar 14, 2022 at 09:18:04AM +0000, Daniel P. Berrangé wrote: > > On Sat, Mar 12, 2022 at 10:50:21AM +, Richard W.M. Jones wrote: > > > Am I doing this wrong? [see log below] This is using the upst

Re: [Libguestfs] Running lcitool in nbdkit

2022-03-14 Thread Daniel P . Berrangé
On Mon, Mar 14, 2022 at 10:14:37AM +, Richard W.M. Jones wrote: > On Mon, Mar 14, 2022 at 10:01:46AM +, Richard W.M. Jones wrote: > > Martin - I guess you must have created that nbdkit.yml file at some > > point, but I can't find it in your fork. > > Found it: > > https://gitlab.com/nertp

Re: [Libguestfs] Running lcitool in nbdkit

2022-03-14 Thread Daniel P . Berrangé
On Mon, Mar 14, 2022 at 10:41:05AM +, Richard W.M. Jones wrote: > I rebased Martin's tree[1] on top of libvirt-ci head, and reran > lcitool. There are several places where I changed the generated files > in nbdkit.git and where those changes are overwritten (I didn't > realise those files were

Re: [Libguestfs] [p2v PATCH] build: remove gnulib

2022-03-21 Thread Daniel P . Berrangé
On Mon, Mar 21, 2022 at 04:16:18PM +0100, Laszlo Ersek wrote: > It turns out that all we need from gnulib @ 253f29d8b391 is xstrtoull(), > ignore_value(), and assure(), when building on Fedora 35 anyway. I guess the question is what OS distros is p2v targetting ? With very rare exceptions, Fedora

Re: [Libguestfs] [PATCH v2v] lib: Use an ACL to allow qemu to access the v2v directory

2022-03-22 Thread Daniel P . Berrangé
On Tue, Mar 22, 2022 at 02:35:54PM +, Richard W.M. Jones wrote: > For fuller explanation see: > https://bugzilla.redhat.com/show_bug.cgi?id=2066773#c1 > > I'm not very happy with this patch for a few reasons: > > - Does every distro use "qemu" as the user that runs qemu? Not sure, but you c

Re: [Libguestfs] [PATCH v2v v2] lib: Use an ACL to allow qemu to access the v2v directory

2022-03-22 Thread Daniel P . Berrangé
On Tue, Mar 22, 2022 at 05:34:25PM +0100, Laszlo Ersek wrote: > On 03/22/22 16:48, Richard W.M. Jones wrote: > > When using the libvirt backend and running as root, libvirt will run > > qemu as a non-root user (eg. qemu:qemu). The v2v directory stores NBD > > endpoints that qemu must be able to op

Re: [Libguestfs] [PATCH nbdkit INCOMPLETE] readahead: Rewrite this filter so it prefetches using .cache

2022-04-19 Thread Daniel P . Berrangé
On Tue, Apr 19, 2022 at 04:05:50PM +0100, Richard W.M. Jones wrote: > On Tue, Apr 19, 2022 at 04:31:44PM +0200, Laszlo Ersek wrote: > > On 04/19/22 14:47, Richard W.M. Jones wrote: > > > The previous readahead filter did not work well and we have stopped > > > using it in virt-v2v. However the con

Re: [Libguestfs] nbdkit worker thread shutdown

2022-05-05 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 02:24:12PM +0100, Nikolaus Rath wrote: > On May 05 2022, "Richard W.M. Jones" wrote: > > On Thu, May 05, 2022 at 08:59:56AM +0100, Nikolaus Rath wrote: > >> Hello, > >> > >> When nbdkit calls a plugin's unload() method, is it guaranteed that all > >> pending requests have

[Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-25 Thread Daniel P . Berrangé
as this is actually an old G4 vintage 32-bit model, rather than a synonym for 'host' / all-TCG-features as on other targets. We can at least simplify the code to use 'max' in all scenarios for appliance CPU model, and simply skip a CPU model for PPC. Signed-off-by:

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-26 Thread Daniel P . Berrangé
On Thu, May 26, 2022 at 10:10:02AM +0200, Andrew Jones wrote: > On Wed, May 25, 2022 at 05:13:53PM +0100, Peter Maydell wrote: > > On Wed, 25 May 2022 at 16:07, Laszlo Ersek wrote: > ... > > > Therefore it seems that starting with qemu-4.2, but strictly preceding > > > qemu-7.0, "-cpu max" and

Re: [Libguestfs] [nbdkit PATCH] RFC: blocksize: Add test for sharding behavior

2022-05-26 Thread Daniel P . Berrangé
On Thu, May 26, 2022 at 09:58:50AM +0100, Richard W.M. Jones wrote: > > Is there any way to do this without the literal sleeps? Gitlab CI in > particular appears to be very contended (I guess it runs in parallel > on huge systems with vast numbers of unrelated containers). I've seen > threads be

Re: [Libguestfs] libnbd: Failed to update to Fedora 36 & OpenSUSE Leap 15.3

2022-06-06 Thread Daniel P . Berrangé
On Mon, May 30, 2022 at 09:25:11AM +0200, Martin Kletzander wrote: > On Sun, May 29, 2022 at 11:22:05AM +0100, Richard W.M. Jones wrote: > > > > I added this commit and regenerated the CI files: > > > > https://gitlab.com/nbdkit/libnbd/-/commit/b6a98aacbe22d599f000d4d1c84c27081ec06957 > > https:/

Re: [Libguestfs] libnbd: Failed to update to Fedora 36 & OpenSUSE Leap 15.3

2022-06-06 Thread Daniel P . Berrangé
On Mon, May 30, 2022 at 09:04:25AM +0100, Richard W.M. Jones wrote: > On Mon, May 30, 2022 at 09:25:11AM +0200, Martin Kletzander wrote: > > On Sun, May 29, 2022 at 11:22:05AM +0100, Richard W.M. Jones wrote: > > > > > >I added this commit and regenerated the CI files: > > > > > >https://gitlab.com

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 02:03:04PM +0100, Richard W.M. Jones wrote: > make[2]: Entering directory '/home/rjones/d/libnbd/golang' > perl /home/rjones/d/libnbd/podwrapper.pl --section=3 --man libnbd-golang.3 \ > --html ../html/libnbd-golang.3.html \ > libnbd-golang.pod > /home/rjones/d/libnbd

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 03:08:51PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 09, 2022 at 02:14:07PM +0100, Daniel P. Berrangé wrote: > > If you can get the test to core dump, then plain old GDB core > > dump could also be useful - might identify which specific API > > i

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 04:48:34PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 09, 2022 at 04:24:12PM +0100, Richard W.M. Jones wrote: > > On Thu, Jun 09, 2022 at 03:20:02PM +0100, Daniel P. Berrangé wrote: > > > > + go test -count=1 -v > > > > === R

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 05:33:03PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 09, 2022 at 07:22:45PM +0300, Nir Soffer wrote: > > On Thu, Jun 9, 2022 at 6:48 PM Richard W.M. Jones wrote: > > > NB: this _does not_ address the other problem where GODEBUG=cgocheck=2 > > > complains about "fatal e

Re: [Libguestfs] [v2v PATCH] output/create_libvirt_xml: generate @check='none' CPU attribute

2022-07-22 Thread Daniel P . Berrangé
On Fri, Jul 22, 2022 at 10:34:44AM +0100, Richard W.M. Jones wrote: > Sorry for the delayed response to this. I see you've posted an > updated patch, so this is just a bit of FYI. > > I originally added CPU modelling in commit 11505e4b84 (March 2017): > > https://github.com/libguestfs/virt-v2v/c

Re: [Libguestfs] [v2v PATCH] output/create_libvirt_xml: generate @check='none' CPU attribute

2022-07-22 Thread Daniel P . Berrangé
On Fri, Jul 22, 2022 at 01:49:21PM +0200, Laszlo Ersek wrote: > On 07/22/22 11:50, Richard W.M. Jones wrote: > > On Fri, Jul 22, 2022 at 10:42:48AM +0100, Daniel P. Berrangé wrote: > >> On Fri, Jul 22, 2022 at 10:34:44AM +0100, Richard W.M. Jones wrote: > >>> Sorry fo

Re: [Libguestfs] libnbd | Failed pipeline for master | 5bd16353

2022-08-11 Thread Daniel P . Berrangé
On Thu, Aug 11, 2022 at 10:01:23AM +0100, Richard W.M. Jones wrote: > On Thu, Aug 11, 2022 at 07:42:17AM +, GitLab wrote: > > Pipeline #610085241 triggered by ● Richard W.M. Jones > >had 3 failed jobs > > Failed jobs > > ✖ builds x86_64-op

Re: [Libguestfs] [p2v PATCH 2/6] restrict vCPU topology to (a) fully populated physical, or (b) 1 * N * 1

2022-09-08 Thread Daniel P . Berrangé
On Mon, Sep 05, 2022 at 01:25:27PM +0200, Laszlo Ersek wrote: > Currently, the CPU topology for the converted domain is determined as > follows: > > (1) main() [main.c] > > (2) set_config_defaults() [main.c] > vcpus <-- sy

Re: [Libguestfs] [p2v PATCH 2/6] restrict vCPU topology to (a) fully populated physical, or (b) 1 * N * 1

2022-09-08 Thread Daniel P . Berrangé
On Thu, Sep 08, 2022 at 02:36:15PM +0100, Richard W.M. Jones wrote: > (Adding Dan for input) > > On Thu, Sep 08, 2022 at 03:23:41PM +0200, Laszlo Ersek wrote: > > On 09/08/22 10:03, Richard W.M. Jones wrote: > > > On Mon, Sep 05, 2022 at 01:25:27PM +0200, Laszlo Ersek wrote: > > >> + "p2v.vcpu.de

Re: [Libguestfs] [p2v PATCH 1/7] "shutdown_actions": suppress "missing initializer" warnings/errors

2022-09-26 Thread Daniel P . Berrangé
On Mon, Sep 26, 2022 at 10:18:06AM +0200, Laszlo Ersek wrote: > gcc reports: > > > gui.c:1795:3: error: missing initializer for field ‘padding’ of > > ‘GActionEntry’ {aka ‘const struct _GActionEntry’} > > [-Werror=missing-field-initializers] > > 1795 | { "shutdown", activate_action, NULL, NULL,

Re: [Libguestfs] [p2v PATCH 7/7] gui.c: annotate GTK_INPUT_PURPOSE_PASSWORD with upstream GTK3 version

2022-09-26 Thread Daniel P . Berrangé
On Mon, Sep 26, 2022 at 12:59:21PM +0100, Richard W.M. Jones wrote: > > Apart from Dan's suggestions in patch 1, the series looks good to me. > > FWIW RHEL 7 (the earliest distro with PCRE 2) has glib2 2.56.1 & > gtk3 3.22.30, so supporting any earlier versions also seems pointless, > so that mig

Re: [Libguestfs] [p2v PATCH 7/7] gui.c: annotate GTK_INPUT_PURPOSE_PASSWORD with upstream GTK3 version

2022-09-27 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 04:53:08PM +0200, Laszlo Ersek wrote: > On 09/26/22 14:09, Daniel P. Berrangé wrote: > > On Mon, Sep 26, 2022 at 12:59:21PM +0100, Richard W.M. Jones wrote: > >> > >> Apart from Dan's suggestions in patch 1, the series looks good to me. >

Re: [Libguestfs] [p2v PATCH 7/7] gui.c: annotate GTK_INPUT_PURPOSE_PASSWORD with upstream GTK3 version

2022-09-27 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 06:27:08PM +0200, Laszlo Ersek wrote: > On 09/27/22 17:59, Daniel P. Berrangé wrote: > > On Tue, Sep 27, 2022 at 04:53:08PM +0200, Laszlo Ersek wrote: > >> On 09/26/22 14:09, Daniel P. Berrangé wrote: > >>> On Mon, Sep 26, 2022 at 12:59:21PM +

Re: [Libguestfs] [p2v PATCH 1/2] require GLIB2 >= 2.56 and GTK3 >= 3.22; enhance API compatibility

2022-09-28 Thread Daniel P . Berrangé
gt; Suggested-by: Richard W.M. Jones > Suggested-by: Daniel P. Berrangé > Signed-off-by: Laszlo Ersek > --- > Makefile.am | 4 > docs/p2v-building.pod | 6 +- > m4/p2v-libraries.m4 | 5 +++-- > 3 files changed, 12 insertions(+), 3 deletions(-)

Re: [Libguestfs] another GTK3 regression...

2022-09-28 Thread Daniel P . Berrangé
On Wed, Sep 28, 2022 at 02:01:11PM +0200, Laszlo Ersek wrote: > (this reproduces at commit 0687cea6a86e; IOW the regression is not from > the recent GTK-related patches, but due to building p2v with GTK3. as > opposed to GTK2) > > In the first dialog, when the Test Connection button is clicked, a

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Thu, Sep 29, 2022 at 07:12:15PM +0100, Richard W.M. Jones wrote: > On Thu, Sep 29, 2022 at 04:47:34PM +0200, Laszlo Ersek wrote: > > http://lacos.interhost.hu/livecd-p2v-202209291608-gitc213ae00a337.iso > > > > (built at c213ae00a337) > > > > sha256: f3a149aeab0179213d74bb1eac30d5d6f807d4c9cf3

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 09:41:02AM +0100, Richard W.M. Jones wrote: > On Fri, Sep 30, 2022 at 08:55:02AM +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 29, 2022 at 07:12:15PM +0100, Richard W.M. Jones wrote: > > > On Thu, Sep 29, 2022 at 04:47:34PM +0200, Laszlo Ersek w

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: > > Hmm, here's an interesting stackoverflow posting ... > > https://stackoverflow.com/questions/3301023/gtk-spinner-not-appearing > > The first point is "Make sure librsvg is installed". librsvg is _not_ > installed in the ISO

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: > On 09/30/22 11:46, Daniel P. Berrangé wrote: > > On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: > >> > >> Hmm, here's an interesting stackoverflow posting ... > >> > &g

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 01:50:43PM +0200, Laszlo Ersek wrote: > On 09/30/22 13:01, Laszlo Ersek wrote: > > > ... meant to add: this has proved Daniel's point that the WM is > > extremely important. For the record, I use IceWM locally, so when I > > run virt-p2v "directly", on my workstation, and f

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 01:11:50PM +0100, Richard W.M. Jones wrote: > On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: > > On 09/30/22 11:46, Daniel P. Berrangé wrote: > > > On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: > > >> >

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 03:23:31PM +0200, Laszlo Ersek wrote: > On 09/30/22 14:11, Richard W.M. Jones wrote: > > On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: > > >> (2d) I started icewm with "icewm --replace" (as recommended by the error > >> message from (2c)), and lo and behold,

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 03:57:15PM +0200, Laszlo Ersek wrote: > On 09/30/22 15:35, Daniel P. Berrangé wrote: > > On Fri, Sep 30, 2022 at 03:23:31PM +0200, Laszlo Ersek wrote: > >> On 09/30/22 14:11, Richard W.M. Jones wrote: > >>> On Fri, Sep 30, 2022 at 12:56:

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 04:39:48PM +0200, Laszlo Ersek wrote: > On 09/30/22 16:03, Daniel P. Berrangé wrote: > > > There are a bunch of users who want you to fully express all the optional > > deps, so they're guaranteed everything is installed by default. There are > &g

Re: [Libguestfs] libnbd | Failed pipeline for master | 018d55a8

2022-10-13 Thread Daniel P . Berrangé
On Thu, Oct 13, 2022 at 09:49:09AM +0100, Richard W.M. Jones wrote: > On Wed, Oct 12, 2022 at 02:00:21PM -0500, Eric Blake wrote: > > > Job #3163966643 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3163966643/raw ) > > > > > > Stage: builds > > > Name: x86_64-opensuse-leap-153-prebuilt-env > > > > Th

Re: [Libguestfs] libnbd | Failed pipeline for master | 018d55a8

2022-10-14 Thread Daniel P . Berrangé
On Thu, Oct 13, 2022 at 03:02:51PM -0600, Jim Fehlig wrote: > Hi Daniel, > > Thanks for the detailed report! > > On 10/13/22 03:33, Daniel P. Berrangé wrote: > > On Thu, Oct 13, 2022 at 09:49:09AM +0100, Richard W.M. Jones wrote: > > > On Wed, Oct 12, 2022 at 02:0

Re: [Libguestfs] libnbd | Failed pipeline for master | 018d55a8

2022-10-18 Thread Daniel P . Berrangé
On Mon, Oct 17, 2022 at 03:22:17PM -0600, Jim Fehlig wrote: > On 10/14/22 01:17, Daniel P. Berrangé wrote: > > On Thu, Oct 13, 2022 at 03:02:51PM -0600, Jim Fehlig wrote: > > > Hi Daniel, > > > > > > Thanks for the detailed report! > > > >

Re: [Libguestfs] libnbd | Failed pipeline for master | 018d55a8

2022-10-19 Thread Daniel P . Berrangé
On Tue, Oct 18, 2022 at 02:59:37PM -0500, Eric Blake wrote: > On Tue, Oct 18, 2022 at 09:10:24AM +0100, Daniel P. Berrangé wrote: > > > > > > > > > > Indeed. Leap 15.4 and newer include the crypto-policies package. > > > > > Sh

Re: [Libguestfs] [libnbd PATCH 2/2] ci: Add coverage of --without-libxml2

2022-10-19 Thread Daniel P . Berrangé
+ > dump/dump-data.sh| 1 + > dump/dump-pattern.sh | 1 + > 5 files changed, 34 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [Libguestfs] [libnbd PATCH 1/2] ci: Add opensuse-leap 15.4, skip TLS on 15.3

2022-10-19 Thread Daniel P . Berrangé
ing CONFIGURE_OPTS in manifest.yml, there was no need for the re-ordering of that line. Still I guess the new order makes sense, as it allows override of stuff set by CONFIG_ARGS should it be needed in future. > > Thanks: Daniel P. Berrangé > --- > ci/build.sh

[Libguestfs] [PATCH] daemon: add inspector support for MS-DOS distro

2018-02-07 Thread Daniel P . Berrangé
An installation of MS-DOS has various files in a /DOS directory, which COMMAND.COM looking like a reasonable signal that its MS-DOS or a very close relative there-of. This is validated with an MS-DOS 6.22 install. Signed-off-by: Daniel P. Berrangé --- BTW, I'm unclear if we should mak

[Libguestfs] [PATCH v2] daemon: add inspector support for MS-DOS distro

2018-02-07 Thread Daniel P . Berrangé
An installation of MS-DOS has various files in a /DOS directory, which COMMAND.COM looking like a reasonable signal that its MS-DOS or a very close relative there-of. This is validated with an MS-DOS 6.22 install. Signed-off-by: Daniel P. Berrangé --- daemon/inspect_fs.ml| 14

Re: [Libguestfs] 1.39 proposal: Let's split up the libguestfs git repo and tarballs

2018-02-12 Thread Daniel P . Berrangé
On Fri, Feb 09, 2018 at 06:01:53PM +, Richard W.M. Jones wrote: > My contention is that the libguestfs git repository is too large and > unwieldy. There are too many separate, unrelated projects and as a > result of that the source has too many dependencies and takes too long > to build and te

Re: [Libguestfs] 1.39 proposal: Let's split up the libguestfs git repo and tarballs

2018-02-12 Thread Daniel P . Berrangé
On Mon, Feb 12, 2018 at 12:09:23PM +, Richard W.M. Jones wrote: > On Mon, Feb 12, 2018 at 09:22:30AM +0000, Daniel P. Berrangé wrote: > > On Fri, Feb 09, 2018 at 06:01:53PM +, Richard W.M. Jones wrote: > > > My contention is that the libguestfs git repositor

Re: [Libguestfs] [PATCH nbdkit] python: Turn python exceptions into nbdkit errors

2018-04-05 Thread Daniel P . Berrangé
On Thu, Apr 05, 2018 at 01:47:30PM +0100, Richard W.M. Jones wrote: > Much more annoying that it needs to be, but I have tested it and it > works on Python 2 & 3. Note this will not work on Python 3.0 - 3.2, > but I guess we don't care about those versions. What's the problem that impacts 3.0 ->

Re: [Libguestfs] [PATCH] tests: Increase appliance memory when testing 256+ disks.

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 12:51:19PM +0100, Richard W.M. Jones wrote: > Currently the tests fail on x86 with recent kernels: > > FAIL: test-255-disks.sh > > This confused me for a while because our other test program > (utils/max-disks/max-disks.pl) reports that it should be possible to > add 255

Re: [Libguestfs] [PATCH for discussion only] lib: libvirt: If root, run qemu subprocess as root.root.

2018-05-21 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 06:22:06PM +0100, Richard W.M. Jones wrote: > libvirt doesn't have a concept of "session qemu" for root: > > https://bugzilla.redhat.com/show_bug.cgi?id=890291 > > When a libguestfs-using process runs as root, and libvirt runs a qemu > subprocess, the qemu subprocess is

Re: [Libguestfs] [PATCH] v2v: Set machine type explicitly for outputs which support it (RHBZ#1581428).

2018-06-19 Thread Daniel P . Berrangé
On Tue, Jun 19, 2018 at 11:37:46AM +0100, Richard W.M. Jones wrote: > QEMU for x86 supports two machine types, "pc" (emulating the ancient > Intel i440FX chipset originally used by the Pentium Pro), and "q35" > (https://wiki.qemu.org/Features/Q35). > > Currently virt-v2v does not set any machine t

Re: [Libguestfs] [PATCH] v2v: Set machine type explicitly for outputs which support it (RHBZ#1581428).

2018-06-19 Thread Daniel P . Berrangé
On Tue, Jun 19, 2018 at 12:12:30PM +0100, Richard W.M. Jones wrote: > On Tue, Jun 19, 2018 at 11:43:38AM +0100, Daniel P. Berrangé wrote: > > I'd encourage apps to check the capabilities XML to see what > > machine types are available. > > One issue is we don't a

Re: [Libguestfs] [PATCH nbdkit] tls: Implement Pre-Shared Keys (PSK) authentication.

2018-06-28 Thread Daniel P . Berrangé
On Thu, Jun 28, 2018 at 10:18:25AM -0500, Eric Blake wrote: > On 06/25/2018 12:01 PM, Richard W.M. Jones wrote: > > --- > > docs/nbdkit.pod.in | 45 +-- > > src/crypto.c | 234 > > + > > src/internal.h | 1 + > > src/mai

Re: [Libguestfs] [PATCH nbdkit] protocol: Implement NBD_OPT_GO.

2018-08-06 Thread Daniel P . Berrangé
On Mon, Aug 06, 2018 at 05:31:54PM +0300, Nir Soffer wrote: > On Mon, Aug 6, 2018 at 5:06 PM Eric Blake wrote: > > > On 08/06/2018 02:54 AM, Richard W.M. Jones wrote: > > > On Sun, Aug 05, 2018 at 12:11:04AM +0300, Nir Soffer wrote: > > >> But we have a bug - server configure to allow access to "

Re: [Libguestfs] Tests and trimming vfat

2018-09-05 Thread Daniel P . Berrangé
On Wed, Sep 05, 2018 at 04:37:05PM +0100, Richard W.M. Jones wrote: > > Here's a fun one: > > + guestfish -N test-virt-sparsify-in-place-fstrim-unsupported.img=fs:vfat exit > + virt-sparsify --in-place test-virt-sparsify-in-place-fstrim-unsupported.img > + tee test-virt-sparsify-in-place-fstrim-u

Re: [Libguestfs] Tests and trimming vfat

2018-09-05 Thread Daniel P . Berrangé
On Wed, Sep 05, 2018 at 04:45:51PM +0100, Richard W.M. Jones wrote: > On Wed, Sep 05, 2018 at 04:41:01PM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 05, 2018 at 04:37:05PM +0100, Richard W.M. Jones wrote: > > > > > > Here's a fun one: > > > > &g

Re: [Libguestfs] Tests and trimming vfat

2018-09-05 Thread Daniel P . Berrangé
On Wed, Sep 05, 2018 at 04:53:03PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 05, 2018 at 04:45:51PM +0100, Richard W.M. Jones wrote: > > On Wed, Sep 05, 2018 at 04:41:01PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Sep 05, 2018 at 04:37:05PM +0100, Richar

Re: [Libguestfs] [PATCH] sparsify: Fix test-virt-sparsify-in-place-fstrim-unsupported.sh

2018-09-05 Thread Daniel P . Berrangé
hanks: Daniel P. Berrangé and Pino Toscano. > --- > ...virt-sparsify-in-place-fstrim-unsupported.sh | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.fli

Re: [Libguestfs] virt-builder fail with "bridge ‘virbr0’ not found" (fixed by LIBGUESTFS_BACKEND=direct ?!)

2018-10-10 Thread Daniel P . Berrangé
On Wed, Oct 10, 2018 at 02:27:44PM +0300, Nir Soffer wrote: > On Wed, Oct 10, 2018 at 10:18 AM Pino Toscano wrote: > > > On Tuesday, 9 October 2018 20:16:04 CEST Nir Soffer wrote: > > > I'm trying to build fedora-27 image for testing uploads: > > > > > > $ virt-builder fedora-27 -o /var/tmp/fedor

Re: [Libguestfs] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Daniel P . Berrangé
On Fri, Nov 09, 2018 at 12:19:30PM +, Richard W.M. Jones wrote: > Peter Dimitrov and myself were debugging a very peculiar bug when > libguestfs is run as a plugin from collectd: > > https://www.redhat.com/archives/libguestfs/2018-November/thread.html#00023 > > The long story short is that

Re: [Libguestfs] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Daniel P . Berrangé
On Tue, Nov 13, 2018 at 10:42:20AM +, Richard W.M. Jones wrote: > On Tue, Nov 13, 2018 at 10:04:33AM +0000, Daniel P. Berrangé wrote: > > On Fri, Nov 09, 2018 at 12:19:30PM +, Richard W.M. Jones wrote: > > > Peter Dimitrov and myself were debugging a very peculiar bug whe

Re: [Libguestfs] [PATCH v2 7/7] build: stop looking for ocaml-libvirt

2018-11-27 Thread Daniel P . Berrangé
On Tue, Nov 27, 2018 at 11:59:08AM +0100, Pino Toscano wrote: > We ship our own copy of it, so we do not need the external version. > (Also, the latest upstream version of ocaml-libvirt was already not > usable to build the test harness of v2v.) This is a significant step backwards from a Fedora p

Re: [Libguestfs] 1.39 proposal: Let's split up the libguestfs git repo and tarballs

2019-06-10 Thread Daniel P . Berrangé
On Mon, Jun 10, 2019 at 04:35:52PM +0100, Richard W.M. Jones wrote: > Sorry for the late reply to this ... > > On Tue, Apr 30, 2019 at 06:28:01PM +0200, Pino Toscano wrote: > > The other problem is how to split the repository, as the various bits > > are in different places: > > a) git filter-bran

Re: [Libguestfs] [libnbd] How close are we to declaring a stable API?

2019-07-03 Thread Daniel P . Berrangé
On Tue, Jul 02, 2019 at 08:48:15PM -0500, Eric Blake wrote: > On 6/29/19 5:25 AM, Richard W.M. Jones wrote: > > As the subject says, how close are we to being able to declare a > > stable API for libnbd? > > > > I believe these are the main topics: > > > > * Do we need to have an extra thread for

Re: [Libguestfs] [PATCH libnbd] lib: Use symbol versions.

2019-07-29 Thread Daniel P . Berrangé
On Sat, Jul 27, 2019 at 02:19:47PM +0100, Richard W.M. Jones wrote: > This patch adds support for symbol versions. It is based on what > libvirt does. > > The generated syms file looks like: > > LIBNBD_1.0 { > global: > nbd_...; > nbd_...; > local: *; > }; > > In a future stable 1.2

  1   2   >