On Wed, Sep 28, 2022 at 02:06:49PM +0200, Laszlo Ersek wrote:
> For further simplifying virt-p2v's GTK API usage, require the GLIB2 and
> GTK3 versions that RHEL7 provides.
> 
> The MIN_REQUIRED=<version> macros elicit warnings if we use an API that
> was already deprecated in said version of the given library.
> 
> The MAX_ALLOWED=<version> macros make sure we don't unwittingly use an API
> that was introduced after our required minimum version.
> 
> (GDK is a layer below GTK, so using the GDK_VERSION_* macros ensures both
> GDK and GTK API compatibility.)
> 
> Suggested-by: Richard W.M. Jones <rjo...@redhat.com>
> Suggested-by: Daniel P. Berrangé <berra...@redhat.com>
> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
> ---
>  Makefile.am           | 4 ++++
>  docs/p2v-building.pod | 6 +++++-
>  m4/p2v-libraries.m4   | 5 +++--
>  3 files changed, 12 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs

Reply via email to