Hi Jones,
On Thu, Aug 25, 2022 at 01:10:55PM +0100, Richard W.M. Jones wrote:
> This patch adds simple support for a ublk-based NBD client.
> It is also available here:
> https://gitlab.com/rwmjones/libnbd/-/tree/nbdublk/ublk
>
> ublk is a way to write Linux block device drivers in userspace:
Ju
On Tue, Aug 30, 2022 at 10:32:02AM +0800, Ming Lei wrote:
> Hi Jones,
>
> On Thu, Aug 25, 2022 at 01:10:55PM +0100, Richard W.M. Jones wrote:
> > This patch adds simple support for a ublk-based NBD client.
> > It is also available here:
> > https://gitlab.com/rwmjones/libnbd/-/tree/nbdublk/ublk
>
On Tue, Aug 30, 2022 at 10:32:02AM +0800, Ming Lei wrote:
> Hi Jones,
>
> On Thu, Aug 25, 2022 at 01:10:55PM +0100, Richard W.M. Jones wrote:
> > This patch adds simple support for a ublk-based NBD client.
> > It is also available here:
> > https://gitlab.com/rwmjones/libnbd/-/tree/nbdublk/ublk
>
On Tue, Aug 30, 2022 at 09:04:07AM +0100, Richard W.M. Jones wrote:
> On Tue, Aug 30, 2022 at 10:32:02AM +0800, Ming Lei wrote:
> > Hi Jones,
> >
> > On Thu, Aug 25, 2022 at 01:10:55PM +0100, Richard W.M. Jones wrote:
> > > This patch adds simple support for a ublk-based NBD client.
> > > It is al
On Tue, Aug 30, 2022 at 04:30:40PM +0800, Ming Lei wrote:
> On Tue, Aug 30, 2022 at 09:04:07AM +0100, Richard W.M. Jones wrote:
> > On Tue, Aug 30, 2022 at 10:32:02AM +0800, Ming Lei wrote:
> > > Hi Jones,
> > >
> > > On Thu, Aug 25, 2022 at 01:10:55PM +0100, Richard W.M. Jones wrote:
> > > > This
On Tue, Aug 30, 2022 at 10:07:40AM +0100, Richard W.M. Jones wrote:
> On Tue, Aug 30, 2022 at 04:30:40PM +0800, Ming Lei wrote:
> > On Tue, Aug 30, 2022 at 09:04:07AM +0100, Richard W.M. Jones wrote:
> > > On Tue, Aug 30, 2022 at 10:32:02AM +0800, Ming Lei wrote:
> > > > Hi Jones,
> > > >
> > > >
On Tue, Aug 30, 2022 at 05:38:35PM +0800, Ming Lei wrote:
> nbd work thread is created by nbd target code just like before, but
> the thread is changed to the following way, basically bound with one
> aio_ctx:
> while (!ublksrv_aio_ctx_dead(aio_ctx)) {
> struct aio_list compl;
>
> a
On 08/25/22 17:05, Eric Blake wrote:
> On Thu, Aug 25, 2022 at 12:13:42PM +0200, Laszlo Ersek wrote:
>> [...]
> The design background does play a big role. When we first started
> libnbd, we did not have an easy way to write an API that would take a
> string vector as a single argument that the g
On 08/27/22 19:40, Richard W.M. Jones wrote:
> Alright, so final version for now is here:
>
> https://gitlab.com/rwmjones/libnbd/-/tree/nbdublk/ublk
I'm slightly interested to review this, but I'm also OK if we just push
it and call it "initial addition" or "experimental" or whatever (I don't
t
On Tue, Aug 30, 2022 at 11:51:00AM +0100, Richard W.M. Jones wrote:
> On Tue, Aug 30, 2022 at 05:38:35PM +0800, Ming Lei wrote:
> > nbd work thread is created by nbd target code just like before, but
> > the thread is changed to the following way, basically bound with one
> > aio_ctx:
>
> > whil
On Fri, Aug 26, 2022 at 07:39:31AM -0500, Eric Blake wrote:
> On Fri, Aug 26, 2022 at 01:39:05PM +0200, Laszlo Ersek wrote:
> > Extract and somewhat generalize the recipe for the $(PHYSICAL_MACHINE)
> > target to a separate shell script. In preparation for the multiple steps
> > we're going to intr
Series looks good, thanks.
Reviewed-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Wi
On Tue, Aug 30, 2022 at 01:16:02PM +0200, Laszlo Ersek wrote:
> Thanks for the explanation. I didn't expect these two principles to have
> driven the design (generability, and long-term convenience calls). I
> think the more usual (albeit likely less programmer-friendly) approach
> is to (a) expose
On 08/30/22 15:11, Richard W.M. Jones wrote:
>
> Series looks good, thanks.
>
> Reviewed-by: Richard W.M. Jones
Thanks :)
Let me wait for Eric's next round of comments / answers though, before I
merge the series.
Laszlo
___
Libguestfs mailing list
L
On Tue, Aug 30, 2022 at 03:12:23PM +0800, Ming Lei wrote:
> The patch sent in last email may cause io hang on MQ, and follows the fixed
> version:
I split this into two commits and cleaned them up and posted them here:
https://gitlab.com/rwmjones/libnbd/-/commits/nbdublk/
Unfortunately this does
On Tue, Aug 30, 2022 at 01:43:17PM +0200, Laszlo Ersek wrote:
> On 08/27/22 19:40, Richard W.M. Jones wrote:
> > Alright, so final version for now is here:
> >
> > https://gitlab.com/rwmjones/libnbd/-/tree/nbdublk/ublk
>
> I'm slightly interested to review this, but I'm also OK if we just push
On Tue, Aug 30, 2022 at 03:38:50PM +0100, Richard W.M. Jones wrote:
> On Tue, Aug 30, 2022 at 03:12:23PM +0800, Ming Lei wrote:
> > The patch sent in last email may cause io hang on MQ, and follows the fixed
> > version:
>
> I split this into two commits and cleaned them up and posted them here:
>
On Tue, Aug 30, 2022 at 11:29:26PM +0800, Ming Lei wrote:
> On Tue, Aug 30, 2022 at 03:38:50PM +0100, Richard W.M. Jones wrote:
> > On Tue, Aug 30, 2022 at 03:12:23PM +0800, Ming Lei wrote:
> > > The patch sent in last email may cause io hang on MQ, and follows the
> > > fixed
> > > version:
> >
On Tue, Aug 30, 2022 at 11:29:26PM +0800, Ming Lei wrote:
> On Tue, Aug 30, 2022 at 03:38:50PM +0100, Richard W.M. Jones wrote:
> > On Tue, Aug 30, 2022 at 03:12:23PM +0800, Ming Lei wrote:
> > > The patch sent in last email may cause io hang on MQ, and follows the
> > > fixed
> > > version:
> >
On Tue, Aug 30, 2022 at 07:28:43AM +0200, Laszlo Ersek wrote:
> I had grepped the virt-p2v and virt-v2v shell scripts for shebangs:
>
> 1 #!/bin/sh
> 2 #!/bin/bash
> 4 #!/usr/bin/env perl
> 17 #!/bin/bash -
>
> 1 #!/bin/bash
> 1 #!/usr/bin/env python3
> 1
On Tue, Aug 30, 2022 at 03:34:46PM +0200, Laszlo Ersek wrote:
> On 08/30/22 15:11, Richard W.M. Jones wrote:
> >
> > Series looks good, thanks.
> >
> > Reviewed-by: Richard W.M. Jones
>
> Thanks :)
>
> Let me wait for Eric's next round of comments / answers though, before I
> merge the series.
On Tue, Aug 30, 2022 at 05:13:46PM +0100, Richard W.M. Jones wrote:
> On Tue, Aug 30, 2022 at 11:29:26PM +0800, Ming Lei wrote:
> > On Tue, Aug 30, 2022 at 03:38:50PM +0100, Richard W.M. Jones wrote:
> > > On Tue, Aug 30, 2022 at 03:12:23PM +0800, Ming Lei wrote:
> > > > The patch sent in last emai
On 08/30/22 21:34, Eric Blake wrote:
> On Tue, Aug 30, 2022 at 07:28:43AM +0200, Laszlo Ersek wrote:
>> I had grepped the virt-p2v and virt-v2v shell scripts for shebangs:
>>
>> 1 #!/bin/sh
>> 2 #!/bin/bash
>> 4 #!/usr/bin/env perl
>> 17 #!/bin/bash -
>>
>> 1 #!/bin/bas
23 matches
Mail list logo
