On Tue, Aug 30, 2022 at 01:43:17PM +0200, Laszlo Ersek wrote: > On 08/27/22 19:40, Richard W.M. Jones wrote: > > Alright, so final version for now is here: > > > > https://gitlab.com/rwmjones/libnbd/-/tree/nbdublk/ublk > > I'm slightly interested to review this, but I'm also OK if we just push > it and call it "initial addition" or "experimental" or whatever (I don't > think it can regress anything).
It'll need these bugs to be resolved before we can consider it for upstream: https://bugzilla.redhat.com/2122595 https://bugzilla.redhat.com/2122605 The second one is closed but waiting for the package to actually end up in Rawhide. Also a package update may be required to add the aio_* branch to ubdsrv (but see below). > For a review, I'd likely need a good amount of time, and also the > "final" version to be on the list. Also, speaking relative to commit > cafc4dbbc8fa, it would be nice to squash / distribute the fixes into the > original patches as appropriate, and maybe to split up the initial code > drop into a gradual build-up of the new feature. I'll see what's possible. At the moment the combined patch of my work with Ming Lei's aio_* branch is not stable, so it's not really worth reviewing it right now. > The latter is a lot of extra work, admittedly, I just find it does > wonders to my review throughput. At the same time, I absolutely don't > insist on reviewing this -- I'm perfectly fine if we merge it at once. Sure! Any feedback is good though. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
