Re: [Libcdio-devel] Vulnerable use of strcpy in iso9660_fs.c

2024-04-08 Thread Thomas Schmitt via Libcdio-devel
Hi, Pete Batard wrote: > Or maybe there's a mathematical proof that > a UTF-8 glyph byte encoding can never be larger than 1.5 the UTF-16 glyph > byte encoding I thought to have given one. Let me try again: https://datatracker.ietf.org/doc/html/rfc3629 "In UTF-8, characters from the U+..

Re: [Libcdio-devel] Vulnerable use of strcpy in iso9660_fs.c

2024-04-06 Thread Thomas Schmitt via Libcdio-devel
Hi, Pete Batard wrote: > strncpy(cpy_result, p_psz_out, i_inlen); Known as nitpicker i want to to point out that this would avoid a memory corruption in case of overflow but would also truncate the name, potentially to an incomplete UTF-8 byte sequence at the end. I add the technical part of m

Re: [Libcdio-devel] [PATCH v3 0/4] Add El Torito virtual image support

2024-01-31 Thread Thomas Schmitt via Libcdio-devel
Hi, the v3 patches apply, but with number 4 there are still "git am" complaints: Applying: Add El Torito tests /home/stacker/libcdio_dir/libcdio.rocky/.git/rebase-apply/patch:69: trailing whitespace. # Tests El Torito (via iso-info and iso-read). /home/stacker/libcdio_dir/libcdio.rocky/.

Re: [Libcdio-devel] [PATCH v2 0/4] Add El Torito virtual image support

2024-01-30 Thread Thomas Schmitt via Libcdio-devel
Hi, Pete Batard wrote: > If you are > going to set a EFI partition to a size of 0 or 1, then the image will occupy > all sectors from the LSN to the end of the volume. I understand that this was specified as a last resort because - UEFI did not want to invent a new competitor to El Torito, - the

Re: [Libcdio-devel] [PATCH v2 0/4] Add El Torito virtual image support

2024-01-29 Thread Thomas Schmitt via Libcdio-devel
Hi, Pete Batard wrote: > I'll just add that I didn't formally test this, since I haven't had a chance > to locate an ISO with a > 32MB El-Torito image yet. You can build yourself one: - Get legacy PC-BIOS boot image isolinux.bin from e.g. a Debian netinst ISO: xorriso -osirrox on -indev d

Re: [Libcdio-devel] [PATCH 1/4] Add case insensitive _cdio_stricmp and _cdio_strnicmp function calls

2024-01-29 Thread Thomas Schmitt via Libcdio-devel
Hi, Rocky Bernstein wrote: > Overall, I'd like to get those patches without any controversy into the > code soon. I am not 100% certain which ones have disputes in them. Is it > just Patch 2? Summary of everything that comes to my mind with v1. I read over v2 and find not much changes in regard t

Re: [Libcdio-devel] [PATCH 2/4] Add El Torito virtual boot image support

2024-01-25 Thread Thomas Schmitt via Libcdio-devel
Hi, i wrote > > [...] UEFI-2.8: > >13.3.2.1 ISO-9660 and El Torito > >[...] > >If the value of Sector Count is set to 0 or 1, EFI will assume the > >system partition consumes the space from the beginning of the > >“no emulation” image to the end of the CD-ROM. Peter Batard wro

Re: [Libcdio-devel] [PATCH 2/4] Add El Torito virtual boot image support

2024-01-24 Thread Thomas Schmitt via Libcdio-devel
Hi, something i forgot to mention yesterday: $ xorriso -indev openSUSE-13.1-NET-x86_64.iso -report_el_torito plain ... El Torito images : N Pltf B Emul Ld_seg Hdpt Ldsiz LBA El Torito boot img : 1 BIOS y none 0x 0x00 44238 El Torito boot img :

Re: [Libcdio-devel] [PATCH 2/4] Add El Torito virtual boot image support

2024-01-24 Thread Thomas Schmitt via Libcdio-devel
Hi, Pete Batard wrote: > Enables the El Torito boot images to be listed and extracted from a virtual > "[BOOT]/" root directory. In [PATCH 3/4]: > +" --no-el-toritoDon't use El-Torito extension information\n" Maybe you should not make it default but enable it only on demand ? Th