Hi,
the v3 patches apply, but with number 4 there are still "git am"
complaints:
Applying: Add El Torito tests
/home/stacker/libcdio_dir/libcdio.rocky/.git/rebase-apply/patch:69: trailing
whitespace.
# Tests El Torito (via iso-info and iso-read).
/home/stacker/libcdio_dir/libcdio.rocky/.git/rebase-apply/patch:158: new
blank line at EOF.
+
/home/stacker/libcdio_dir/libcdio.rocky/.git/rebase-apply/patch:172: new
blank line at EOF.
+
warning: 3 lines add whitespace errors.
I have no big-endian system at hand, but the provisions for them
look good to me (assuming the functions do indeed what their names say):
+ p_iso->boot_img[k].lsn = uint32_from_le(br[j].image_lsn);
+ p_iso->boot_img[k++].num_sectors =
uint16_from_le(br[j].num_sectors);
To make some realistic test i tried ./src/iso-info with the three ISO
images which came today with the DELUG DVD of german Linux Magazin.
(All three were made by xorriso, while the DVD ISO was made by DELUG by
genisoimage):
alpine-standard-3.19.0-x86_64.iso:
/[BOOT]/:
- [LSN 56] 2048 Dec 04 2023 21:01:51 0-Boot-NoEmul.img
- [LSN 77] 1474560 Dec 04 2023 21:01:51 1-Boot-NoEmul.img
kali-linux-2023.4-live-amd64.iso:
/[BOOT]/:
- [LSN 2519] 2048 Nov 30 2023 11:21:39 0-Boot-NoEmul.img
- [LSN 2055] 950272 Nov 30 2023 11:21:39 1-Boot-NoEmul.img
proxmox-backup-server_3.1-1.iso:
/[boot]/:
- [LSN 5768] 2048 Nov 30 2023 11:19:33 0-boot-noemul.img
- [LSN 108] 8388608 Nov 30 2023 11:19:33 1-boot-noemul.img
The latter shows lowercase names although the ISO contains Rock Ridge
information. Does its lack of Joliet cause the lowercase ?
Further i looked into the OpenSUSE ISO, which bears unlimited boot image
size:
openSUSE-13.1-NET-x86_64.iso:
/[BOOT]/:
- [LSN 4238] 2048 Nov 06 2013 16:27:21 0-Boot-NoEmul.img
- [LSN 70] 512 Nov 06 2013 16:27:21 1-Boot-NoEmul.img
The size of 512 bytes is unfortunate. But it is what Pete announced to
implement.
The ISO stems from mkisofs or genisoimage: Rock Ridge NM comes before PX.
(The load size 1 was not caused by oversize but rather looks deliberate.)
So modulo my known objections, this patch set seems to implement what was
announced as goals.
Have a nice day :)
Thomas
