Re: [LEDE-DEV] [PATCH 1/3] busybox: enable flock by default

2017-12-18 Thread Mathias Kresin
17.12.2017 19:30, Roman Yeryomin: This is needed for procd init script protection to work. flock adds 4248 bytes to stripped busybox binary. Signed-off-by: Roman Yeryomin --- package/utils/busybox/Config-defaults.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/

Re: [LEDE-DEV] [PATCH] gcc: 7.2: remove mips patch causing broken code

2017-12-18 Thread Felix Fietkau
On 2017-12-17 22:21, Hauke Mehrtens wrote: > This patch made GCC produce broken code, remove it. > In mp_cmp_d() function in th libtommath shipped with dropbear the > following code was compiled wrong: > > /* compare based on magnitude */ > if (a->used > 1) { > return 1; > } > > In the broken A

Re: [LEDE-DEV] [PATCH] gcc: 7.2: remove mips patch causing broken code

2017-12-18 Thread Syrone Wong
I agree with Felix. I found libtommath issue in dropbear several months before. I can confirm the issue fixed by upgrading libtommath and libtomcrypt. The update is already done by upstream, but not released yet. You can try a CI-successfully-built commit from https://github.com/mkj/dropbear and s

Re: [LEDE-DEV] [PATCH 1/3] busybox: enable flock by default

2017-12-18 Thread Roman Yeryomin
On 2017-12-18 09:58, Mathias Kresin wrote: 17.12.2017 19:30, Roman Yeryomin: This is needed for procd init script protection to work. flock adds 4248 bytes to stripped busybox binary. Signed-off-by: Roman Yeryomin --- package/utils/busybox/Config-defaults.in | 2 +- 1 file changed, 1 insert

Re: [LEDE-DEV] [PATCH] gcc: 7.2: remove mips patch causing broken code

2017-12-18 Thread Kevin Darbyshire-Bryant
> On 18 Dec 2017, at 08:40, Felix Fietkau wrote: > > On 2017-12-17 22:21, Hauke Mehrtens wrote: >> This patch made GCC produce broken code, remove it. >> In mp_cmp_d() function in th libtommath shipped with dropbear the >> following code was compiled wrong: >> >> /* compare based on magnitude

Re: [LEDE-DEV] [PATCH] gcc: 7.2: remove mips patch causing broken code

2017-12-18 Thread Felix Fietkau
On 2017-12-18 11:07, Kevin Darbyshire-Bryant wrote: > Hi Felix, > > Thanks for explaining that. I suspect you’re right that there’s an > underlying bug in gcc mips. So ideally we need some code that exposes the > bug when using -O2 (or even just -funroll_loops) Looking at FS 814 there’s a > h

Re: [LEDE-DEV] [PATCH] gcc: 7.2: remove mips patch causing broken code

2017-12-18 Thread Kevin Darbyshire-Bryant
> On 18 Dec 2017, at 10:12, Felix Fietkau wrote: > > On 2017-12-18 11:07, Kevin Darbyshire-Bryant wrote: >> Hi Felix, >> >> Thanks for explaining that. I suspect you’re right that there’s an >> underlying bug in gcc mips. So ideally we need some code that exposes the >> bug when using -O2

[LEDE-DEV] [PATCH 2/3] support Quanta and Blackberry modes

2017-12-18 Thread Bjørn Mork
Quanta mode was introduced in usb_modeswitch 1.2.6 and Blackberry mode in usb_modeswitch 1.2.7 Signed-off-by: Bjørn Mork --- convert-modeswitch.pl | 2 ++ switch.c | 21 + 2 files changed, 23 insertions(+) diff --git a/convert-modeswitch.pl b/convert-modeswitch

[LEDE-DEV] [PATCH 1/3] fix support for Option modems

2017-12-18 Thread Bjørn Mork
USB_ModeSwitch version 2.3.0 introduced "OptionMode". Signed-off-by: Bjørn Mork --- convert-modeswitch.pl | 1 + switch.c | 16 2 files changed, 17 insertions(+) diff --git a/convert-modeswitch.pl b/convert-modeswitch.pl index 6930e5f8d668..71c2b7950cb5 100755 ---

[LEDE-DEV] [PATCH 0/3] usb-modeswitch: adding new modes supporting new config format

2017-12-18 Thread Bjørn Mork
The usb_modeswitch application is continously updated with new modes, and it's configuration data is updated accordingly by replacing explicit switching messages with references to these new modes. This has caused regressions in the OpenWrt usb-modeswitch package when the configuration data was up

[LEDE-DEV] [PATCH 3/3] support PantechMode

2017-12-18 Thread Bjørn Mork
The behaviour of the usb_modeswitch "Pantech" mode depends on the option value, so we need to propagate this via the json config to the usbmode tool. Signed-off-by: Bjørn Mork --- convert-modeswitch.pl | 9 + switch.c | 16 2 files changed, 25 insertions(+)

Re: [LEDE-DEV] [PATCH 1/3] busybox: enable flock by default

2017-12-18 Thread Mathias Kresin
18.12.2017 10:48, Roman Yeryomin: On 2017-12-18 09:58, Mathias Kresin wrote: 17.12.2017 19:30, Roman Yeryomin: This is needed for procd init script protection to work. flock adds 4248 bytes to stripped busybox binary. Signed-off-by: Roman Yeryomin --- package/utils/busybox/Config-defaults.i

Re: [LEDE-DEV] [PATCH] gcc: 7.2: remove mips patch causing broken code

2017-12-18 Thread Hauke Mehrtens
On 12/18/2017 10:34 AM, Syrone Wong wrote: > I agree with Felix. I found libtommath issue in dropbear several > months before. I can confirm the issue fixed by upgrading libtommath > and libtomcrypt. The update is already done by upstream, but not > released yet. With this patch libtommath will be

Re: [LEDE-DEV] [PATCH] gcc: 7.2: remove mips patch causing broken code

2017-12-18 Thread Hauke Mehrtens
On 12/18/2017 03:07 PM, Kevin Darbyshire-Bryant wrote: > > >> On 18 Dec 2017, at 10:12, Felix Fietkau wrote: >> >> On 2017-12-18 11:07, Kevin Darbyshire-Bryant wrote: >>> Hi Felix, >>> >>> Thanks for explaining that. I suspect you’re right that there’s an >>> underlying bug in gcc mips. So id

Re: [LEDE-DEV] [PATCH] gcc: 7.2: remove mips patch causing broken code

2017-12-18 Thread Hauke Mehrtens
On 12/18/2017 11:38 PM, Hauke Mehrtens wrote: > On 12/18/2017 03:07 PM, Kevin Darbyshire-Bryant wrote: >> >> >>> On 18 Dec 2017, at 10:12, Felix Fietkau wrote: >>> >>> On 2017-12-18 11:07, Kevin Darbyshire-Bryant wrote: Hi Felix, Thanks for explaining that. I suspect you’re right t

Re: [LEDE-DEV] Patch refresh issues - mystery whitespace

2017-12-18 Thread Syrone Wong
This is mine. QUILT_DIFF_ARGS="--no-timestamps --no-index -pab --color=auto" QUILT_REFRESH_ARGS="--no-timestamps --no-index -pab" QUILT_PATCH_OPTS="--unified" QUILT_DIFF_OPTS="-p" EDITOR="vim" quilt --version 0.65 Best Regards, Syrone Wong On Sun, Dec 17, 2017 at 5:57 PM, Kevin Darbyshire-Bry

[LEDE-DEV] [PATCH] ar71xx: spi-rb4xx: balance clk_prepare_enable() call

2017-12-18 Thread Gabor Juhos
Commit c312cef223dd ("ar71xx: spi-rb4xx fix.") replaced the clk_enable() call with clk_prepare_enable() to meet the common clock framework requirements. However it did not change the clk_disable() call in the error patch which thus leads to imbalance. Fix the code by using the correct counterpart