[LEDE-DEV] sysupgrade with URL did not work

2016-10-02 Thread Dennis Schneck
Hello, i tryed to Upgrade my C7 V2 with the sysupgrade command.   https did not work:   root@lede:~# sysupgrade https://downloads.lede-project.org/snapshots/targets/ar71xx/generic/lede-ar71xx-generic-archer-c7-v2-squashfs-sysupgrade.bin Invalid image type. Image check 'platform_check_image' faile

[LEDE-DEV] [PATCH v2] Consider using { cmd1; cmd2; } >> file instead of individual redirects

2016-10-02 Thread Jan-Tarek Butt
--- scripts/config/lxdialog/check-lxdialog.sh | 16 ++-- scripts/diffconfig.sh | 18 +++-- scripts/ext-toolchain.sh | 118 +- 3 files changed, 86 insertions(+), 66 deletions(-) diff --git a/scripts/config/lxdialog/check-lxdialog.s

Re: [LEDE-DEV] [patch master 13/15] To read lines rather than words, pipe/redirect to a 'while read' loop

2016-10-02 Thread Jan-Tarek Butt
Hi, On 10/01/16 11:09, Oswald Buddenhagen wrote: > On Sat, Oct 01, 2016 at 12:44:36AM +0200, Lars Kruse wrote: >> Am Fri, 30 Sep 2016 22:02:27 +0200 schrieb Jan-Tarek Butt : >> >>> --- >>> scripts/deptest.sh | 8 >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/sc

Re: [LEDE-DEV] [patch master 14/15] Expressions don't expand in single quotes, use double quotes for that

2016-10-02 Thread Jan-Tarek Butt
Hi Lars, > > I think, this is just a change based on style preferences, or? > Using single quotes specifically for situation where expansion is not intended > feels quite explicite and clear to me - thus personally I would prefer to > stick > with single quotes instead of double quotes combined

[LEDE-DEV] [PATCH v2] read without -r will mangle backslashes

2016-10-02 Thread Jan-Tarek Butt
--- scripts/clean-package.sh | 4 ++-- scripts/rstrip.sh| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index 2de3c51..0940732 100755 --- a/scripts/clean-package.sh +++ b/scripts/clean-package.sh @@ -10,14 +10,14 @@

Re: [LEDE-DEV] [patch master 13/15] To read lines rather than words, pipe/redirect to a 'while read' loop

2016-10-02 Thread Lars Kruse
Hi Oswald, Am Sat, 1 Oct 2016 11:09:48 +0200 schrieb Oswald Buddenhagen : > this won't work, because it makes the loop body a subshell, and thus the > assignment of SELECTED will get lost. Right. I missed that. > to achieve the goal with minimal effort, adding > > local IFS=$'\n' > > pri

Re: [LEDE-DEV] [patch master 05/15] Use cd ... || exit in case cd fails

2016-10-02 Thread Lars Kruse
Hi Jan-Tarek, Am Sat, 1 Oct 2016 21:37:14 +0200 schrieb Jan-Tarek Butt : > > I am not sure, if this script is supposed to break on every missing libdir > > (I > > do not know the context). Thus maybe " && " would be better instead ";"? > > This would prevent unwanted directories (e.g. the curre

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-10-02 Thread Lars Kruse
Hello Oswald, Am Sat, 1 Oct 2016 09:35:47 +0200 schrieb Oswald Buddenhagen : > On Fri, Sep 30, 2016 at 11:50:09PM +0200, Lars Kruse wrote: > > Am Fri, 30 Sep 2016 22:02:15 +0200 schrieb Jan-Tarek Butt : > > > [...] > > > > Just out of curiosity: do you know, what could be the purpose of t

Re: [LEDE-DEV] [patch master 00/15] shell code improvement for /scripts

2016-10-02 Thread Bastian Bittorf
* Jan-Tarek Butt [02.10.2016 17:48]: > I did some bugfixing and code quality improvement for > all shell scrips inside the dir ./scripts. thanks for the work, but for now i'am against merging it: we discussed all (and more) of these changes during battlemesh and we agreed to *first* have an auto

Re: [LEDE-DEV] Automated shell code debugging

2016-10-02 Thread Bastian Bittorf
* Jan-Tarek Butt [02.10.2016 17:48]: > As a part of code quallity enhancemend and prevenition. We can do an ondemand > daemon as engine to > check all shell scrips. We can use the opensource Project shellcheck [0]. > > My idea is to do an insatnce on a server: > This insatnce can pull the lede r

Re: [LEDE-DEV] [wiki]Wiki structure proposals and some questions

2016-10-02 Thread Rich Brown
Two items re: wiki 1) I finished importing the entire www.lede-project.org site into the wiki. You can see the current (draft) pages at: https://wiki.lede-project.org/playground:experiment:docs:start 2) I added a comment about potential organization at: https://wiki.lede-project.org/talk:to_do

Re: [LEDE-DEV] [patch master 05/15] Use cd ... || exit in case cd fails

2016-10-02 Thread Bastian Bittorf
* Felix Fietkau [02.10.2016 17:48]: > >> +[ -n "$TOPDIR" ] && cd "$TOPDIR" || exit > >> > > these two are plain broken, as the script would just exit if TOPDIR is > > empty. you need to use braces. > I think a better approach would be to write a wrapper for cd, making it > easier to read and rev

[LEDE-DEV] [PATCH] package/uboot-envtools.sh remove function vals and fix indentation

2016-10-02 Thread Jan-Tarek Butt
--- package/boot/uboot-envtools/files/uboot-envtools.sh | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/package/boot/uboot-envtools/files/uboot-envtools.sh b/package/boot/uboot-envtools/files/uboot-envtools.sh index e21b283..ad41e07 100644 --- a/package/

[LEDE-DEV] Adding support for dlink dwr-512

2016-10-02 Thread Giuseppe Lippolis
Hi all, I'm trying to port lede to the dwr-512. I'm using the latest trunk downloaded with git clone https://git.lede-project.org/source.git The dwr-512 oem bootloader accept a firmware image that shall be processed with a dlink tool called binboy and need the binary_kernel_image (lzma compressed

Re: [LEDE-DEV] Adding support for dlink dwr-512

2016-10-02 Thread Mathias Kresin
02.10.2016 21:10, Giuseppe Lippolis: Hi all, I'm trying to port lede to the dwr-512. I'm using the latest trunk downloaded with git clone https://git.lede-project.org/source.git The dwr-512 oem bootloader accept a firmware image that shall be processed with a dlink tool called binboy and need th

[LEDE-DEV] [PATCH] LuaSrcDiet call define for lua code Minifying

2016-10-02 Thread Jan-Tarek Butt
Hi, This patch makes able to minify lua code sequential inside directories. Here is an example how do can call it in package Makefiles: Just call the following command inside the package compile define. $(call LuaSrcDiet,./luasrc,$(PKG_BUILD_DIR)/luadest/) luasrc can have subdirectorys there wil

[LEDE-DEV] [PATCH] add luaSrcDiet call define to package.mk

2016-10-02 Thread Jan-Tarek Butt
--- include/package.mk | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/include/package.mk b/include/package.mk index fa5c4e7..fb76057 100644 --- a/include/package.mk +++ b/include/package.mk @@ -5,6 +5,8 @@ # See /LICENSE for more information. # +# Depende

[LEDE-DEV] Default kernel config and CONFIG_LEDS_TRIGGER_*

2016-10-02 Thread Rafał Miłecki
Hi, I noticed we have few triggers enabled by default: $ grep "CONFIG_LEDS_TRIGGER_.*=y" ./target/linux/generic/config-4.4 CONFIG_LEDS_TRIGGER_DEFAULT_ON=y CONFIG_LEDS_TRIGGER_NETDEV=y CONFIG_LEDS_TRIGGER_TIMER=y At the same time we have packages for them: # CONFIG_PACKAGE_kmod-ledtrig-default-on

Re: [LEDE-DEV] Adding support for dlink dwr-512

2016-10-02 Thread Giuseppe Lippolis
Dear Mathias, thanks for your info. Just a couple of question before to proceed. 1) From my understanding the append-dtb seems to append the dtb after the kernel. But in this way in my opinion the kernel cannot point to the dbt (remember that currently It seems that the oem bootloader cannot pass

Re: [LEDE-DEV] Adding support for dlink dwr-512

2016-10-02 Thread Mathias Kresin
02.10.2016 23:08, Giuseppe Lippolis: Dear Mathias, thanks for your info. Just a couple of question before to proceed. 1) From my understanding the append-dtb seems to append the dtb after the kernel. But in this way in my opinion the kernel cannot point to the dbt (remember that currently It se

[LEDE-DEV] [PATCH] owl-loader: allow 4KiB EEPROMs

2016-10-02 Thread Martin Blumenstingl
This was discovered by Mathias Kresin while he was doing a small review of the owl-loader code (by comparing it with some changes that we made before the owl-loader was accepted). The size check currently seems to fail for EEPROMs with 4KiB. Unfortunately I do not have a device with 4KiB EEPROM,

[LEDE-DEV] [PATCH] kernel: owl-loader: fix EEPROM size validation for 4KiB EEPROMs

2016-10-02 Thread Martin Blumenstingl
The validation of the received EEPROM data uses struct firmware's size field, which contains the size in bytes. ath9k_platform_data's eeprom_data field however is an u16 array with 2048 elements. Using a simple sizeof(pdata->eeprom_data) returns the array size (2048 in our case). The actual maximum

[LEDE-DEV] [RFC] build: use CXXFLAGS if defined

2016-10-02 Thread Hauke Mehrtens
Instead of using TARGET_CFLAGS and EXTRA_CFLAGS in cmake and scons build use the TARGET_CXXFLAGS and EXTRA_CXXFLAGS like it is done for normal make and configure. configure used TARGET_CXXFLAGS and EXTRA_CFLAGS for the CXXFLAGS. The package-default.mk sets "EXTRA_CXXFLAGS = $(EXTRA_CFLAGS)" so usin

Re: [LEDE-DEV] o2 box 6431 / VGV7510KW22 - SIP with FXS/TAE Ports | owsip or alternative ?

2016-10-02 Thread Hauke Mehrtens
On 09/23/2016 09:02 PM, Daniel Golle wrote: > On Fri, Sep 23, 2016 at 08:14:24PM +0200, Dennis Schneck wrote: >> >> >> >> Hello, >> i use the o2 box 6431 / VGV7510KW22 with LEDE r1640. >> Like to use my SIP Accout with the 3x FXS Ports (Analog Phone / TAE Ports) >> >> I read about owsip but can