Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Mathias Kresin
12.12.2017 23:01, Jonas Gorski: > On 12 December 2017 at 21:03, Jo-Philipp Wich wrote: >> Hi Piotr, >> >> my rough idea was to somehow tie the manifest generation to the "define >> Device/*" macros present in the image building code because there you >> have all required information in a central

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Matthias Schiffer
On 12/12/2017 11:01 PM, Jonas Gorski wrote: > On 12 December 2017 at 21:03, Jo-Philipp Wich wrote: >> Hi Piotr, >> >> my rough idea was to somehow tie the manifest generation to the "define >> Device/*" macros present in the image building code because there you >> have all required information in

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Jonas Gorski
On 12 December 2017 at 21:03, Jo-Philipp Wich wrote: > Hi Piotr, > > my rough idea was to somehow tie the manifest generation to the "define > Device/*" macros present in the image building code because there you > have all required information in a central place: > > - unique board identifier >

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Mathias Kresin
12.12.2017 21:02, Piotr Dymacz: On 01.12.2017 16:12, Mathias Kresin wrote: I really doubt that upstream is going to accept vendor prefixes if they aren't used anywhere. I would prefer to use what already exists, add our own prefixes where required and upstream them at the time the dts is send up

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Mathias Kresin
Hey Daniel, sorry for the late reply, I totally missed your mail and only spotted it due to the recent replies. 01.12.2017 22:20, Daniel Golle: On Wed, Nov 29, 2017 at 09:33:39AM +0100, Mathias Kresin wrote: 28.11.2017 19:24, Daniel Golle: Hi Moritz, thanks for stepping forward and adressi

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Piotr Dymacz
Hi Mathias, On 01.12.2017 16:12, Mathias Kresin wrote: Hey Piotr , thanks a lot for thinking about my proposal. Sorry for a very late reply. 2017-12-01 14:30 GMT+01:00 Piotr Dymacz : On 29.11.2017 09:33, Mathias Kresin wrote: 1. fix the compatible strings in the DTS files I think we sho

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Jo-Philipp Wich
Hi Piotr, my rough idea was to somehow tie the manifest generation to the "define Device/*" macros present in the image building code because there you have all required information in a central place: - unique board identifier - image name / build steps - default package selection ~ Jo

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Piotr Dymacz
Hi Jo, On 01.12.2017 14:37, Jo-Philipp Wich wrote: Hi, I still have here some concerns/thoughts: 1. I don't know how to deal in above approach with region variant images but I'm sure we should _somehow_ separate region code from boardname and other parts of the image filename. IMHO, dash char

Re: [LEDE-DEV] fixing of image file names

2017-12-01 Thread Daniel Golle
On Wed, Nov 29, 2017 at 09:33:39AM +0100, Mathias Kresin wrote: > 28.11.2017 19:24, Daniel Golle: > > Hi Moritz, > > > > thanks for stepping forward and adressing this issue. > > It'd be good to include the two assertions added to your list beelow. > > > > On Tue, Nov 28, 2017 at 07:05:23PM +0100

Re: [LEDE-DEV] fixing of image file names

2017-12-01 Thread Mathias Kresin
Hey Piotr , thanks a lot for thinking about my proposal. 2017-12-01 14:30 GMT+01:00 Piotr Dymacz : > On 29.11.2017 09:33, Mathias Kresin wrote: >> 1. fix the compatible strings in the DTS files > > I think we should start at the same time upstreaming vendor prefixes to [1], > to avoid possible in

Re: [LEDE-DEV] fixing of image file names

2017-12-01 Thread Jo-Philipp Wich
Hi, > I still have here some concerns/thoughts: > > 1. I don't know how to deal in above approach with region variant images > but I'm sure we should _somehow_ separate region code from boardname and > other parts of the image filename. IMHO, dash character won't work here. > > 2. We have some b

Re: [LEDE-DEV] fixing of image file names

2017-12-01 Thread Piotr Dymacz
Hello Mathias, On 29.11.2017 09:33, Mathias Kresin wrote: 28.11.2017 19:24, Daniel Golle: Hi Moritz, thanks for stepping forward and adressing this issue. It'd be good to include the two assertions added to your list beelow. On Tue, Nov 28, 2017 at 07:05:23PM +0100, Moritz Warning wrote: Hi,

Re: [LEDE-DEV] fixing of image file names

2017-12-01 Thread Mathias Kresin
30.11.2017 04:20, Luis Araneda: That seems like the correct way to go, but is a lot of work as you mentioned. I can start with the ipq806x and sunxi targets, since they are the ones I am most familiar with. @Mathias: Should I send you the patches to be applied to your staging tree, or to the mai

Re: [LEDE-DEV] fixing of image file names

2017-11-29 Thread Luis Araneda
Hi, > I would like to propose something different which basically aims the same. > > 1. fix the compatible strings in the DTS files > 2. use the compatible string from the DTS in userspace (boardname) > 3. use the compatible string for the image filename (board_name in above > example) > > The DT

Re: [LEDE-DEV] fixing of image file names

2017-11-29 Thread Mathias Kresin
28.11.2017 19:24, Daniel Golle: Hi Moritz, thanks for stepping forward and adressing this issue. It'd be good to include the two assertions added to your list beelow. On Tue, Nov 28, 2017 at 07:05:23PM +0100, Moritz Warning wrote: Hi, I noticed that there are some image file names that do not

Re: [LEDE-DEV] fixing of image file names

2017-11-28 Thread Moritz Warning
I have forked the lede source code started to add some fixes. The commits need to be cleaned up, tested, etc.. If somebody has some fixes, ideas, please let me know: https://github.com/mwarning/source - mwarning On 11/28/2017 07:05 PM, Moritz Warning wrote: > Hi, > > I noticed that there are s

Re: [LEDE-DEV] fixing of image file names

2017-11-28 Thread Daniel Golle
On Tue, Nov 28, 2017 at 08:16:33PM +0100, Moritz Warning wrote: > Ok, > > looks like I should make a patch. :P > > On 11/28/2017 07:24 PM, Daniel Golle wrote: > > Hi Moritz, > > > > thanks for stepping forward and adressing this issue. > > It'd be good to include the two assertions added to your

Re: [LEDE-DEV] fixing of image file names

2017-11-28 Thread Moritz Warning
Ok, looks like I should make a patch. :P On 11/28/2017 07:24 PM, Daniel Golle wrote: > Hi Moritz, > > thanks for stepping forward and adressing this issue. > It'd be good to include the two assertions added to your list beelow. > > On Tue, Nov 28, 2017 at 07:05:23PM +0100, Moritz Warning wrote:

Re: [LEDE-DEV] fixing of image file names

2017-11-28 Thread Henrique de Moraes Holschuh
Em 28/11/17 16:24, Daniel Golle escreveu: thanks for stepping forward and adressing this issue. It'd be good to include the two assertions added to your list beelow. - board_name (in target userspace) == profile (in imagebuilder) == DTS name - image_filename == ${distro}-${target}-${subtar

Re: [LEDE-DEV] fixing of image file names

2017-11-28 Thread Thomas Endt
See also http://lists.infradead.org/pipermail/lede-dev/2017-January/005307.html, where I mentioned some of this and some more. > -Ursprüngliche Nachricht- > Von: Lede-dev [mailto:lede-dev-boun...@lists.infradead.org] Im Auftrag > von Moritz Warning > Gesendet: Dienstag, 28. November 2017 1

Re: [LEDE-DEV] fixing of image file names

2017-11-28 Thread Daniel Golle
Hi Moritz, thanks for stepping forward and adressing this issue. It'd be good to include the two assertions added to your list beelow. On Tue, Nov 28, 2017 at 07:05:23PM +0100, Moritz Warning wrote: > Hi, > > I noticed that there are some image file names that do not follow the > "common" name