Re: [LEDE-DEV] [PATCH v3 00/13] shell code improvement for /scripts

2016-10-27 Thread bittorf wireless )) Bastian Bittorf
* John Crispin [27.10.2016 12:55]: > obvious, additionally i find it hard to believe that alot his stuff > has been properly tested. unless someone steps up and starts reviewing > these patches on the next 1-2 days i will NAK them and ask you to start > resending it in smaller chunks. I'am a

Re: [LEDE-DEV] [PATCH v3 00/13] shell code improvement for /scripts

2016-10-27 Thread John Crispin
Hi, right now i see the chance of this series being merged as very slim. alot of it is very useful. however every patch i have a detailed look at has some minor issues, whether it be the actual formatting, description text not correlating, unrelated changes the purpose of which is not obvious, ...

[LEDE-DEV] [PATCH v3 00/13] shell code improvement for /scripts

2016-10-06 Thread Jan-Tarek Butt
Hi, hopefully now all is clear. SoB should now set by all patches. Also I change the commit messages a bit. If something unclear please tell me. For me that is a good praxis to learn it properly :) cheers Tarek Jan-Tarek Butt (13): scripts: Double quote to prevent globbing and word splitting