Hi,
right now i see the chance of this series being merged as very slim.
alot of it is very useful. however every patch i have a detailed look at
has some minor issues, whether it be the actual formatting, description
text not correlating, unrelated changes the purpose of which is not
obvious, .... additionally i find it hard to believe that alot his stuff
has been properly tested. unless someone steps up and starts reviewing
these patches on the next 1-2 days i will NAK them and ask you to start
resending it in smaller chunks.
John
On 06/10/2016 10:50, Jan-Tarek Butt wrote:
> Hi,
>
> hopefully now all is clear. SoB should now set by all patches.
> Also I change the commit messages a bit.
>
> If something unclear please tell me. For me that is a good
> praxis to learn it properly :)
>
> cheers
> Tarek
>
> Jan-Tarek Butt (13):
> scripts: Double quote to prevent globbing and word splitting
> scripts: fix formatting
> scripts: add and fix shebang
> scripts: $/${} is unnecessary on arithmetic variables
> scripts: Use cd ... || exit in case cd fails
> scripts: redirect matters, the 2>&1 has to be last
> scripts: Quote to prevent word splitting
> scripts: Use $(..) instead of legacy `..`
> scripts: Argument mixes string and array. Use $*
> scripts: quote literal {
> scripts: using { cmd1; cmd2; } >> file instead of individual redirects
> scripts: use * instead of @ to concatenate
> scripts: read without -r will mangle backslashes
>
> scripts/arm-magic.sh | 11 ++-
> scripts/clean-package.sh | 7 +-
> scripts/combined-ext-image.sh | 14 +--
> scripts/combined-image.sh | 4 +-
> scripts/config/lxdialog/check-lxdialog.sh | 20 ++--
> scripts/deptest.sh | 20 ++--
> scripts/diffconfig.sh | 18 ++--
> scripts/ext-toolchain.sh | 153
> +++++++++++++++++-------------
> scripts/flashing/flash.sh | 16 ++--
> scripts/freebsd.sh | 1 +
> scripts/gen-dependencies.sh | 14 +--
> scripts/get_source_date_epoch.sh | 4 +-
> scripts/getver.sh | 14 +--
> scripts/ipkg-make-index.sh | 14 +--
> scripts/make-ipkg-dir.sh | 6 +-
> scripts/mkits.sh | 8 +-
> scripts/om-fwupgradecfg-gen.sh | 26 ++---
> scripts/patch-kernel.sh | 26 ++---
> scripts/patch-specs.sh | 2 +-
> scripts/relink-lib.sh | 4 +-
> scripts/rstrip.sh | 16 ++--
> scripts/strip-kmod.sh | 8 +-
> scripts/sysupgrade-tar.sh | 2 +-
> scripts/ubinize-image.sh | 20 ++--
> 24 files changed, 229 insertions(+), 199 deletions(-)
>
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
