Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2017-01-02 Thread Jo-Philipp Wich
Hi Florian, ACK from me on this one. I think it makes sense. ~ Jo ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-27 Thread Florian Fainelli
On 12/27/2016 02:13 PM, Christian Schoenebeck wrote: > Am 27.12.2016 um 21:15 schrieb Florian Fainelli: >> >> On 12/27/2016 12:07 PM, Christian Schoenebeck wrote: >>> In general that's right, but disabling all postinst(-pkg) and prerm(-pkg) >>> is more than awful. >>> If base-files not selected yo

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-27 Thread Christian Schoenebeck
Am 27.12.2016 um 21:15 schrieb Florian Fainelli: > > On 12/27/2016 12:07 PM, Christian Schoenebeck wrote: >> In general that's right, but disabling all postinst(-pkg) and prerm(-pkg) is >> more than awful. >> If base-files not selected you should nevertheless call postinst-/prerm-pkg. > > To wha

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-27 Thread Florian Fainelli
(please stop top-posting). On 12/27/2016 12:07 PM, Christian Schoenebeck wrote: > In general that's right, but disabling all postinst(-pkg) and prerm(-pkg) is > more than awful. > If base-files not selected you should nevertheless call postinst-/prerm-pkg. To what purpose is that helpful? base-f

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-27 Thread Christian Schoenebeck
In general that's right, but disabling all postinst(-pkg) and prerm(-pkg) is more than awful. If base-files not selected you should nevertheless call postinst-/prerm-pkg. Otherwise their is no real chance to work without base-files whatever you do in package Makefile. Am 27.12.2016 um 21:00 schr

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-27 Thread Florian Fainelli
On 12/27/2016 11:32 AM, Christian Schoenebeck wrote: > Do you really think this is a good idea ? > If base-files package is not selected, the postinst-pkg and prerm-pkg of none > of the other selected packages will be called. > It's nice to suppress error messages but to switch off all postinst an

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-27 Thread Christian Schoenebeck
Also keep in mind my pull https://github.com/lede-project/source/pull/618 Am 26.12.2016 um 20:53 schrieb Florian Fainelli: > Le 12/09/16 à 16:04, Florian Fainelli a écrit : >> If the base-files package is not selected, we will fail executing the >> very first postinst script: >> >> make[3]: Leavin

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-27 Thread Christian Schoenebeck
Do you really think this is a good idea ? If base-files package is not selected, the postinst-pkg and prerm-pkg of none of the other selected packages will be called. It's nice to suppress error messages but to switch off all postinst and prerm defined inside Makefile of any selected package in n

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-26 Thread Florian Fainelli
Le 12/09/16 à 16:04, Florian Fainelli a écrit : > If the base-files package is not selected, we will fail executing the > very first postinst script: > > make[3]: Leaving directory `/local/users/fainelli/openwrt/trunk' > cp -fpR > /local/users/fainelli/openwrt/trunk/build_dir/target-arm_xscale_mus

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-18 Thread Florian Fainelli
On 12/09/2016 04:04 PM, Florian Fainelli wrote: > If the base-files package is not selected, we will fail executing the > very first postinst script: > > make[3]: Leaving directory `/local/users/fainelli/openwrt/trunk' > cp -fpR > /local/users/fainelli/openwrt/trunk/build_dir/target-arm_xscale_m

[LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-09 Thread Florian Fainelli
If the base-files package is not selected, we will fail executing the very first postinst script: make[3]: Leaving directory `/local/users/fainelli/openwrt/trunk' cp -fpR /local/users/fainelli/openwrt/trunk/build_dir/target-arm_xscale_musl-1.1.15_eabi/root-orion /local/users/fainelli/openwrt/trunk