On 12/27/2016 02:13 PM, Christian Schoenebeck wrote: > Am 27.12.2016 um 21:15 schrieb Florian Fainelli: >> >> On 12/27/2016 12:07 PM, Christian Schoenebeck wrote: >>> In general that's right, but disabling all postinst(-pkg) and prerm(-pkg) >>> is more than awful. >>> If base-files not selected you should nevertheless call postinst-/prerm-pkg. >> >> To what purpose is that helpful? base-files is deselected, not much is >> going to work anyway. >> >> What do you suggest as a change we make to keep builds working even if >> base-files is deselected and satisfy running scripts at the same time? >> > > If it's not planned to disable base-files then it should be a NOT > de-selectable package. > So the whole build should depend on base-files i.e. as part of > PKG_DEFAULT_DEPENDS or similar or as a "hidden" package. > But never suppress error messages.
This is not a great idea IMHO, the default should of course include base-files, but it should be possible (for the reasons outlined before) to not have base-files selected all, yet benefit from OpenWrt to have built you a toolchain, kernel, applications, etc. you might not just want the whole Linux distribution from it for a specific test. > In my opinion OpenWRT/LEDE needs base-files otherwise the build system became > inconsistent. It's not the build system per-se that becomes inconsistent, it's the user experience as a consequence of utilizing packages that becomes such. > > If it's really planned to still allow to disable base-files then I do not see > any reason why my pull request at > https://github.com/lede-project/source/pull/618 was disagreed because it > might produce inconsistency. > During build it should already help to disable default_postinst/_prerm and > dependency of /lib/functions.sh > So you can disable base-files without errors during install but still running > postinst-/prerm-pkg. I don't disagree with what you are saying, and I don't think your changes are irrelevant nor anything, but I am trying to fix a build error that I met while purposely disabling base-files, whereas your goal is entirely different it seems. Anyway, I don't have energy to argue about whether this patch should be accepted or not, so it can rejected, all I ask is to have patchwork and the git repository be in sync about the decision being made... > > I don't know if this pull/option helps in your use cases. > >>> Otherwise their is no real chance to work without base-files whatever you >>> do in package Makefile. >>> >>> Am 27.12.2016 um 21:00 schrieb Florian Fainelli: >>>> base-files can be deselected (and it should remain that way), in which >>>> case you cannot complete an OpenWrt build because we stop with the >>>> errors mentioned below, fixing that alone has value IMHO. >>>> >>>> It seems reasonable to expect that nothing in your system that relies on >>>> base-files can be working, the use case for a system without base-files >>>> can be: a) replacement of the full OpenWrt/LEDE user-space with >>>> something custom, b) build testing/combination coverage (how this was >>>> caught here), c) minimal system getting you to a prompt without starting >>>> anything. >>>> >> >> -- Florian _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
