Re: [LEDE-DEV] anonymous stats / was: Release Candidate Test Plan - first draft

2017-02-07 Thread Lars Kruse
Hi, Am Tue, 7 Feb 2017 08:39:53 -0800 schrieb Etienne Champetier : > [..] > Haven't looked how debian and others are doing telemetry Debian uses the package "popularity contest". It submits the ist of installed (and based on file timestamps: used) packages along with a unique host ID (AFAIK). T

Re: [LEDE-DEV] DMARC related mass bounces / disabled subscriptions

2016-12-14 Thread Lars Kruse
Hi Michael, Am Wed, 14 Dec 2016 09:29:18 -0500 schrieb Michael Richardson : > Jo-Philipp Wich wrote: > > a recent mailing list post from a DMARC enabled domain caused a large > > flood of bounces from various mail providers, causing an automatic > > disabling of about 190 subscripti

Re: [LEDE-DEV] can I have some feedback about a wrapper to call initscripts

2016-11-22 Thread Lars Kruse
Hi, Am Tue, 22 Nov 2016 10:12:53 - schrieb Karl Palsson : > [..] > The life of the "service start|stop|status" really wasn't > very long. I just looked up the changelog of sysvinit-utils in Debian: this wrapper was introduced in 2009. Seven years is not that bad, I guess. Anyway: the wrapp

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-10-02 Thread Lars Kruse
Hello Oswald, Am Sat, 1 Oct 2016 09:35:47 +0200 schrieb Oswald Buddenhagen : > On Fri, Sep 30, 2016 at 11:50:09PM +0200, Lars Kruse wrote: > > Am Fri, 30 Sep 2016 22:02:15 +0200 schrieb Jan-Tarek Butt : > > > [...] > > > > Just out of curiosity: do you know

Re: [LEDE-DEV] [patch master 05/15] Use cd ... || exit in case cd fails

2016-10-02 Thread Lars Kruse
Hi Jan-Tarek, Am Sat, 1 Oct 2016 21:37:14 +0200 schrieb Jan-Tarek Butt : > > I am not sure, if this script is supposed to break on every missing libdir > > (I > > do not know the context). Thus maybe " && " would be better instead ";"? > > This would prevent unwanted directories (e.g. the curre

Re: [LEDE-DEV] [patch master 13/15] To read lines rather than words, pipe/redirect to a 'while read' loop

2016-10-02 Thread Lars Kruse
Hi Oswald, Am Sat, 1 Oct 2016 11:09:48 +0200 schrieb Oswald Buddenhagen : > this won't work, because it makes the loop body a subshell, and thus the > assignment of SELECTED will get lost. Right. I missed that. > to achieve the goal with minimal effort, adding > > local IFS=$'\n' > > pri

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-09-30 Thread Lars Kruse
Hi Jan-Tarek, Am Sat, 1 Oct 2016 01:27:24 +0200 schrieb Jan-Tarek Butt : > > Is there a reason for not adding quotes for CE_VERSION and FILE_NUM? > > bacause there just nummeric. personally I would add quotes wherever possible. They would not hurt here. Whenever I will read the above line

Re: [LEDE-DEV] Build ar71xx / 4MB with IPv6, Luci, OpenVPN (PolarSSL), Command, Watchcat, relay and printk without debug ?

2016-09-30 Thread Lars Kruse
Hello Daniel, Am Fri, 30 Sep 2016 18:39:39 +0300 schrieb Daniel Petre : > > CONFIG_TARGET_ROOTFS_SQUASHFS=y > > CONFIG_TARGET_SQUASHFS_BLOCK_SIZE=256 > > > > You could try setting the blocksize to 1024 - this should make a > > noticeable difference as squashfs can compress better. > > Awesome

Re: [LEDE-DEV] Automated shell code debugging

2016-09-30 Thread Lars Kruse
Hi, Am Sat, 1 Oct 2016 00:11:23 +0200 schrieb Martin Tippmann : > [..] > I'm not a shell pro but I found it very difficult to impossible to > write something that passes without any hints/errors. > > There is a way to avoid this by using special comments that prevent > shellcheck from nagging a

Re: [LEDE-DEV] [patch master 14/15] Expressions don't expand in single quotes, use double quotes for that

2016-09-30 Thread Lars Kruse
Hi Jan-Tarek, I think, this is just a change based on style preferences, or? Using single quotes specifically for situation where expansion is not intended feels quite explicite and clear to me - thus personally I would prefer to stick with single quotes instead of double quotes combined with esca

Re: [LEDE-DEV] [patch master 13/15] To read lines rather than words, pipe/redirect to a 'while read' loop

2016-09-30 Thread Lars Kruse
Hi, Am Fri, 30 Sep 2016 22:02:27 +0200 schrieb Jan-Tarek Butt : > --- > scripts/deptest.sh | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/scripts/deptest.sh b/scripts/deptest.sh > index 8c859ef..0b0e7a9 100755 > --- a/scripts/deptest.sh > +++ b/scripts/deptest

Re: [LEDE-DEV] [patch master 12/15] use * instead of @ to concatenate

2016-09-30 Thread Lars Kruse
Hi Jan-Tarek, Am Fri, 30 Sep 2016 22:02:26 +0200 schrieb Jan-Tarek Butt : > - cc="$@" > + cc="$*" as far as I understand $* and $@, there should be no difference in this context, or? Cheers, Lars ___ Lede-dev mailing list Led

Re: [LEDE-DEV] [patch master 11/15] Consider using { cmd1; cmd2; } >> file instead of individual redirects

2016-09-30 Thread Lars Kruse
Hi Jan-Tarek, Am Fri, 30 Sep 2016 22:02:25 +0200 schrieb Jan-Tarek Butt : > --- > scripts/config/lxdialog/check-lxdialog.sh | 16 +++- > scripts/diffconfig.sh | 16 +++- > scripts/ext-toolchain.sh | 43 > +-- 3 file

Re: [LEDE-DEV] [patch master 10/15] quote literal {

2016-09-30 Thread Lars Kruse
Hi Jan-Tarek, Am Fri, 30 Sep 2016 22:02:24 +0200 schrieb Jan-Tarek Butt : > --- > scripts/getver.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/getver.sh b/scripts/getver.sh > index f8b4ed3..27f246e 100755 > --- a/scripts/getver.sh > +++ b/scripts/getve

Re: [LEDE-DEV] [patch master 07/15] Quote to prevent word splitting

2016-09-30 Thread Lars Kruse
Hi Jan-Tarek, Am Fri, 30 Sep 2016 22:02:21 +0200 schrieb Jan-Tarek Butt : > diff --git a/scripts/strip-kmod.sh b/scripts/strip-kmod.sh > index ef35b82..2946408 100755 > --- a/scripts/strip-kmod.sh > +++ b/scripts/strip-kmod.sh > @@ -50,6 +50,6 @@ $3 && $2 ~ /[brtd]/ && $3 !~ /\$LC/ && !def[$3] {

Re: [LEDE-DEV] [patch master 06/15] redirect matters, the 2>&1 has to be last.

2016-09-30 Thread Lars Kruse
Hi, Am Fri, 30 Sep 2016 22:02:20 +0200 schrieb Jan-Tarek Butt : > --- > scripts/make-ipkg-dir.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/make-ipkg-dir.sh b/scripts/make-ipkg-dir.sh > index 529e430..9e38df5 100755 > --- a/scripts/make-ipkg-dir.sh > +

Re: [LEDE-DEV] [patch master 05/15] Use cd ... || exit in case cd fails

2016-09-30 Thread Lars Kruse
Hi, Am Fri, 30 Sep 2016 22:02:19 +0200 schrieb Jan-Tarek Butt : > diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh > index 5cae341..9efcac5 100755 > --- a/scripts/clean-package.sh > +++ b/scripts/clean-package.sh > @@ -8,14 +8,14 @@ > exit 1 > } > cat "$1" | ( > - cd

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-09-30 Thread Lars Kruse
Hi Jan-Tarek, first of all: I am very happy to see your patches! Whenever I took a look at some shell scripts in openwrt, I felt the strong urge to change many of the things you went out to fix. But until now I was always stopped by the sheer amount of changes necessary. Thank you! Am Fri, 30 Se

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt userspace git repo location

2016-09-28 Thread Lars Kruse
Hello Valent, Am Wed, 28 Sep 2016 13:25:20 +0200 schrieb "valent.turko...@gmail.com" : > Github has become de facto standard for contributing to open source > projects, so no matter if you hate it or love it, this is just now the > new norm. > Going against the "norm" is seen by potential contri

Re: [LEDE-DEV] lede integration issues remaining from the detrius of cerowrt

2016-06-12 Thread Lars Kruse
Hi Dave, Am Sun, 12 Jun 2016 08:23:04 -0700 schrieb Dave Taht : > Groovy. There are quite a few other devices that have POE (edgerouter > is the first that comes to mind), perhaps this can be built on > generically? here should be the proper place (it was changed after my patch): https://git.

Re: [LEDE-DEV] lede integration issues remaining from the detrius of cerowrt

2016-06-11 Thread Lars Kruse
Hi Dave, > D) https://github.com/dtaht/ceropackages-3.10/tree/master/utils/nanom5poe > > I don't know what landed upstream to control poe for the nano-m5 > radios, if anything? I submitted a patch (that was accepted) for GPIO-based POE control - at least for Nanostations XM/XW and for TP-Link CP