Hi Karl,
this comment is completely devoid any usefulness. let me help by
rephrasing it to make it useful.
"Hi community,
i have noticed that it is common practice to not annotate the upstream
changes properly in commit bumping the git hash of packages. i feel that
it would be much better if we
On 12/01/2016 11:18 PM, Mathias Kresin wrote:
02.12.2016 06:28, J Mo:
On 11/27/2016 02:29 AM, Mathias Kresin wrote:
I asked you three (!) times to _explain_ what this code should do
[0][1][2]. Now I see the very same code again without having ever seen
the requested explanation.
This stil
Brings in the following changes:
41b526884030 dhcpv6-ia : Fix static DHCPv6 assignments becoming non static
be6c5159a46b dhcpv6-ia: Fix assignment of static DHCPv6 leases
374dc3f13623 cmake: Find libubox/uloop.h
01c919c49ccb odhcpd: Display infinite valid lifetime as -1
Signed-off-by: Florian Fai
On 12/04/2016 03:17 PM, Karl Palsson wrote:
>
> Florian Fainelli wrote:
>> On 12/04/2016 02:53 PM, Karl Palsson wrote:
>>> Care to explain what you're updating? This patch is completely
>>> devoid of useful information without resorting to external
>>> sources. Surely, you have motivation for upd
Florian Fainelli wrote:
> On 12/04/2016 02:53 PM, Karl Palsson wrote:
> > Care to explain what you're updating? This patch is completely
> > devoid of useful information without resorting to external
> > sources. Surely, you have motivation for updating?
>
> Having this commit below, and the oth
Fixes:
uclient-http.c:385:8: error: ignoring return value of 'fread', declared with
attribute warn_unused_result [-Werror=unused-result]
fread(&val, sizeof(val), 1, f);
^
uclient-fetch.c: In function 'main':
uclient-fetch.c:664:12: error: ignoring return value of 'asprintf', declared
libfstools/rootdisk.c: In function 'rootdisk_volume_identify':
libfstools/rootdisk.c:172:7: error: ignoring return value of 'fread', declared
with attribute warn_unused_result [-Werror=unused-result]
fread(&magic, sizeof(magic), 1, f);
^
libfstools/rootdisk.c:179:7: error: ignoring return
On 12/04/2016 02:53 PM, Karl Palsson wrote:
> Care to explain what you're updating? This patch is completely
> devoid of useful information without resorting to external
> sources. Surely, you have motivation for updating?
Having this commit below, and the other two make on top which are
bugfixes
Care to explain what you're updating? This patch is completely
devoid of useful information without resorting to external
sources. Surely, you have motivation for updating?
Sincerely,
Karl Palsson
Florian Fainelli wrote:
> Signed-off-by: Florian Fainelli
> ---
> package/network/services/odhcp
Le 12/04/16 à 07:14, John Crispin a écrit :
>
>
> On 03/12/2016 18:58, Florian Fainelli wrote:
>> Fixes:
>>
>> uclient-http.c:385:8: error: ignoring return value of 'fread', declared with
>> attribute warn_unused_result [-Werror=unused-result]
>>fread(&val, sizeof(val), 1, f);
>> ^
>
On 03/12/2016 18:58, Florian Fainelli wrote:
> Fixes:
>
> uclient-http.c:385:8: error: ignoring return value of 'fread', declared with
> attribute warn_unused_result [-Werror=unused-result]
>fread(&val, sizeof(val), 1, f);
> ^
>
> uclient-fetch.c: In function 'main':
> uclient-fetc
On 03/12/2016 18:32, Florian Fainelli wrote:
> libfstools/rootdisk.c: In function 'rootdisk_volume_identify':
> libfstools/rootdisk.c:172:7: error: ignoring return value of 'fread',
> declared with attribute warn_unused_result [-Werror=unused-result]
> fread(&magic, sizeof(magic), 1, f);
>
12 matches
Mail list logo
