[LEDE-DEV] [PATCH] [rebased] fstools: added f2fs to block

2016-10-27 Thread Alberto Bursi
added code to block so it can recognize and operate the filesystem checker of f2fs added f2fs to the filesystem whitelist of block so it can mount it on /overlay at boot. Signed-off-by: Alberto Bursi --- block.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --gi

Re: [LEDE-DEV] OpenVPN capath + cafile uci options

2016-10-27 Thread John Crispin
On 27/10/2016 20:29, p.wa...@gmx.at wrote: > Hi John, > > yesterday I've looked into the feature request for adding OpenVPN's "capath" > option > to uci. Just a comment on today's changes in > /package/network/services/openvpn/files/openvpn.init: > > -) there's no such option like "cafile"; t

[LEDE-DEV] OpenVPN capath + cafile uci options

2016-10-27 Thread p . wassi
Hi John, yesterday I've looked into the feature request for adding OpenVPN's "capath" option to uci. Just a comment on today's changes in /package/network/services/openvpn/files/openvpn.init: -) there's no such option like "cafile"; the option to pass a CA file is called "ca" and is already

Re: [LEDE-DEV] [PATCH] brcm47xx: add support for per-device rootfs

2016-10-27 Thread John Crispin
On 24/10/2016 21:33, Rafał Miłecki wrote: > From: Rafał Miłecki > > Signed-off-by: Rafał Miłecki Acked-by: John Crispin > --- > target/linux/brcm47xx/image/Makefile | 99 > ++-- > 1 file changed, 95 insertions(+), 4 deletions(-) > > diff --git a/target/li

Re: [LEDE-DEV] [PATCH v3 00/13] shell code improvement for /scripts

2016-10-27 Thread bittorf wireless )) Bastian Bittorf
* John Crispin [27.10.2016 12:55]: > obvious, additionally i find it hard to believe that alot his stuff > has been properly tested. unless someone steps up and starts reviewing > these patches on the next 1-2 days i will NAK them and ask you to start > resending it in smaller chunks. I'am a

Re: [LEDE-DEV] [PATCH] initramfs: Escape colons in depfile

2016-10-27 Thread John Crispin
Hi, this seems to be a backport for the kernel tree. please resend it as a patch adding the actual patch that is being backported to the generic targets patch folder. this would need to be done for 3.18, 4.1 and 4.4 John On 23/09/2016 10:35, Michal Marek wrote: > Special characters are p

Re: [LEDE-DEV] [PATCH] base-files: sysfixtime: Allow system time in local timezones

2016-10-27 Thread John Crispin
On 21/10/2016 10:31, Petr Štetiar wrote: > Daniel Dickinson [2016-10-20 16:47:09]: > >> On Wed, 19 Oct 2016 22:05:43 +0200 >> Petr Štetiar wrote: >> >>> Felix Fietkau [2016-10-19 21:44:06]: >>> I'd like to know why you need to use local time for the RTC, I think that's rather uncomm

[LEDE-DEV] [PATCH] fstools: added f2fs to block-mount, rebased

2016-10-27 Thread Alberto Bursi
added the code to recognize and operate the filesystem checker of f2fs added f2fs to the filesystem whitelist of block so it can mount it on /overlay at boot. Signed-off-by: Alberto Bursi --- block.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/block.c b

Re: [LEDE-DEV] [PATCH 1/1] package/utils: Add beep package

2016-10-27 Thread John Crispin
Hi, after some time considering i am against merging this into trunk. there are no direct users and no hardware that wont function without. please submit the package as a PR to the packages feed. John On 19/10/2016 16:59, Chris Blake wrote: > This adds the "beep" binary as a package to L

Re: [LEDE-DEV] [PATCH v3 02/13] scripts: fix formatting

2016-10-27 Thread John Crispin
patch looks good but subject and description do not match John On 06/10/2016 10:50, Jan-Tarek Butt wrote: > remove whitespaces on end of lines > > Signed-off-by: Jan-Tarek Butt > --- > scripts/combined-ext-image.sh | 4 ++-- > scripts/flashing/flash.sh | 6 +++--- > scripts/patch

Re: [LEDE-DEV] [PATCH] fstools: added f2fs to block-mount, rebased

2016-10-27 Thread John Crispin
Hi subject is bad. the f2fs support is added to the block tool and not block-mount. the "rebased needs to go to the front with the subject-prefix or go below the tear line one more comment inline On 27/10/2016 11:10, Alberto Bursi wrote: > added the code to recognize and operate the filesystem

Re: [LEDE-DEV] [PATCH v3 03/13] scripts: add and fix shebang

2016-10-27 Thread John Crispin
patch looks good, the subject is just silly and the description is missing John On 06/10/2016 10:50, Jan-Tarek Butt wrote: > Signed-off-by: Jan-Tarek Butt > --- > scripts/freebsd.sh | 1 + > scripts/om-fwupgradecfg-gen.sh | 2 +- > 2 files changed, 2 insertions(+), 1 deletio

Re: [LEDE-DEV] [PATCH v3 00/13] shell code improvement for /scripts

2016-10-27 Thread John Crispin
Hi, right now i see the chance of this series being merged as very slim. alot of it is very useful. however every patch i have a detailed look at has some minor issues, whether it be the actual formatting, description text not correlating, unrelated changes the purpose of which is not obvious, ...

Re: [LEDE-DEV] [PATCH v3 01/13] scripts: Double quote to prevent globbing and word splitting

2016-10-27 Thread John Crispin
patch looks good but is imho autogenerated and most likely not thoroughly runtime tested. John On 06/10/2016 10:50, Jan-Tarek Butt wrote: > Signed-off-by: Jan-Tarek Butt > --- > scripts/arm-magic.sh | 11 ++- > scripts/clean-package.sh | 2 +- > scripts/comb