Re: [PATCH] kvm-kmod: Various compat fixes for older kernels

2009-05-26 Thread Amit Shah
On (Tue) May 26 2009 [10:49:35], Avi Kivity wrote: > I had these two already, but not pushed. Maybe I need to have a script > push my master branch somewhere, so you don't duplicate my work > needlessly. A 'next' branch that's the real bleeding-edge, while the patches get tested and master get

Re: Status of pci passthrough work?

2009-05-30 Thread Amit Shah
Hi Pablo, On (Fri) May 29 2009 [11:41:58], Passera, Pablo R wrote: > Hi Amit, > > Please correct me if I am wrong, but the fact that the PVDMA module > is located in the guest imposes a security problem. So, if someone in the > guest has root access, he could modify the PVDMA module and

[PATCH] KVM: x86: Ignore reads to K7 EVNTSEL MSRs

2009-06-15 Thread Amit Shah
In commit 7fe29e0faacb650d31b9e9f538203a157bec821d we ignored the reads to the P6 EVNTSEL MSRs. That fixed crashes on Intel machines. Ignore the reads to K7 EVNTSEL MSRs as well to fix this on AMD hosts. This fixes Kaspersky antivirus crashing Windows guests on AMD hosts. Signed-off-by: Amit

Re: [PATCH] add sysenter/syscall emulation for 32bit compat mode

2009-06-16 Thread Amit Shah
up the > processor state accordingly. > The sysenter code was originally sketched by Amit Shah, it was completed, > debugged, syscall added and made-to-work by Christoph Egger and polished > up by Andre Przywara. > Please note that sysret does not need to be emulated, because it wi

Re: [patch] qemu-kvm introduce -maxcpus argument

2009-06-19 Thread Amit Shah
On (Fri) Jun 19 2009 [15:59:57], Jes Sorensen wrote: > Hi, > > This one introduces a -maxcpus setting, allowing the user to specify > the maximum number of vCPUs the system can have, as discussed with Gleb > earlier in the week. ACK, but please fix this: +DEF("maxcpus", HAS_ARG, QEMU_OPTION_maxcp

Re: Checking guest memory pages changes from host userspace

2009-06-19 Thread Amit Shah
On (Fri) Jun 19 2009 [12:09:10], Passera, Pablo R wrote: > Hi list, > I need to monitor some guest memory pages. I need to know if the > information in these pages was changed. For this, I was thinking to mark the > guest memory pages in some way (like write protecting them) so a page fau

virtio-serial: A guest <-> host interface for simple communication

2009-06-23 Thread Amit Shah
Hello, Here are two patches. One implements a virtio-serial device in qemu and the other is the driver for a guest kernel. While working on a vmchannel interface that is needed for communication between guest userspace and host userspace, I saw that most of the interface can be abstracted out as

[PATCH] virtio-serial: virtio device for simple host <-> guest communication

2009-06-23 Thread Amit Shah
al interface is a paravirtualised guest<->host + * communication channel for relaying short messages and events in + * either direction. + * + * There's support for multiple serial channels within one virtio PCI + * device to keep the guest PCI device count low. + * + * Copyright (C) 2009, Red Hat

[PATCH] virtio_serial: A char device for simple guest <-> host communication

2009-06-23 Thread Amit Shah
like this: fd = open("/dev/vmch0", O_RDWR); ret = read(fd, buf, 100); ret = write(fd, string, strlen(string)); ret = ioctl(fd, VIRTIO_SERIAL_IOCTL_GET_PORT_NAME, &port_name); Signed-off-by: Amit Shah --- drivers/char/Kconfig |6

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-23 Thread Amit Shah
On (Tue) Jun 23 2009 [13:55:52], Paul Brook wrote: > > Here are two patches. One implements a virtio-serial device in qemu > > and the other is the driver for a guest kernel. > > So I'll ask again. Why is this separate from virtio-console? I'm basically writing a vmchannel and found out that a lo

Re: virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [13:45:01], Rusty Russell wrote: > On Tue, 23 Jun 2009 10:12:31 pm Amit Shah wrote: > > Hello, > > > > Here are two patches. One implements a virtio-serial device in qemu > > and the other is the driver for a guest kernel. > > > > While w

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [17:40:49], Jamie Lokier wrote: > Amit Shah wrote: > > A few sample uses for a vmchannel are to share the host and guest > > clipboards (to allow copy/paste between a host and a guest), to > > lock the screen of the guest session when the vnc viewer is cl

Re: [PATCH] support colon in filenames

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [09:58:59], Ram Pai wrote: > Problem: It is impossible to feed filenames with the character colon because > qemu interprets such names as a protocol. For example a filename scsi:0, > is interpreted as a protocol by name "scsi". > > This patch allows users to espace colon cha

Re: [PATCH] support colon in filenames

2009-06-24 Thread Amit Shah
(Actually add Eduardo to CC) On (Wed) Jun 24 2009 [22:56:59], Amit Shah wrote: > On (Wed) Jun 24 2009 [09:58:59], Ram Pai wrote: > > Problem: It is impossible to feed filenames with the character colon > > because > > qemu interprets such names as a protocol. For examp

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [18:50:02], Jamie Lokier wrote: > Amit Shah wrote: > > On (Wed) Jun 24 2009 [17:40:49], Jamie Lokier wrote: > > > Amit Shah wrote: > > > > A few sample uses for a vmchannel are to share the host and guest > > > > clipboards (to allow

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [20:20:27], Jamie Lokier wrote: > Amit Shah wrote: > > > > I think the interface from the guest POV stays the same: reads / writes > > to char devices. With virtio-serial, though, we can add a few other > > interesting things like names to ports,

Re: virtio-serial: A guest <-> host interface for simple communication

2009-06-25 Thread Amit Shah
On (Thu) Jun 25 2009 [21:03:02], Rusty Russell wrote: > On Wed, 24 Jun 2009 10:09:37 pm Amit Shah wrote: > > On (Wed) Jun 24 2009 [13:45:01], Rusty Russell wrote: > > > On Tue, 23 Jun 2009 10:12:31 pm Amit Shah wrote: > > > > Hello, > > > > > > &

[PATCH] kvm: x86: ignore reads to perfctr msrs

2009-06-30 Thread Amit Shah
We ignore writes to the perfctr msrs. Ignore reads as well. Kaspersky antivirus crashes Windows guests if it can't read these MSRs. Signed-off-by: Amit Shah --- arch/x86/kvm/x86.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/

Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened

2009-06-30 Thread Amit Shah
On (Mon) Jun 29 2009 [17:04:49], Avi Kivity wrote: > The qcow block driver format is no longer maintained and likely contains > serious data corruptors. Urge users to stay away for it, and advertise > the new and improved replacement. Does this also print the message at the time of creating the i

Re: Does KVM support communication between hypervisor node and guest OS?

2009-07-01 Thread Amit Shah
On (Wed) Jul 01 2009 [22:03:17], Zhang Qian wrote: > Hi, > > I'd like to know if there is a way to communicate the VM's guest OS > from the hypervisor node which hosts the VM. > As you know, Xen provide xenstore command to do it, I can use it to > pass some parameters into guest OS, is there a sim

[PATCH] libkvm: x86: fix memleak if ioctl fails

2009-07-13 Thread Amit Shah
Fix a memleak for when the KVM_SET_CPUID2 ioctl fails. Free the memory that we allocate to store cpuids. Signed-off-by: Amit Shah --- kvm/libkvm/libkvm-x86.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kvm/libkvm/libkvm-x86.c b/kvm/libkvm/libkvm-x86.c index 9ca77d5

Re: [PATCH] libkvm: x86: fix memleak if ioctl fails

2009-07-13 Thread Amit Shah
On (Mon) Jul 13 2009 [11:38:18], Avi Kivity wrote: > On 07/13/2009 11:27 AM, Amit Shah wrote: >> Fix a memleak for when the KVM_SET_CPUID2 ioctl fails. Free the >> memory that we allocate to store cpuids. >> >> > > Applied, thanks. Note that this libkv

[PATCH] qemu-kvm: x86: fix memleak if ioctl fails

2009-07-13 Thread Amit Shah
Fix a memleak when the KVM_SET_CPUID2 ioctl fails. Free the memory that we allocate to store cpuids. Reported-by: Mark McLoughlin Signed-off-by: Amit Shah --- qemu-kvm-x86.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c index daf60b6

Re: KVM: cdrom passthrough?

2009-07-15 Thread Amit Shah
On (Wed) Jul 08 2009 [16:19:27], Dâniel Fraga wrote: > I like very much KVM, but I decided to test Virtualbox and it > has nice features KVM doesn't have. BUT... Virtualbox is orders of > magnitude SLOWER than KVM. Virtualbox just can't compete with KVM > regarding speed. KVM is much, much, m

Re: KVM and kernel 2.6.30 file system madness

2009-07-15 Thread Amit Shah
On (Thu) Jul 09 2009 [08:27:48], Robert Wimmer wrote: > Hi there, > > back in days before kernel 2.6.25/2.6.26 and KVM 70-77 KVM decided to > crash from time to time. That time we used XFS as filesystem (/ and /boot > where ext3/ext2). Since XFS worked so very well for us on physical > hosts the n

Re: qemu-kvm process is running at 100% CPU, but no response from guest

2009-07-15 Thread Amit Shah
On (Thu) Jul 09 2009 [07:18:54], Ján ONDREJ (SAL) wrote: > Hello, > > today I have second incident, that my qemu-kvm process is running at 100% > or 200% CPU (watched using top program), but there is no response from guest > long time (some hours). First time lots of these messages appeared in d

Re: Qemu 0.10.50 CAN NOT get ip from dhcp server

2009-07-15 Thread Amit Shah
On (Mon) Jul 06 2009 [10:13:12], John Wong wrote: > I notice that, when i use qemu 0.10.50 (which from kvm-0.87.tar.gz), the > guest OS CAN NOT get the ip from dhcp server. > When i use qemu 0.10.0 (which from debian's kvm-0.85 package), the guest > OS CAN get the ip from the SAME dhcp server. Thi

Re: KVM and kernel 2.6.30 file system madness

2009-07-15 Thread Amit Shah
On (Wed) Jul 15 2009 [09:52:36], Robert Wimmer wrote: > Hi! > > > Are you using virtio-block? > > Yes. OK, then there is a known problem. I think the fix is waiting to be applied. > > In any case, not using a released version always has risks. > > Well, what do you mean by "not using a release

Re: qemu-kvm process is running at 100% CPU, but no response from guest

2009-07-15 Thread Amit Shah
On (Wed) Jul 15 2009 [09:58:51], Ján ONDREJ (SAL) wrote: > On Wed, Jul 15, 2009 at 12:51:33PM +0530, Amit Shah wrote: > > On (Thu) Jul 09 2009 [07:18:54], Ján ONDREJ (SAL) wrote: > > > PID USER PR NI VIRT RES SHR S %CPU %MEMTIME+ COMMAND > > >

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-16 Thread Amit Shah
On (Wed) Jul 15 2009 [10:40:37], Anthony Liguori wrote: > Blue Swirl wrote: >> Then how about something like: >> -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img >> -drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img >> -drive name=sdb,if=scsi,unit=1,fnarg -

Re: Qemu 0.10.50 CAN NOT get ip from dhcp server

2009-07-16 Thread Amit Shah
On (Wed) Jul 15 2009 [16:54:15], John Wong wrote: > Yes, kvm-88 fixed this problem. > > I also notice another problem, when i use kvm-88(qemu-system-x86_64 with > kvm-kmod-2.6.30.1-rc2.tar.gz) installing 64bit OS (window7 & debian & > netbsd), > the install CD show the error message, say this s

Re: Qemu 0.10.50 CAN NOT get ip from dhcp server

2009-07-16 Thread Amit Shah
On (Thu) Jul 16 2009 [19:44:42], John Wong wrote: > Amit Shah 提到: >> On (Wed) Jul 15 2009 [16:54:15], John Wong wrote: >> >>> Yes, kvm-88 fixed this problem. >>> >>> I also notice another problem, when i use kvm-88(qemu-system-x86_64 >>> with

Re: Qemu 0.10.50 CAN NOT get ip from dhcp server

2009-07-16 Thread Amit Shah
On (Thu) Jul 16 2009 [20:52:36], John Wong wrote: >> >> Any messages in the host kernel's logs? Also can you try running a >> 32-bit VM and report what /proc/cpuinfo shows? I'm assuming you're >> running on a 64 bit host. Can you confirm that? >> > Yes, i installed Debian/32-bit VM, below is "cat /

Re: How much physical memory can be used to run domains in a KVM machine?

2009-07-17 Thread Amit Shah
On (Fri) Jul 17 2009 [15:26:49], sudhir kumar wrote: > On Fri, Jul 17, 2009 at 12:47 PM, Dor Laor wrote: > > On 07/17/2009 08:50 AM, Zhang Qian wrote: > >> > >> Hi, > >> > >> I have a KVM box which has 4GB physical memory totally, I'd like to > >> know how much I can use to run my domains, and how

Re: Connection between KVM and QEMU.

2009-07-17 Thread Amit Shah
On (Fri) Jul 17 2009 [11:48:32], Rakesh Avichal Ughreja wrote: > Hello All, > > I am trying to understand the what is the connection between KVM and QEMU. > > The way I understand it so far from the information on the net, KVM is > an emulator for x86 based machine and it uses the virtualization

qemu-kvm missing some msix capability check

2009-07-17 Thread Amit Shah
Hello, Using recent qemu-kvm userspace with a slightly older kernel module I get this when using the virtio-net device: kvm_msix_add: kvm_get_irq_route_gsi failed: No space left on device ... and the guest doesn't use the net device. This goes away when using a newer kvm module.

Re: KVM and kernel 2.6.30 file system madness

2009-07-20 Thread Amit Shah
On (Tue) Jul 21 2009 [16:42:50], Mark van Walraven wrote: > On Wed, Jul 15, 2009 at 02:33:03PM +0530, Amit Shah wrote: > > On (Wed) Jul 15 2009 [09:52:36], Robert Wimmer wrote: > > > Hi! > > > > > > > Are you using virtio-block? > > > > >

Re: qemu-kvm missing some msix capability check

2009-07-21 Thread Amit Shah
On (Tue) Jul 21 2009 [19:54:00], Michael S. Tsirkin wrote: > On Fri, Jul 17, 2009 at 06:34:40PM +0530, Amit Shah wrote: > > Hello, > > > > Using recent qemu-kvm userspace with a slightly older kernel module I > > get this when using the virtio-net de

Re: qemu-kvm missing some msix capability check

2009-07-23 Thread Amit Shah
On (Tue) Jul 21 2009 [19:54:00], Michael S. Tsirkin wrote: > On Fri, Jul 17, 2009 at 06:34:40PM +0530, Amit Shah wrote: > > Hello, > > > > Using recent qemu-kvm userspace with a slightly older kernel module I > > get this when using the virtio-net device: I was gett

[PATCH] kvm: balloon: test multiple devices

2011-08-08 Thread Amit Shah
Multiple balloon devices should not be allowed. Check if the qemu we're running under has the right fixes. Signed-off-by: Amit Shah --- client/tests/kvm/tests/balloon_check.py | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-25 Thread Amit Shah
On (Wed) 25 Jul 2012 [10:06:37], Rusty Russell wrote: > On Tue, 24 Jul 2012 15:01:59 +0200, Sasha Levin > wrote: > > virtio on it's own was introduced to help solve the fragmentation > > around virtualized devices, so I don't think that the main purpose of > > doing virtio drivers is due to any p

Re: KVM: x86: fix pvclock guest stopped flag reporting (v2)

2012-08-07 Thread Amit Shah
On (Fri) 03 Aug 2012 [15:57:49], Marcelo Tosatti wrote: > > kvm_guest_time_update unconditionally clears hv_clock.flags field, > so the notification never reaches the guest. > > Fix it by allowing PVCLOCK_GUEST_STOPPED to passthrough. > > Signed-off-by: Marcelo Tosatti R

Re: [RFC/PATCH] virtio-console: wait for console ports

2011-09-22 Thread Amit Shah
Hi Christian, On (Wed) 21 Sep 2011 [17:52:23], Christian Borntraeger wrote: > Amit, > > can you have a look at the patch below and give feedback or apply > if appropriate? The patch looks good. Just a couple of comments: > On s390 I have seen some random "Warning: unable to open an initial > c

Re: [RFC/PATCH] virtio-console: wait for console ports

2011-09-22 Thread Amit Shah
On (Thu) 22 Sep 2011 [13:20:07], Christian Borntraeger wrote: > On 22/09/11 12:08, Amit Shah wrote: > >> + /* If there was an early virtio console, assume that there are no > >> + * other consoles. We need to wait until the hvc_alloc matches the > >> + * hvc_i

[PATCH 0/1] virtio: console: fix for early console

2011-09-22 Thread Amit Shah
Hi Rusty, This is a fix from Christian for early console handling with multiport support. Please apply. Christian, I've made some changes to the patch as noted in the commit message. Nothing major, but an ACK would be nice. Thanks. Christian Borntraeger (1): virtio: console: wait for first

[PATCH 1/1] virtio: console: wait for first console port for early console output

2011-09-22 Thread Amit Shah
rison * Rename 'port_added' to 'early_console_added' * Re-format, re-word commit message * Rebase patch on top of current queue] Signed-off-by: Christian Borntraeger Signed-off-by: Amit Shah --- drivers/char/virtio_console.c | 20 1 files changed, 20 inser

Re: [PATCH 0/1] virtio: console: fix for early console

2011-10-31 Thread Amit Shah
On (Thu) 22 Sep 2011 [23:44:22], Amit Shah wrote: > Hi Rusty, > > This is a fix from Christian for early console handling with multiport > support. Please apply. > > Christian, I've made some changes to the patch as noted in the commit > message. Nothing major

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Amit Shah
On (Mon) 14 Feb 2011 [16:18:10], Anthony Liguori wrote: > On 02/14/2011 11:56 AM, Chris Wright wrote: > >Please send in any agenda items you are interested in covering. > > -rc2 is tagged and waiting for announcement. Please take a look at > -rc2 and make sure there is nothing critical missing.

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-16 Thread Amit Shah
On (Tue) 15 Feb 2011 [17:13:13], Anthony Liguori wrote: > On 02/15/2011 10:26 AM, Chris Wright wrote: > > > >revisit new -> old migration > >- Amit offers virtio-serial patches and some legwork > > So, to me, migration correctness trumps compatibility. I don't > think compatibility is useful if

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Amit Shah
On (Wed) 16 Feb 2011 [08:41:27], Anthony Liguori wrote: > On 02/16/2011 08:39 AM, Amit Shah wrote: > >On (Tue) 15 Feb 2011 [17:13:13], Anthony Liguori wrote: > >>On 02/15/2011 10:26 AM, Chris Wright wrote: > >>>revisit new -> old migration > >>>

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-08 Thread Amit Shah
On (Mon) 05 Dec 2011 [15:18:59], Eric B Munson wrote: > When a guest kernel is stopped by the host hypervisor it can look like a soft > lockup to the guest kernel. This false warning can mask later soft lockup > warnings which may be real. This patch series adds a method for a host > hypervisor t

Re: [Qemu-devel] [PATCH] virtio-serial: Allow one MSI-X vector per virtqueue

2011-12-16 Thread Amit Shah
On (Fri) 16 Dec 2011 [09:14:26], zanghongy...@huawei.com wrote: > From: Hongyong Zang > > In pci_enable_msix(), the guest's virtio-serial driver tries to set msi-x > with one vector per queue. But it fails and eventually all virtio-serial > ports share one MSI-X vector. Because every virtio-seria

Re: [Qemu-devel] [PATCH] virtio-serial: Allow one MSI-X vector per virtqueue

2011-12-18 Thread Amit Shah
On (Mon) 19 Dec 2011 [14:09:43], Zang Hongyong wrote: > 于 2011/12/16,星期五 17:39, Amit Shah 写道: > >On (Fri) 16 Dec 2011 [09:14:26], zanghongy...@huawei.com wrote: > >>From: Hongyong Zang > >> > >>In pci_enable_msix(), the guest's virtio-serial driver tries t

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-19 Thread Amit Shah
On (Thu) 15 Dec 2011 [13:55:15], Avi Kivity wrote: > On 12/08/2011 01:34 PM, Amit Shah wrote: > > On (Mon) 05 Dec 2011 [15:18:59], Eric B Munson wrote: > > > When a guest kernel is stopped by the host hypervisor it can look like a > > > soft > > > lockup to t

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-19 Thread Amit Shah
On (Mon) 19 Dec 2011 [14:59:36], Avi Kivity wrote: > On 12/19/2011 02:52 PM, Amit Shah wrote: (snip) > > S4 needs some treatment, though, as resume after s4 doesn't work with > > kvmclock enabled. I didn't realise this series was only handling the > > soft lockup

Re: [PATCH 2/2] virtio-serial: setup_port_vq when adding port

2012-02-01 Thread Amit Shah
Hi, Sorry for the late reply. On (Thu) 12 Jan 2012 [09:20:07], zanghongy...@huawei.com wrote: > From: Hongyong Zang > > Add setup_port_vq(). Create the io ports' vqs when add_port. Can you describe the changes in more detail, please? > Signed-off-by: Hongyong Zang > --- > drivers/char/virti

Re: [PATCH 1/2] virtio-pci: add setup_vqs flag in vp_try_to_find_vqs

2012-02-01 Thread Amit Shah
Michael, Rusty, any comments? On (Thu) 12 Jan 2012 [09:20:06], zanghongy...@huawei.com wrote: > From: Hongyong Zang > > changes in vp_try_to_find_vqs: > Virtio-serial's probe() calls it to request irqs and setup vqs of port0 and > controls; add_port() calls it to set up vqs of io_port. > it will

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-03 Thread Amit Shah
On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote: > disable_cb is just an optimization: it > can not guarantee that there are no callbacks. Even then, what's the harm in keeping it? If indeed there's an attempt to raise an interrupt after the host has been notified, it will be suppressed

Re: [PATCH] Add a page cache-backed balloon device driver.

2012-06-27 Thread Amit Shah
On (Tue) 26 Jun 2012 [13:32:58], Frank Swiderski wrote: > This implementation of a virtio balloon driver uses the page cache to > "store" pages that have been released to the host. The communication > (outside of target counts) is one way--the guest notifies the host when > it adds a page to the p

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-09 Thread Amit Shah
On (Tue) 07 Feb 2012 [19:05:42], Marcelo Tosatti wrote: > > Upon resume from hibernation, CPU 0's hvclock area contains the old > values for system_time and tsc_timestamp. It is necessary for the > hypervisor to update these values with uptodate ones before the CPU uses > them. > > Abstract TSC's

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-10 Thread Amit Shah
On (Thu) 09 Feb 2012 [16:13:29], Igor Mammedov wrote: > Stalls are probably caused by uninitialized percpu hv_clock, with > following patch I don't see stalls. Although I might be just lucky. > http://git.kernel.org/?p=virt/kvm/kvm.git;a=commit;h=e2971ac7e1d186af059e088d305496c5cb47d487 Your comm

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-10 Thread Amit Shah
On (Fri) 10 Feb 2012 [05:11:00], Igor Mammedov wrote: > Could you send me your .config and commit id of kernel you are using? Kernel's based on bd3ce7d57c380af110c86d19e256115d0e7053ca plus your commit + Marcelo's patch. config is attached below. # # Automatically generated file; DO NOT EDIT. #

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-10 Thread Amit Shah
On (Fri) 10 Feb 2012 [10:32:16], Marcelo Tosatti wrote: > On Fri, Feb 10, 2012 at 03:32:11PM +0530, Amit Shah wrote: > > On (Thu) 09 Feb 2012 [16:13:29], Igor Mammedov wrote: > > > > > Stalls are probably caused by uninitialized percpu hv_clock, with > > > f

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-13 Thread Amit Shah
On (Fri) 10 Feb 2012 [21:58:47], Igor Mammedov wrote: > BTW Amit, > your config doesn't have CONFIG_KVM_GUEST set, which causes primary cpu clock > to be > uninitialized too in case of SMP kernel. Interesting. I didn't notice that. However, if I enable that option, resume fails for me even the

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-13 Thread Amit Shah
On (Fri) 10 Feb 2012 [13:43:05], Igor Mammedov wrote: > Another thing is to try smp guest without kvmclock and see if it helps. > It might be just something else. Nope, it's related to kvmclock. Amit -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-13 Thread Amit Shah
On (Fri) 10 Feb 2012 [10:33:37], Marcelo Tosatti wrote: > On Fri, Feb 10, 2012 at 10:32:16AM -0200, Marcelo Tosatti wrote: > > On Fri, Feb 10, 2012 at 03:32:11PM +0530, Amit Shah wrote: > > > On (Thu) 09 Feb 2012 [16:13:29], Igor Mammedov wrote: > > > > >

Re: x86: kvmclock: abstract save/restore sched_clock_state (v2)

2012-02-13 Thread Amit Shah
ck (also for TSC). > Thanks to Igor Mammedov for tracking it down. > > Fixes suspend-to-disk with kvmclock. > > Signed-off-by: Marcelo Tosatti This works fine, thanks. Tested-by: Amit Shah Amit -- To unsubscribe from this list: send the line "unsubscribe kvm&q

Re: vsyscall=emulate regression

2012-02-15 Thread Amit Shah
On (Tue) 14 Feb 2012 [08:26:22], Andy Lutomirski wrote: > On Tue, Feb 14, 2012 at 4:22 AM, Amit Shah wrote: > > On (Fri) 03 Feb 2012 [13:57:48], Amit Shah wrote: > >> Hello, > >> > >> I'm booting some latest kernels on a Fedora 11 (released June 2009

Re: [KVM paravirt issue?] Re: vsyscall=emulate regression

2012-02-28 Thread Amit Shah
On (Tue) 28 Feb 2012 [12:00:34], Avi Kivity wrote: > On 02/24/2012 08:58 PM, Andy Lutomirski wrote: > > On Thu, Feb 23, 2012 at 8:34 PM, H. Peter Anvin wrote: > > > On 02/16/2012 09:39 AM, Avi Kivity wrote: > > >>> > > >>> Yes, this is on purpose > > > > > > Why? > > > > I think the "this" refers

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > At 03/13/2012 06:47 PM, Avi Kivity Wrote: > > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > >> On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > >>> On 03/12/2012 11:04 AM, Wen Congyang wrote: > Do you have any other comm

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > At 03/14/2012 05:24 PM, Avi Kivity Wrote: > > On 03/14/2012 10:29 AM, Wen Congyang wrote: > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > On Mon, Mar 12, 2012 at 12:33:33PM +0200, Av

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:04:40], Wen Congyang wrote: > At 03/14/2012 05:51 PM, Amit Shah Wrote: > > On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > >&g

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:52:07], Wen Congyang wrote: > At 03/14/2012 06:37 PM, Amit Shah Wrote: > > On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > >> At 03/14/2012 05:24 PM, Avi Kivity Wrote: > >>> On 03/14/2012 10:29 AM, Wen Congyang wrote: > >>>

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-04-02 Thread Amit Shah
On (Mon) 02 Apr 2012 [18:05:45], Wen Congyang wrote: > At 03/19/2012 03:33 PM, Wen Congyang Wrote: > > At 03/08/2012 03:57 PM, Wen Congyang Wrote: > >> We can know the guest is paniced when the guest runs on xen. > >> But we do not have such feature on kvm. > >> > >> Another purpose of this feature

Call for Proposals: Linux Plumbers Conference (Aug 2012)

2012-04-19 Thread Amit Shah
Hello, The Call for Proposals for the Linux Plumbers Conf 2012 is out. We're looking for speakers to talk at the Virtualization microconference as well as the main conference. The deadline for proposal submissions is 1st May. This year's edition of LPC is co-located with LinuxCon NA and will be

Re: [PATCH 1/2] KVM test: virtio subtest: Add subtest layer v2

2010-11-25 Thread Amit Shah
Hi Lucas, Jiri, Lukas, On (Thu) Nov 25 2010 [17:28:57], Lucas Meneghel Rodrigues wrote: > From: Jiri Zupka > > This patch changes structure of the virtio_console test and > prepares this test for simpler porting of another required tests. > > It creates a new layer for running the elementary te

Re: [PATCH 0/2] virtio-serial: set up vqs on demand

2013-04-08 Thread Amit Shah
On (Thu) 12 Jan 2012 [09:20:05], zanghongy...@huawei.com wrote: > From: Hongyong Zang > > Virtio-serial set up (max_ports+1)*2 vqs when device probes, but may not all > io_ports are used. > These patches create vqs of port0 and control port when probing the device, > then > create io-vqs when

Re: When I boot two virtio-rng devices, guest will hang

2014-07-28 Thread Amit Shah
true; return 0; } Amit >From ec1aa555b67628beefa0ac6902baa2cc2e156f58 Mon Sep 17 00:00:00 2001 Message-Id: From: Amit Shah Date: Mon, 21 Jul 2014 14:46:28 +0530 Subject: [PATCH 1/1] virtio-rng: add some trace events Add some trace events to virtio-rng for easier d

Re: When I boot two virtio-rng devices, guest will hang

2014-07-28 Thread Amit Shah
On (Mon) 28 Jul 2014 [16:49:20], Amos Kong wrote: > On Mon, Jul 28, 2014 at 01:25:14PM +0530, Amit Shah wrote: > > On (Mon) 28 Jul 2014 [15:32:42], Amos Kong wrote: > > > QEMU commandline: > > > > > > ./x86_64-softmmu/qemu-system-x86_64 --enable-kvm

Re: [PATCH] virtio-rng: complete have_data completion in removing device

2014-08-06 Thread Amit Shah
On (Wed) 06 Aug 2014 [16:05:41], Amos Kong wrote: > On Wed, Aug 06, 2014 at 01:35:15AM +0800, Amos Kong wrote: > > When we try to hot-remove a busy virtio-rng device from QEMU monitor, > > the device can't be hot-removed. Because virtio-rng driver hangs at > > wait_for_completion_killable(). > > >

[PATCH 1/1] virtio: rng: add derating factor for use by hwrng core

2014-08-11 Thread Amit Shah
ss we receive is perfectly trustworthy. Hence, we use 100% for the factor, indicating maximum confidence in the source. Signed-off-by: Amit Shah --- Pretty small and contained patch; would be great if it is picked up for 3.17. --- drivers/char/hw_random/virtio-rng.c | 1 + 1 file changed, 1 inse

Re: [PATCH 1/1] virtio: rng: add derating factor for use by hwrng core

2014-08-11 Thread Amit Shah
On (Mon) 11 Aug 2014 [15:11:03], H. Peter Anvin wrote: > On 08/11/2014 11:49 AM, Amit Shah wrote: > > The khwrngd thread is started when a hwrng device of sufficient > > quality is registered. The virtio-rng device is backed by the > > hypervisor, and we trust the hyper

[PATCH v2 1/1] virtio: rng: add derating factor for use by hwrng core

2014-08-12 Thread Amit Shah
ts of badness, and a compromised hwrng is not the biggest threat. Given this, we are certain the quality of randomness we receive is perfectly trustworthy. Hence, we use 100% for the factor, indicating maximum confidence in the source. Signed-off-by: Amit Shah --- Pretty small and contained patch;

[PATCH v3 1/1] virtio: rng: add derating factor for use by hwrng core

2014-08-14 Thread Amit Shah
nd to cause all sorts of badness, and a compromised hwrng is the least of the user's worries. Given this, we might as well assume that the quality of randomness we receive is perfectly trustworthy. Hence, we use 100% for the factor, indicating maximum confidence in the source. Signed-off-by:

[PULL] virtio-rng: add derating factor for use by hwrng core

2014-08-14 Thread Amit Shah
virtio: rng: add derating factor for use by hwrng core (2014-08-15 10:26:01 +0530) ---- Amit Shah (1): virtio: rng: add derating factor for use by hwrng core drivers/char/hw_random/virtio-rng.c | 1 + 1 file changed, 1 insertion(

Re: [Qemu-devel] [question] virtio-blk performance degradation happened with virito-serial

2014-08-29 Thread Amit Shah
On (Fri) 29 Aug 2014 [15:45:30], Zhang Haoyu wrote: > Hi, all > > I start a VM with virtio-serial (default ports number: 31), and found that > virtio-blk performance degradation happened, about 25%, this problem can be > reproduced 100%. > without virtio-serial: > 4k-read-random 1186 IOPS > with

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-01 Thread Amit Shah
On (Mon) 01 Sep 2014 [20:38:20], Zhang Haoyu wrote: > >> Hi, all > >> > >> I start a VM with virtio-serial (default ports number: 31), and found that > >> virtio-blk performance degradation happened, about 25%, this problem can > >> be reproduced 100%. > >> without virtio-serial: > >> 4k-read-ra

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-01 Thread Amit Shah
On (Mon) 01 Sep 2014 [20:52:46], Zhang Haoyu wrote: > >>> Hi, all > >>> > >>> I start a VM with virtio-serial (default ports number: 31), and found > >>> that virtio-blk performance degradation happened, about 25%, this problem > >>> can be reproduced 100%. > >>> without virtio-serial: > >>> 4k-

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-02 Thread Amit Shah
On (Tue) 02 Sep 2014 [22:05:45], Andrey Korolyov wrote: > Can confirm serious degradation comparing to the 1.1 with regular > serial output - I am able to hang VM forever after some tens of > seconds after continuously printing dmest to the ttyS0. VM just ate > all available CPU quota during test

Re: [PATCH v2] virtio-rng: fix stuck of hot-unplugging busy device

2014-09-09 Thread Amit Shah
Hi Amos, On (Tue) 09 Sep 2014 [19:14:02], Amos Kong wrote: > When we try to hot-remove a busy virtio-rng device from QEMU monitor, > the device can't be hot-removed. Because virtio-rng driver hangs at > wait_for_completion_killable(). > > This patch exits the waiting by completing have_data compl

Re: RFC virtio-rng: fail to read sysfs of a busy device

2014-09-09 Thread Amit Shah
On (Tue) 09 Sep 2014 [23:23:07], Amos Kong wrote: > (Resend to fix the subject) > > Hi Amit, Rusty > > RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1127062 > steps: > - Read random data by 'dd if=/dev/hwrng of=/dev/null' in guest > - check sysfs files in the same time, 'cat /sys/class/misc/h

Re: [PATCH v3 1/2] virtio-rng: fix stuck of hot-unplugging busy device

2014-09-10 Thread Amit Shah
have_data completion before > unregistering, resets data_avail to avoid the hwrng core use wrong > buffer bytes. > > Signed-off-by: Amos Kong > Cc: sta...@vger.kernel.org Reviewed-by: Amit Shah Amit -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v3 2/2] virtio-rng: skip reading when we start to remove the device

2014-09-10 Thread Amit Shah
rnel.org Reviewed-by: Amit Shah Amit -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] virtio-rng cleanup: move some code out of mutex protection

2014-09-10 Thread Amit Shah
On (Wed) 10 Sep 2014 [17:07:06], Amos Kong wrote: > It doesn't save too much cpu time as expected, just a cleanup. Frankly I won't bother with this. It doesn't completely remove all copying from the mutex, so it's not worthwhile. > Signed-off-by: Amos Kong > --- > drivers/char/hw_random/core.c

Re: [PATCH 2/2] virtio-rng: fix stuck in catting hwrng attributes

2014-09-10 Thread Amit Shah
s is safer. I'd prefer two patches for this one: one to remove the need_resched() check, and the other to increase the timeout. Anyway, Reviewed-by: Amit Shah > > Signed-off-by: Amos Kong > --- > drivers/char/hw_random/core.c | 3 +-- > 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [question] virtio-blk performance degradationhappenedwith virito-serial

2014-09-10 Thread Amit Shah
On (Sun) 07 Sep 2014 [17:46:26], Zhang Haoyu wrote: > Hi, Paolo, Amit, > any ideas? I'll check this, thanks for testing with Linux guests. Amit -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH v2 01/15] virtio_pci: fix virtio spec compliance on restore

2014-10-07 Thread Amit Shah
port butden for the hypervisors. > > Cc: sta...@vger.kernel.org > Cc: Amit Shah > Signed-off-by: Michael S. Tsirkin I didn't see my previous questions answered from the initial posting -- can you please respond to them? Amit -- To unsubscribe from this list: send

Re: [PATCH v2 01/15] virtio_pci: fix virtio spec compliance on restore

2014-10-07 Thread Amit Shah
On (Tue) 07 Oct 2014 [15:53:55], Michael S. Tsirkin wrote: > On Mon, Oct 06, 2014 at 06:10:40PM +0300, Michael S. Tsirkin wrote: > > On restore, virtio pci does the following: > > + set features > > + init vqs etc - device can be used at this point! > > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status

[PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Amit Shah
code added previously dead code. This patch reworks the code so that it's called when 'running' is 0, which indicates the VM was stopped. CC: Eric B Munson CC: Raghavendra K T CC: Andreas Färber CC: Marcelo Tosatti CC: Paolo Bonzini CC: Laszlo Ersek Signed-off-by: Amit Shah -

Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-10-08 Thread Amit Shah
On (Sun) 30 Sep 2012 [20:05:16], Marcelo Tosatti wrote: > On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: > > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop > > > not

  1   2   3   4   5   >