Re: [PATCH 2/2] virtio-serial: setup_port_vq when adding port

2012-02-01 Thread Amit Shah
Hi, Sorry for the late reply. On (Thu) 12 Jan 2012 [09:20:07], zanghongy...@huawei.com wrote: > From: Hongyong Zang > > Add setup_port_vq(). Create the io ports' vqs when add_port. Can you describe the changes in more detail, please? > Signed-off-by: Hongyong Zang > --- > drivers/char/virti

Re: [PATCH v4 0/3] virtio-scsi driver

2012-02-01 Thread Paolo Bonzini
On 02/01/2012 08:31 AM, Pekka Enberg wrote: What's the benefit of virtio-scsi over virtio-blk? Most of this is in the spec or the KVM Forum 2011 presentation. 1) scalability limitations: virtio-blk-over-PCI puts a strong upper limit on the number of devices that can be added to a guest. Common

Re: [PATCH 1/2] virtio-pci: add setup_vqs flag in vp_try_to_find_vqs

2012-02-01 Thread Amit Shah
Michael, Rusty, any comments? On (Thu) 12 Jan 2012 [09:20:06], zanghongy...@huawei.com wrote: > From: Hongyong Zang > > changes in vp_try_to_find_vqs: > Virtio-serial's probe() calls it to request irqs and setup vqs of port0 and > controls; add_port() calls it to set up vqs of io_port. > it will

Re: [PATCH v4 0/3] virtio-scsi driver

2012-02-01 Thread Pekka Enberg
On Wed, 1 Feb 2012, Paolo Bonzini wrote: Have the virtio specification changes been reviewed? Can we guarantee stable ABI for the virtio-scsi driver? Of course. I would have proposed it for staging otherwise. I'm not a SCSI expert but FWIW I went through the patches and I think they're defi

Re: [PATCH v4 0/3] virtio-scsi driver

2012-02-01 Thread Paolo Bonzini
On 02/01/2012 09:18 AM, Pekka Enberg wrote: Of course. I would have proposed it for staging otherwise. I'm not a SCSI expert but FWIW I went through the patches and I think they're definitely worthwhile having in mainline for v3.4: Acked-by: Pekka Enberg Thanks Pekka! Actually we had a

Re: [PATCH 1/9] pci-assign: Optionally enable 64bit BARs in guest

2012-02-01 Thread Avi Kivity
On 01/31/2012 11:14 PM, Michael S. Tsirkin wrote: > On Tue, Jan 31, 2012 at 02:08:38PM -0700, Alex Williamson wrote: > > On Tue, 2012-01-31 at 15:33 +0200, Avi Kivity wrote: > > > On 01/31/2012 03:21 PM, Jan Kiszka wrote: > > > > On 2012-01-31 14:10, Avi Kivity wrote: > > > > > On 01/31/2012 02:57

Re: [PATCH 3/9] pci-assign: Update MSI-X MMIO to Memory API

2012-02-01 Thread Avi Kivity
On 02/01/2012 06:22 AM, Alex Williamson wrote: > On Tue, 2012-01-31 at 14:13 -0700, Alex Williamson wrote: > > On Tue, 2012-01-31 at 14:45 +0200, Avi Kivity wrote: > > > On 01/28/2012 04:21 PM, Alex Williamson wrote: > > > > Stop using compatibility mode and at the same time fix available > > > > a

Re: [PATCH] emulator: add movdqa tests

2012-02-01 Thread Takuya Yoshikawa
(2012/01/09 1:35), Stefan Hajnoczi wrote: > The movdqa instruction performs a 128-bit vector move and requires that > operands are aligned in memory. Unlike the movdqu instruction, a #GP is > raised if operands are unaligned. > > This patch does not exercise misalignment because the CPU detects >

Re: [PATCH] emulator: add movdqa tests

2012-02-01 Thread Avi Kivity
On 02/01/2012 11:08 AM, Takuya Yoshikawa wrote: > What is the status of Stefan's work? Stefan's on vacation. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH] emulator: add movdqa tests

2012-02-01 Thread Takuya Yoshikawa
(2012/02/01 18:13), Avi Kivity wrote: > On 02/01/2012 11:08 AM, Takuya Yoshikawa wrote: >> What is the status of Stefan's work? > > Stefan's on vacation. > No no, about this unit-test patch. Not applied yet? Takuya -- To unsubscribe from this list: send the line "unsubscribe kvm" in th

Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev

2012-02-01 Thread Jan Kiszka
On 2012-02-01 08:29, Paolo Bonzini wrote: > On 01/31/2012 09:49 PM, Anthony Liguori wrote: >>> >>> +DEFINE_PROP_HEX32("iobase", PCSpkState, iobase, -1), >>> +DEFINE_PROP_PTR("pit", PCSpkState, pit), >> >> Please don't introduce a pointer property here. They cannot be used in >> a

Re: [PATCH] emulator: add movdqa tests

2012-02-01 Thread Avi Kivity
On 02/01/2012 11:17 AM, Takuya Yoshikawa wrote: > (2012/02/01 18:13), Avi Kivity wrote: > > On 02/01/2012 11:08 AM, Takuya Yoshikawa wrote: > >> What is the status of Stefan's work? > > > > Stefan's on vacation. > > > > No no, about this unit-test patch. > > Not applied yet? > Well, movdqa is no

Re: [PATCH] emulator: add movdqa tests

2012-02-01 Thread Takuya Yoshikawa
(2012/02/01 18:21), Avi Kivity wrote: > On 02/01/2012 11:17 AM, Takuya Yoshikawa wrote: >> (2012/02/01 18:13), Avi Kivity wrote: >>> On 02/01/2012 11:08 AM, Takuya Yoshikawa wrote: What is the status of Stefan's work? >>> >>> Stefan's on vacation. >>> >> >> No no, about this unit-test patch. >

[PATCH] vapic: add copyright and licensing terms

2012-02-01 Thread Avi Kivity
Signed-off-by: Avi Kivity --- pc-bios/optionrom/vapic.S | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/pc-bios/optionrom/vapic.S b/pc-bios/optionrom/vapic.S index 97fa19c..e1d8f18 100644 --- a/pc-bios/optionrom/vapic.S +++ b/pc-bios/optionrom/vapic.S @@ -1,3 +

Re: [PATCH 2/2] virtio-serial: setup_port_vq when adding port

2012-02-01 Thread Zang Hongyong
On 2012/2/1,星期三 16:12, Amit Shah wrote: Hi, Sorry for the late reply. On (Thu) 12 Jan 2012 [09:20:07], zanghongy...@huawei.com wrote: From: Hongyong Zang Add setup_port_vq(). Create the io ports' vqs when add_port. Can you describe the changes in more detail, please? The motivation of this

Re: Partial review of kvm arm git patches.

2012-02-01 Thread Avi Kivity
On 02/01/2012 08:27 AM, Rusty Russell wrote: > > +#define VM_STAT(x) (offsetof(struct kvm, stat.x), KVM_STAT_VM) > > +#define VCPU_STAT(x) (offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU) > > + > > +struct kvm_stats_debugfs_item debugfs_entries[] = { > > + { NULL } > > +}; > > That's weird.

Re: [PATCH 0/2] virtio-serial: set up vqs on demand

2012-02-01 Thread Michael S. Tsirkin
On Thu, Jan 12, 2012 at 09:20:05AM +0800, zanghongy...@huawei.com wrote: > From: Hongyong Zang > > Virtio-serial set up (max_ports+1)*2 vqs when device probes, but may not all > io_ports are used. > These patches create vqs of port0 and control port when probing the device, > then > create io-

Re: [PATCH 1/2] virtio-pci: add setup_vqs flag in vp_try_to_find_vqs

2012-02-01 Thread Michael S. Tsirkin
On Thu, Jan 12, 2012 at 09:20:06AM +0800, zanghongy...@huawei.com wrote: > From: Hongyong Zang > > changes in vp_try_to_find_vqs: > Virtio-serial's probe() calls it to request irqs and setup vqs of port0 and > controls; add_port() calls it to set up vqs of io_port. > it will not create virtqueue

Re: [PATCH 1/9] pci-assign: Optionally enable 64bit BARs in guest

2012-02-01 Thread Michael S. Tsirkin
On Wed, Feb 01, 2012 at 11:03:25AM +0200, Avi Kivity wrote: > On 01/31/2012 11:14 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 31, 2012 at 02:08:38PM -0700, Alex Williamson wrote: > > > On Tue, 2012-01-31 at 15:33 +0200, Avi Kivity wrote: > > > > On 01/31/2012 03:21 PM, Jan Kiszka wrote: > > > > >

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Peter Zijlstra
On Tue, 2012-01-31 at 14:24 -0800, Paul E. McKenney wrote: > > > Can we get it back to speed by scheduling a work function on all cpus? > > > wouldn't that force a quiescent state and allow call_srcu() to fire? > > > > > > In kvm's use case synchronize_srcu_expedited() is usually called when no

[PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Avi Kivity
If the guest thinks it's an AMD, it will not have prepared the SYSENTER MSRs, and if the guest executes SYSENTER in compatibility mode, it will fails. Detect this condition and #UD instead, like the spec says. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 18 ++ 1 fil

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Avi Kivity
On 02/01/2012 12:22 PM, Peter Zijlstra wrote: > One of the things I was thinking of is adding a sequence counter in the > per-cpu data. Using that we could do something like: > > unsigned int seq1 = 0, seq2 = 0, count = 0; > int cpu, idx; > > idx = ACCESS_ONCE(sp->completions) & 1; > > for_

Re: [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Stephan Bärwolf
On 02/01/12 11:27, Avi Kivity wrote: > > +static bool vendor_intel(struct x86_emulate_ctxt *ctxt) > +{ > + u32 eax, ebx, ecx, edx; Just to be clean: Shouldn't eax and ecx be initialized to zero? regards Stephan > + > + return ctxt->ops->get_cpuid(ctxt, &eax, &ebx, &ecx, &edx) > +

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Avi Kivity
On 02/01/2012 12:44 PM, Avi Kivity wrote: > On 02/01/2012 12:22 PM, Peter Zijlstra wrote: > > One of the things I was thinking of is adding a sequence counter in the > > per-cpu data. Using that we could do something like: > > > > unsigned int seq1 = 0, seq2 = 0, count = 0; > > int cpu, idx; >

Re: [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Avi Kivity
On 02/01/2012 12:45 PM, Stephan Bärwolf wrote: > On 02/01/12 11:27, Avi Kivity wrote: > > > > +static bool vendor_intel(struct x86_emulate_ctxt *ctxt) > > +{ > > + u32 eax, ebx, ecx, edx; > Just to be clean: > > Shouldn't eax and ecx be initialized to zero? Either get_cpuid() initializes them

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Takuya Yoshikawa
(2012/02/01 19:49), Avi Kivity wrote: On 02/01/2012 12:44 PM, Avi Kivity wrote: On 02/01/2012 12:22 PM, Peter Zijlstra wrote: One of the things I was thinking of is adding a sequence counter in the per-cpu data. Using that we could do something like: unsigned int seq1 = 0, seq2 = 0, count =

Re: [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Stephan Bärwolf
On 02/01/12 11:50, Avi Kivity wrote: > On 02/01/2012 12:45 PM, Stephan Bärwolf wrote: >> On 02/01/12 11:27, Avi Kivity wrote: >>> >>> +static bool vendor_intel(struct x86_emulate_ctxt *ctxt) >>> +{ >>> + u32 eax, ebx, ecx, edx; >> Just to be clean: >> >> Shouldn't eax and ecx be initialized to

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Avi Kivity
On 02/01/2012 01:00 PM, Takuya Yoshikawa wrote: > >> rcu_assign_pointer), and use atomic operations to copy and clear: >> >>word = bitmap[i] >>put_user(word) >>atomic_and(&bitmap[i], ~word) >> >> > > This kind of this was really slow IIRC. > > > How about just doing: > > take a spin_loc

Re: [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Marcelo Tosatti
On Wed, Feb 01, 2012 at 12:27:00PM +0200, Avi Kivity wrote: > If the guest thinks it's an AMD, it will not have prepared the SYSENTER MSRs, > and if the guest executes SYSENTER in compatibility mode, it will fails. > > Detect this condition and #UD instead, like the spec says. Note the SYSENTER_C

Re: [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Avi Kivity
On 02/01/2012 12:59 PM, Stephan Bärwolf wrote: > On 02/01/12 11:50, Avi Kivity wrote: > > On 02/01/2012 12:45 PM, Stephan Bärwolf wrote: > >> On 02/01/12 11:27, Avi Kivity wrote: > >>> > >>> +static bool vendor_intel(struct x86_emulate_ctxt *ctxt) > >>> +{ > >>> + u32 eax, ebx, ecx, edx; > >> Jus

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Takuya Yoshikawa
(2012/02/01 20:01), Avi Kivity wrote: On 02/01/2012 01:00 PM, Takuya Yoshikawa wrote: How about just doing: take a spin_lock copy the entire (or some portions of) bitmap locally clear the bitmap unlock That means that vcpus dirtying memory also have to take that lock, and spin while the bi

Re: [Android-virt] [PATCH v5 00/13] KVM/ARM Implementation

2012-02-01 Thread Marc Zyngier
On 30/01/12 22:46, Peter Maydell wrote: > On 20 January 2012 02:59, Christoffer Dall > wrote: >> There's a new list of issues available at: >> >> https://github.com/virtualopensystems/linux-kvm-arm/issues > > Thanks for putting this up. Here's a couple more for you :-) > > * Support guest kerne

Re: [Android-virt] [PATCH v5 00/13] KVM/ARM Implementation

2012-02-01 Thread Peter Maydell
On 1 February 2012 12:11, Marc Zyngier wrote: > The obvious fix would be to test for the virt extensions in ID_PFR1 > before enabling KVM, and mask out the virt extensions from the same > register in the guest by trapping CP15-c0. But c0 is used by cache > maintenance operations, and trapping woul

--disable-kvm breaks build of qemu-kvm

2012-02-01 Thread Erik Rull
Hi all, the current qemu-kvm master does not compile if --disable-kvm is configured (also earlier version fail). It fails here: CCx86_64-softmmu/apic.o /home/erik/qemu-kvm/hw/apic.c: In function 'kvm_irqchip_deliver_nmi': /home/erik/qemu-kvm/hw/apic.c:141: error: storage size of 'klapic' i

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Paolo Bonzini
On 01/31/2012 10:49 PM, Jan Kiszka wrote: > Just make the methods that you want to override virtual with the default > implementation and then make a KVMPIT that inherits from the PIT and > then overrides whatever virtual functions it needs to. That doesn't sound like the proper design for th

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Jan Kiszka
On 2012-02-01 13:23, Paolo Bonzini wrote: > On 01/31/2012 10:49 PM, Jan Kiszka wrote: >>> Just make the methods that you want to override virtual with the default >>> implementation and then make a KVMPIT that inherits from the PIT and >>> then overrides whatever virtual functions it needs to. >

Re: [PATCH] kvm tools: Fix segfault when failing to initialize KVM

2012-02-01 Thread Sasha Levin
On Wed, 2012-02-01 at 09:05 +0200, Pekka Enberg wrote: > On Tue, 31 Jan 2012, Sasha Levin wrote: > > Might happen when hardware virtualization is not supported. > > > > Reported-by: Ingo Molnar > > Signed-off-by: Sasha Levin > > --- > > tools/kvm/builtin-run.c |4 > > 1 files changed, 4 i

git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
Hi all, first of all I'm a bit confused: What is the difference between qemu with command line option --enable-kvm and qemu-kvm? It seems to be a difference in code so far, from the performance point of view it seems to be the same... Now my issue that lead me to a git bisect on qemu-kvm: The f

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Paolo Bonzini
On 02/01/2012 01:43 PM, Jan Kiszka wrote: > It looks good, besides the need to rebase to Anthony's "part 3" changes. Given that this part is not upstream and that the relevant conversion is scripted, I would leave this to Anthony so far. Or what is the schedule? By the time your series is revi

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Jan Kiszka
On 2012-02-01 13:55, Paolo Bonzini wrote: > On 02/01/2012 01:43 PM, Jan Kiszka wrote: >>> It looks good, besides the need to rebase to Anthony's "part 3" changes. >> Given that this part is not upstream and that the relevant conversion is >> scripted, I would leave this to Anthony so far. Or what

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Jan Kiszka
On 2012-02-01 14:10, Jan Kiszka wrote: > On 2012-02-01 13:55, Paolo Bonzini wrote: >> On 02/01/2012 01:43 PM, Jan Kiszka wrote: It looks good, besides the need to rebase to Anthony's "part 3" changes. >>> Given that this part is not upstream and that the relevant conversion is >>> scripted, I

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Avi Kivity
On 02/01/2012 01:12 PM, Takuya Yoshikawa wrote: > (2012/02/01 20:01), Avi Kivity wrote: >> On 02/01/2012 01:00 PM, Takuya Yoshikawa wrote: > >>> How about just doing: >>> >>> take a spin_lock >>> copy the entire (or some portions of) bitmap locally >>> clear the bitmap >>> unlock >>> >> >> That mea

Re: [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Avi Kivity
On 02/01/2012 01:00 PM, Marcelo Tosatti wrote: > On Wed, Feb 01, 2012 at 12:27:00PM +0200, Avi Kivity wrote: > > If the guest thinks it's an AMD, it will not have prepared the SYSENTER > > MSRs, > > and if the guest executes SYSENTER in compatibility mode, it will fails. > > > > Detect this condi

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Anthony Liguori
On 02/01/2012 06:43 AM, Jan Kiszka wrote: On 2012-02-01 13:23, Paolo Bonzini wrote: On 01/31/2012 10:49 PM, Jan Kiszka wrote: Just make the methods that you want to override virtual with the default implementation and then make a KVMPIT that inherits from the PIT and then overrides whatev

Re: [Android-virt] [PATCH v5 00/13] KVM/ARM Implementation

2012-02-01 Thread Marc Zyngier
On 01/02/12 12:20, Peter Maydell wrote: > On 1 February 2012 12:11, Marc Zyngier wrote: >> The obvious fix would be to test for the virt extensions in ID_PFR1 >> before enabling KVM, and mask out the virt extensions from the same >> register in the guest by trapping CP15-c0. But c0 is used by cach

Re: git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Avi Kivity
On 02/01/2012 02:52 PM, Erik Rull wrote: > Hi all, > > first of all I'm a bit confused: > > What is the difference between qemu with command line option --enable-kvm > and qemu-kvm? > It seems to be a difference in code so far, from the performance point of > view it seems to be the same... The d

Re: [PATCH v2 8/8] pci-assign: Update MSI-X config based on table writes

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 09:22 +0200, Michael S. Tsirkin wrote: > On Tue, Jan 31, 2012 at 10:33:14PM -0700, Alex Williamson wrote: > > When a guest enables MSI-X in PCI configuration space we walk > > through the MSI-X vector table trying to guess what might get > > used. We have to guess because we

[PATCH v2] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Avi Kivity
If the guest thinks it's an AMD, it will not have prepared the SYSENTER MSRs, and if the guest executes SYSENTER in compatibility mode, it will fails. Detect this condition and #UD instead, like the spec says. Signed-off-by: Avi Kivity --- v2: initialize eax/ecx for cpuid arch/x86/kvm/emulate

Re: [PATCH v2 8/8] pci-assign: Update MSI-X config based on table writes

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 09:25 +0200, Michael S. Tsirkin wrote: > On Tue, Jan 31, 2012 at 10:33:14PM -0700, Alex Williamson wrote: > > @@ -1438,11 +1448,71 @@ static void msix_mmio_write(void *opaque, > > target_phys_addr_t addr, > > uint64_t val, unsigned size) > > { >

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Marcelo Tosatti
On Wed, Feb 01, 2012 at 12:49:57PM +0200, Avi Kivity wrote: > On 02/01/2012 12:44 PM, Avi Kivity wrote: > > On 02/01/2012 12:22 PM, Peter Zijlstra wrote: > > > One of the things I was thinking of is adding a sequence counter in the > > > per-cpu data. Using that we could do something like: > > > >

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Marcelo Tosatti
On Wed, Feb 01, 2012 at 01:01:38PM +0200, Avi Kivity wrote: > On 02/01/2012 01:00 PM, Takuya Yoshikawa wrote: > > > >> rcu_assign_pointer), and use atomic operations to copy and clear: > >> > >>word = bitmap[i] > >>put_user(word) > >>atomic_and(&bitmap[i], ~word) > >> > >> > > > > This

Re: [PATCH 1/9] pci-assign: Optionally enable 64bit BARs in guest

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 11:03 +0200, Avi Kivity wrote: > On 01/31/2012 11:14 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 31, 2012 at 02:08:38PM -0700, Alex Williamson wrote: > > > On Tue, 2012-01-31 at 15:33 +0200, Avi Kivity wrote: > > > > On 01/31/2012 03:21 PM, Jan Kiszka wrote: > > > > > On 201

Re: [PATCH 3/9] pci-assign: Update MSI-X MMIO to Memory API

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 11:04 +0200, Avi Kivity wrote: > On 02/01/2012 06:22 AM, Alex Williamson wrote: > > On Tue, 2012-01-31 at 14:13 -0700, Alex Williamson wrote: > > > On Tue, 2012-01-31 at 14:45 +0200, Avi Kivity wrote: > > > > On 01/28/2012 04:21 PM, Alex Williamson wrote: > > > > > Stop using

Re: [Android-virt] [PATCH v5 00/13] KVM/ARM Implementation

2012-02-01 Thread Peter Maydell
On 1 February 2012 13:40, Marc Zyngier wrote: > On 01/02/12 12:20, Peter Maydell wrote: >> On 1 February 2012 12:11, Marc Zyngier wrote: >>> The obvious fix would be to test for the virt extensions in ID_PFR1 >>> before enabling KVM, and mask out the virt extensions from the same >>> register in

Re: [Android-virt] [PATCH v5 00/13] KVM/ARM Implementation

2012-02-01 Thread Christoffer Dall
If the final implementation is going to be as per this thread: http://lists.linaro.org/pipermail/boot-architecture/2011-August/58.html then this shouldn't actually be an issue right? On Wed, Feb 1, 2012 at 8:40 AM, Marc Zyngier wrote: > On 01/02/12 12:20, Peter Maydell wrote: >> On 1 Februa

Re: git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
On February 1, 2012 at 2:40 PM Avi Kivity wrote: > On 02/01/2012 02:52 PM, Erik Rull wrote: > > Hi all, > > > > first of all I'm a bit confused: > > > > What is the difference between qemu with command line option --enable-kvm > > and qemu-kvm? > > It seems to be a difference in code so far, fr

Re: [PATCH v2 8/8] pci-assign: Update MSI-X config based on table writes

2012-02-01 Thread Jan Kiszka
On 2012-02-01 14:48, Alex Williamson wrote: > On Wed, 2012-02-01 at 09:22 +0200, Michael S. Tsirkin wrote: >> On Tue, Jan 31, 2012 at 10:33:14PM -0700, Alex Williamson wrote: >>> When a guest enables MSI-X in PCI configuration space we walk >>> through the MSI-X vector table trying to guess what mi

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Paul E. McKenney
On Wed, Feb 01, 2012 at 11:22:29AM +0100, Peter Zijlstra wrote: > On Tue, 2012-01-31 at 14:24 -0800, Paul E. McKenney wrote: > > > > > Can we get it back to speed by scheduling a work function on all cpus? > > > > wouldn't that force a quiescent state and allow call_srcu() to fire? > > > > > > >

Re: Partial review of kvm arm git patches.

2012-02-01 Thread Christoffer Dall
On Wed, Feb 1, 2012 at 1:27 AM, Rusty Russell wrote: > Hi all, > >        Started reading through the git tree at > git://github.com/virtualopensystems/linux-kvm-arm.git (kvm-a15-v6-stage > branch), and noticed some things.  I'm learning ARM as I go, so > apologies in advance for any dumb question

Re: git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Jan Kiszka
On 2012-02-01 15:02, Erik Rull wrote: > > On February 1, 2012 at 2:40 PM Avi Kivity wrote: > >> On 02/01/2012 02:52 PM, Erik Rull wrote: >>> Hi all, >>> >>> first of all I'm a bit confused: >>> >>> What is the difference between qemu with command line option > --enable-kvm >>> and qemu-kvm? >>>

Re: [PATCH v2 8/8] pci-assign: Update MSI-X config based on table writes

2012-02-01 Thread Michael S. Tsirkin
On Wed, Feb 01, 2012 at 06:48:32AM -0700, Alex Williamson wrote: > On Wed, 2012-02-01 at 09:22 +0200, Michael S. Tsirkin wrote: > > On Tue, Jan 31, 2012 at 10:33:14PM -0700, Alex Williamson wrote: > > > When a guest enables MSI-X in PCI configuration space we walk > > > through the MSI-X vector tab

Re: [PATCH 1/9] pci-assign: Optionally enable 64bit BARs in guest

2012-02-01 Thread Michael S. Tsirkin
On Wed, Feb 01, 2012 at 06:55:40AM -0700, Alex Williamson wrote: > On Wed, 2012-02-01 at 11:03 +0200, Avi Kivity wrote: > > On 01/31/2012 11:14 PM, Michael S. Tsirkin wrote: > > > On Tue, Jan 31, 2012 at 02:08:38PM -0700, Alex Williamson wrote: > > > > On Tue, 2012-01-31 at 15:33 +0200, Avi Kivity

Re: [PATCH 1/9] pci-assign: Optionally enable 64bit BARs in guest

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 17:18 +0200, Michael S. Tsirkin wrote: > On Wed, Feb 01, 2012 at 06:55:40AM -0700, Alex Williamson wrote: > > On Wed, 2012-02-01 at 11:03 +0200, Avi Kivity wrote: > > > On 01/31/2012 11:14 PM, Michael S. Tsirkin wrote: > > > > On Tue, Jan 31, 2012 at 02:08:38PM -0700, Alex Wil

Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Takuya Yoshikawa
On Wed, 1 Feb 2012 11:43:47 -0200 Marcelo Tosatti wrote: > > > I can show you some performance numbers, this weekend, if you like. > > > > That'll be great, numbers are better than speculation. > > get dirty log:5634134 ns for 262144 dirty pages > > 5ms (for the entire operation). >

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
On February 1, 2012 at 3:42 PM Jan Kiszka wrote: > On 2012-02-01 15:02, Erik Rull wrote: > > > > On February 1, 2012 at 2:40 PM Avi Kivity wrote: > > > >> On 02/01/2012 02:52 PM, Erik Rull wrote: > >>> Hi all, > >>> > >>> first of all I'm a bit confused: > >>> > >>> What is the difference betw

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Jan Kiszka
On 2012-02-01 16:43, Erik Rull wrote: > On February 1, 2012 at 3:42 PM Jan Kiszka wrote: > >> On 2012-02-01 15:02, Erik Rull wrote: >>> >>> On February 1, 2012 at 2:40 PM Avi Kivity wrote: >>> On 02/01/2012 02:52 PM, Erik Rull wrote: > Hi all, > > first of all I'm a bit confus

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
On February 1, 2012 at 5:01 PM Jan Kiszka wrote: > On 2012-02-01 16:43, Erik Rull wrote: > > On February 1, 2012 at 3:42 PM Jan Kiszka wrote: > > > >> On 2012-02-01 15:02, Erik Rull wrote: > >>> > >>> On February 1, 2012 at 2:40 PM Avi Kivity wrote: > >>> > On 02/01/2012 02:52 PM, Erik R

Re: git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Jan Kiszka
On 2012-02-01 13:52, Erik Rull wrote: > Hi all, > > first of all I'm a bit confused: > > What is the difference between qemu with command line option --enable-kvm > and qemu-kvm? > It seems to be a difference in code so far, from the performance point of > view it seems to be the same... > > No

Re: [PATCH 2/3] device_isolation: Support isolation on POWER p5ioc2 bridges

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > This patch adds code to the code for the powernv platform to create > and populate isolation groups on hardware using the p5ioc2 PCI host > bridge used on some IBM POWER systems. > > Signed-off-by: Alexey Kardashevskiy > Signed-off-by: Davi

Re: [PATCH 2/3] device_isolation: Support isolation on POWER p5ioc2 bridges

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 11:58 -0700, Alex Williamson wrote: > On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > > This patch adds code to the code for the powernv platform to create > > and populate isolation groups on hardware using the p5ioc2 PCI host > > bridge used on some IBM POWER system

Re: [PATCH 3/3] device_isolation: Support isolation on POWER p7ioc (IODA) bridges

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > This patch adds code to the code for the powernv platform to create > and populate isolation groups on hardware using the p7ioc (aka IODA) PCI host > bridge used on some IBM POWER systems. > > Signed-off-by: Alexey Kardashevskiy > Signed-of

[PATCH v4 1/7] i8254: Do not raise IRQ level on reset

2012-02-01 Thread Jan Kiszka
Avoid changing the IRQ level to high on reset as it may trigger spurious events. Instead, open-code the effects of pit_load_count(0) in the reset handler. Signed-off-by: Jan Kiszka --- hw/i8254.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/i8254.c b/hw/i825

[PATCH v4 0/7] pit, hpet, pcspk: fixes & preparation for KVM

2012-02-01 Thread Jan Kiszka
Changes in V4: - rebased over qom-upstream.13 - comment on rtc_irq_level clearing on reset - fix call to isa_register_ioport by passing the pcspk device Not changed: - PIT pointer property of pcspk (Paolo will port it together with other PROP_PTR users) CC: Paolo Bonzini Jan Kiszka (7):

[PATCH v4 3/7] i8254: Factor out interface header

2012-02-01 Thread Jan Kiszka
Move the public interface of the PIT into its own header file and update all users. Signed-off-by: Jan Kiszka --- hw/alpha_dp264.c |1 + hw/hpet.c |1 + hw/i82378.c|1 + hw/i8254.c |1 + hw/i8254.h | 54

[PATCH v4 5/7] i8254: Rework & fix interaction with HPET in legacy mode

2012-02-01 Thread Jan Kiszka
When the HPET enters legacy mode, the IRQ output of the PIT is suppressed and replaced by the HPET timer 0. But the current code to emulate this was broken in many ways. It reset the PIT state after re-enabling, it worked against a stale static PIT structure, and it did not properly saved/restored

[PATCH v4 4/7] i8254: Pass alternative IRQ output object on initialization

2012-02-01 Thread Jan Kiszka
HPET legacy emulation will require control over the PIT IRQ output. To enable this, add support for an alternative IRQ output object to the PIT factory function. If the isa_irq number is < 0, this object will be used. This also removes the IRQ number property from the PIT class as we now use a gen

[PATCH v4 6/7] pcspk: Convert to qdev

2012-02-01 Thread Jan Kiszka
Convert the PC speaker device to a qdev ISA model. Move the public interface to a dedicated header file at this chance. CC: Paolo Bonzini Signed-off-by: Jan Kiszka --- arch_init.c|1 + hw/i82378.c|3 +- hw/mips_jazz.c |3 +- hw/pc.c|3 +- hw/pc.h|4 --

[PATCH v4 2/7] hpet: Save/restore cached RTC IRQ level

2012-02-01 Thread Jan Kiszka
In legacy mode, the HPET suppresses the RTC interrupt delivery via IRQ 8 but keeps track of the RTC output level and applies it when legacy mode is turned off again. This value has to be preserved across save/ restore as it cannot be reconstructed otherwise. To document that a raised rtc_irq_level

[PATCH v4 7/7] i8254: Factor out pit_get_channel_info

2012-02-01 Thread Jan Kiszka
Instead of providing 4 individual query functions for mode, gate, output and initial counter state, introduce a service that queries all information at once. This comes with tiny additional costs for pcspk_callback but with a much cleaner interface. Also, it will simplify the implementation of the

Re: [Qemu-discuss] E1000 & virtio will not respect set MTU

2012-02-01 Thread Markus Kovero
As we can see here, packet length varies over what it should be, when using realtek, packet length is strictly 1448, which fits uplink fine and upload degration will not occur. This is not a pmtu problem either, same thing happens when pmtu discovery is disabled. This also happens on Windows, s

Re: RFC: Device isolation groups

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > This patch series introduces a new infrastructure to the driver core > for representing "device isolation groups". That is, groups of > devices which can be "isolated" in such a way that the rest of the > system can be protected from them, e

Re: git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
Jan Kiszka wrote: On 2012-02-01 13:52, Erik Rull wrote: Hi all, first of all I'm a bit confused: What is the difference between qemu with command line option --enable-kvm and qemu-kvm? It seems to be a difference in code so far, from the performance point of view it seems to be the same...

[PATCH] pci: Add generic PCI device option to disable 64bit MMIO BARs

2012-02-01 Thread Alex Williamson
As we start to enable 64bit I/O devices, there's a good chance we'll find bugs and compatibility issues. This allows a user to toggle off (default on) 64bit PCI MMIO BARs, downgrading them to 32bit BARs. Signed-off-by: Alex Williamson --- Should this be an "x-mem64" option implying that it's re

Re: [PATCH] pci: Add generic PCI device option to disable 64bit MMIO BARs

2012-02-01 Thread Michael S. Tsirkin
On Wed, Feb 01, 2012 at 03:57:02PM -0700, Alex Williamson wrote: > As we start to enable 64bit I/O devices, there's a good chance > we'll find bugs and compatibility issues. This allows a user > to toggle off (default on) 64bit PCI MMIO BARs, downgrading > them to 32bit BARs. > > Signed-off-by: A

Re: [PATCH] pci: Add generic PCI device option to disable 64bit MMIO BARs

2012-02-01 Thread Alex Williamson
On Thu, 2012-02-02 at 01:14 +0200, Michael S. Tsirkin wrote: > On Wed, Feb 01, 2012 at 03:57:02PM -0700, Alex Williamson wrote: > > As we start to enable 64bit I/O devices, there's a good chance > > we'll find bugs and compatibility issues. This allows a user > > to toggle off (default on) 64bit P

Re: [PATCH] pci: Add generic PCI device option to disable 64bit MMIO BARs

2012-02-01 Thread Alex Williamson
On Wed, 2012-02-01 at 15:57 -0700, Alex Williamson wrote: > As we start to enable 64bit I/O devices, there's a good chance > we'll find bugs and compatibility issues. This allows a user > to toggle off (default on) 64bit PCI MMIO BARs, downgrading > them to 32bit BARs. > > Signed-off-by: Alex Wil

Re: [PATCH 3/3] device_isolation: Support isolation on POWER p7ioc (IODA) bridges

2012-02-01 Thread David Gibson
On Wed, Feb 01, 2012 at 12:17:05PM -0700, Alex Williamson wrote: > On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > > This patch adds code to the code for the powernv platform to create > > and populate isolation groups on hardware using the p7ioc (aka IODA) PCI > > host > > bridge used on

Re: RFC: Device isolation groups

2012-02-01 Thread David Gibson
On Wed, Feb 01, 2012 at 01:08:39PM -0700, Alex Williamson wrote: > On Wed, 2012-02-01 at 15:46 +1100, David Gibson wrote: > > This patch series introduces a new infrastructure to the driver core > > for representing "device isolation groups". That is, groups of > > devices which can be "isolated"

[PATCH V3] kvm tools: Add build target for statically-linked binary

2012-02-01 Thread Matt Evans
This commit adds a target for 'lkvm-static' which is linked -static. (This can be useful to construct kvmtool binaries for minimalist auto-test host filesystems.) Since extra features (SDL, AIO, VNC etc.) are auto-detected in the makefile AND some features may only work when linked one way (but n

Re: [PATCH V3] kvm tools: Add build target for statically-linked binary

2012-02-01 Thread Asias He
On 02/02/2012 10:47 AM, Matt Evans wrote: > This commit adds a target for 'lkvm-static' which is linked -static. > > (This can be useful to construct kvmtool binaries for minimalist > auto-test host filesystems.) > > Since extra features (SDL, AIO, VNC etc.) are auto-detected in the makefile > AN

[PULL 0/5] ppc patch queue 2012-02-02

2012-02-01 Thread Alexander Graf
Hi Avi / Marcelo, This is my current patch queue for ppc. Please pull. Alex The following changes since commit e27aad2f39d85009e8b6ce8f58b9809b22083c23: Avi Kivity (1): Merge remote-tracking branch 'upstream' into next are available in the git repository at: git://github.com/agraf

[PATCH 4/5] KVM: PPC: Initialize linears with zeros

2012-02-01 Thread Alexander Graf
RMAs and HPT preallocated spaces should be zeroed, so we don't accidently leak information from previous VM executions. Signed-off-by: Alexander Graf Acked-by: Paul Mackerras --- arch/powerpc/kvm/book3s_hv_builtin.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/p

[PATCH 5/5] KVM: PPC: Add HPT preallocator

2012-02-01 Thread Alexander Graf
We're currently allocating 16MB of linear memory on demand when creating a guest. That does work some times, but finding 16MB of linear memory available in the system at runtime is definitely not a given. So let's add another command line option similar to the RMA preallocator, that we can use to

[PATCH 3/5] KVM: PPC: Convert RMA allocation into generic code

2012-02-01 Thread Alexander Graf
We have code to allocate big chunks of linear memory on bootup for later use. This code is currently used for RMA allocation, but can be useful beyond that extent. Make it generic so we can reuse it for other stuff later. Signed-off-by: Alexander Graf Acked-by: Paul Mackerras --- arch/powerpc/

[PATCH 1/5] KVM: Move gfn_to_memslot() to kvm_host.h

2012-02-01 Thread Alexander Graf
From: Paul Mackerras This moves __gfn_to_memslot() and search_memslots() from kvm_main.c to kvm_host.h to reduce the code duplication caused by the need for non-modular code in arch/powerpc/kvm/book3s_hv_rm_mmu.c to call gfn_to_memslot() in real mode. Rather than putting gfn_to_memslot() itself

[PATCH 2/5] KVM: PPC: E500: Fail init when not on e500v2

2012-02-01 Thread Alexander Graf
When enabling the current KVM code on e500mc, I get the following oops: Oops: Exception in kernel mode, sig: 4 [#1] SMP NR_CPUS=8 P2041 RDB Modules linked in: NIP: c067df4c LR: c067df44 CTR: REGS: ee055ed0 TRAP: 0700 Not tainted (3.2.0-10391-g36c5afe) MSR: 00029

Partial review of kvm arm git patches.

2012-02-01 Thread Rusty Russell
Hi all, Started reading through the git tree at git://github.com/virtualopensystems/linux-kvm-arm.git (kvm-a15-v6-stage branch), and noticed some things. I'm learning ARM as I go, so apologies in advance for any dumb questions. Firstly, I want to say that reading this code was a pleasant

[test result] dirty logging without srcu update -- Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-01 Thread Takuya Yoshikawa
Avi Kivity wrote: > >> That'll be great, numbers are better than speculation. > >> > > > > > > Yes, I already have some good numbers to show (and some patches). > > Looking forward. I made a patch to see if Avi's suggestion of getting rid of srcu update for dirty logging is practical; tested w

Re: [PATCH V3] kvm tools: Add build target for statically-linked binary

2012-02-01 Thread Pekka Enberg
On Thu, Feb 2, 2012 at 5:03 AM, Asias He wrote: > On 02/02/2012 10:47 AM, Matt Evans wrote: >> This commit adds a target for 'lkvm-static' which is linked -static. >> >> (This can be useful to construct kvmtool binaries for minimalist >> auto-test host filesystems.) >> >> Since extra features (SDL

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-01 Thread Michael S. Tsirkin
On Sun, Nov 20, 2011 at 08:30:24AM -0800, Roopa Prabhu wrote: > > > > On 11/17/11 4:15 PM, "Ben Hutchings" wrote: > > > Sorry to come to this rather late. > > > > On Tue, 2011-11-08 at 23:55 -0800, Roopa Prabhu wrote: > > [...] > >> v2 -> v3 > >> - Moved set and get filter ops from rtnl_link_

  1   2   >