Re: [PATCH 1/2] virtio: fix memory leak on device removal

2009-07-23 Thread Michael S. Tsirkin
On Thu, Jul 23, 2009 at 01:56:58PM +0930, Rusty Russell wrote: > On Wed, 22 Jul 2009 01:29:09 am Michael S. Tsirkin wrote: > > Free up msi vector tables. > > Michael, this papers over the bug, but doesn't actually fix the problem. > > The problem is that vp_free_vectors() does not do the reverse

Re: [PATCH 1/2] virtio: fix memory leak on device removal

2009-07-22 Thread Rusty Russell
On Wed, 22 Jul 2009 01:29:09 am Michael S. Tsirkin wrote: > Free up msi vector tables. Michael, this papers over the bug, but doesn't actually fix the problem. The problem is that vp_free_vectors() does not do the reverse of vp_request_vectors. If the author (you) can't get it right, what hope

Re: [PATCH 1/2] virtio: fix memory leak on device removal

2009-07-21 Thread Michael S. Tsirkin
Free up msi vector tables. Signed-off-by: Michael S. Tsirkin --- Resending with corrected To list. Sorry about the churn. drivers/virtio/virtio_pci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 193c8