On Thu, Jul 23, 2009 at 01:56:58PM +0930, Rusty Russell wrote: > On Wed, 22 Jul 2009 01:29:09 am Michael S. Tsirkin wrote: > > Free up msi vector tables. > > Michael, this papers over the bug, but doesn't actually fix the problem. > > The problem is that vp_free_vectors() does not do the reverse of > vp_request_vectors. If the author (you) can't get it right, what hope the > rest of us?
I agree. This code belongs in free_vectors. And might as well reset the pointers to make the reversal complete. > Indeed, if you look harder, you'll see another leak caused by this problem, > which your patch *didn't* fix. Couldn't spot it yet. I'll send out a fixed patch, see if I got everything covered. > Thanks, > Rusty. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
