SVN commit 926385 by mlaurent:
Fix iterator and pedantic
CCMAIL: kopete-devel@kde.org
A 024_fix_semicolons_and_iterator.patch
M +1 -1 iris/irisnet/appledns/appledns.cpp
M +1 -1 iris/irisnet/corelib/jdnsshared.cpp
M +2 -2 iris/irisnet/corelib/netinterface_u
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123489/#review79436
---
Ship it!
Seems good for me.
Ship it
- Laurent Montel
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123162/#review79617
---
Ship it!
If url works.
Ship it :)
- Laurent Montel
On
Le Friday 01 May 2015 16:41:05 R.Harish Navnit a écrit :
> Not sure if Laurent is subscribed to this list. Adding him to the
> discussions.
>
> Warm Regards.
>
> Thanking You,
> R.Harish Navnit
I am on ML but thanks to add me to CC :)
Regards.
___
kop
art.
It's not a customwidget now that it use a QListWidget
- Laurent Montel
On juin 14, 2015, 2:08 après-midi, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. T
p currentItem
plugins/texteffect/texteffectpreferences.cpp (line 204)
<https://git.reviewboard.kde.org/r/124094/#comment55932>
currentItem ?
plugins/texteffect/texteffectpreferences.cpp (line 232)
<https://git.reviewboard.kde.org/r/124094/#comment55933>
fix indent
- Laurent Montel
On juin 19
> On juin 23, 2015, 7:41 matin, R.Harish Navnit wrote:
> > This change has been pushed to the frameworks scratch repo :
> > http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.git&a=commit&h=1b3909d2d81042804a217bfe9f81b8caa38bdb86
> >
> >
> > Should this be closed/marked
tps://git.reviewboard.kde.org/r/124184/#comment56071>
Why this definition ?
- Laurent Montel
On juin 26, 2015, 4:28 matin, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
460)
<https://git.reviewboard.kde.org/r/124181/#comment56073>
it's not local include.
Remove it.
- Laurent Montel
On juin 25, 2015, 6:12 après-midi, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated
24173/#comment56079>
Remove it...
- Laurent Montel
On juin 25, 2015, 12:47 après-midi, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
tps://git.reviewboard.kde.org/r/124173/#comment56091>
Remove it too.
QTreeView is a native widget
protocols/groupwise/ui/gwcustomstatus.ui (line 83)
<https://git.reviewboard.kde.org/r/124173/#comment56092>
Not necessary
- Laurent Montel
On juin 26, 2015, 1:59 après-mi
)
<https://git.reviewboard.kde.org/r/124184/#comment56161>
Remove it...
Please read diff before to upload it
Thanks
- Laurent Montel
On juin 27, 2015, 5:20 après-midi, R.Harish Navnit wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124184/#review81838
---
Ship it!
- Laurent Montel
On juin 28, 2015, 8:19 après
tps://git.reviewboard.kde.org/r/124173/#comment56178>
Remove it as usual it's a native widget
- Laurent Montel
On juin 28, 2015, 8:04 après-midi, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To r
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124173/#review81975
---
Ship it!
Seems good now.
Ship it
- Laurent Montel
On juin
)
<https://git.reviewboard.kde.org/r/124094/#comment56646>
you want to take currentitem no ?
so why to get item from listWidget()->row(i) ?
- Laurent Montel
On juin 21, 2015, 11:41 matin, R.Harish Navnit wrote:
>
> -
)
<https://git.reviewboard.kde.org/r/124305/#comment56647>
-1...
=> crash.
- Laurent Montel
On juil. 9, 2015, 12:20 après-midi, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To rep
)
<https://git.reviewboard.kde.org/r/124094/#comment56671>
takeItem(p) is enough no ?
- Laurent Montel
On juin 21, 2015, 11:41 matin, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
's ok.
Please commit in master
- Laurent Montel
On juil. 12, 2015, 2:14 après-midi, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.review
::setOpenExternalLinks(true) for labels with
hyperlinks;
*
QLabel::setTextInteractionFlags(Qt::TextSelectableByMouse|Qt::TextSelectableByKeyboard)
for labels whose text
* should be selectable by user.)
But you replace just by QLabel it's normal ?
- Laurent Montel
On juil. 14, 2015,
tps://git.reviewboard.kde.org/r/124345/#comment56921>
Why it's not ported ?
libkopete/ui/accountselector.cpp (line 109)
<https://git.reviewboard.kde.org/r/124345/#comment56922>
Please reread doc
- Laurent Montel
On juil. 14, 2015, 7:20 matin, R.Har
(line 80)
<https://git.reviewboard.kde.org/r/124349/#comment56925>
Read doc it's a QStackedWidget...
protocols/gadu/gadupubdir.cpp (line 120)
<https://git.reviewboard.kde.org/r/124349/#comment56926>
?
- Laurent Montel
On juil. 14, 2015, 6:07
)
<https://git.reviewboard.kde.org/r/124227/#comment56927>
Why ?
Why not add directly setColumCount(2) ?
plugins/autoreplace/autoreplacepreferences.cpp (line 214)
<https://git.reviewboard.kde.org/r/124227/#comment56928>
indent
- Laurent Montel
On juil. 14, 2015, 6:2
)
<https://git.reviewboard.kde.org/r/124227/#comment56995>
why it's better ?
you know how many column you added.
=> so not necessary to recalculate the number of column.
- Laurent Montel
On juil. 19, 2015, 12:15 après-midi, R.Harish
)
<https://git.reviewboard.kde.org/r/124227/#comment57044>
What do you think about
for (int i = 0; i < prefer...->m_list->toplevelitemcount() ; ++i) {
QTreeWidgetItem *item = ...->m_list->toplevelitem(i);
newWords[item->text(0)] = ...;
}
?
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124344/#review82723
---
Ship it!
Seems ok.
Ship it
- Laurent Montel
On juil. 20
tps://git.reviewboard.kde.org/r/124345/#comment57045>
when do you increase *it ?
(see doc )
libkopete/ui/accountselector.cpp (line 141)
<https://git.reviewboard.kde.org/r/124345/#comment57046>
same here
- Laurent Montel
On juil. 20, 2015, 1:30 après-midi, R.Harish
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review82747
---
Ship it!
Seems good.
Ship it
- Laurent Montel
On juil. 10
)
<https://git.reviewboard.kde.org/r/124227/#comment57131>
It's duplicate no ?
- Laurent Montel
On juil. 21, 2015, 1:10 après-midi, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To r
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124344/#review82813
---
Ship it!
Seems good.
Ship it
- Laurent Montel
On juil. 21
)
<https://git.reviewboard.kde.org/r/124305/#comment57256>
Why you don't :
QListWidgetItem *item = new QListWidgetITem(QIcon, QString);
QListWidget::addITem(item); ?
- Laurent Montel
On juil. 26, 2015, 5:43 matin, R.Harish N
)
<https://git.reviewboard.kde.org/r/124181/#comment57658>
verify signal please :)
are you sure that it's value ands not pointer ?
- Laurent Montel
On juil. 26, 2015, 11:17 matin, R.Harish Navnit wrote:
>
> ---
> On juil. 15, 2015, 4:43 matin, Laurent Montel wrote:
> > protocols/gadu/gadueditcontact.cpp, line 111
> > <https://git.reviewboard.kde.org/r/124349/diff/1/?file=385399#file385399line111>
> >
> > So item which is not selectable and disable ?
>
> R.
.
- Laurent Montel
On juil. 26, 2015, 7:19 matin, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124800/#review83978
---
Ship it!
Seems good.
Ship it
- Laurent Montel
On août 18
tps://git.reviewboard.kde.org/r/124181/#comment58181>
? isSelected => isHidden ?
- Laurent Montel
On août 9, 2015, 9:19 après-midi, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To rep
tps://git.reviewboard.kde.org/r/124691/#comment58180>
KLocalizedString
- Laurent Montel
On août 10, 2015, 8:49 après-midi, R.Harish Navnit wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
mt ?
protocols/sms/services/CMakeLists.txt (line 9)
<https://git.reviewboard.kde.org/r/124721/#comment58187>
Add info about commented code ?
MESSAGE(STATUS "commented code ")
- Laurent Montel
On août 12,
Le jeudi 11 mai 2017, 10:36:10 CEST laurent Montel a écrit :
> Le jeudi 11 mai 2017, 10:15:05 CEST Pali Rohár a écrit :
> > Ok, finish timetime and send it to mailing list. I hope that Montel
> > would comment it as one big part is automatic testing and should have
> > better
> On Friday 05 May 2017 22:16:48 vijay krishnavanshi wrote:
> > > >> Do we have to give updates on kde-devel also or just updates on
> > > >> kopete-devel are fine?
> > > >
> > > > kopete-devel is enough. It is public list with public ema
etter to work on kf5 port directly as it's disable in kf5 and
in next release 17.08 we will merge kf5 branch in master
So starting your Gsoc against kf5 branch is a better idea.
Regards
>
> > If I was willing to upgrade to Kopete as part of my GSoC project, even
> > before Qt5
create a Review Request and describe the
> issue?
>
> I know this needs to be figured out by me and I am doing it. But I thought
> its better to ask for help :)
>
> Regards,
> Vijay Krishnavanshi
Missing export symbol perhaps no ?
--
Laurent Montel | laurent.mon...@kdab.com
gins/history/historypreferences.cpp (line 27)
<https://git.reviewboard.kde.org/r/130154/#comment68730>
same here.
- Laurent Montel
On June 10, 2017, 3 p.m., Paulo Lieuthier wrote:
>
> ---
> This is an automatically generated e-mai
> On June 10, 2017, 4:26 p.m., Laurent Montel wrote:
> >
>
> Paulo Lieuthier wrote:
> I had already started translating those (and all others) in my main
> branch, and didn't want to mess with that here. Next review request will be
> such translation, isn&#
r ->
use QStringLiteral
tests/libkopete/kopetestatustest.cpp (line 43)
<https://git.reviewboard.kde.org/r/130155/#comment68742>
remove space before/after ->
use QStringLiteral etc.
- Laurent Montel
On June 17, 2017, 9:03 a.
line 46)
<https://git.reviewboard.kde.org/r/130155/#comment68745>
now you can test 2 signal etc.
Perhaps emit signal when same message etc.
you need to create more autotests which is more complex.
Regards
- Laurent Montel
On June 17, 2017, 8:21 p.m., Vija
eivefiletask.cpp
<https://git.reviewboard.kde.org/r/130161/#comment68764>
Why removed all debug ?
protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp (line 22)
<https://git.reviewboard.kde.org/r/130161/#comment68765>
why renamed it ?
e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130154/
> ---
>
> (Updated June 10, 2017, 3 p.m.)
>
>
> Review request for Kopete, Laurent Montel and Pali Rohár.
>
>
> Repository: kopete
>
>
> Descri
> On June 19, 2017, 4:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 287
> > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496313#file496313line287>
> >
> > it's not debug categories changes no ?:)
>
> Paulo Lieu
> On June 19, 2017, 4:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 326
> > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496313#file496313line326>
> >
> > same here etc.
>
> Paulo Lieuthier wrote:
> Same here
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103378
---
Ship it!
Ship It!
- Laurent Montel
On June 25, 2017
tps://git.reviewboard.kde.org/r/130155/#comment68931>
QCOMPARE
tests/libkopete/kopetestatusgrouptest.cpp (line 49)
<https://git.reviewboard.kde.org/r/130155/#comment68930>
QCOMPARE(...)
- Laurent Montel
On July 4, 2017, 9:15 p.m., Vijay Krishna
t them or discard. They will be available on
> git.reviewboard for reference later.
>
> Regards,
> Vijay Krishnavanshi
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53,
www.kdab.fr KDAB
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130183/#review103810
---
Ship it!
Ship It!
- Laurent Montel
On août 27, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130225/#review103811
---
Ship it!
Ship It!
- Laurent Montel
On août 12, 2017
mlaurent added a comment.
qCDebug not only qDebug :)
Otherwise we can't disable debug.
thanks
REPOSITORY
R434 Kopete
REVISION DETAIL
https://phabricator.kde.org/D7635
To: vijaykrishnavanshi, pali, mlaurent
Cc: #kopete
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R434 Kopete
BRANCH
kf5-fix-aboutbox
REVISION DETAIL
https://phabricator.kde.org/D8319
To: ltoscano, pali, mlaurent
Cc: #kopete
mlaurent commandeered this revision.
mlaurent edited reviewers, added: vijaykrishnavanshi; removed: mlaurent.
Herald edited subscribers, added: kopete-devel; removed: Kopete.
REPOSITORY
R434 Kopete
REVISION DETAIL
https://phabricator.kde.org/D7635
To: mlaurent, pali, vijaykrishnavanshi
Cc: k
mlaurent abandoned this revision.
mlaurent added a comment.
no change from 1 years 1/2
REPOSITORY
R434 Kopete
REVISION DETAIL
https://phabricator.kde.org/D7635
To: mlaurent, pali, vijaykrishnavanshi
Cc: kopete-devel, himanshuvishwakarma, cochise
59 matches
Mail list logo
