Review Request 113698: Krazy2 fix : New line at the end of file

/avatarwebcamdialog.h c6ab517 Diff: http://git.reviewboard.kde.org/r/113698/diff/ Testing --- Compiles & runs (Arch Linux) Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Review Request 113699: Krazy2 fix: Include own header first

/ui/kopetelistviewitem.cpp a330974 libkopete/ui/metacontactselectorwidget.cpp 7f8be2a Diff: http://git.reviewboard.kde.org/r/113699/diff/ Testing --- Compiles & runs (Arch Linux) Thanks, Harsh Kumar ___ kopete-devel mailing list ko

Re: Review Request 113698: Krazy2 fix : New line at the end of file

/index.html Diffs - kopete/config/avdevice/IdGuiElements.h e95bc16 libkopete/ui/avatarwebcamdialog.h c6ab517 Diff: http://git.reviewboard.kde.org/r/113698/diff/ Testing --- Compiles & runs (Arch Linux) Thanks, Harsh Kumar ___ kopete-d

Re: Review Request 113699: Krazy2 fix: Include own header first

anks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Review Request 113717: Krazy2 fix: More files - Include own header first

/chatwindow/chatmemberslistview.cpp 3229d91 Diff: http://git.reviewboard.kde.org/r/113717/diff/ Testing --- Compiles & runs (Arch Linux) Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/list

Review Request 113718: Krazy2 fix: Even More files - Include own header first

/privacymanager.cpp e4278a2 protocols/groupwise/libgroupwise/qcatlshandler.cpp 0c9265b protocols/groupwise/libgroupwise/requestfactory.cpp 6387370 Diff: http://git.reviewboard.kde.org/r/113718/diff/ Testing --- Compiles & runs (Arch Linux Thanks, Harsh K

Re: Review Request 113718: protocols: Krazy2 fix: Include own header first

370 Diff: http://git.reviewboard.kde.org/r/113718/diff/ Testing --- Compiles & runs (Arch Linux Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Review Request 113732: Including own header first in two files

--- Note: Please commit this patch after review. Diffs - plugins/autoreplace/autoreplacepreferences.cpp 7b5ed12 protocols/skype/libskype/skypewindow.cpp 1b22ff8 Diff: http://git.reviewboard.kde.org/r/113732/diff/ Testing --- Compiles & runs (Arch Linux) Thanks, H

Review Request 113733: [patch 1/28] nljuk header file needs to include other header files

ning/nljuk.cpp 26001b7 Diff: http://git.reviewboard.kde.org/r/113733/diff/ Testing --- Compiles & runs (Arch Linux) Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Review Request 113735: [patch 2/28] customnotificationprops header file needs to include other header files

[patch 1/28] of this series Diffs - kopete/contactlist/customnotificationprops.cpp 6f46fc3 kopete/contactlist/customnotificationprops.h 923aecb Diff: http://git.reviewboard.kde.org/r/113735/diff/ Testing --- Thanks, Harsh Kumar

Review Request 113736: [patch 3/28] kabcpersistence header file needs to include other header files

[patch 1/28] of this series Diffs - libkopete/kabcpersistence.h b14741e libkopete/kabcpersistence.cpp 56b7007 Diff: http://git.reviewboard.kde.org/r/113736/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete

Review Request 113737: [patch 4/28] kopeteutils_private header file needs to include other header files

[patch 1/28] of this series Diffs - libkopete/private/kopeteutils_private.h a684c96 libkopete/private/kopeteutils_private.cpp 4c2c0de Diff: http://git.reviewboard.kde.org/r/113737/diff/ Testing --- Thanks, Harsh Kumar ___ kopete

Review Request 113738: [patch 5/28] nlmpris2 header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/nowlistening/nlmpris2.h a12d588 plugins/nowlistening/nlmpris2.cpp a20c530 Diff: http://git.reviewboard.kde.org/r/113738/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list

Review Request 113739: [patch 6/28] nlkscd.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/nowlistening/nlkscd.h 0e415bc plugins/nowlistening/nlkscd.cpp 5b09355 Diff: http://git.reviewboard.kde.org/r/113739/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list

Review Request 113740: [patch 7/28] nlkaffeine.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/nowlistening/nlkaffeine.h df3e795 plugins/nowlistening/nlkaffeine.cpp 780c240 Diff: http://git.reviewboard.kde.org/r/113740/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing

Review Request 113742: [patch 9/28] latexplugin.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/latex/latexplugin.h 8bd6297 plugins/latex/latexplugin.cpp 51b327c Diff: http://git.reviewboard.kde.org/r/113742/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete

Review Request 113747: [patch 13/28] highlightplugin.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/highlight/highlightplugin.h aa5e3f5 plugins/highlight/highlightplugin.cpp 1eb9818 Diff: http://git.reviewboard.kde.org/r/113747/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel

Review Request 113744: [patch 11/28] statisticscontact.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/statistics/statisticscontact.h 9d11eff plugins/statistics/statisticscontact.cpp a6c3783 Diff: http://git.reviewboard.kde.org/r/113744/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel

Review Request 113743: [patch 10/28] texteffectplugin.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/texteffect/texteffectplugin.h 14f4172 plugins/texteffect/texteffectplugin.cpp b810079 Diff: http://git.reviewboard.kde.org/r/113743/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel

Review Request 113741: [patch 8/28] nlamarok.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/nowlistening/nlamarok.h 6787552 plugins/nowlistening/nlamarok.cpp 6a23a15 Diff: http://git.reviewboard.kde.org/r/113741/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list

Review Request 113745: [patch 12/28] statisticsplugin.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/statistics/statisticsplugin.h 80f398d plugins/statistics/statisticsplugin.cpp a2f0cf8 Diff: http://git.reviewboard.kde.org/r/113745/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel

Review Request 113746: [patch 14/28] autoreplaceplugin.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/autoreplace/autoreplaceplugin.h 617e99a plugins/autoreplace/autoreplaceplugin.cpp 3206232 Diff: http://git.reviewboard.kde.org/r/113746/diff/ Testing --- Thanks, Harsh Kumar ___ kopete

Review Request 113755: [patch 21/28] qtbrowserplugin.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/skype/skypebuttons/qtbrowserplugin/qtbrowserplugin.h 34248a8 protocols/skype/skypebuttons/qtbrowserplugin/qtbrowserplugin.cpp 1e2881a Diff: http://git.reviewboard.kde.org/r/113755/diff/ Testing --- Thanks, Harsh Kumar

Review Request 113752: [patch 17/28] yahooverifyaccount.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/yahoo/yahooverifyaccount.h 29ed4c7 protocols/yahoo/yahooverifyaccount.cpp cc896c6 Diff: http://git.reviewboard.kde.org/r/113752/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel

Review Request 113754: [patch 20/28] yahoochatselectordialog.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/yahoo/ui/yahoochatselectordialog.h 6184497 protocols/yahoo/ui/yahoochatselectordialog.cpp f2984c6 Diff: http://git.reviewboard.kde.org/r/113754/diff/ Testing --- Thanks, Harsh Kumar

Review Request 113757: [patch 23/28] createconferencetask.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/groupwise/libgroupwise/tasks/createconferencetask.h bf7bec6 protocols/groupwise/libgroupwise/tasks/createconferencetask.cpp 5908ba5 Diff: http://git.reviewboard.kde.org/r/113757/diff/ Testing --- Thanks, Harsh Kumar

Review Request 113756: [patch 22/28] userdetailsmanager.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/groupwise/libgroupwise/userdetailsmanager.h 7fedfa5 protocols/groupwise/libgroupwise/userdetailsmanager.cpp 6a912bc Diff: http://git.reviewboard.kde.org/r/113756/diff/ Testing --- Thanks, Harsh Kumar

Review Request 113748: [patch 15/28] contactnotesplugin.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/contactnotes/contactnotesplugin.h dfc5865 plugins/contactnotes/contactnotesplugin.cpp 831e76b Diff: http://git.reviewboard.kde.org/r/113748/diff/ Testing --- Thanks, Harsh Kumar ___ kopete

Review Request 113753: [patch 19/28] yahooeditaccount.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/yahoo/yahooeditaccount.h ad18433 protocols/yahoo/yahooeditaccount.cpp 32074fc Diff: http://git.reviewboard.kde.org/r/113753/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing

Review Request 113758: [patch 24/28] joinchattask.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/groupwise/libgroupwise/tasks/joinchattask.h 2ff8145 protocols/groupwise/libgroupwise/tasks/joinchattask.cpp d4956ef Diff: http://git.reviewboard.kde.org/r/113758/diff/ Testing --- Thanks, Harsh Kumar

Review Request 113749: [patch 16/28] nlmpris.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/nowlistening/nlmpris.h 7f76a8c plugins/nowlistening/nlmpris.cpp 46f7a05 Diff: http://git.reviewboard.kde.org/r/113749/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list

Review Request 113751: [patch 18/28] yahooconferencemessagemanager.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/yahoo/yahooconferencemessagemanager.h 1fb1b84 protocols/yahoo/yahooconferencemessagemanager.cpp 3979dec Diff: http://git.reviewboard.kde.org/r/113751/diff/ Testing --- Thanks, Harsh Kumar

Review Request 113762: [patch 28/28] kabcexport.h header file needs to include other header files

[patch 1/28] of this series Diffs - kopete/contactlist/kabcexport.h e1a8089 kopete/contactlist/kabcexport.cpp d8b0978 Diff: http://git.reviewboard.kde.org/r/113762/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list

Review Request 113760: [patch 26/28] joinconferencetask.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/groupwise/libgroupwise/tasks/joinconferencetask.h ed36934 protocols/groupwise/libgroupwise/tasks/joinconferencetask.cpp 95ef20b Diff: http://git.reviewboard.kde.org/r/113760/diff/ Testing --- Thanks, Harsh Kumar

Review Request 113761: [patch 27/28] highlightpreferences.h header file needs to include other header files

[patch 1/28] of this series Diffs - plugins/highlight/highlightpreferences.h 0f84bf0 plugins/highlight/highlightpreferences.cpp 8bc74b1 Diff: http://git.reviewboard.kde.org/r/113761/diff/ Testing --- Thanks, Harsh Kumar ___ kopete

Review Request 113759: [patch 25/28] searchchattask.h header file needs to include other header files

[patch 1/28] of this series Diffs - protocols/groupwise/libgroupwise/tasks/searchchattask.h 5d97687 protocols/groupwise/libgroupwise/tasks/searchchattask.cpp 3011a20 Diff: http://git.reviewboard.kde.org/r/113759/diff/ Testing --- Thanks, Harsh Kumar

Re: Review Request 113733: [patch 1/28] nljuk header file needs to include other header files

ated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113733/#review43327 --- On Nov. 9, 2013, 8:32 p.m., Harsh Kumar wrote: > > --- > This is an automatically generated e

Re: Review Request 113718: protocols: Krazy2 fix: Include own header first

.kde.org/r/113718/diff/ Testing --- Compiles & runs (Arch Linux Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113717: Krazy2 fix: More files - Include own header first

/tests/chatwindowstyle_test.cpp 76e526e kopete/chatwindow/kopetechatwindow.cpp 0e52fb3 kopete/chatwindow/chatmemberslistview.cpp 3229d91 Diff: http://git.reviewboard.kde.org/r/113717/diff/ Testing --- Compiles & runs (Arch Linux) Thanks, Harsh K

Re: Review Request 113735: [patch 2/28] customnotificationprops header file needs to include other header files

/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113736: [patch 3/28] kabcpersistence header file needs to include other header files

, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113737: [patch 4/28] kopeteutils_private header file needs to include other header files

/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113742: [patch 9/28] latexplugin.h header file needs to include other header files

, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113747: [patch 13/28] highlightplugin.h header file needs to include other header files

--- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113740: [patch 7/28] nlkaffeine.h header file needs to include other header files

--- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113743: [patch 10/28] texteffectplugin.h header file needs to include other header files

/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113739: [patch 6/28] nlkscd.h header file needs to include other header files

--- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113738: [patch 5/28] nlmpris2 header file needs to include other header files

--- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113741: [patch 8/28] nlamarok.h header file needs to include other header files

--- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113746: [patch 14/28] autoreplaceplugin.h header file needs to include other header files

/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113745: [patch 12/28] statisticsplugin.h header file needs to include other header files

/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113744: [patch 11/28] statisticscontact.h header file needs to include other header files

/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113748: [patch 15/28] contactnotesplugin.h header file needs to include other header files

/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113752: [patch 17/28] yahooverifyaccount.h header file needs to include other header files

--- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113753: [patch 19/28] yahooeditaccount.h header file needs to include other header files

--- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113751: [patch 18/28] yahooconferencemessagemanager.h header file needs to include other header files

/113751/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113756: [patch 22/28] userdetailsmanager.h header file needs to include other header files

://git.reviewboard.kde.org/r/113756/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113761: [patch 27/28] highlightpreferences.h header file needs to include other header files

/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113758: [patch 24/28] joinchattask.h header file needs to include other header files

://git.reviewboard.kde.org/r/113758/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113759: [patch 25/28] searchchattask.h header file needs to include other header files

://git.reviewboard.kde.org/r/113759/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113754: [patch 20/28] yahoochatselectordialog.h header file needs to include other header files

/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113762: [patch 28/28] kabcexport.h header file needs to include other header files

--- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113755: [patch 21/28] qtbrowserplugin.h header file needs to include other header files

://git.reviewboard.kde.org/r/113755/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113760: [patch 26/28] joinconferencetask.h header file needs to include other header files

://git.reviewboard.kde.org/r/113760/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113733: [patch 1/28] nljuk header file needs to include other header files

for different files Diffs - plugins/nowlistening/nljuk.h 73cf5f4 plugins/nowlistening/nljuk.cpp 26001b7 Diff: http://git.reviewboard.kde.org/r/113733/diff/ Testing --- Compiles & runs (Arch Linux) Thanks, Harsh Kumar ___ kopete-devel

Re: Review Request 113749: [patch 16/28] nlmpris.h header file needs to include other header files

--- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request 113757: [patch 23/28] createconferencetask.h header file needs to include other header files

://git.reviewboard.kde.org/r/113757/diff/ Testing --- Thanks, Harsh Kumar ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel