----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113733/ -----------------------------------------------------------
(Updated Nov. 25, 2013, 5:45 p.m.) Status ------ This change has been marked as submitted. Review request for Kopete. Repository: kopete Description ------- 1. The nljuk.h needs to include QtDBus & nlmediaplayer.h But these header files were earlier not included. These header files were included in nljuk.cpp This will cause problems when nljuk.h will be included in some other file. This patch includes the required header files in nljuk.h 2. This patch also makes nljuk.cpp file to include its own header first. This is the fix which actually exposed the above issue. 3. The above 2 points apply to all the following patches in this series, but for different files Diffs ----- plugins/nowlistening/nljuk.h 73cf5f4 plugins/nowlistening/nljuk.cpp 26001b7 Diff: http://git.reviewboard.kde.org/r/113733/diff/ Testing ------- Compiles & runs (Arch Linux) Thanks, Harsh Kumar
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
