Re: Review Request 124345: Use treeWidgets instead of listviews in libkopete accountSelector

2017-06-18 Thread Pali Rohár
> On sep. 3, 2015, 8:38 dopoludnia, Pali Rohár wrote: > > libkopete/ui/accountselector.cpp, line 100 > > > > > > Are you sure that setHeaderLabel() is equivalent to addColumn? > > R.Harish Navnit wrote: > I

Re: Review Request 124701: Port libkopete to KDE4

2017-06-18 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124701/#review103336 --- libkopete/ui/accountselector.cpp (line 98)

KF5 patches for Kopete

2017-06-18 Thread Pali Rohár
Hi! I'm looking at kf5 branch and open review requests on reviewboard and I still see some patches on reviewboard which are marked as "needs fixing" but are already committed in kf5 branch. So before we push changes from kf5 branch into master, we need to resolve those "needs fixing" patches/comm

Re: Review Request 124332: Compile kopete plugins without KDE3/Qt3 support

2017-06-18 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/ --- (Updated June 18, 2017, 10:29 a.m.) Status -- This change has been m

Re: Review Request 124227: Remove Q3ListViews from autoreplace

2017-06-18 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/ --- (Updated June 18, 2017, 10:29 a.m.) Status -- This change has been m

Re: Review Request 124345: Use treeWidgets instead of listviews in libkopete accountSelector

2017-06-18 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/ --- (Updated June 18, 2017, 8:29 a.m.) Status -- This change has been ma

Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-18 Thread Paulo Lieuthier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130161/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kop

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-18 Thread Paulo Lieuthier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130161/#review103338 --- I'm not sure if you wanted all of this, but now here it is.

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

2017-06-18 Thread Paulo Lieuthier
> On June 10, 2017, 1:26 p.m., Laurent Montel wrote: > > > > Paulo Lieuthier wrote: > I had already started translating those (and all others) in my main > branch, and didn't want to mess with that here. Next review request will be > such translation, isn't that better? > > By the

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-18 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130161/#review103341 --- protocols/gadu/gaduaccount.cpp (line 284)

Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

2017-06-18 Thread Laurent Montel
> On June 11, 2017, 9:52 a.m., Paulo Lieuthier wrote: > > Ship It! Do you know it's not the creator of request which must click on "ship it" - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboa