----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124701/#review103336 -----------------------------------------------------------
libkopete/ui/accountselector.cpp (line 98) <https://git.reviewboard.kde.org/r/124701/#comment68747> Is this correct? Because in https://git.reviewboard.kde.org/r/124227 is for same code use ->setHeaderLabels() and in https://git.reviewboard.kde.org/r/124345 is used ->setHeaderLabel(). libkopete/ui/addressbookselectorwidget.cpp (line 72) <https://git.reviewboard.kde.org/r/124701/#comment68748> FIXME which needs to be fixed libkopete/ui/kopetelistview.cpp (line 236) <https://git.reviewboard.kde.org/r/124701/#comment68750> FIXME libkopete/ui/kopetelistview.cpp (line 242) <https://git.reviewboard.kde.org/r/124701/#comment68749> FIXME libkopete/ui/kopetelistviewitem.cpp (line 1153) <https://git.reviewboard.kde.org/r/124701/#comment68751> FIXME libkopete/ui/metacontactselectorwidget.cpp (line 208) <https://git.reviewboard.kde.org/r/124701/#comment68752> FIXME - Pali Rohár On aug. 11, 2015, 10:17 popoludní, R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124701/ > ----------------------------------------------------------- > > (Updated aug. 11, 2015, 10:17 popoludní) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Remove all K3 and Qt3 classes from libkopete. Sections of this patch are > under review at https://git.reviewboard.kde.org/r/124345/ and > https://git.reviewboard.kde.org/r/124344/ > This patch is the squash of 4 commits to make reviewboard happy. > > > Diffs > ----- > > libkopete/kopetecontact.cpp 670fba008f6b0aa134de1a97644cd42190a8e336 > libkopete/tests/kopetemessage_test.cpp > 4c07dfbc2ff94e9e67f5c4729bb3c1e43763c09d > libkopete/ui/accountselector.h ff42a881f9151fe3b4db175577807fa191351467 > libkopete/ui/accountselector.cpp e6d5ee5f788cbc7606be25d8a9e3aff9b4866468 > libkopete/ui/addressbookselectordialog.h > 0586a7a39d31688362199a626d19fed33d8e737d > libkopete/ui/addressbookselectordialog.cpp > afd2f3a6623fbd3f2612eb2f7bb3922a1185d405 > libkopete/ui/addressbookselectorwidget.h > a565d5593b8478eb50f1e46a1603cc930a3b4fde > libkopete/ui/addressbookselectorwidget.cpp > d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 > libkopete/ui/addressbookselectorwidget_base.ui > de6ec4d24cd10eebfebc11b4fb9839be206552dc > libkopete/ui/addresseeitem.h 080f770a1d3c316b8fbf4e4a7fc9d1c130f756fc > libkopete/ui/addresseeitem.cpp e47f36c8c79e62ca593e282dc66b7874a12d789f > libkopete/ui/kopetelistview.h 53817bdcfc3a19e359bda22577c7ad09e2be3cdd > libkopete/ui/kopetelistview.cpp 420347c1b73bcf983ab5874ded9ff25c4755880b > libkopete/ui/kopetelistviewitem.h fdcdbc181668ff8a4411d4a3ca722a2618a0d77b > libkopete/ui/kopetelistviewitem.cpp > 608fd9a6c1933ee7f6f51c56bc1e7a1d4c15ebfb > libkopete/ui/kopetelistviewsearchline.h > 13a7e9d785ba1a14fd21ec0cc3a790fb3be16858 > libkopete/ui/kopetelistviewsearchline.cpp > 43bc4025e767c432b8d4b538903e19ce282de943 > libkopete/ui/metacontactselectorwidget.h > 6ca3b6e501e0d49531a3de5db438424db6f3fbc7 > libkopete/ui/metacontactselectorwidget.cpp > 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a > libkopete/ui/metacontactselectorwidget_base.ui > 1f69a48c559ab3f002700068ec6a6c200a9242e3 > > Diff: https://git.reviewboard.kde.org/r/124701/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > R.Harish Navnit > >
