Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kop

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thursday 25 June 2015 12:47:20 R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124173/ > --- > > Rev

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

Hi Pali, Yes you'd raised this issue earlier too. Forgive my absent mindedness. I'll take a look and update the diff :) Warm Regards. Thanking You, R.Harish Navnit The Enigma On Thu, Jun 25, 2015 at 6:33 PM, Pali Rohár wrote: > On Thursday 25 June 2015 12:4

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

> > On Thu, Jun 25, 2015 at 6:33 PM, Pali Rohár wrote: >> >> >> Just a quick note about your patches which removing KDE3/Qt3 code: >> >> Look also at CMakeLists.txt files and remove coresponding KDE3/Qt3 >> defines ideally with linking with KDE3/Qt3 libraries... >> > I'm not really sure how this i

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thursday 25 June 2015 18:56:05 R.Harish Navnit wrote: > > > > On Thu, Jun 25, 2015 at 6:33 PM, Pali Rohár wrote: > >> > >> > >> Just a quick note about your patches which removing KDE3/Qt3 code: > >> > >> Look also at CMakeLists.txt files and remove coresponding KDE3/Qt3 > >> defines ideally wi

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thu, Jun 25, 2015 at 7:06 PM, Pali Rohár wrote: > > If there are errors it means that there are more calls to KDE3/Qt3 > functions... Not all KDE3/Qt3 methods are in headers prefixed with > K3/Q3. This is reason why I wrote you to look at compiler defines and > linker flags > Okay. There is ho

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thursday 25 June 2015 19:19:18 R.Harish Navnit wrote: > On Thu, Jun 25, 2015 at 7:06 PM, Pali Rohár wrote: > > > > > If there are errors it means that there are more calls to KDE3/Qt3 > > functions... Not all KDE3/Qt3 methods are in headers prefixed with > > K3/Q3. This is reason why I wrote y

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thu, Jun 25, 2015 at 7:25 PM, Pali Rohár wrote: > > Sounds good. Do not remember that some defines enable additional > KDE3/Qt3 member methods. So once you remove defines some other code does > not have to compile... You need to port those methods too! > Yes. Noted :) Thanks, R.Harish Navnit

Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/ --- Review request for Kopete and Laurent Montel. Repository: kopete Descri

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thursday 25 June 2015 16:13:18 R.Harish Navnit wrote: > On Thu, Jun 25, 2015 at 7:25 PM, Pali Rohár wrote: > > Sounds good. Do not remember that some defines enable additional > > KDE3/Qt3 member methods. So once you remove defines some other code > > does not have to compile... You need to por

Review Request 124184: Remove Qt3 dependencies from meanwhile protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124184/ --- Review request for Kopete and Laurent Montel. Repository: kopete Descri

Re: Review Request 124184: Remove Qt3 dependencies from meanwhile protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124184/#review81762 --- protocols/meanwhile/CMakeLists.txt (line 4)

Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/#review81763 --- protocols/groupwise/ui/gwchatprops.ui (line 380)

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81764 --- protocols/gadu/ui/gadusearch.ui (line 441)