Re: Review Request: Fix overwrite of manually chosen nicknames

2012-01-05 Thread cyberbeat
> On Nov. 9, 2011, 3:01 p.m., Pali Rohár wrote: > > Your patch disable updating nickname of all contacts from jabber server. > > This is bad because some people want to autoupdate new nicknames from > > server. > > Instead totally disabling this functions, it should be configurable (in > > jab

Re: Review Request: Fix overwrite of manually chosen nicknames

2012-01-05 Thread Pali Rohár
> On Nov. 9, 2011, 3:01 p.m., Pali Rohár wrote: > > Your patch disable updating nickname of all contacts from jabber server. > > This is bad because some people want to autoupdate new nicknames from > > server. > > Instead totally disabling this functions, it should be configurable (in > > jab

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-05 Thread cyberbeat
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/ --- (Updated Jan. 5, 2012, 8:48 p.m.) Review request for Kopete. Description -

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-05 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/#review10628 --- /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelega

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-05 Thread cyberbeat
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/ --- (Updated Jan. 5, 2012, 9:13 p.m.) Review request for Kopete. Description -

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-05 Thread cyberbeat
> On Dec. 12, 2011, 6:10 p.m., Lamarque Souza wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp, > > line 835 > > > > > > are these spaces? If so then please change them to tabs to

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-05 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/#review10631 --- /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-05 Thread Pali Rohár
> On Jan. 5, 2012, 9:06 p.m., Pali Rohár wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp, > > line 48 > > > > > > Here is whitespace change and only one in this file. In diff3 is not