Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/ --- (Updated 2009-07-09 18:11:17.332665) Review request for Kopete. Changes ---

Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/ --- (Updated 2009-07-10 07:20:32.547875) Review request for Kopete. Changes ---

Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

Lamarque Souza wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/971/ > --- > > (Updated 2009-07-10 07:20:32.547875) > > > Review r

Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/ --- (Updated 2009-07-10 09:02:21.403623) Review request for Kopete. Changes ---

Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/#review1530 --- This patch is a little rough to go in as-is. The security vulnerability

Re: [kopete-devel] Review Request: kopete - Implement the "Drag and hover focus for tabs" junior job

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/920/#review1533 --- Ship it! I don't understand why you have 'const QDragMoveEvent*' point

Re: [kopete-devel] Review Request: Fix for kopete blank line bug

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/#review1537 --- Ship it! Does a Kopete developer need to commit this, or do you have a

Re: [kopete-devel] Review Request: kopete - Implement the "Drag and hover focus for tabs" junior job

On Fri, Jul 10, 2009 at 10:57, Matt Rogers wrote: > I don't understand why you have 'const QDragMoveEvent*' pointers. IMO, the > const doesn't add any value. Shouldn't you be always be using const unless there's a specific reason not to? Without const, you have an implicit assumption that someth

Re: [kopete-devel] Review Request: kopete - Implement the "Drag and hover focus for tabs" junior job

> On 2009-07-10 10:57:54, Matt Rogers wrote: > > I don't understand why you have 'const QDragMoveEvent*' pointers. IMO, the > > const doesn't add any value. This can still be committed (or let me know if > > I need to do it) Shipped, thanks for the feedback. I thought "const" was needed to co

Re: [kopete-devel] Review Request: Fix for crash when disconnecting from WLM

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/972/#review1539 --- how many times were you able to reproduce this crash? What was the inte

Re: [kopete-devel] Review Request: Fix for crash when disconnecting from WLM

> On 2009-07-10 13:11:54, Tiago Salem Herrmann wrote: > > how many times were you able to reproduce this crash? > > What was the interval between the two offline status requests? > > I'm not sure if a race condition can happen here, because as far as I know > > there are no threads running in th

Re: [kopete-devel] Review Request: Fix for crash when disconnecting from WLM

> On 2009-07-10 13:11:54, Tiago Salem Herrmann wrote: > > how many times were you able to reproduce this crash? > > What was the interval between the two offline status requests? > > I'm not sure if a race condition can happen here, because as far as I know > > there are no threads running in th

Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/#review1536 --- /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp

Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/ --- (Updated 2009-07-10 22:20:32.502678) Review request for Kopete. Changes ---

Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/ --- (Updated 2009-07-10 22:21:41.275711) Review request for Kopete. Changes ---

Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/ --- (Updated 2009-07-10 22:32:19.830830) Review request for Kopete. Changes ---

Re: [kopete-devel] Review Request: Implements mail notification and open inbox feature for wlm plugin

Em Friday 10 July 2009, Tiago Salem Herrmann escreveu: > Lamarque Souza wrote: > > --- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.kde.org/r/971/ > > --

[kopete-devel] Help with KParts::BrowserRun

Hi, I am trying to use KParts::BrowserRun to do the POST to open Hotmail inbox, the code is bellow. When I hit "Open inbox" button it calls the browser to inspect the URL and afterwards it calls krita (!?) to try to open the file returned by Hotmail server. Can you help me fin