----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/920/#review1533 -----------------------------------------------------------
Ship it! I don't understand why you have 'const QDragMoveEvent*' pointers. IMO, the const doesn't add any value. This can still be committed (or let me know if I need to do it) - Matt On 2009-07-07 12:24:00, Bruno Bigras wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/920/ > ----------------------------------------------------------- > > (Updated 2009-07-07 12:24:00) > > > Review request for Kopete. > > > Summary > ------- > > Drag and hover focus for tabs > When links or files are dragged and hovered over the taskbar they pop up the > associated window. For other tabbed applications when there is a drag and > hoverover a tab that tab is given focus. Kopete should do the same. > http://techbase.kde.org/Projects/Kopete/JuniorJobs#Drag_and_hover_focus_for_tabs > > By making the tabs accept the dragEnterEvent, the tab is given focus > automatically. Also if the user drop the file on the tab the event is sent to > the ChatView (it initiate a file transfert). > > Currently the tab reject the dragEvent if the ChatView->isDragEventAccepted() > return false. This mean that a user can only use this feature to send a file, > if the user want to send a url (or uri?) and isDragEventAccepted() return > false, it won't work. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.h 990058 > /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp 990058 > /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h 990058 > /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp 990058 > > Diff: http://reviewboard.kde.org/r/920/diff > > > Testing > ------- > > This patch seem to work fine with project neon. > > > Thanks, > > Bruno > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
