Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2016-03-13 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated March 13, 2016, 3:24 p.m.) Status -- This change has been m

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2016-03-11 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated March 11, 2016, 3:24 p.m.) Status -- This change has been m

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-09-06 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated Sept. 6, 2015, 7:50 p.m.) Status -- This change has been ma

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-25 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82953 --- Ship it! Ship It! - Pali Rohár On júl 25, 2015, 5:37 popol

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-25 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 25, 2015, 9:07 p.m.) Review request for Kopete, Laurent Mon

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-22 Thread R.Harish Navnit
> On July 21, 2015, 10:33 p.m., Pali Rohár wrote: > > libkopete/ui/metacontactselectorwidget.cpp, line 21 > > > > > > Is this change needed? And if yes it is cosmetic, should be in separate > > commit and should

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-22 Thread Pali Rohár
> On júl 21, 2015, 7:03 popoludní, Pali Rohár wrote: > > libkopete/ui/addressbookselectorwidget.cpp, line 143 > > > > > > TextEditorInteraction = TextSelectableByMouse | > > TextSelectableByKeyboard | TextEd

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-22 Thread R.Harish Navnit
> On July 21, 2015, 10:33 p.m., Pali Rohár wrote: > > libkopete/ui/addressbookselectorwidget.cpp, line 143 > > > > > > TextEditorInteraction = TextSelectableByMouse | > > TextSelectableByKeyboard | TextEdita

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-22 Thread R.Harish Navnit
> On July 21, 2015, 10:33 p.m., Pali Rohár wrote: > > libkopete/ui/metacontactselectorwidget.cpp, line 21 > > > > > > Is this change needed? And if yes it is cosmetic, should be in separate > > commit and should

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-22 Thread Pali Rohár
> On júl 21, 2015, 7:03 popoludní, Pali Rohár wrote: > > libkopete/ui/metacontactselectorwidget.cpp, line 21 > > > > > > Is this change needed? And if yes it is cosmetic, should be in separate > > commit and shou

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-22 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82813 --- Ship it! Seems good. Ship it - Laurent Montel On juil. 21,

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-21 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 22, 2015, 1:05 a.m.) Review request for Kopete, Laurent Mon

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-21 Thread R.Harish Navnit
> On July 21, 2015, 10:33 p.m., Pali Rohár wrote: > > libkopete/ui/metacontactselectorwidget.cpp, line 21 > > > > > > Is this change needed? And if yes it is cosmetic, should be in separate > > commit and should

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-21 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82777 --- libkopete/ui/addressbookselectorwidget.cpp (line 140)

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-21 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82775 --- libkopete/ui/addressbookselectorwidget.cpp (line 141)

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-20 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82723 --- Ship it! Seems ok. Ship it - Laurent Montel On juil. 20, 2

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-20 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 20, 2015, 7:31 p.m.) Review request for Kopete, Laurent Mon

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-20 Thread R.Harish Navnit
> On July 15, 2015, 10:08 a.m., Laurent Montel wrote: > > When I read doc I see: > > * @deprecated Use QLabel. (QLabel::setOpenExternalLinks(true) for labels > > with hyperlinks; > > * > > QLabel::setTextInteractionFlags(Qt::TextSelectableByMouse|Qt::TextSelectableByKeyboard) > > for label

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-14 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82517 --- When I read doc I see: * @deprecated Use QLabel. (QLabel::se