> On July 21, 2015, 10:33 p.m., Pali Rohár wrote: > > libkopete/ui/addressbookselectorwidget.cpp, line 143 > > <https://git.reviewboard.kde.org/r/124344/diff/2/?file=386361#file386361line143> > > > > TextEditorInteraction = TextSelectableByMouse | > > TextSelectableByKeyboard | TextEditable > > > > Why it is needed? Have you looked what this lblHeader means and where > > is used? > > Pali Rohár wrote: > I'm reopening this issue because: > 1) it does not have comment any comment or answers to my questions > 2) I bet answer to my second question is "No", because it is really not > needed (or correct me if I'm wrong!)
I have looked at this label header and Qt::TextEditorInteraction was not required for the same and hence I updated the patch, replacing it with Qt::NoTextInteraction (since I felt there needn't be any text interaction for a header label) https://git.reviewboard.kde.org/r/124344/diff/2-3/ - R.Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82775 ----------------------------------------------------------- On July 22, 2015, 1:05 a.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124344/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 1:05 a.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Use QLabel instead of K3ActiveLabel > > > Diffs > ----- > > libkopete/ui/addressbookselectorwidget.cpp > d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 > libkopete/ui/addressbookselectorwidget_base.ui > de6ec4d24cd10eebfebc11b4fb9839be206552dc > libkopete/ui/metacontactselectorwidget.cpp > 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a > libkopete/ui/metacontactselectorwidget_base.ui > 1f69a48c559ab3f002700068ec6a6c200a9242e3 > > Diff: https://git.reviewboard.kde.org/r/124344/diff/ > > > Testing > ------- > > Build succeeded. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
