Re: Review Request: yahoo protocol - fixes receive and sending files

2011-01-24 Thread Cristi P
Review closed. Thanks for helping! On Tue, Jan 25, 2011 at 3:06 AM, Raphael Kubo da Costa wrote: >This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6339/ > > Applied, please remember to close the request. Thank you! > > > - Raphael > > On January

Re: Review Request: yahoo protocol - fixes receive and sending files

2011-01-24 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6339/#review9712 --- Applied, please remember to close the request. Thank you! - Rapha

Re: Review Request: yahoo protocol - fixes receive and sending files

2011-01-24 Thread Cristi P
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6339/ --- (Updated Jan. 24, 2011, 10:48 p.m.) Review request for Kopete. Changes ---

Re: Review Request: yahoo protocol - fixes receive and sending files

2011-01-23 Thread Cristi P
> On Jan. 22, 2011, 6:31 p.m., Raphael Kubo da Costa wrote: > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.cpp, > > line 143 > > > > > > Can you add a TODO: here to make it easier to spot t

Re: Review Request: yahoo protocol - fixes receive and sending files

2011-01-23 Thread Cristi P
> On Jan. 22, 2011, 6:31 p.m., Raphael Kubo da Costa wrote: > > Most changes needed are cosmetic or related to variable names/coding style. > > > > I don't use the Yahoo protocol, so I can't test your changes, so I'm > > assuming they work fine. As for bug 194833, you could try to ask for more

Re: Review Request: yahoo protocol - fixes receive and sending files

2011-01-22 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6339/#review9677 --- Most changes needed are cosmetic or related to variable names/codi

Re: Review Request: yahoo protocol - fixes receive and sending files

2011-01-20 Thread Cristi P
Can I get this reviewed/commented on? Weekend is approaching and I might have a bit of time to change things if there will be comments on it or on the coding style :-) Don't know about you but I was bugged by the yahoo transfer not working most of the time for a long time... Regards. On Sun, Jan